Re: [Piglit] Vulkan headers dependency

2020-05-05 Thread Lionel Landwerlin
Maybe embedding them like we do in Mesa? -Lionel On 05/05/2020 17:40, Jose Fonseca wrote: Could we please make Vulkan headers an optional dependency?  It would simplify building and running piglit on Windows. ___ Piglit mailing list

Re: [Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add YUYV format support

2019-02-27 Thread Lionel Landwerlin
resolutions (I recall having issues on 32x32 images). With the value changed, this is : Reviewed-by: Lionel Landwerlin -Lionel ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/3] arb_enhanced_layouts: don't call glLinkProgram twice

2019-02-20 Thread Lionel Landwerlin
On 20/02/2019 16:06, Alejandro Piñeiro wrote: GLSL codepath uses piglit_build_simple_program_multiple_shaders, that already calls glLinkProgram. Minor thing, but makes debug the test more easy. Reviewed-by: Lionel Landwerlin --- .../transform-feedback-layout-qualifiers.c

Re: [Piglit] [PATCH v2] primitive-restart: extend the test to catch regressions of bug-109451

2019-02-18 Thread Lionel Landwerlin
Pushed. On 18/02/2019 14:05, andrey simiklit wrote: Yes, it would be great. Thanks, Andrii. On Mon, Feb 18, 2019 at 4:03 PM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: Do you need me to push this change? -Lionel On 18/02/2019 14:00, asimi

Re: [Piglit] [PATCH v2] primitive-restart: extend the test to catch regressions of bug-109451

2019-02-18 Thread Lionel Landwerlin
which makes us unable to disable the primitive restart option it should draw just one triangle. The solution was suggested. v2: Added the link to the bug in the comment of the new function ( Lionel Landwerlin ) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109451 Reviewed-by: Lionel

Re: [Piglit] [PATCH] primitive-restart: extend the test to catch regressions of bug-109451

2019-02-18 Thread Lionel Landwerlin
function. Reviewed-by: Lionel Landwerlin --- tests/general/primitive-restart.c | 72 +++ 1 file changed, 72 insertions(+) diff --git a/tests/general/primitive-restart.c b/tests/general/primitive-restart.c index 4219a6c5b..aef9bed41 100644 --- a/tests/general

Re: [Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add support for XYUV format

2019-02-16 Thread Lionel Landwerlin
On 16/02/2019 01:43, Vivek Kasireddy wrote: This format is similar to AYUV except that the alpha channel is ignored. Cc: Tapani Palli Cc: Lionel Landwerlin Signed-off-by: Vivek Kasireddy Reviewed-by: Lionel Landwerlin --- tests/opengl.py | 2

[Piglit] [PATCH] tests/shaders/bug-109601: drop ARB_shader_storage_buffer_object requirement

2019-02-15 Thread Lionel Landwerlin
We're failing this test on Sandybridge because we're requiring an extension that isn't necessary. This is a leftover from a previous iteration of the test. Signed-off-by: Lionel Landwerlin Reported-by: Mark Janes Fixes: ffb5627758eb77 ("shaders: Reproduce a bug in the i965/anv backend com

[Piglit] [PATCH] shaders: Reproduce a bug in the i965/anv backend compiler

2019-02-14 Thread Lionel Landwerlin
We were dropping negations/abs while trying to optimize. Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109601 --- tests/shaders/glsl-bug-109601.shader_test | 28 +++ 1 file changed, 28 insertions(+) create mode 100644 tests/shaders

Re: [Piglit] [PATCH] EGL_EXT_image_dma_buf_import: test alpha channel for AYUV format

2019-02-13 Thread Lionel Landwerlin
On 13/02/2019 08:28, Tapani Pälli wrote: Patches changes expected result to have a alpha ramp in case format supports alpha, each alpha supporting format should make sure data matches this expectation. Signed-off-by: Tapani Pälli Looks good, thanks! Reviewed-by: Lionel Landwerlin

Re: [Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add P12, P16 format support

2019-02-13 Thread Lionel Landwerlin
On 13/02/2019 12:20, Tapani Pälli wrote: Signed-off-by: Tapani Pälli Thanks for adding these. Reviewed-by: Lionel Landwerlin --- tests/opengl.py | 4 +++ .../ext_image_dma_buf_import/sample_common.c | 2 ++ .../ext_image_dma_buf_import/sample_yuv.c

Re: [Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: add P10 format support

2019-02-11 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 11/02/2019 09:44, Tapani Pälli wrote: v2: use correct range for P10 Signed-off-by: Tapani Pälli Signed-off-by: Harish Krupo --- tests/opengl.py| 2 ++ .../spec/ext_image_dma_buf_import/sample_common.c | 1

Re: [Piglit] [PATCH v2] fbo-blit-check-limits: New test

2019-02-06 Thread Lionel Landwerlin
lorp functions take integers. That sounds like a cleaner fix, rather than trying to bump the precision (there might still be cases where that won't workout well). -Lionel So in plans also is to try to use integers... What is your opinion? On Wed, Feb 6, 2019 at 12:46 PM Lionel Landwe

Re: [Piglit] [PATCH v2] fbo-blit-check-limits: New test

2019-02-06 Thread Lionel Landwerlin
): readIntMax_toIntMax.png On Tue, Feb 5, 2019 at 1:13 PM Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: On 05/02/2019 07:52, Sergii Romantsov wrote: > From: Vadym Shovkoplias mailto:vadim.shovkopl...@gmail.com>> > > This test checks max possible blit buffers

Re: [Piglit] [PATCH v2] fbo-blit-check-limits: New test

2019-02-05 Thread Lionel Landwerlin
On 05/02/2019 07:52, Sergii Romantsov wrote: From: Vadym Shovkoplias This test checks max possible blit buffers sizes v2: copyright updated Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108088 Signed-off-by: Vadym Shovkoplias Hi Sergii, The bug opened about does not give any

Re: [Piglit] [PATCH] Add test for external sampler with 2D tex

2019-02-03 Thread Lionel Landwerlin
On 02/02/2019 08:42, Aditya Swarup wrote: Commit 649c149dbb96ac367 removed the test for intel external sampler with dma only because of failure due to commit a5c39ed974402c - ("i965: Lift restriction in external textures for EGLImage support"). Since, there is no test coverage for external

Re: [Piglit] [PATCH] vulkan: Add some tests for block member decorations

2019-01-24 Thread Lionel Landwerlin
On 24/01/2019 16:15, Alejandro Piñeiro wrote: From: Neil Roberts v2: imported to piglit from a example vkrunner examples branch, also updated description on the top comment (Alejandro Piñeiro) v3: use location 1 instead of location 0 for one of the tests (Lionel) Reviewed-by: Lionel

Re: [Piglit] [PATCH] vulkan: Add some tests for block member decorations

2019-01-24 Thread Lionel Landwerlin
On 24/01/2019 15:45, apinheiro wrote: On 24/1/19 16:28, Lionel Landwerlin wrote: Thanks a lot for explaining. I was wondering whether it would be worth checking something like this : (layout location = 1) out block myBlock {     vec4 a;     vec4 b; } And verify whether a would bet location

Re: [Piglit] [PATCH] vulkan: Add some tests for block member decorations

2019-01-24 Thread Lionel Landwerlin
-by: Lionel Landwerlin Side question that I cannot find the answer to in the spec, the following would be illegal right? : layout (location= 1) out block myOtherBlock {    layout (location = 1) vec4 a;    layout (location = 0) vec4 b;    layout (location = 3) vec4 c;    layout (location = 2) vec4 d

Re: [Piglit] [PATCH] vulkan: Add some tests for block member decorations

2019-01-24 Thread Lionel Landwerlin
I'm not sure whether my understanding of block-layout-location.vk_shader_test is correct. Is the expectation that the location of %name (0) is added to the location of its field (a, b, c, d)? Thanks, -Lionel On 23/01/2019 15:07, Alejandro Piñeiro wrote: From: Neil Roberts v2: imported to

Re: [Piglit] [PATCH] util: fix off-by-one when loading source

2019-01-20 Thread Lionel Landwerlin
opies n characters plus an additional '\0' while the latter copies n characters including '\0'. Reviewed-by: Lionel Landwerlin if (output_source) *output_source = strndup(first_line, text_size); ___ Piglit mailing list Piglit@lis

Re: [Piglit] [PATCH crucible] Add test for bug 108911

2018-12-04 Thread Lionel Landwerlin
On 04/12/2018 19:13, Lionel Landwerlin wrote: +if (resolvedData[1][i] != 0xff00ff00) { +printf("unexpected clear color in layer1: got 0x%x expected 0x00ff00ff\n", + resolvedData[1][i]); +t_fail(); +return; Duh! fixed

[Piglit] [PATCH crucible] Add test for bug 108911

2018-12-04 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- Makefile.am| 1 + src/tests/bug/108911.c | 306 + 2 files changed, 307 insertions(+) create mode 100644 src/tests/bug/108911.c diff --git a/Makefile.am b/Makefile.am index 528650a..6e99516 100644

Re: [Piglit] [PATCH crucible] Add a test for bug 108909

2018-12-04 Thread Lionel Landwerlin
On 04/12/2018 14:52, Józef Kucia wrote: On Tue, Dec 4, 2018 at 3:46 PM Lionel Landwerlin wrote: Signed-off-by: Lionel Landwerlin --- Makefile.am| 1 + src/tests/bug/108909.c | 106 + 2 files changed, 107 insertions(+) create mode

[Piglit] [PATCH crucible] Add a test for bug 108909

2018-12-04 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- Makefile.am| 1 + src/tests/bug/108909.c | 106 + 2 files changed, 107 insertions(+) create mode 100644 src/tests/bug/108909.c diff --git a/Makefile.am b/Makefile.am index b35e329..528650a 100644

Re: [Piglit] [PATCH piglit 2/2] ext_image_dma_buf_import/unsupported_format has no reason to be intel-only

2018-11-30 Thread Lionel Landwerlin
On 30/11/2018 13:59, Eric Engestrom wrote: Signed-off-by: Eric Engestrom Reviewed-by: Lionel Landwerlin --- tests/opengl.py | 3 +-- .../ext_image_dma_buf_import/CMakeLists.gles1.txt | 2 +- ...ntel_unsupported_format.c

Re: [Piglit] [PATCH piglit 1/2] make sure 'unsupported format' test always uses an unsupported format

2018-11-30 Thread Lionel Landwerlin
On 30/11/2018 13:58, Eric Engestrom wrote: Instead of using the fact this one driver currently doesn't support this one format, let's just use a format that will never be supported by anyone. Maybe put it in tests/util/piglit-framework-gl/piglit_drm_dma_buf.h ? Signed-off-by: Eric

Re: [Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: add fbo option to yuv formats with alpha channel

2018-11-15 Thread Lionel Landwerlin
On 14/11/2018 17:12, Eric Anholt wrote: Lionel Landwerlin writes: Depending on the platform you're running on, the test might fail with the AYUV format. To make this reliable, force to render to fbo. It should be reliable with just the RGBA change. Separately, I think you should be able

[Piglit] [PATCH] EGL_EXT_image_dma_buf_import: set RGBA visual for yuv sampling tests

2018-11-15 Thread Lionel Landwerlin
Depending on the platform you're running on, the test might fail with the AYUV format (or another format with alpha channel). To make this reliable, force to visual to RGBA. Signed-off-by: Lionel Landwerlin Suggested-by: Eric Anholt --- tests/spec/ext_image_dma_buf_import/sample_yuv.c | 1 + 1

[Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: fix error check with unknown drm format

2018-11-14 Thread Lionel Landwerlin
MATCH is generated. " v2: Add spec quote (Eric) Signed-off-by: Lionel Landwerlin Fixes: 0ee445dbbc161f ("tests/spec: EXT_image_dma_buf_import invalid attributes") --- tests/spec/ext_image_dma_buf_import/invalid_attributes.c | 9 - 1 file changed, 8 insertions(+),

[Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: add fbo option to yuv formats with alpha channel

2018-11-14 Thread Lionel Landwerlin
Depending on the platform you're running on, the test might fail with the AYUV format. To make this reliable, force to render to fbo. v2: request RGBA visual (Eric) Signed-off-by: Lionel Landwerlin --- tests/opengl.py | 2 +- tests/spec/ext_image_dma_buf_import

[Piglit] [PATCH 2/2] EGL_EXT_image_dma_buf_import: add fbo option to yuv formats with alpha channel

2018-11-13 Thread Lionel Landwerlin
Depending on the platform you're running on, the test might fail with the AYUV format. To make this reliable, force to render to fbo. Signed-off-by: Lionel Landwerlin --- tests/opengl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/opengl.py b/tests/opengl.py index

[Piglit] [PATCH 1/2] EGL_EXT_image_dma_buf_import: drop alpha-one to sample yuv tests

2018-11-13 Thread Lionel Landwerlin
This option only applies to the sample_rgb tests. Signed-off-by: Lionel Landwerlin --- tests/opengl.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/opengl.py b/tests/opengl.py index c672fdad4..8957de6e2 100644 --- a/tests/opengl.py +++ b/tests/opengl.py

[Piglit] [PATCH] EGL_EXT_image_dma_buf_import: fix error check with unknown drm format

2018-11-13 Thread Lionel Landwerlin
MATCH is generated. " Signed-off-by: Lionel Landwerlin Fixes: 0ee445dbbc161f ("tests/spec: EXT_image_dma_buf_import invalid attributes") --- tests/spec/ext_image_dma_buf_import/invalid_attributes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: add AYUV format support

2018-11-13 Thread Lionel Landwerlin
On 09/11/2018 17:31, Eric Engestrom wrote: On Friday, 2018-11-09 17:27:15 +, Lionel Landwerlin wrote: v2: Forgot to add the new test to opengl.py Drop some code to deal with alpha channel Signed-off-by: Lionel Landwerlin --- tests/opengl.py | 2

[Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: add AYUV format support

2018-11-09 Thread Lionel Landwerlin
v2: Forgot to add the new test to opengl.py Drop some code to deal with alpha channel Signed-off-by: Lionel Landwerlin --- tests/opengl.py | 2 ++ .../ext_image_dma_buf_import/sample_yuv.c | 26 ++- .../piglit-framework-gl

[Piglit] [PATCH] remove ext_image_dma_buf_import-intel_external_sampler_with_dma_only

2018-11-09 Thread Lionel Landwerlin
Commit a5c39ed974402c ("i965: Lift restriction in external textures for EGLImage support") from Mesa lifted the restriction that this test was checking. Easy fix! Signed-off-by: Lionel Landwerlin --- tests/opengl.py | 2 - .../CMakeLists

[Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add AYUV format support

2018-11-08 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- .../ext_image_dma_buf_import/sample_yuv.c | 33 ++- .../piglit-framework-gl/piglit_drm_dma_buf.c | 1 + 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/tests/spec/ext_image_dma_buf_import/sample_yuv.c b/tests/spec

Re: [Piglit] [PATCH] ext_texture_norm16-render: read SNORM formats if EXT_render_snorm

2018-07-31 Thread Lionel Landwerlin
On 31/07/18 12:21, Tapani Pälli wrote: This was missed from commit a440e4390. Signed-off-by: Tapani Pälli Reviewed-by: Lionel Landwerlin --- tests/spec/ext_texture_norm16/render.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/spec/ext_texture_norm16

Re: [Piglit] [PATCH v2] GL_ARB_texture_buffer_object: New test for error behavior.

2018-07-26 Thread Lionel Landwerlin
Looks good to me but maybe Ilia or Ian can confirm. Acked-by: Lionel Landwerlin - Lionel On 26/07/18 14:14, Vadim Shovkoplias wrote: ping 2018-06-06 12:57 GMT+03:00 Illia Iorin <mailto:illia.io...@gmail.com>>: This test checks that if we allocate more memory for the buffer

[Piglit] [PATCH] tests: intel_conservative_rasterization: fix invalid draws

2018-07-10 Thread Lionel Landwerlin
tests/opengl: Add intel_conservative_rasterization-invalid_gles3") Signed-off-by: Lionel Landwerlin --- .../intel_conservative_rasterization/invalid.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/tests/spec/intel_conservative_rasterization/invalid.

Re: [Piglit] [PATCH 7/9] tests/opengl: Add intel_conservative_rasterization-invalid_gles3

2018-06-29 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 27/06/18 18:32, Dylan Baker wrote: Fixes: ed153b51b57762e43d44e8f49dbe9bf0422e1400 ("Add GL_INTEL_conservative_rasterization tests") CC: Lionel Landwerlin --- tests/opengl.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/o

Re: [Piglit] [PATCH 8/9] tests/opengl: Add nv_image_formats-gles3

2018-06-29 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 27/06/18 18:32, Dylan Baker wrote: Fixes: 6ed37e5d2a58d36b4b04b09f8c069f2dbcff1968 ("Add nv_image_formats tests") CC: Lionel Landwerlin --- tests/opengl.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/opengl.py b/tests

Re: [Piglit] [PATCH v2 4/4] getteximage-simple: Stress an i965 blitter path

2018-06-20 Thread Lionel Landwerlin
On 20/06/18 20:49, Nanley Chery wrote: On Wed, Jun 20, 2018 at 06:32:58PM +0100, Lionel Landwerlin wrote: On 19/06/18 18:53, Nanley Chery wrote: On Tue, Jun 19, 2018 at 11:03:17AM +0100, Lionel Landwerlin wrote: On 18/06/18 19:57, Nanley Chery wrote: Change the dimension of the texture

Re: [Piglit] [PATCH v2 4/4] getteximage-simple: Stress an i965 blitter path

2018-06-20 Thread Lionel Landwerlin
On 19/06/18 18:53, Nanley Chery wrote: On Tue, Jun 19, 2018 at 11:03:17AM +0100, Lionel Landwerlin wrote: On 18/06/18 19:57, Nanley Chery wrote: Change the dimension of the texture to test how i965 handles having a row pitch too large for the BLT engine. v2: Query the maximum supported

Re: [Piglit] [PATCH v2 0/4] Stress an i965 blitter path

2018-06-19 Thread Lionel Landwerlin
Patches 1 to 3 are : Reviewed-by: Lionel Landwerlin On 18/06/18 19:57, Nanley Chery wrote: This series modifies getteximage-simple to work on a texture of maximum width. This enables us to test an existing fallback path for i965 which changes the texture's tiling to linear. It also enables us

Re: [Piglit] [PATCH piglit] glsl-1.50: fix glsl-1.50-geometry-primitive-types

2018-06-12 Thread Lionel Landwerlin
Lenum stringification macros." Cc: Fabian Bieler Cc: Brian Paul Signed-off-by: Eric Engestrom Reviewed-by: Lionel Landwerlin --- .../execution/geometry/primitive-types.c | 35 +++ 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/tests/spec/glsl-1.50

[Piglit] [PATCH v2] tests/egl: add query test for egl_ext_image_dma_buf_import_modifiers

2018-06-07 Thread Lionel Landwerlin
the required EGL version Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106642 --- tests/egl/spec/CMakeLists.txt | 1 + .../CMakeLists.no_api.txt | 7 + .../CMakeLists.txt| 1

Re: [Piglit] [PATCH] tests/egl: add query test for egl_ext_image_dma_buf_import_modifiers

2018-06-07 Thread Lionel Landwerlin
On 07/06/18 17:22, Jason Ekstrand wrote: On Thu, Jun 7, 2018 at 7:16 AM, Lionel Landwerlin mailto:lionel.g.landwer...@intel.com>> wrote: We've been running into crashes in i965 because of a number of issue throughout the driver stack. This is a really basic tests tha

Re: [Piglit] [PATCH 1/8] README: Move README.md so it gets parsed by GitLab

2018-06-07 Thread Lionel Landwerlin
Not a markdown expert but this series looks good to me : Acked-by: Lionel Landwerlin On 07/06/18 17:03, Jason Ekstrand wrote: --- README => README.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename README => README.md (100%) diff --git a/README b/README.md similarity

[Piglit] [PATCH] tests/egl: add query test for egl_ext_image_dma_buf_import_modifiers

2018-06-07 Thread Lionel Landwerlin
We've been running into crashes in i965 because of a number of issue throughout the driver stack. This is a really basic tests that list the formats and their associated modifiers to just catch any regressions. Signed-off-by: Lionel Landwerlin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi

Re: [Piglit] [PATCH 2/2] Specify an explicit window size in builtin uniform tests.

2018-05-16 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 10/05/18 00:12, Kenneth Graunke wrote: Currently, these tests assume a 250x250 window size, but don't specify SIZE 250x250, which means they can break when using PIGLIT_DEFAULT_SIZE. The tests draw multiple 4x4 rectangle

Re: [Piglit] [PATCH 1/2] Fix bogus assertions in builtin uniform test generator.

2018-05-16 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 10/05/18 00:12, Kenneth Graunke wrote: self.test_rows is measured in a number of 4x4 rectangles, but y is measured in pixels, so they are not comparable. The only reason this doesn't trip is because self.test_rows is cur

Re: [Piglit] [PATCH] tests: intel_blackhole_render: use GLSL ES 1.0 on ES profiles

2018-04-09 Thread Lionel Landwerlin
On 09/04/18 16:16, Tapani Pälli wrote: One nit that you can consider below .. Reviewed-by: Tapani Pälli <tapani.pa...@intel.com> On 09.04.2018 14:00, Lionel Landwerlin wrote: Not all of our platforms support GLSL ES 3.0 so extend the coverage by lowering the GLSL requirements. Sign

[Piglit] [PATCH] tests: intel_blackhole_render: use GLSL ES 1.0 on ES profiles

2018-04-09 Thread Lionel Landwerlin
Not all of our platforms support GLSL ES 3.0 so extend the coverage by lowering the GLSL requirements. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- tests/spec/intel_blackhole_render/blackhole_draw.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)

[Piglit] [PATCH 2/3] tests: intel_blackhole_render: require extension in dispatch test

2018-04-06 Thread Lionel Landwerlin
Fixes: c8d89e733c52a6 ("tests: add INTEL_blackhole_render") Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- tests/spec/intel_blackhole_render/blackhole_dispatch.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/intel_blackhole_render/blackho

[Piglit] [PATCH 0/3] tests: intel blackhole render fixes

2018-04-06 Thread Lionel Landwerlin
Hi, I've made a few mistake when sending the initial patch. I'm not quite sure how I missed them :( Thanks, Lionel Landwerlin (3): tests: fix INTEL_blackhole_render test names tests: intel_blackhole_render: require extension in dispatch test tests: nv_image_formats: remove unintended new

[Piglit] [PATCH 1/3] tests: fix INTEL_blackhole_render test names

2018-04-06 Thread Lionel Landwerlin
Fixes: c8d89e733c52a6 ("tests: add INTEL_blackhole_render") Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- tests/all.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/all.py b/tests/all.py index 39ad46926..26638cd82 10

[Piglit] [PATCH 3/3] tests: nv_image_formats: remove unintended new files

2018-04-06 Thread Lionel Landwerlin
This file was added by mistake. Fixes: c8d89e733c52a6 ("tests: add INTEL_blackhole_render") Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- tests/spec/nv_image_formats/CMakeLists.gl.txt | 8 1 file changed, 8 deletions(-) delete mode 1

Re: [Piglit] [PATCH] tests: add INTEL_blackhole_render

2018-03-16 Thread Lionel Landwerlin
On 16/03/18 07:31, Alejandro Piñeiro wrote: Is adding ${OPENGL_gl_LIBRARY} at link_libraries really needed at this gles CMakeKist? As far as I have seen, most gles2/3 CMakeLists just adds piglitutil_${piglit_target_api}. Looks like I can drop it from the GL tests too and it still links... Does

[Piglit] [PATCH] tests: add INTEL_blackhole_render

2018-03-15 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- registry/gl.xml| 8 +- tests/all.py | 9 ++ tests/spec/CMakeLists.txt | 1 + .../spec/intel_blackhole_

Re: [Piglit] [PATCH] crucible: fix m32 build errors due to formatting for uint64 and size_t

2017-12-07 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 07/12/17 02:49, Clayton Craft wrote: This fixes compile errors when building crucible for m32 targets, mainly that %lu means something different on m32 than it does on m64. Bugzilla: https://bugs.freedesktop.org/show_bug.

Re: [Piglit] [PATCH] arb_get_program_binary: check correctly got_error

2017-05-30 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 29/05/17 16:18, Juan A. Suarez Romero wrote: Seems it was checking if *not* error got, instead of the other way around. Suggested-by: Fabio Lagalla Signed-off-by: Juan A. Suarez Romero <jasua...@igalia.com> ---

Re: [Piglit] [PATCH] arb_fragment_shader_interlock: fix MinGW build

2017-04-27 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 27/04/17 19:25, Brian Paul wrote: uint isn't a standard type. GLuint would be another possibility. Untested. --- .../arb_fragment_shader_interlock/image-load-store.c | 16 1 file changed, 8 inse

Re: [Piglit] [PATCH 2/3] arb_post_depth_coverage-multisampling: Add a multisampling test.

2017-04-12 Thread Lionel Landwerlin
Oops sorry, I thought I did too... On 11/04/17 17:28, Manolova, Plamena wrote: Hi Ilia, This series got Reviewed-by: Lionel Landwerlin, but unfortunately I don't have write access to the repo to merge them. Lionel would you mind doing that for me? Thank you, Pam On Tue, Apr 11, 2017 at 5:24

Re: [Piglit] [PATCH 2/2] unittests: fix tests that check for tesselation

2017-02-24 Thread Lionel Landwerlin
Thanks! I see an additional one in tests/spec/arb_internalformat_query2/common.c :) Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 24/02/17 01:52, Dylan Baker wrote: This is a test fix for the practical fix in e8fbd270b35b1bb927acc34383cbf9db95863a26. Signed-off-by:

Re: [Piglit] [PATCH 1/2] unittests: Fix rename of gen_conversion -> gen_conversion_fp64

2017-02-24 Thread Lionel Landwerlin
Actually, that might explain Jason's failures :( Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 24/02/17 01:52, Dylan Baker wrote: Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- unittests/generators/test_generators.py | 2 +- 1 file changed, 1 ins

Re: [Piglit] [PATCH] builtin_functions: Add more 64-bit integers

2017-02-24 Thread Lionel Landwerlin
I thought these would have been caught by gen_conversion.py :/ Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 24/02/17 01:20, Jason Ekstrand wrote: Seriously, 1000 is not the only 64-bit integer. We should test a few more of them. These new integers trigger

[Piglit] [PATCH] tests: INTEL_conservative_rasterization: add missing gles3 build file

2017-02-09 Thread Lionel Landwerlin
Completely missed this, the tests were just being skipped. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- .../spec/intel_conservative_rasterization/CMakeLists.gles3.txt | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 test

Re: [Piglit] [PATCH 1/3] arb_post_depth_coverage-basic: Add a basic initial test.

2017-02-09 Thread Lionel Landwerlin
This series is : Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 02/02/17 14:31, Plamena Manolova wrote: A basic test to check whether the values written to gl_SampleMaskIn are still correct after enabling the ARB_post_depth_coverage extension. Signed-off-by: P

Re: [Piglit] [PATCH 1/3] PNG files, write mode correction

2017-01-10 Thread Lionel Landwerlin
ure :) Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 10/01/17 14:38, Sebastian Olender wrote: Signed-off-by: Sebastian Olender <sebastian.d.olen...@intel.com> --- tests/util/piglit-util-png.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ut

Re: [Piglit] [PATCH 2/3] arb_texture_view_rendering-formats: fix wrong array initialization

2017-01-10 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 10/01/17 14:38, Sebastian Olender wrote: Signed-off-by: Sebastian Olender <sebastian.d.olen...@intel.com> --- tests/spec/arb_texture_view/rendering-formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Piglit] [PATCH 1/3] PNG files, write mode correction

2017-01-10 Thread Lionel Landwerlin
The man page of fopen says : "This is strictly for compatibility with C89 and has no effect; the 'b' is ignored on all POSIX conforming systems, including Linux." I don't know where you're running this, but sure :) Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com&

Re: [Piglit] [PATCH] glsl-1.10: another test for min max optimisation pass

2017-01-05 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 05/01/17 23:20, Timothy Arceri wrote: This simple test exposes a bug in the GLSL IR optimisation pass in Mesa master. --- .../glsl-1.10/execution/fs-min-min-min.shader_test | 32 ++ 1 file chang

Re: [Piglit] [PATCH] glsl-1.10: test min max optimisation pass

2017-01-05 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> On 05/01/17 12:33, Timothy Arceri wrote: This simple test exposes a bug in the GLSL IR optimisation pass in Mesa master. --- .../glsl-1.10/execution/fs-max-max-max.shader_test | 32 ++ 1 file chang

Re: [Piglit] [PATCH 3/3] arb_post_depth_coverage-sample-shading: Test sample shading.

2016-12-20 Thread Lionel Landwerlin
Hi Pam, With the small changed below, this is : Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cheers, - Lionel On 22/11/16 22:04, Plamena Manolova wrote: A multisampling test with sample shading enabled to check whether the values written to gl_SampleMaskIn are

Re: [Piglit] [PATCH 2/3] arb_post_depth_coverage-multisampling: Add a multisampling test.

2016-12-20 Thread Lionel Landwerlin
This test is failing on my Kabylake laptop. Please check the comments below. Cheers, - Lionel On 22/11/16 22:03, Plamena Manolova wrote: A simple multisampling test to check whether the values written to gl_SampleMaskIn are still correct after enabling the ARB_post_depth_coverage extension.

Re: [Piglit] [PATCH 1/3] arb_post_depth_coverage-basic: Add a basic initial test.

2016-12-20 Thread Lionel Landwerlin
Hi Pam, Here are some tiny comments inline. With that updated this patch is : Reviewed-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> Cheers, - Lionel On 22/11/16 22:01, Plamena Manolova wrote: A basic test to check whether the values written to gl_SampleMaskIn are still c

[Piglit] [PATCH v2] Add GL_INTEL_conservative_rasterization tests

2016-12-02 Thread Lionel Landwerlin
This extension is a subset of GL_NV_conservative_raster, applying only to polygons. v2: Drop wrongly added files from Plamena's work (Lionel) Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- tests/all.py | 8 ++ test

[Piglit] [PATCH 0/2] INTEL_conservative_rasterization tests

2016-12-01 Thread Lionel Landwerlin
Hi, Here are some new tests for the INTEL_conservative_rasterization extension. This can be considered as a subset of NV_conservative_raster. Any feedback is more than welcome :) Cheers, Lionel Landwerlin (2): Add GL_INTEL_conservative_rasterization tests generated_tests: new compiler

[Piglit] [PATCH 1/2] Add GL_INTEL_conservative_rasterization tests

2016-12-01 Thread Lionel Landwerlin
This extension is a subset of GL_NV_conservative_raster, applying only to polygons. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- tests/all.py | 5 + tests/spec/CMakeLists.txt | 2 + ..

[Piglit] [PATCH 2/2] generated_tests: new compiler tests for INTEL_conservative_rasterization

2016-12-01 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- generated_tests/CMakeLists.txt | 4 + .../gen_shader_intel_conservative_rasterization.py | 173 + 2 files changed, 177 insertions(+) create mode 100644 generated

[Piglit] [PATCH] Add nv_image_formats tests

2016-11-11 Thread Lionel Landwerlin
Following the compiler tests added by edee46325935, we can also check that no errors are raised with new formats through glBindImageTexture(). Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- tests/spec/CMakeLists.txt| 1 + test

[Piglit] [PATCH v2 2/2] generated_tests: new compiler tests for NV_image_formats

2016-11-09 Thread Lionel Landwerlin
This tests that the compiler accepts the new layout formats introduced by NV_image_formats and also it's correct interaction with the EXT_texture_norm16 specification. v2: Only disallow normalized formats when EXT_texture_norm16 is not available (Ilia) Signed-off-by: Lionel Landwerlin

[Piglit] [PATCH v2 1/2] gen_extensions_defined.py: add NV_image_formats

2016-11-09 Thread Lionel Landwerlin
This extensions is written against OpenGL ES 3.1 and 3.10 of the OpenGL ES Shading Language specification. v2: Fix missing 'GL_' prefix (Ilia) Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- generated_tests/gen_extensions_defined.py | 1 + 1 file changed, 1 ins

[Piglit] [PATCH 2/2] generated_tests: new compiler tests for NV_image_formats

2016-11-09 Thread Lionel Landwerlin
This tests that the compiler accepts the new layout formats introduced by NV_image_formats and also it's correct interaction with the EXT_texture_norm16 specification. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- generated_tests/CMakeLists.txt

[Piglit] [PATCH 0/2] Tests for NV_image_formats

2016-11-09 Thread Lionel Landwerlin
basic tests to verify that the compiler doesn't rejects new formats with the NV_image_formats [2] extension. Cheers, [1]: https://bugs.freedesktop.org/show_bug.cgi?id=98480 [2]: https://www.khronos.org/registry/gles/extensions/NV/NV_image_formats.txt Lionel Landwerlin (2): gen_extensions_defined.py

[Piglit] [PATCH 1/2] gen_extensions_defined.py: add NV_image_formats

2016-11-09 Thread Lionel Landwerlin
This extensions is written against OpenGL ES 3.1 and 3.10 of the OpenGL ES Shading Language specification. Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel.com> --- generated_tests/gen_extensions_defined.py | 1 + 1 file changed, 1 insertion(+) diff --git a/generated