Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

2017-12-12 Thread Tapani Pälli
Hi; On 11.12.2017 22:15, Emil Velikov wrote: From: Emil Velikov Current Mesa implementation was overly cautious, flagging an error where it shouldn't - patch for Mesa is on the list. See the test for details. Cc: Ian Romanick Signed-off-by: Emil Velikov --- Nitpicks: - suggestions for te

Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

2017-12-13 Thread Emil Velikov
Hi Tapani, Thanks for having a look! On 13 December 2017 at 06:10, Tapani Pälli wrote: > Hi; > > On 11.12.2017 22:15, Emil Velikov wrote: >> + /* Set the env. variable to force the platform 'detection' to use >> +* different platform (than X11). >> +* >> +* NOTE: T

Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

2017-12-13 Thread Tapani Pälli
On 13.12.2017 14:22, Emil Velikov wrote: Hi Tapani, Thanks for having a look! On 13 December 2017 at 06:10, Tapani Pälli wrote: Hi; On 11.12.2017 22:15, Emil Velikov wrote: + /* Set the env. variable to force the platform 'detection' to use +* different platform (than X11)

Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

2017-12-18 Thread Emil Velikov
On 13 December 2017 at 12:54, Tapani Pälli wrote: >> The test doesn't care how well eglCopyBuffers itself works - aim it to >> illustrate the buggy validation in Mesa. >> Hence the wait + pixmap readback are not really needed. >> >> Admittedly the test name is quite misleading as-is - I'm short o

Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

2017-12-21 Thread Tapani Pälli
On 12/18/2017 04:37 PM, Emil Velikov wrote: On 13 December 2017 at 12:54, Tapani Pälli wrote: The test doesn't care how well eglCopyBuffers itself works - aim it to illustrate the buggy validation in Mesa. Hence the wait + pixmap readback are not really needed. Admittedly the test name is qu

Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

2018-01-25 Thread Emil Velikov
On 21 December 2017 at 09:26, Tapani Pälli wrote: > > On 12/18/2017 04:37 PM, Emil Velikov wrote: >> >> On 13 December 2017 at 12:54, Tapani Pälli wrote: >> The test doesn't care how well eglCopyBuffers itself works - aim it to illustrate the buggy validation in Mesa. Hence the wai

Re: [Piglit] [PATCH 5/5] egl: add eglCopyBuffers test

2018-01-26 Thread Tapani Pälli
On 01/25/2018 07:28 PM, Emil Velikov wrote: On 21 December 2017 at 09:26, Tapani Pälli wrote: On 12/18/2017 04:37 PM, Emil Velikov wrote: On 13 December 2017 at 12:54, Tapani Pälli wrote: The test doesn't care how well eglCopyBuffers itself works - aim it to illustrate the buggy validat