Review Request: Plasmate:now StartPage::createNewProject() creates the plasmateprojectrc and not the StartPage::loadLocalProject()

2011-09-29 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102732/ --- Review request for Plasma. Description --- Hello, for the moment the

Re: Review Request: Bug fix for 278765

2011-09-29 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102304/ --- (Updated Sept. 29, 2011, 10:39 a.m.) Review request for Plasma and Aaron J

Re: Review Request: quicklaunch: Add a confirmation dialog before the delete

2011-09-29 Thread Lukas Appelhans
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102727/#review6904 --- Hey! Even though I'm not anymore the maintainer of the quicklau

Re: Review Request: quicklaunch: Add a confirmation dialog before the delete

2011-09-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102727/#review6906 --- First, this is the wrong way to fix it. Why should this confirma

The case for a kdelibs 4.8

2011-09-29 Thread Kevin Kofler
Hi, as you probably already know, a decision was recently made that kdelibs 4.7 would be the last 4.x release series of kdelibs, and work would be ongoing in the 5.0 (frameworks) and 4.7 (KDE/4.7) branches only. I think this is a huge mistake, for several reasons (the "TL/DR" crowd can stop rig

Re: Review Request: quicklaunch: Add a confirmation dialog before the delete

2011-09-29 Thread Antonis Tsiapaliokas
> On Sept. 29, 2011, 11:55 a.m., Sebastian Kügler wrote: > > First, this is the wrong way to fix it. Why should this confirmation only > > go for a specific widget? This introduces inconsistence in the UI that > > leads to more data loss (the next time a user deletes a widget, she'll > > expec

Re: The case for a kdelibs 4.8

2011-09-29 Thread Markus Slopianka
On Donnerstag 29 September 2011 14:01:50 Kevin Kofler wrote: > 2. It will be confusing to our users, and even to some packagers, to have a > KDE SC 4.8 on kdelibs 4.7. Since almost exactly 2 years we (esp. the promo team) are communicating that Platform/Frameworks, Applications and Workspaces ar

Re: The case for a kdelibs 4.8

2011-09-29 Thread Kevin Kofler
On Thursday 29 September 2011, Heinz Wiesinger wrote: > From what I remember from the desktop summit the picture you draw here is > quite an exaggeration of what is actually happening. > > kdelibs 4.7 is meant to be frozen for new features, but not for bugfixes. > Bugfix releases of kdelibs-4.7 ha

Re: The case for a kdelibs 4.8

2011-09-29 Thread Alexander Neundorf
On Thursday 29 September 2011, Kevin Kofler wrote: > On Thursday 29 September 2011, Heinz Wiesinger wrote: ... > > The KDE Frameworks 5.0 development is not meant to take forever. In fact > > I think it's meant to be finished around early 2012, which would leave > > us with a frozen kdelibs for on

Re: The case for a kdelibs 4.8

2011-09-29 Thread Heinz Wiesinger
On Thursday 29 September 2011 14:01:50 Kevin Kofler wrote: > Hi, > > as you probably already know, a decision was recently made that kdelibs 4.7 > would be the last 4.x release series of kdelibs, and work would be ongoing > in the 5.0 (frameworks) and 4.7 (KDE/4.7) branches only. I think this is a

Re: The case for a kdelibs 4.8

2011-09-29 Thread Scott Kitterman
On Thursday, September 29, 2011 08:01:00 PM Kevin Kofler wrote: > On Thursday 29 September 2011, Heinz Wiesinger wrote: > > From what I remember from the desktop summit the picture you draw here > > is > > quite an exaggeration of what is actually happening. > > > > kdelibs 4.7 is meant to be froz

ScreenSaver and KDE Plasma 4.8?

2011-09-29 Thread Martin Gräßlin
Hi all, the work on the new screen locker implementation is nearly done (I can unlock again :-) and that brings me to an issue where I wanted to have more opinions: screensaver. What's important to see: screen locker and screen saver are two different things mixed together for historic reasons

Re: ScreenSaver and KDE Plasma 4.8?

2011-09-29 Thread Marco Martin
On Thursday 29 September 2011, Martin Gräßlin wrote: > Hi all, > > the work on the new screen locker implementation is nearly done (I can > unlock again :-) and that brings me to an issue where I wanted to have > more opinions: screensaver. > +1 > > But when compositing is turned off, you curr

Re: ScreenSaver and KDE Plasma 4.8?

2011-09-29 Thread Thomas Lübking
Am Thu, 29 Sep 2011 22:14:59 +0200 schrieb Martin Gräßlin : > But when compositing is turned off, you currently get the plain old > implementation including screen savers. And I don't want to change > that code. Seconding Marco: "Why?" > So there are some solutions: > * drop screensaver support

Re: ScreenSaver and KDE Plasma 4.8?

2011-09-29 Thread Kevin Kofler
Martin Gräßlin wrote: > * drop screensaver support altogether, probably would create some troubles > as evil KDE removed screensavers > * add Plasma widget support to new screen locker implementation but drop > screensaver support (same problems as first option) I don't think these are acceptable.

Re: Review Request: Bugfix: Plasma::PackageMetadata::read: Match the behavior of KService

2011-09-29 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102404/#review6930 --- Ping? Can I commit this bugfix to the KDE/4.7 branch? - Kevin K

Re: ScreenSaver and KDE Plasma 4.8?

2011-09-29 Thread todd rme
On Thu, Sep 29, 2011 at 10:14 PM, Martin Gräßlin wrote: > So there are some solutions: > * drop screensaver support altogether, probably would create some troubles as > evil KDE removed screensavers > * add Plasma widget support to new screen locker implementation but drop > screensaver support

Re: ScreenSaver and KDE Plasma 4.8?

2011-09-29 Thread Ivan Cukic
> But when compositing is turned off, you currently get the plain old > implementation including screen savers. And I don't want to change that > code. I'm with Marco on this one. I don't think having two totally different code paths and user exp is a good idea. > * drop screensaver support al

Re: Review Request: Remove waste setTextBackgroundColor for internal KTextEdit in Plasma::TextEdit widget

2011-09-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102698/ --- (Updated Sept. 30, 2011, 6:25 a.m.) Review request for Plasma. Changes -

Re: Review Request: Remove waste setTextBackgroundColor for internal KTextEdit in Plasma::TextEdit widget

2011-09-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102698/#review6939 --- Ship it! Ship It! - Aaron J. Seigo On Sept. 30, 2011, 6:25 a

Re: Plasma Applet empty config entrymap in init() but filled entrymap after init()

2011-09-29 Thread Aaron J. Seigo
On Wednesday, September 28, 2011 14:28:36 Oliver Friedrich wrote: > Hello > > I'm writing an applet. Therefore I call in init() configChanged() which > calls "KConfigGroup cg=config()". > cg.entryMap() should return the entries I put in before. > The problem is that the entryMap is empty until ini