Re: Review Request 115435: Add an option to uniform the style of time and data in digital clock applet

> On Feb. 3, 2014, 9:34 a.m., Sebastian Kügler wrote: > > Unfortunately, we have to discard this patch, as it adds a feature and > > kde-workspace has been in feature freeze for some time now. > > > > The implementation in Plasma Next is an entirely different one, so this > > catch can't be ca

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

> On Feb. 3, 2014, 9:32 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/digital-clock/clock.cpp, line 714 > > > > > > This seems overly complex to me. In other such places, we happily use > > "M". > >

Re: Review Request 115452: Use a single layout for panels

> On Feb. 3, 2014, 8:31 p.m., Marco Martin wrote: > > hmm, do minimum sizes and fillWidth/fillHeight keep working with it? > > David Edmundson wrote: > It seems to. The task manager stretches to fit, and is the one that > shrinks when I resize the panel. > Internally the QtQuickLayouts

Re: Review Request 115452: Use a single layout for panels

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115452/#review48868 --- Ship it! Ship It! - Marco Martin On Feb. 3, 2014, 8:10 p.m

Re: Review Request 115452: Use a single layout for panels

> On Feb. 3, 2014, 8:31 p.m., Marco Martin wrote: > > hmm, do minimum sizes and fillWidth/fillHeight keep working with it? It seems to. The task manager stretches to fit, and is the one that shrinks when I resize the panel. Internally the QtQuickLayouts Row object uses from QQuickGridLayoutBase

Re: Review Request 115452: Use a single layout for panels

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115452/#review48861 --- hmm, do minimum sizes and fillWidth/fillHeight keep working wi

Review Request 115452: Use a single layout for panels

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115452/ --- Review request for Plasma. Repository: kde-workspace Description --

Re: Proposed fix for issue 330115

On Mon, Feb 3, 2014 at 10:34 PM, R.Harish Navnit wrote: > Hello everyone , > > I've successfully built plasma-mediacenter in my newly installed kubuntu > 13.10 on my laptop . However , the problems with the virtualbox still > persist (The virtualbox also has kubuntu 13.10) . > Do you have problem

Re: Minutes Monday Plasma hangout

Hi David, Thanks for the review! On Monday, February 03, 2014 18:07:51 David Edmundson wrote: > > sebas: > > > > - sebas/themeswitch branch allows switching themes, almost good to merge: > > - Blur should depend on theme values > > - styled icons don't change on theme changes (not

Re: Minutes Monday Plasma hangout

EDIT: I of course mean QHash> and then keeping a strong ref in the public Theme object. I know what I mean anyway. I'll try and submit a review when I've got through the other hundred items more important items in my TODO list. ___ Plasma-devel mailing

Re: Review Request 115448: Fix multiscreen popup positioning

> On Feb. 3, 2014, 6:07 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/dialog.cpp, line 258 > > > > > > why do you cast to int? That will break with > > https://git.reviewboard.kde.org/r/115442/ >

Re: Review Request 115448: Fix multiscreen popup positioning

> On Feb. 3, 2014, 5:07 p.m., Martin Gräßlin wrote: > > src/declarativeimports/core/dialog.cpp, line 258 > > > > > > why do you cast to int? That will break with > > https://git.reviewboard.kde.org/r/115442/ we

Re: Review Request 115448: Fix multiscreen popup positioning

> On Feb. 3, 2014, 5:40 p.m., Àlex Fiestas wrote: > > src/declarativeimports/core/dialog.cpp, lines 299-301 > > > > > > What does it represent then? QWindow::screen() is always only the screen where the window g

Re: Review Request 115448: Fix multiscreen popup positioning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115448/#review48842 --- src/declarativeimports/core/dialog.cpp

Re: Proposed fix for issue 330115

That is good news, I hope you can work on your laptop directly :) On Mon, Feb 3, 2014 at 10:34 PM, R.Harish Navnit wrote: > Hello everyone , > > I've successfully built plasma-mediacenter in my newly installed kubuntu > 13.10 on my laptop . However , the problems with the virtualbox still > pers

Re: Minutes Monday Plasma hangout

> sebas: > - sebas/themeswitch branch allows switching themes, almost good to merge: > - Blur should depend on theme values > - styled icons don't change on theme changes (notmart will have a > look) > I did a code review of the branch. A few nitpicks Missing & in src/plasma/pack

Re: Proposed fix for issue 330115

Hello everyone , I've successfully built plasma-mediacenter in my newly installed kubuntu 13.10 on my laptop . However , the problems with the virtualbox still persist (The virtualbox also has kubuntu 13.10) . Regards. R.Harish Navnit The Enigma On Mon, Feb

Re: Review Request 115448: Fix multiscreen popup positioning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115448/#review48840 --- src/declarativeimports/core/dialog.cpp

Re: Review Request 115448: Fix multiscreen popup positioning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115448/#review48832 --- Ship it! Code looks good. src/declarativeimports/core/dialo

Re: Review Request 115447: Add songs or videos to Misc playlist while pmc is running.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115447/ --- (Updated Feb. 3, 2014, 3:53 p.m.) Review request for Plasma, Shantanu Tus

Review Request 115447: Add songs or videos to Misc playlist while pmc is running.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115447/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository:

[plasma-framework] src/declarativeimports: units.longDuration and units.shortDuration properties

Git commit 30e98ba8f7646fcceaf85cc808e05fcc88b66442 by Sebastian Kügler. Committed on 03/02/2014 at 15:30. Pushed by sebas into branch 'master'. units.longDuration and units.shortDuration properties These centralize the duration of animations, currently set to 250 and 50 milliseconds. They're not

Review Request 115448: Fix multiscreen popup positioning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115448/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Proposed fix for issue 330115

On Thu, Jan 30, 2014 at 11:44 AM, sujith h wrote: > Hi Harish, > > Try this only if you are *not* having trouble with downloading the gz > files mentioned by Shantanu. > I was able to download the packages manually but I don't know how to handle them . Where do I extract it to ? Regards. R.Hari

Re: Proposed fix for issue 330115

On Wed, Jan 29, 2014 at 9:39 PM, Shantanu Tushar Jha wrote: > did you try apt-get update few more times? If yes, It could be that files > above a size are blocked? Try downloading them manually and see if you get > an error or something, the URLs which failed for you are- > > > http://in.archive.u

Re: Release schedule for Plasma Next: Recap

On Wednesday, January 29, 2014 13:52:43 Sebastian Kügler wrote: > What do you think? I've gone over the replies in this thread, and reduced it down to the following points that have been agreed upon: - Two freezes (soft, hard) - target date for repo splitting needed - more intermediate releases,

Re: Minutes Monday Plasma hangout

On Monday 03 February 2014 13:31:55 Sebastian Kügler wrote: > Plasma Meeting February, 3rd, 2014 > Present: David Edmundson, Marco Martin, Martin Gräßlin, Sebastian Kügler > > sebas: > - sebas/themeswitch branch allows switching themes, almost good to merge: > - Blur should depend on theme v

Minutes Monday Plasma hangout

Plasma Meeting February, 3rd, 2014 Present: David Edmundson, Marco Martin, Martin Gräßlin, Sebastian Kügler sebas: - sebas/themeswitch branch allows switching themes, almost good to merge: - Blur should depend on theme values - styled icons don't change on theme changes (notmart wi

Re: Release schedule for Plasma Next

On Wednesday, January 29, 2014 13:52:43 Sebastian Kügler wrote: > What do you think? During our weekly hangout, the following points came up: - Martin G requested to exclude Wayland-specific code to be exempt from feature freezes (as they don't affect code running under X11), no objections were

Re: Animation durations

On Monday, February 03, 2014 13:02:45 David Edmundson wrote: > >to be made configurable, and put into units, even? In this case, > > > > we'll probably need a more fine-grained solution, maybe > > units.shortAnimation (for things like highlights on buttons), and > > longAnimation (for example the s

Re: Animation durations

>to be made configurable, and put into units, even? In this case, > we'll probably need a more fine-grained solution, maybe units.shortAnimation > (for things like highlights on buttons), and longAnimation (for example the > sliding of a popup). > Putting into units makes sense. For now you can ju

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

> On Feb. 3, 2014, 9:32 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/digital-clock/clock.cpp, line 714 > > > > > > This seems overly complex to me. In other such places, we happily use > > "M". > >

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

> On Feb. 3, 2014, 9:35 a.m., David Edmundson wrote: > > plasma/generic/applets/digital-clock/clock.cpp, line 736 > > > > > > Why this change? If this patch applies, the font will be smaller than before. I hope

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

> On Feb. 3, 2014, 9:32 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/digital-clock/clock.cpp, line 714 > > > > > > This seems overly complex to me. In other such places, we happily use > > "M". > >

Re: Review Request 115435: Add an option to uniform the style of time and data in digital clock applet

Hi Yichao, On Monday, February 03, 2014 10:50:04 Yichao Zhou wrote: > If I also want to implement some new features in the task bar (or task > manager) applet, will these changes available to Plasma Next? The taskbar, like the digital clock is frozen (they're both part of workspace), so new feat

Re: Review Request 115435: Add an option to uniform the style of time and data in digital clock applet

> On Feb. 3, 2014, 9:34 a.m., Sebastian Kügler wrote: > > Unfortunately, we have to discard this patch, as it adds a feature and > > kde-workspace has been in feature freeze for some time now. > > > > The implementation in Plasma Next is an entirely different one, so this > > catch can't be ca

Re: Review Request 115435: Add an option to uniform the style of time and data in digital clock applet

> On Feb. 3, 2014, 9:34 a.m., Sebastian Kügler wrote: > > Unfortunately, we have to discard this patch, as it adds a feature and > > kde-workspace has been in feature freeze for some time now. > > > > The implementation in Plasma Next is an entirely different one, so this > > catch can't be ca

Re: Animation durations

On Monday 03 February 2014, Jens Reuterberg wrote: > The issue here is not only about the length of animation but the STYLE of > animation. This is of course my own personal small tests on friends/family > (they are hardly anywhere near definitive or even scientific) but the most > hated bit isn't

Re: Animation durations

> would be nice to find something in this regard..the interwebs doesn't seem > to have much.. do you have any source? One of the things we talked about in bcn was to have popups slide only 50-100 pixels, and fade in at the same time. Looks faster, and is really nice visually. -- There are no

Re: Animation durations

> Anybody objecting to adding this to units, in the form of shortDuration and > longDuration properties (I agree with Ivan that the currently used ones are > not the most intuitive names)? No objections from me :) -- Those people who think they know everything are a great annoyance to those of

Re: Animation durations

On Monday 03 February 2014, Thomas Pfeiffer wrote: > That's why the exact values for these levels should be based on either > published scientific research or our own studies (I'd prefer published > studies if we find them, because conducting such studies well would > require a lot of work). We'd w

Re: Animation durations

The issue here is not only about the length of animation but the STYLE of animation. This is of course my own personal small tests on friends/family (they are hardly anywhere near definitive or even scientific) but the most hated bit isn't the speed but things like the "lagging animation". You

Re: Animation durations

On 03.02.2014 00:50, Vishesh Handa wrote: On Sunday 02 February 2014 16:59:00 Marco Martin wrote: i'm not sure if configurability is a good idea at all. Could you please elaborate on rationale behind this? Is it just technical? the only this that should be configurable is the possibility to

Re: Animation durations

On Monday 03 February 2014, Vishesh Handa wrote: > On Sunday 02 February 2014 16:59:00 Marco Martin wrote: > > i'm not sure if configurability is a good idea at all. > > Could you please elaborate on rationale behind this? Is it just technical? > > > the only this that should be configurable is t

Re: Animation durations

On Sunday, February 02, 2014 16:59:00 Marco Martin wrote: > On Sunday 02 February 2014, Sebastian Kügler wrote: > > On Sunday, February 02, 2014 11:24:59 Ivan Čukić wrote: > > > Is there any particular reason for Animations.js not being present in > > > the > > > qmldir file of PlasmaExtras? > > >

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/#review48794 --- This seems pretty clever. Thanks. A few comments below. plas

Re: Review Request 115435: Add an option to uniform the style of time and data in digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115435/#review48796 --- Unfortunately, we have to discard this patch, as it adds a fea

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/#review48795 --- Thanks for the patch, one remark inline. Otherwise, I think it

Re: Review Request 115435: Add an option to uniform the style of time and data in digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115435/#review48793 --- plasma/generic/applets/digital-clock/clock.cpp