Re: Review Request 117779: fix crash when textureNode-texture() is null

2014-04-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117779/#review56587 --- I'd rather not want to see us hide this crash. There is an

Re: plasma-framework in kdereview

2014-04-26 Thread Kevin Ottens
Hello, On Saturday 26 April 2014 02:33:07 Kevin Ottens wrote: On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote: El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure: since it was done earlier this week, better announce it formally, so everybody can

Build failed in Jenkins: plasma-desktop_master_qt5 #75

2014-04-26 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_master_qt5/75/ -- Started by user dfaure Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/plasma-desktop_master_qt5/ws/ Running Prebuild steps

Re: plasma-framework in kdereview

2014-04-26 Thread Marco Martin
On 4/26/14, David Edmundson da...@davidedmundson.co.uk wrote: foreach (KConfigSkeletonItem *item, loader.items()) { d-operationsMap[item-group()][item-key()] = item-property(); } I ran plasmaengineexplorer and the UI for the activities service appeared properly. ok, if it

Jenkins build is back to normal : khotkeys_master_qt5 #10

2014-04-26 Thread KDE CI System
See http://build.kde.org/job/khotkeys_master_qt5/10/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 117783: Handle QxOrm release and debug mode properly

2014-04-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith

Re: Review Request 117783: Handle QxOrm release and debug mode properly

2014-04-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/ --- (Updated April 26, 2014, 5:27 p.m.) Review request for Plasma, Shantanu

Re: Review Request 117783: Handle QxOrm release and debug mode properly

2014-04-26 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/#review56612 --- cmake/FindQxOrm.cmake

Re: Review Request 117783: Handle QxOrm release and debug mode properly

2014-04-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/ --- (Updated April 26, 2014, 6:11 p.m.) Review request for Plasma, Shantanu

Re: plasma-framework in kdereview

2014-04-26 Thread Marco Martin
On Saturday, April 26, 2014, David Faure fa...@kde.org wrote: David is acting on the move as I'm typing that email. Stay tuned! :-) plasma-framework is now under frameworks/. kdesrc-build users, remember to do rm -rf kdereview/plasma-framework playground/libs/plasma-framework to avoid

Review Request 117784: Remove duplicated ConfigLoader

2014-04-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117784/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 117732: Move settings class to lib from shell

2014-04-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117732/ --- (Updated April 26, 2014, 6:32 p.m.) Status -- This change has been

Re: Review Request 117784: Remove duplicated ConfigLoader

2014-04-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117784/ --- (Updated April 26, 2014, 1:02 p.m.) Review request for Plasma. Changes

Re: Review Request 117783: Handle QxOrm release and debug mode properly

2014-04-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/ --- (Updated April 26, 2014, 6:39 p.m.) Review request for Plasma, Shantanu

Re: Review Request 117783: Handle QxOrm release and debug mode properly

2014-04-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/ --- (Updated April 26, 2014, 6:41 p.m.) Review request for Plasma, Shantanu

Re: Review Request 117783: Handle QxOrm release and debug mode properly

2014-04-26 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/#review56617 --- cmake/FindQxOrm.cmake

Re: Review Request 117783: Handle QxOrm release and debug mode properly

2014-04-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/ --- (Updated April 26, 2014, 7:11 p.m.) Review request for Plasma, Shantanu

Re: Review Request 117784: Remove duplicated ConfigLoader

2014-04-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117784/#review56623 --- did you try a service? here for instance the mpris dataengine

Re: Review Request 117783: Handle QxOrm release and debug mode properly

2014-04-26 Thread Christophe Giboudeaux
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/#review56625 --- Ship it! Ship It! cmake/FindQxOrm.cmake

Build failed in Jenkins: kde-runtime_frameworks_qt5 #164

2014-04-26 Thread KDE CI System
See http://build.kde.org/job/kde-runtime_frameworks_qt5/164/changes Changes: [afiestas] soliduiserver has been moved to plasma-workspace repo. [afiestas] Remove solid-device-automounter -- [...truncated 9 lines...] From git://anongit.kde.org/kde-runtime

Re: Review Request 117783: Handle QxOrm release and debug mode properly

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/#review56626 --- This review has been submitted with commit

Re: Review Request 117783: Handle QxOrm release and debug mode properly

2014-04-26 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783/ --- (Updated April 26, 2014, 2:13 p.m.) Status -- This change has been

Re: Review Request 117784: Remove duplicated ConfigLoader

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117784/#review56627 --- This review has been submitted with commit

Re: Review Request 117784: Remove duplicated ConfigLoader

2014-04-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117784/ --- (Updated April 26, 2014, 3:09 p.m.) Status -- This change has been

New 4.11.x release dates

2014-04-26 Thread Mario Fux
Morning guys I just added some new release dates for the Plasma 4.11.x LTS release: http://techbase.kde.org/Schedules/KDE4/4.11_Release_Schedule We tried to coordinate it as much as possible with the KDE apps 4.13 and 4.14 release schedules. Nice Sunday wishes Mario

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-26 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/ --- (Updated April 26, 2014, 6:17 p.m.) Status -- This change has been

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/#review56644 --- This review has been submitted with commit

Review Request 117798: Add a ComboBox to PlasmaComponents

2014-04-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117798/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 117798: Add a ComboBox to PlasmaComponents

2014-04-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117798/#review56651 --- Nice! Maybe you could keep the style file in a separate

Re: Review Request 117798: Add a ComboBox to PlasmaComponents

2014-04-26 Thread David Edmundson
On April 26, 2014, 8:55 p.m., Aleix Pol Gonzalez wrote: Nice! Maybe you could keep the style file in a separate file? One day it could be useful. Also you need to modify the CMakeLists.txt file to install it too, no? No, there's a install(DIRECTORY qml/ DESTINATION