Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 18, 2014, 11:58 a.m., Marco Martin wrote: > > framesvgitem part starting to look good! > > I would still like to have all of framesvg private again tough > > Aleix Pol Gonzalez wrote: > Can you ellaborate on what don't you like about the approach? > We're not installing headers

Re: Assign plasmoid global shortcut to custom action

On Sunday 20 July 2014, Simone Gaiarin wrote: > Hi all, > I'm trying to use the global shortcut that the user can configure from the > "Shortcut configuration page" of a plasma applet, to trigger a KAction and > let the plasmoid do something. > > I've done this > > //Setup the action > m_

Re: Review Request 119379: Lockscreen accessibility

> On Lug. 20, 2014, 4:11 p.m., David Edmundson wrote: > > lookandfeel/contents/components/LogoutOptions.qml, line 64 > > > > > > I think this may need to be i18ncd; unless someone is setting the > > catalog on th

Fallbacks for packages

Hi all, I have been thinking about the problem of the look and feel and shell packages: we want them to be easily customizable for distributions without forcing to copy and paste the mayority of the qml in the package (and also having things like providing only a spashscreen and nothing else)

Re: Plasma 5

On Wednesday, July 16, 2014 03:09:51 Rob Merritt wrote: [...] > Right. I think that's successfully conveyed how pleased as punch I am, so > I'll shut up now. > > See ya, and keep it coming!! Thanks Rob, your feedback is much appreciated and makes us happier hackers! :) -- sebas http://www.kde.o

Minutes Monday Plasma Hangout

Minutes Plasma Hangout week 30, 21st July 2014 Present: Antonis, Aleix, David, Jonathan, Marco, Martin Gräßlin, Vishesh, Sebastian Antonis: - worked on porting the Plasma Active panel, done - worked on porting the Plasma Active widgets explorer, minor issues remain Aleix - worked with David on

Re: Wayland planning meeting

On Wednesday, July 16, 2014 15:49:42 Sebastian Kügler wrote: > Hey, > > During the planning meeting for 5.1, it became evident that we need a > planning meeting for our Wayland efforts. Here's a doodle, that, if you > will work on Wayland support or can help otherwise, you'll want to fill in: > >

Re: Wayland planning meeting

On Monday, July 21, 2014 12:39:52 Sebastian Kügler wrote: > On Wednesday, July 16, 2014 15:49:42 Sebastian Kügler wrote: > > Hey, > > > > > > > > During the planning meeting for 5.1, it became evident that we need a > > planning meeting for our Wayland efforts. Here's a doodle, that, if you > > >

Review Request 119384: Plasma-Active: Make widget explorer more friendly on touch devices.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119384/ --- Review request for Plasma and Marco Martin. Repository: plasma-mobile D

Re: Review Request 119384: Plasma-Active: Make widget explorer more friendly on touch devices.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119384/#review62771 --- activeshellpackage/package/contents/views/Desktop.qml

Re: Review Request 119384: Plasma-Active: Make widget explorer more friendly on touch devices.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119384/ --- (Updated July 21, 2014, 11:48 a.m.) Review request for Plasma and Marco M

Re: Review Request 119384: Plasma-Active: Make widget explorer more friendly on touch devices.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119384/#review62773 --- Ship it! You should also center it horizontally activeshell

Re: Review Request 118180: slideshow BUG patch fix

> On June 5, 2014, 10:12 a.m., Christoph Feck wrote: > > Please add Plasma developers to the group of reviewers. > > > > Btw, you cannot give "Ship It" to yourself, others have to approve it. > > TOM Harrison wrote: > that just a wrong click :) > > TOM Harrison wrote: > thanks for remi

Re: Review Request 118180: slideshow BUG patch fix

> On 六月 5, 2014, 10:12 a.m., Christoph Feck wrote: > > Please add Plasma developers to the group of reviewers. > > > > Btw, you cannot give "Ship It" to yourself, others have to approve it. > > TOM Harrison wrote: > that just a wrong click :) > > TOM Harrison wrote: > thanks for remind

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62779 --- libs/plasmagenericshell/backgrounddialog.cpp

Re: Review Request 118180: slideshow BUG patch fix

> On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote: > > what kind of issue? tab and space different ? - TOM --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62779 --

Re: Review Request 118180: slideshow BUG patch fix

> On July 21, 2014, 12:39 p.m., Martin Gräßlin wrote: > > > > TOM Harrison wrote: > what kind of issue? tab and space different ? Yes, don't use tabs at all for code indentation, use 4 spaces. It should look consistent with the surrounding code after that. - Sebastian -

Wayland plasnning meeting notes

This is hopefully a synopsis of what has been said in the wayland planning meeting. If I got something wrong, please reply in the thread the correction ;) mgraesslin: * will give a talk on the current state at akademy * it probably does not make any sense to start working on other parts before

Re: Review Request 118180: slideshow BUG patch fix

> On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote: > > > > TOM Harrison wrote: > what kind of issue? tab and space different ? > > Sebastian Kügler wrote: > Yes, don't use tabs at all for code indentation, use 4 spaces. It should > look consistent with the surrounding code after that.

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62784 --- modulo the indentation, it should be ok - Marco Martin On G

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated 七月 21, 2014, 1:12 p.m.) Review request for kde-workspace and Pla

Re: Assign plasmoid global shortcut to custom action

Yes. It's kde4. 2014-07-21 10:29 GMT+02:00 Marco Martin : > On Sunday 20 July 2014, Simone Gaiarin wrote: > > Hi all, > > I'm trying to use the global shortcut that the user can configure from > the > > "Shortcut configuration page" of a plasma applet, to trigger a KAction > and > > let the plas

Re: Wayland plasnning meeting notes

On Mon, Jul 21, 2014 at 3:06 PM, Marco Martin wrote: > This is hopefully a synopsis of what has been said in the wayland planning > meeting. > > If I got something wrong, please reply in the thread the correction ;) > > > mgraesslin: > * will give a talk on the current state at akademy > * it pro

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/ --- (Updated July 21, 2014, 1:51 p.m.) Review request for Plasma. Repositor

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/#review62788 --- It is possible to have neither private objects exported, neith

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 2:09 p.m., Marco Martin wrote: > > src/plasma/framesvg.h, line 290 > > > > > > err, it's not really how I intended in the previous review.. adding > > public api is even worse... > > > >

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 2:09 p.m., Marco Martin wrote: > > It is possible to have neither private objects exported, neither public api > > added. Yes, it duplicates a bit of the implementation, but I rather prefer > > it a lot than either adding api or exporting private symbols. It's possible to d

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 2:09 p.m., Marco Martin wrote: > > src/plasma/framesvg.h, line 290 > > > > > > err, it's not really how I intended in the previous review.. adding > > public api is even worse... > > > >

Re: Minutes Monday Plasma Hangout

I mentioned in the meeting that I was poking around in the Intel graphics driver with Aleix. That's now in a Qt bug report here: https://bugreports.qt-project.org/browse/QTBUG-40341 The short version of it is: Qt defaults to a loading an OpenGL context with comparability for a super super old ve

org.kde.notifications settings via qtscript

Hi, i was pointed here with my plasma/desktop configuration issue. I want to set a certain configuration item for the notifications via qtscript. I tried to access the systemtray widget and access from there the applet for org.kde.notifications. But this did not work. Any idea how to set configurat

Re: Wayland plasnning meeting notes

2014-07-21 15:51 GMT+02:00 Aleix Pol : > On Mon, Jul 21, 2014 at 3:06 PM, Marco Martin wrote: >> >> This is hopefully a synopsis of what has been said in the wayland planning >> meeting. >> >> Plasmashell relies heavily on KScreen that may pose a problem: it will >> need >> either to have KScreen

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/ --- (Updated July 21, 2014, 4:04 p.m.) Review request for Plasma. Changes -

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/#review62799 --- Ship it! yes, that :p still an issue below I'm unsure of.

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 4:26 p.m., Marco Martin wrote: > > src/plasma/framesvg.cpp, line 480 > > > > > > are you sure about this one? > > doesn't contentGeometry returns the rectangle adjusted only by frame > >

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/ --- (Updated July 21, 2014, 4:40 p.m.) Status -- This change has been ma

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 4:26 p.m., Marco Martin wrote: > > src/plasma/framesvg.cpp, line 480 > > > > > > are you sure about this one? > > doesn't contentGeometry returns the rectangle adjusted only by frame > >

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/#review62810 --- seems the patch doesn't apply anymore, at least reviewboard co

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 4:26 p.m., Marco Martin wrote: > > src/plasma/framesvg.cpp, line 480 > > > > > > are you sure about this one? > > doesn't contentGeometry returns the rectangle adjusted only by frame > >

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 4:26 p.m., Marco Martin wrote: > > src/plasma/framesvg.cpp, line 480 > > > > > > are you sure about this one? > > doesn't contentGeometry returns the rectangle adjusted only by frame > >

Re: Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

On Monday 21 July 2014 16:40:48 David Edmundson wrote: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119330/ > --- > > (Updated

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 4:26 p.m., Marco Martin wrote: > > src/plasma/framesvg.cpp, line 480 > > > > > > are you sure about this one? > > doesn't contentGeometry returns the rectangle adjusted only by frame > >

Re: 4.x transition blockage - workspace libs

On 07/18/2014 06:54 PM, Harald Sitter wrote: > On Thu, Jul 17, 2014 at 1:37 PM, Michael Palimaka > wrote: >>> I just discused this with mgraesslin on IRC and he's fine with adding >>> a compatibility build flag to 4.x that makes it only install the >>> necessary libraries to avoid file conflicts

Re: Re: 4.x transition blockage - workspace libs

On Tuesday 22 July 2014 05:28:36 Michael Palimaka wrote: > On 07/18/2014 06:54 PM, Harald Sitter wrote: > > On Thu, Jul 17, 2014 at 1:37 PM, Michael Palimaka wrote: > >>> I just discused this with mgraesslin on IRC and he's fine with adding > >>> a compatibility build flag to 4.x that makes it o

Re: Review Request 119352: missing fclose - Resource leaking

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119352/ --- (Updated July 21, 2014, 11:09 p.m.) Status -- This change has been m