Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread Marco Martin
> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > > ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) > > > > - Compiler warning: > > > > fr

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- (Updated July 23, 2014, 9:18 a.m.) Review request for KDE Frameworks and

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread David Edmundson
> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > > ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) > > > > - Compiler warning: > > > > fr

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread Marco Martin
> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > > ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) > > > > - Compiler warning: > > > > fr

Re: Review Request 119409: framework part of the applet alternatives shooser

2014-07-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119409/ --- (Updated July 23, 2014, 10:31 a.m.) Status -- This change has been m

Alternatives config

2014-07-23 Thread Marco Martin
Hi all, now the alternatives config ui has landed. about the ui behavior, see https://forum.kde.org/viewtopic.php?f=285&t=122067&p=315919#p315919 right now, how make alternatives appear? right now is using X-Plasma-Provides in the desktop file (it's a list, an applet may provide more than one th

Re: Alternatives config

2014-07-23 Thread Martin Gräßlin
On Wednesday 23 July 2014 12:35:33 Marco Martin wrote: > Hi all, > > now the alternatives config ui has landed. > about the ui behavior, see > https://forum.kde.org/viewtopic.php?f=285&t=122067&p=315919#p315919 > > right now, how make alternatives appear? > right now is using X-Plasma-Provides in

Re: Alternatives config

2014-07-23 Thread Ivan Čukić
> go for a new key. You never know what 3rd-party applets do, so having an > explicit key they need to opt-in is way more secure. +10 ... and don't put it in any example plasmoid :) Cheerio, Ivan KDE, ivan.cukic at kde.org, http://ivan.fomentgroup.org/ gpg key id: 850B6F76, keyserver.pgp.com

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread David Edmundson
> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > > ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) > > > > - Compiler warning: > > > > fr

Re: Alternatives config

2014-07-23 Thread Marco Martin
On Wednesday 23 July 2014 12:42:15 Martin Gräßlin wrote: > > so, either using this new key for purpose, or adjusting the categories of > > things that don't work yet. > > > > opinions? > > go for a new key. You never know what 3rd-party applets do, so having an > explicit key they need to opt-in

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread Marco Martin
> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > > ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) > > > > - Compiler warning: > > > > fr

Re: Re: Alternatives config

2014-07-23 Thread Martin Gräßlin
On Wednesday 23 July 2014 13:06:22 Marco Martin wrote: > On Wednesday 23 July 2014 12:42:15 Martin Gräßlin wrote: > > > so, either using this new key for purpose, or adjusting the categories > > > of > > > things that don't work yet. > > > > > > opinions? > > > > go for a new key. You never know

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread Marco Martin
> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > > ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) > > > > - Compiler warning: > > > > fr

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread David Edmundson
> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > > ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) > > > > - Compiler warning: > > > > fr

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread Marco Martin
> On July 22, 2014, 10:50 p.m., Eike Hein wrote: > > Two issues: > > > > - Existing Dialog instances don't get the corner mask applied correctly > > when switching from transparent to opague: > > > > ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) > > > > - Compiler warning: > > > > fr

Re: Alternatives config

2014-07-23 Thread Eike Hein
On 07/23/2014 12:35 PM, Marco Martin wrote: opinions? Hmm, let's talk about Task Manager ... I'm bringing back Icon Tasks for 5.1, and it would be nice to also ship Netrunner's Expanding Icons Taskmanager (similar to Icon Tasks, but launchers expand into regular tasks with labels when run, a

Re: Alternatives config

2014-07-23 Thread Marco Martin
On Wednesday 23 July 2014 13:07:47 Martin Gräßlin wrote: > On Wednesday 23 July 2014 13:06:22 Marco Martin wrote: > > On Wednesday 23 July 2014 12:42:15 Martin Gräßlin wrote: > > > > so, either using this new key for purpose, or adjusting the categories > > > > of > > > > things that don't work yet

Re: Alternatives config

2014-07-23 Thread Marco Martin
On Wednesday 23 July 2014 13:40:28 Eike Hein wrote: > On 07/23/2014 12:35 PM, Marco Martin wrote: > > opinions? > > Hmm, let's talk about Task Manager ... > > I'm bringing back Icon Tasks for 5.1, and it would be nice to also > ship Netrunner's Expanding Icons Taskmanager (similar to Icon Tasks,

Re: Alternatives config

2014-07-23 Thread Eike Hein
On 07/23/2014 01:48 PM, Marco Martin wrote: i could add a key in the metadata file, that overrides the folder where the package is searched for, so two plasmoid metadatas could point to the same plasmoid package That's a good first step, but how do we let the package know which identity it ha

Re: Alternatives config

2014-07-23 Thread Marco Martin
On Wednesday 23 July 2014 13:54:29 Eike Hein wrote: > On 07/23/2014 01:48 PM, Marco Martin wrote: > > i could add a key in the metadata file, that overrides the folder where > > the > > package is searched for, so two plasmoid metadatas could point to the same > > plasmoid package > > That's a goo

Re: Alternatives config

2014-07-23 Thread Eike Hein
On 07/23/2014 02:00 PM, Marco Martin wrote: there is already a property in qml plasmoid.pluginName Sounds good then! Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Alternatives config

2014-07-23 Thread Thomas Pfeiffer
On 23.07.2014 13:48, Marco Martin wrote: I'm bringing back Icon Tasks for 5.1, and it would be nice to also ship Netrunner's Expanding Icons Taskmanager (similar to Icon Tasks, but launchers expand into regular tasks with labels when run, and all windows appear on the bar, grouped together and dr

Re: Review Request 119406: Always take the painter based path for composeOverBorder

2014-07-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/ --- (Updated July 23, 2014, 1:53 p.m.) Status -- This change has been ma

Review Request 119424: Fix paths used in kstartupconfig

2014-07-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119424/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 119424: Fix paths used in kstartupconfig

2014-07-23 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119424/#review62962 --- Question: instead of writing into ~/.config, why not using ~/

Re: Review Request 119424: Fix paths used in kstartupconfig

2014-07-23 Thread David Edmundson
> On July 23, 2014, 2:06 p.m., Luca Beltrame wrote: > > Question: instead of writing into ~/.config, why not using > > ~/.config/plasma-workspace? (for all the programs mentioned). IMO it does > > not make sense to pollute the root of ~/.config. plasma-workspace is > > already used by startkde

Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 119424: Fix paths used in kstartupconfig

2014-07-23 Thread Luca Beltrame
> On Lug. 23, 2014, 2:06 p.m., Luca Beltrame wrote: > > Question: instead of writing into ~/.config, why not using > > ~/.config/plasma-workspace? (for all the programs mentioned). IMO it does > > not make sense to pollute the root of ~/.config. plasma-workspace is > > already used by startkde

Re: Review Request 119424: Fix paths used in kstartupconfig

2014-07-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119424/#review62966 --- Ship it! Makes sense, I don't have .config/share but I have .

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review62967 --- src/declarativeimports/core/framesvgitem.cpp

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 23, 2014, 3:35 p.m.) Status -- This change has been ma

Re: Review Request 119424: Fix paths used in kstartupconfig

2014-07-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119424/ --- (Updated July 23, 2014, 3:39 p.m.) Status -- This change has been ma

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review62973 --- Ignore the marking as submitted. I had two reviewboard tabs op

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Marco Martin
> On July 23, 2014, 2:38 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 391 > > > > > > this means every object performs a method on a singleton. > > > > Arguably fol

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Aleix Pol Gonzalez
> On July 23, 2014, 2:38 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 391 > > > > > > this means every object performs a method on a singleton. > > > > Arguably fol

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Aleix Pol Gonzalez
> On July 23, 2014, 2:38 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 391 > > > > > > this means every object performs a method on a singleton. > > > > Arguably fol

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Marco Martin
> On July 23, 2014, 2:38 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 391 > > > > > > this means every object performs a method on a singleton. > > > > Arguably fol

Review Request 119430: Don't remove dbus-activated plasmoids too early.

2014-07-23 Thread Anton Kreuzkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119430/ --- Review request for Plasma and Sebastian Kügler. Repository: plasma-worksp

Re: Review Request 119430: Don't remove dbus-activated plasmoids too early.

2014-07-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119430/#review62985 --- Ship it! good catch applets/systemtray/plugin/protocols/pla

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Aleix Pol Gonzalez
> On July 23, 2014, 2:38 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 391 > > > > > > this means every object performs a method on a singleton. > > > > Arguably fol

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Marco Martin
> On July 23, 2014, 2:38 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 391 > > > > > > this means every object performs a method on a singleton. > > > > Arguably fol

Re: Review Request 119430: Don't remove dbus-activated plasmoids too early.

2014-07-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119430/#review62988 --- Ship it! Good catch, patch seems sane. Thanks for fixing this

Re: Fallbacks for packages

2014-07-23 Thread Marco Martin
On Mon, Jul 21, 2014 at 11:26 AM, Marco Martin wrote: > Hi all, > > I have been thinking about the problem of the look and feel and shell > packages: we want them to be easily customizable for distributions without > forcing to copy and paste the mayority of the qml in the package (and also > hav

Re: Review Request 119430: Don't remove dbus-activated plasmoids too early.

2014-07-23 Thread Anton Kreuzkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119430/ --- (Updated July 23, 2014, 7:40 p.m.) Status -- This change has been ma

Re: Review Request 119379: Lockscreen accessibility

2014-07-23 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119379/ --- (Updated July 23, 2014, 11:17 p.m.) Status -- This change has been m

Re: Review Request 119425: Cache the textures created for the fast path

2014-07-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 24, 2014, 12:44 a.m.) Review request for Plasma. Changes