port plasma to imx6 device (cubox-i)

2014-07-28 Thread Malte Grosse
Dear plasma team, ive seen a review about the new plasma 5. i really like the design - it looks really nice. my question is - if anybody is interested in porting the new plasma to the cubox-i? the cubox i is a small arm device (freescale imx6) http://www.solid-run.com/wiki/CuBox-i_Hardware the

systemtray initial configuration

2014-07-28 Thread Marek Marczykowski-Górecki
Hello, I'm trying to alter default configuration of systemtray applet. I want to remove device notifier (notifier) from there, but keep org.kde.notifications and others. The problem is that whenever I touch systemtray configuration (even simple reloadConfig call), org.kde.notifications widget

Re: Review Request 119465: Have separate texture hashes for each window

2014-07-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119465/#review63313 --- src/declarativeimports/core/framesvgitem.cpp

Minutes Monday Plasma Hangout

2014-07-28 Thread Sebastian Kügler
Minutes Plasma Hangout week 31, 28th July 2014 Present: Antonis, Marco, David, Ivan, Jonathan, Vishesh, Sebastian, Aleix, Aleix: - worked on texture sharing in FrameSvg Antonis: - Worked on widgetexplorer in Active shell - Worked on main containment for Active - both need more work David: -

Review Request 119513: reintroduce containmentForScreen(int screen, const QString defaultPluginIfNonExistent, args)

2014-07-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119513/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 119513: reintroduce containmentForScreen(int screen, const QString defaultPluginIfNonExistent, args)

2014-07-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119513/#review63318 --- Ship it! Ship It! - Sebastian Kügler On July 28, 2014,

Re: Review Request 119513: reintroduce containmentForScreen(int screen, const QString defaultPluginIfNonExistent, args)

2014-07-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119513/ --- (Updated July 28, 2014, 11:46 a.m.) Status -- This change has been

Review Request 119515: Support per-activity favourites

2014-07-28 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119515/ --- Review request for Plasma, Eike Hein, Marco Martin, and Sebastian Kügler.

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119515/#review63321 --- +1 from me, would like toknow from Eike if this provides all

Re: Minutes Monday Plasma Hangout

2014-07-28 Thread Marco Martin
On Monday 28 July 2014, Sebastian Kügler wrote: - Started mechanism to load stuff from Look and Feel packages would like comment on https://git.reviewboard.kde.org/r/119451/ Based on the discussion with David in the hangout, i would still do: - the look and feel package provides qml files for

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Eike Hein
On July 28, 2014, 12:03 p.m., Marco Martin wrote: +1 from me, would like toknow from Eike if this provides all is needed for use cases outside kickoff Kicker doesn't use Kickoff's models, i.e. activity support has to be implemented in Kicker's own favorites model. - Eike

Re: Using more of our CI, Coverage and cppcheck

2014-07-28 Thread Aleix Pol
On Sun, Jul 27, 2014 at 11:59 PM, Àlex Fiestas afies...@kde.org wrote: Hi there! During this weekend Ben and I have enabled the code-coverage in plasma- framework, my personal idea is to enable it in most projects. We should not go loco with code coverage, we stand where we stand and

Re: port plasma to imx6 device (cubox-i)

2014-07-28 Thread Aleix Pol
On Mon, Jul 21, 2014 at 2:32 PM, Malte Grosse malte.gro...@googlemail.com wrote: Dear plasma team, ive seen a review about the new plasma 5. i really like the design - it looks really nice. my question is - if anybody is interested in porting the new plasma to the cubox-i? the cubox i is a

Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

2014-07-28 Thread Raphael Kubo da Costa
On July 19, 2014, 12:17 a.m., Vadim Zhukov wrote: (As a general note, for build system related stuff like this you can also try including the buildsystem group, which can be more responsive at times) The ibus-panel can't build on OpenBSD because some required definitions

Re: Review Request 119464: port ToolButton to QtControls

2014-07-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/#review63337 --- Ship it! Ship It! - David Edmundson On July 25, 2014,

Re: Review Request 119464: port ToolButton to QtControls

2014-07-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/ --- (Updated July 28, 2014, 3:50 p.m.) Status -- This change has been

Re: Minutes Monday Plasma Hangout

2014-07-28 Thread Marco Martin
On Monday 28 July 2014, Marco Martin wrote: On Monday 28 July 2014, Sebastian Kügler wrote: - Started mechanism to load stuff from Look and Feel packages would like comment on https://git.reviewboard.kde.org/r/119451/ Based on the discussion with David in the hangout, i would still

qml controls and documentation

2014-07-28 Thread Marco Martin
Hi all, right now the plasma qml components are documented not bad, like: http://api.kde.org/frameworks-api/frameworks5-apidocs/plasma-framework/html/classorg_1_1kde_1_1plasma_1_1components_1_1TextField.html however, porting them to QtControls, has the sideeffect of pretty much killing the

Re: qml controls and documentation

2014-07-28 Thread Aleix Pol
On Mon, Jul 28, 2014 at 6:11 PM, Marco Martin notm...@gmail.com wrote: Hi all, right now the plasma qml components are documented not bad, like: http://api.kde.org/frameworks-api/frameworks5-apidocs/plasma-framework/html/classorg_1_1kde_1_1plasma_1_1components_1_1TextField.html however,

Re: Review Request 119464: port ToolButton to QtControls

2014-07-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/#review63340 --- The ugly thing here is that QtControls ToolButton doesn't

Running Plasma on Qt 5.4

2014-07-28 Thread Aleix Pol
Hi, Just in case somebody has the magic idea of trying Qt 5.4, bear in mind that it's currently not working (or, well, working very bad). Here's a patch if you really feel like trying it [1] which seems to work. Cheers! Aleix [1] https://codereview.qt-project.org/#/c/90811/

Re: Review Request 119464: port ToolButton to QtControls

2014-07-28 Thread Marco Martin
On July 28, 2014, 4:40 p.m., David Edmundson wrote: The ugly thing here is that QtControls ToolButton doesn't have a flat property, it should probably be upstreamed, at least for compatibility with the qwidgets ToolButton I can't see a flat property on the widget's toolbutton.

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Ivan Čukić
On July 28, 2014, 12:03 p.m., Marco Martin wrote: +1 from me, would like toknow from Eike if this provides all is needed for use cases outside kickoff Eike Hein wrote: Kicker doesn't use Kickoff's models, i.e. activity support has to be implemented in Kicker's own favorites

Review Request 119522: readlink fails whens the folder does not exist.

2014-07-28 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119522/ --- Review request for Plasma and Àlex Fiestas. Repository: plasma-workspace

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119515/#review63347 --- Ship it! for kickoff, for what i'm concerned is good to go

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Thomas Braxton
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119515/#review63349 --- applets/kickoff/package/contents/ui/ContextMenu.qml

Re: Review Request 119522: readlink fails whens the folder does not exist.

2014-07-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119522/#review63351 --- So does it still work if it's a link, after this patch? -

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Ivan Čukić
On July 28, 2014, 5:31 p.m., Thomas Braxton wrote: applets/kickoff/package/contents/ui/ContextMenu.qml, line 62 https://git.reviewboard.kde.org/r/119515/diff/1/?file=293832#file293832line62 addToGlobalFavorites sounds better Agreed. - Ivan

Re: Review Request 119522: readlink fails whens the folder does not exist.

2014-07-28 Thread Rohan Garg
On July 28, 2014, 11:14 p.m., Aleix Pol Gonzalez wrote: So does it still work if it's a link, after this patch? Yep, works when my ~/.config is a symlink. - Rohan --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 119465: Have separate texture hashes for each window

2014-07-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119465/ --- (Updated July 28, 2014, 5:48 p.m.) Status -- This change has been

Re: Review Request 119515: Support per-activity favourites

2014-07-28 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119515/ --- (Updated July 28, 2014, 5:50 p.m.) Status -- This change has been

Re: qml controls and documentation

2014-07-28 Thread Marco Martin
On Monday 28 July 2014, Aleix Pol wrote: does somebody knows if is possible with the markup used now for extracting documentation to still have comments to document all the properties, even those *not* defined in the qml file in question? It should probably look more or less like

Review Request 119524: Force OpenGLES if on Qt 5.4

2014-07-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 119523: port TextField to QtControls

2014-07-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-07-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/#review63360 --- I still don't have 5.4 to test for now.. but, are you sure

Re: Review Request 119523: port TextField to QtControls

2014-07-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/#review63363 --- Even if we fix the methods it's too close to 5.1 to merge

Re: Review Request 119523: port TextField to QtControls

2014-07-28 Thread Marco Martin
On July 28, 2014, 6:54 p.m., David Edmundson wrote: src/declarativeimports/plasmacomponents/qml/TextField.qml, line 366 https://git.reviewboard.kde.org/r/119523/diff/1/?file=293985#file293985line366 This is going to overlap with the text I think. It might be worth trying to

Re: Review Request 119523: port TextField to QtControls

2014-07-28 Thread David Edmundson
On July 28, 2014, 6:54 p.m., Marco Martin wrote: Which methods do we need the inner control for? I saw positionAtPos and positionToRectangle, any others? Marco Martin wrote: those two and passwordCharacter and missing properties are: passwordCharacter errorHighlight - David

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-07-28 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/#review63366 --- If there is one hardware combination that works best on

Re: Review Request 119523: port TextField to QtControls

2014-07-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/#review63367 ---

Re: Review Request 119523: port TextField to QtControls

2014-07-28 Thread Marco Martin
On July 28, 2014, 7:09 p.m., Kai Uwe Broulik wrote: src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml, line 52 https://git.reviewboard.kde.org/r/119523/diff/1/?file=293986#file293986line52 Can't you account for the clear button width here? probably On July

Re: Review Request 119523: port TextField to QtControls

2014-07-28 Thread David Edmundson
On July 28, 2014, 6:54 p.m., David Edmundson wrote: src/declarativeimports/plasmacomponents/qml/TextField.qml, line 366 https://git.reviewboard.kde.org/r/119523/diff/1/?file=293985#file293985line366 This is going to overlap with the text I think. It might be worth trying to

Re: Minutes Monday Plasma Hangout

2014-07-28 Thread Marco Martin
On Monday 28 July 2014, Marco Martin wrote: [Icons] Theme=~/.share/plasma/lookandfeel/foo/icons comments on that? furthermore, how would you prefer to use it? as a standalone library? static in plasma-workspace stuff? in libplasmaquick? other? next on that, the lookandfeel package

Re: qml controls and documentation

2014-07-28 Thread Aleix Pol
On Mon, Jul 28, 2014 at 8:07 PM, Marco Martin notm...@gmail.com wrote: On Monday 28 July 2014, Aleix Pol wrote: does somebody knows if is possible with the markup used now for extracting documentation to still have comments to document all the properties, even those *not* defined in

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-07-28 Thread Aleix Pol Gonzalez
On July 28, 2014, 6:25 p.m., Eike Hein wrote: Can you recompile plasma-desktop with OpenGL ES and test if the drag pixmap for Folder icons works? I wrote the code in a way that ought to work on both desktop GL and ES, but it's worth testing. I have it running with OpenGLES at the

Re: Review Request 119524: Force OpenGLES if on Qt 5.4

2014-07-28 Thread Aleix Pol Gonzalez
On July 28, 2014, 7:03 p.m., Mark Gaiser wrote: If there is one hardware combination that works best on linux, it's OpenGL + Intel. I find it hard to believe that GLES is better and in all cases. That must be a driver/mesa bug that should be investigated and fixed. If this

Re: Minutes Monday Plasma Hangout

2014-07-28 Thread Aleix Pol
On Mon, Jul 28, 2014 at 9:36 PM, Marco Martin notm...@gmail.com wrote: On Monday 28 July 2014, Marco Martin wrote: [Icons] Theme=~/.share/plasma/lookandfeel/foo/icons comments on that? furthermore, how would you prefer to use it? as a standalone library? static in plasma-workspace

Re: Minutes Monday Plasma Hangout

2014-07-28 Thread Aleix Pol
On Mon, Jul 28, 2014 at 5:56 PM, Marco Martin notm...@gmail.com wrote: On Monday 28 July 2014, Marco Martin wrote: On Monday 28 July 2014, Sebastian Kügler wrote: - Started mechanism to load stuff from Look and Feel packages would like comment on