Jenkins build is back to normal : plasma-desktop_master_qt5 #593

2014-08-28 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Àlex Fiestas
On Thursday 28 August 2014 12:14:28 Sebastian Kügler wrote: > I agree that it could be tried, but I wouldn't be surprised if for Plasma, > we come to a different conclusion. There's a certain difference in the > "audiences" between Unity and Plasma Is there? I don't really know what is our audienc

Re: Review Request 119983: Use font metrics to scale icons for high dpi outputs

2014-08-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119983/#review65459 --- src/declarativeimports/core/units.cpp

Review Request 119983: Use font metrics to scale icons for high dpi outputs

2014-08-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119983/ --- Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Vishesh Ha

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Sebastian Kügler
On Thursday, August 28, 2014 19:54:53 David Edmundson wrote: > > For this case, to allow to configure this basic functionality we came up > > with greying them out if the plasmoid is not configured to show > > non-removable devices. This way it's clear that it currently does not hold > > any inform

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread David Edmundson
> > For this case, to allow to configure this basic functionality we came up > with greying them out if the plasmoid is not configured to show > non-removable devices. This way it's clear that it currently does not hold > any information, however the configuration dialogue is still available. The

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Philipp Stefan
On 28.08.2014 17:52, Marco Martin wrote: On Tuesday 26 August 2014 21:26:42 Philipp Stefan wrote: Hello everyone, the VDG told me to take a look at the system tray after the 5.0 releases, because even though it's a huge step forward, we felt that there are some inconsistencies in how it behave

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Philipp Stefan
On 28.08.2014 14:32, Sebastian Kügler wrote: On Thursday, August 28, 2014 13:38:49 Marco Martin wrote: it is a really a bad thing to have so many empty panels in - no devices, no notifications, no batteries etc. I think for batteries, we're doing that already (at least in Plasma 4 we didn't a

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Marco Martin
On Thursday 28 August 2014 19:06:45 David Edmundson wrote: > > I don't understand why we would have an extra state. > > If one wants to completely hide a status notifier, don't create a > status notifier in the first place. yes, if an application doesn't need it and is visible, it should just no

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread David Edmundson
On Thu, Aug 28, 2014 at 5:52 PM, Marco Martin wrote: > On Tuesday 26 August 2014 21:26:42 Philipp Stefan wrote: >> Hello everyone, >> >> the VDG told me to take a look at the system tray after the 5.0 >> releases, because even though it's a huge step forward, we felt that >> there are some inconsi

Re: Request: better override functionality in locale settings

2014-08-28 Thread Thomas Pfeiffer
On Thursday 28 August 2014 12:21:21 Sebastian Kügler wrote: > > Actually, while the fact that choosing formats and units by locale instead > > of directly isn't necessarily a usability problem, presenting all locales > > in a single drop-down _is_ . > > Surely, and almost every bugreport has some

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Kai Uwe Broulik
> yeah, the function to check from the scripting engine is there and ported, > but > the systray doesn't use it and just adds it by default, i guess because there > are brightness controls as well now And the PM checkbox which is handy on desktop too. And it shows your mouse battery, if any.

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Marco Martin
On Thursday 28 August 2014 18:09:49 Ivan Čukić wrote: > > I think for batteries, we're doing that already (at least in Plasma 4 we > > didn't add the battery plasmoid to the panel for desktop systems). > > It does not work for me. Source install on the desktop system, but I do have > the battery i

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Ivan Čukić
> I think for batteries, we're doing that already (at least in Plasma 4 we > didn't add the battery plasmoid to the panel for desktop systems). It does not work for me. Source install on the desktop system, but I do have the battery indicator. Cheerio ___

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Marco Martin
On Tuesday 26 August 2014 21:26:42 Philipp Stefan wrote: > Hello everyone, > > the VDG told me to take a look at the system tray after the 5.0 > releases, because even though it's a huge step forward, we felt that > there are some inconsistencies in how it behaves. My task was to > identify these

Re: Review Request 119913: Force creation of a OpenGL core context

2014-08-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119913/ --- (Updated Aug. 28, 2014, 5:35 nachm.) Status -- This change has been

Re: Review Request 119945: Dialog: Simplify handling of min/max width/height changed

2014-08-28 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119945/ --- (Updated Aug. 28, 2014, 2:39 p.m.) Status -- This change has been di

Re: Review Request 119974: port Slider to QtControls

2014-08-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/ --- (Updated Aug. 28, 2014, 2:17 p.m.) Status -- This change has been ma

Re: Review Request 119974: port Slider to QtControls

2014-08-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/ --- (Updated Aug. 28, 2014, 2:14 p.m.) Review request for Plasma. Repositor

Re: Review Request 119974: port Slider to QtControls

2014-08-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/#review65440 --- Ship it! src/declarativeimports/plasmacomponents/qml/Slider.

Re: Review Request 119974: port Slider to QtControls

2014-08-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/ --- (Updated Aug. 28, 2014, 2:09 p.m.) Review request for Plasma. Repositor

Re: Review Request 119974: port Slider to QtControls

2014-08-28 Thread Marco Martin
> On Aug. 28, 2014, 1:46 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml, line 35 > > > > > > in the last review we explicilty set panel to Item {} > > > >

Re: Review Request 119974: port Slider to QtControls

2014-08-28 Thread Marco Martin
> On Aug. 28, 2014, 1:31 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmacomponents/qml/Slider.qml, lines 125-126 > > > > > > Is that still needed? > > Marco Martin wrote: > I don't know, but t

Re: Review Request 119974: port Slider to QtControls

2014-08-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/#review65431 --- src/declarativeimports/plasmacomponents/qml/Slider.qml

Re: Review Request 119974: port Slider to QtControls

2014-08-28 Thread Marco Martin
> On Aug. 28, 2014, 1:31 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmacomponents/qml/Slider.qml, lines 125-126 > > > > > > Is that still needed? I don't know, but the base component doesn't have

Re: Review Request 119974: port Slider to QtControls

2014-08-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/#review65430 --- src/declarativeimports/plasmacomponents/qml/Slider.qml

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Marco Martin
On Thursday 28 August 2014 14:32:38 Sebastian Kügler wrote: > I'd think that dbus-activated plasmoids don't need this, since they come and > go already (makes them essentially hidden). > > For the devicenotifier, it has to stay, since it could be configured to show > non-removable devices as well,

Re: Review Request 119964: Avoid dlopening plasmaadapter's devel symlink

2014-08-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119964/ --- (Updated Aug. 28, 2014, 12:42 p.m.) Status -- This change has been m

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Sebastian Kügler
On Thursday, August 28, 2014 13:38:49 Marco Martin wrote: > > > it is a really a bad thing to have so many empty panels in - no > > > devices, > > > no notifications, no batteries etc. > > > > I think for batteries, we're doing that already (at least in Plasma 4 we > > didn't add the battery plasm

Re: Review Request 119964: Avoid dlopening plasmaadapter's devel symlink

2014-08-28 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119964/#review65427 --- Ship it! Ship It! - Bhushan Shah On Aug. 28, 2014, 11:09 a

Review Request 119974: port Slider to QtControls

2014-08-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/ --- Review request for Plasma. Summary (updated) - port Slid

Re: Review Request 119967: Fix systemloadviewer monitorType settings

2014-08-28 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119967/ --- (Updated Aug. 28, 2014, 12:05 p.m.) Status -- This change has been m

Re: Review Request 119967: Fix systemloadviewer monitorType settings

2014-08-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119967/#review65420 --- Ship it! Ship It! - David Edmundson On Aug. 28, 2014, 8:23

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Marco Martin
On Thursday 28 August 2014 12:02:04 Sebastian Kügler wrote: > On Wednesday, August 27, 2014 10:12:54 Ivan Čukić wrote: > > I'm not going to chime in regarding the applications - I tend to agree > > with > > both parties - that not everything needs to be shown, yet that people like > > some of their

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Sebastian Kügler
[I'm obviously on the list, CC:ing breaks threading and filtering for me] On Thursday, August 28, 2014 12:29:19 Kai Uwe Broulik wrote: > > I think for batteries, we're doing that already (at least in Plasma 4 we > > didn't add the battery plasmoid to the panel for desktop systems). > > I am not

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Kai Uwe Broulik
Hi, > I think for batteries, we're doing that already (at least in Plasma 4 we > didn't add the battery plasmoid to the panel for desktop systems). I am not sure whether distributions with their custom layout.js picked that up (I'm not even sure if I changed that in our default layout) but batt

Re: Request: better override functionality in locale settings

2014-08-28 Thread Sebastian Kügler
On Wednesday, August 27, 2014 19:16:29 Thomas Pfeiffer wrote: > On Wednesday 27 August 2014 11:34:52 Sebastian Kügler wrote: > > > In my opinion, this is a very serious usability regression and would > > > stop me from using Plasma 5. Are there any plans to change the > > > behavior/appearance of t

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Thomas Pfeiffer
On Thursday 28 August 2014 12:02:04 Sebastian Kügler wrote: > For notifications and storage devices, I quite like the idea. Maybe worth a > try to hide them completely and gauge the user reaction? (I can imagine > nobody would miss it.) +1. If people just want to access the configuration for them,

Re: Request: better override functionality in locale settings

2014-08-28 Thread Thomas Pfeiffer
On Thursday 28 August 2014 10:06:07 John Layt wrote: > Just setting the standard POSIX codes has one very big advantage in > being universal: all apps running under Plasma will respect them, > rather than just KDE apps. If we implement a Qt-only solution then any > POSIX/glibc/Java/Firefox/ > Chrom

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Sebastian Kügler
On Thursday, August 28, 2014 12:08:04 Martin Klapetek wrote: > On Thu, Aug 28, 2014 at 12:02 PM, Sebastian Kügler wrote: > > On Tuesday, August 26, 2014 22:00:54 Eike Hein wrote: > > Hiding "passive" status notifier items robs the user of an > > entire tier of organization when deciding how near/

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Martin Klapetek
On Thu, Aug 28, 2014 at 12:02 PM, Sebastian Kügler wrote: > On Tuesday, August 26, 2014 22:00:54 Eike Hein wrote: > > Hiding "passive" status notifier items robs the user of an > > entire tier of organization when deciding how near/far they > > want to place a running app. > > This may also encou

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Sebastian Kügler
On Wednesday, August 27, 2014 10:12:54 Ivan Čukić wrote: > I'm not going to chime in regarding the applications - I tend to agree with > both parties - that not everything needs to be shown, yet that people like > some of their applications minimized to tray (myself included - I even hide > those

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Sebastian Kügler
On Tuesday, August 26, 2014 22:00:54 Eike Hein wrote: > Hiding "passive" status notifier items robs the user of an > entire tier of organization when deciding how near/far they > want to place a running app. This may also encourage more abuse: i.e. not setting the status to hidden, ever. Remember

Re: VDG suggestions and wishes about the system tray

2014-08-28 Thread Sebastian Kügler
On Tuesday, August 26, 2014 22:35:01 Philipp Stefan wrote: > In case of music players and similar, we feel like these applications > should not provide their own status notifiers. E.g. a music player > should be controlled via their mpris2 interface, which can be accessed > by a separate plasmoi

Re: Review Request 119966: add an InteractiveConsole.qml

2014-08-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119966/ --- (Updated Aug. 28, 2014, 9:54 a.m.) Status -- This change has been ma

Re: Review Request 119965: rely on shell package to create the interactive console interface

2014-08-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119965/ --- (Updated Aug. 28, 2014, 9:53 a.m.) Status -- This change has been ma

Re: Request: better override functionality in locale settings

2014-08-28 Thread John Layt
Hi, Just to add to the background (and seeing as I'm the primary culprit in the death of KLocale and the slow pace of improvements to QLocale), there's 2 very big reasons for removing it (and the consequent loss of the customization feature): 1) It was very big and a maintenance burden, especially

Re: Request: better override functionality in locale settings

2014-08-28 Thread John Layt
Hi, Just to add to the background (and seeing as I'm the primary culprit in the death of KLocale and the slow pace of improvements to QLocale), there's 2 very big reasons for removing it (and the consequent loss of the customization feature): 1) It was very big and a maintenance burden, especially

Re: Review Request 119966: add an InteractiveConsole.qml

2014-08-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119966/#review65401 --- Ship it! Ship it! (after 119965) - Marco Martin On Aug. 28

Re: Review Request 119965: rely on shell package to create the interactive console interface

2014-08-28 Thread Aaron J. Seigo
> On Aug. 28, 2014, 8:48 a.m., Marco Martin wrote: > > shell/interactiveconsole.h, line 158 > > > > > > Could this be an enum? It could, yes. It means importing an enum into the QML runtime, though, and that me

Re: Request: better override functionality in locale settings

2014-08-28 Thread Martin Klapetek
On Thu, Aug 28, 2014 at 10:37 AM, John Layt wrote: > On 28 August 2014 09:28, Martin Klapetek > wrote: > > On Wed, Aug 27, 2014 at 11:34 AM, Sebastian Kügler > wrote: > >> > >> > >> There's more than just metric and imperial. This page gives you a slight > >> impression of the complexity: > >>

Re: Review Request 119965: rely on shell package to create the interactive console interface

2014-08-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119965/#review65399 --- Ship it! I was definitely bothered by the dependency from kte

Re: Re: Request: better override functionality in locale settings

2014-08-28 Thread Martin Gräßlin
On Wednesday 27 August 2014 19:16:29 Thomas Pfeiffer wrote: > On Wednesday 27 August 2014 11:34:52 Sebastian Kügler wrote: > > > In my opinion, this is a very serious usability regression and would > > > stop me from using Plasma 5. Are there any plans to change the > > > behavior/appearance of thi

Re: Request: better override functionality in locale settings

2014-08-28 Thread John Layt
On 28 August 2014 09:31, Harald Sitter wrote: > On Thu, Aug 28, 2014 at 3:49 AM, Matthew Ruffalo wrote: >> I still strongly, *strongly* disagree that it's acceptable for a user to >> choose an appropriate locale for override settings. > > Perhaps I am leaning myself way out the window but I think

Re: Request: better override functionality in locale settings

2014-08-28 Thread John Layt
On 28 August 2014 09:28, Martin Klapetek wrote: > On Wed, Aug 27, 2014 at 11:34 AM, Sebastian Kügler wrote: >> >> >> There's more than just metric and imperial. This page gives you a slight >> impression of the complexity: >> http://en.wikipedia.org/wiki/Imperial_units#Current_use_of_imperial_uni

Re: Request: better override functionality in locale settings

2014-08-28 Thread John Layt
On 28 August 2014 09:28, Martin Klapetek wrote: > On Wed, Aug 27, 2014 at 11:34 AM, Sebastian Kügler wrote: >> >> >> There's more than just metric and imperial. This page gives you a slight >> impression of the complexity: >> http://en.wikipedia.org/wiki/Imperial_units#Current_use_of_imperial_uni

Re: Request: better override functionality in locale settings

2014-08-28 Thread John Layt
On 28 August 2014 09:31, Harald Sitter wrote: > On Thu, Aug 28, 2014 at 3:49 AM, Matthew Ruffalo wrote: > Perhaps I am leaning myself way out the window but I think there is > one very portable solution to this problem: writing an own locale > defintion [1] and installing&configuring that. And I

Re: Request: better override functionality in locale settings

2014-08-28 Thread Harald Sitter
On Thu, Aug 28, 2014 at 3:49 AM, Matthew Ruffalo wrote: > I still strongly, *strongly* disagree that it's acceptable for a user to > choose an appropriate locale for override settings. Perhaps I am leaning myself way out the window but I think there is one very portable solution to this problem:

Re: Request: better override functionality in locale settings

2014-08-28 Thread Martin Klapetek
On Wed, Aug 27, 2014 at 11:34 AM, Sebastian Kügler wrote: > > There's more than just metric and imperial. This page gives you a slight > impression of the complexity: > http://en.wikipedia.org/wiki/Imperial_units#Current_use_of_imperial_units > > A binary combobox is just not enough to portray th

Review Request 119967: Fix systemloadviewer monitorType settings

2014-08-28 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119967/ --- Review request for Plasma. Repository: kdeplasma-addons Description ---

Review Request 119966: add an InteractiveConsole.qml

2014-08-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119966/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 119965: rely on shell package to create the interactive console interface

2014-08-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119965/ --- (Updated Aug. 28, 2014, 8:17 a.m.) Review request for Plasma. Repositor

Review Request 119965: rely on shell package to create the interactive console interface

2014-08-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119965/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Request: better override functionality in locale settings

2014-08-28 Thread Matthew Ruffalo
On 08/27/2014 01:16 PM, Thomas Pfeiffer wrote: > On Wednesday 27 August 2014 11:34:52 Sebastian Kügler wrote: >>> In my opinion, this is a very serious usability regression and would >>> stop me from using Plasma 5. Are there any plans to change the >>> behavior/appearance of this settings applet?