Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/ --- (Updated Out. 30, 2014, 1:35 a.m.) Review request for kdewin and Plasma.

Re: Review Request 120894: Forward wheel events inside panelview

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120894/ --- (Updated Okt. 29, 2014, 8:56 nachm.) Review request for Plasma. Changes

Re: Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/ --- (Updated Oct. 29, 2014, 9:41 p.m.) Review request for Plasma, Ben Cooksle

Re: Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

> On Okt. 29, 2014, 12:41 nachm., Thomas Lübking wrote: > > The version check is actually on the bugzilla version (KDE_MAKE_VERSION is > > just a bitshifting macro) - it's the important part in the original patch > > ;-) > > Thomas Lübking wrote: > To prevent future confusion, one might wa

Re: Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/ --- (Updated Oct. 29, 2014, 9:25 p.m.) Review request for Plasma, Ben Cooksle

Re: Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

> On Oct. 29, 2014, 1:41 p.m., Thomas Lübking wrote: > > The version check is actually on the bugzilla version (KDE_MAKE_VERSION is > > just a bitshifting macro) - it's the important part in the original patch > > ;-) > > Thomas Lübking wrote: > To prevent future confusion, one might want

Re: Review Request 120894: Forward wheel events inside panelview

> On Ott. 29, 2014, 7:55 p.m., Marco Martin wrote: > > shell/panelview.cpp, line 688 > > > > > > would be cleaner to put it in its own case, instead of grouped together > > with the mouse events, since is comple

Re: Review Request 120894: Forward wheel events inside panelview

> On Okt. 29, 2014, 7:55 nachm., Marco Martin wrote: > > shell/panelview.cpp, line 688 > > > > > > would be cleaner to put it in its own case, instead of grouped together > > with the mouse events, since is comp

Re: Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

> On Okt. 29, 2014, 12:41 nachm., Thomas Lübking wrote: > > The version check is actually on the bugzilla version (KDE_MAKE_VERSION is > > just a bitshifting macro) - it's the important part in the original patch > > ;-) > > Thomas Lübking wrote: > To prevent future confusion, one might wa

Re: Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

> On Oct. 29, 2014, 1:41 p.m., Thomas Lübking wrote: > > The version check is actually on the bugzilla version (KDE_MAKE_VERSION is > > just a bitshifting macro) - it's the important part in the original patch > > ;-) > > Thomas Lübking wrote: > To prevent future confusion, one might want

Re: Review Request 120894: Forward wheel events inside panelview

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120894/#review69482 --- Ship it! good apart a small issue. Also, this should be done

Review Request 120894: Forward wheel events inside panelview

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120894/ --- Review request for Plasma. Bugs: 340412 https://bugs.kde.org/show_bug

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120806/ --- (Updated Oct. 29, 2014, 6:23 p.m.) Status -- This change has been ma

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120806/#review69475 --- Ship it! Ship It! - David Edmundson On Oct. 28, 2014, 5:48

Re: Review Request 120891: Remove unused logout effects in KSMServer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120891/#review69474 --- Ship it! Ship It! - Martin Gräßlin On Oct. 29, 2014, 6:14

Review Request 120892: move notification out of the way of other plasma windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120892/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 120891: Remove unused logout effects in KSMServer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120891/#review69473 --- Ship it! +1 that's in the category of "world cultural heritag

Review Request 120891: Remove unused logout effects in KSMServer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120891/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 109832: New tabbox layout with scaling thumbnails

> On Oct. 29, 2014, 12:57 p.m., Kai Uwe Broulik wrote: > > tabbox/qml/clients/scaling/contents/ui/main.qml, line 405 > > > > > > i18n this? > > Andre Heinecke wrote: > I don't think this is neccessary. The b

Re: Review Request 109832: New tabbox layout with scaling thumbnails

> On Oct. 29, 2014, 12:57 p.m., Kai Uwe Broulik wrote: > > tabbox/qml/clients/scaling/contents/ui/main.qml, line 405 > > > > > > i18n this? > > Andre Heinecke wrote: > I don't think this is neccessary. The b

Re: Review Request 109832: New tabbox layout with scaling thumbnails

> On Oct. 29, 2014, 12:57 p.m., Kai Uwe Broulik wrote: > > tabbox/qml/clients/scaling/contents/ui/main.qml, line 405 > > > > > > i18n this? > > Andre Heinecke wrote: > I don't think this is neccessary. The b

Re: Review Request 109832: New tabbox layout with scaling thumbnails

> On Okt. 29, 2014, 11:57 vorm., Kai Uwe Broulik wrote: > > > > Martin Gräßlin wrote: > @Kai Uwe: may I ask you to do such a review for all other existing window > switchers? Or just have a look at them and improve as you seem fit. Okay, once they've all landed in kdeplasma-addons I will t

Re: Review Request 109832: New tabbox layout with scaling thumbnails

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109832/ --- (Updated Oct. 29, 2014, 3:22 p.m.) Review request for kwin, Plasma and Ma

Re: Review Request 120880: Import window switchers from KWin repository

> On Okt. 29, 2014, 3:06 nachm., Thomas Pfeiffer wrote: > > That means that other desktop enviornments cannot really use KWin without > > installing at least one l&f package anymore, right? Could that be a > > problem, or is KWin no fun without any L&Fs installed, anyway, even without > > that

Re: Review Request 120880: Import window switchers from KWin repository

> On Oct. 29, 2014, 4:06 p.m., Thomas Pfeiffer wrote: > > That means that other desktop enviornments cannot really use KWin without > > installing at least one l&f package anymore, right? Could that be a > > problem, or is KWin no fun without any L&Fs installed, anyway, even without > > that c

Re: Review Request 120880: Import window switchers from KWin repository

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120880/#review69457 --- That means that other desktop enviornments cannot really use K

Re: Review Request 109832: New tabbox layout with scaling thumbnails

> On Oct. 29, 2014, 11:57 a.m., Kai Uwe Broulik wrote: > > tabbox/qml/clients/scaling/contents/ui/main.qml, lines 31-32 > > > > > > Is this needed? Adds a bit of overhead and you're not using it > > consistently

Re: Review Request 120352: Remove keyboard click volume setting

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120352/#review69438 --- I don't have much of an opinion when it comes to keyboard soun

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 10:39 a.m., Martin Klapetek wrote: > > src/plasma/data/notifications/plasmashell.notifyrc, line 9 > > > > > > You myyybe also want Sound? > > Marco Martin wrote: > hmm, really? > > Mar

Re: Review Request 109832: New tabbox layout with scaling thumbnails

> On Oct. 29, 2014, 12:57 p.m., Kai Uwe Broulik wrote: > > @Kai Uwe: may I ask you to do such a review for all other existing window switchers? Or just have a look at them and improve as you seem fit. - Martin --- This is an automatica

Re: Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

> On Okt. 29, 2014, 12:41 nachm., Thomas Lübking wrote: > > The version check is actually on the bugzilla version (KDE_MAKE_VERSION is > > just a bitshifting macro) - it's the important part in the original patch > > ;-) To prevent future confusion, one might want to add #define KDE_MAKE_BUGZ

Re: Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/#review69429 --- The version check is actually on the bugzilla version (KDE_MAK

Re: Review Request 120881: [tabbox] Window Switcher layouts moved to kdeplasma-addons

> On Okt. 29, 2014, 10:07 vorm., Thomas Lübking wrote: > > i recall a crashbug on kf5 which occurred when a swtcher was configured, > > but none could be loaded (got to look out for the id) > > in case the code cannot be reasonably hardened otherwise, we might need to > > keep a failsafe. (but

Re: Review Request 109832: New tabbox layout with scaling thumbnails

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109832/#review69422 --- tabbox/qml/clients/scaling/contents/ui/main.qml

Re: Review Request 120884: [tabbox] Get DesktopSwitcher from look and feel package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120884/#review69423 --- +1 - Marco Martin On Ott. 29, 2014, 10:26 a.m., Martin Gräß

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/#review69421 --- I tried to do it in a single squashed commit again on gerrit:

Re: Review Request 109832: New tabbox layout with scaling thumbnails

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109832/ --- (Updated Oct. 29, 2014, 11:38 a.m.) Review request for kwin, Plasma and M

Re: Review Request 120884: [tabbox] Get DesktopSwitcher from look and feel package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120884/ --- (Updated Oct. 29, 2014, 11:26 a.m.) Review request for kwin and Plasma.

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 10:49 a.m., Martin Gräßlin wrote: > > src/plasma/data/notifications/plasmashell.notifyrc, lines 7-8 > > > > > > Isn't "Plasmoid" a little bit too techy? > > Marco Martin wrote: > changed (e

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 9:49 a.m., Martin Gräßlin wrote: > > src/plasma/private/applet_p.cpp, lines 239-241 > > > > > > not sure whether it's allowed in frameworks: > > > > const QStringList actions({i18n("U

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/ --- (Updated Oct. 29, 2014, 10:16 a.m.) Review request for Plasma. Reposito

Re: Review Request 120881: [tabbox] Window Switcher layouts moved to kdeplasma-addons

> On Oct. 29, 2014, 11:07 a.m., Thomas Lübking wrote: > > i recall a crashbug on kf5 which occurred when a swtcher was configured, > > but none could be loaded (got to look out for the id) > > in case the code cannot be reasonably hardened otherwise, we might need to > > keep a failsafe. (but i

Re: Review Request 120881: [tabbox] Window Switcher layouts moved to kdeplasma-addons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120881/#review69398 --- i recall a crashbug on kf5 which occurred when a swtcher was c

Re: Review Request 120884: [tabbox] Get DesktopSwitcher from look and feel package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120884/#review69397 --- Ship it! since the branches only differ by a substring which

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 10:39 a.m., Martin Klapetek wrote: > > src/plasma/data/notifications/plasmashell.notifyrc, line 9 > > > > > > You myyybe also want Sound? > > Marco Martin wrote: > hmm, really? > > Mar

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 10:39 a.m., Martin Klapetek wrote: > > src/plasma/data/notifications/plasmashell.notifyrc, line 9 > > > > > > You myyybe also want Sound? > > Marco Martin wrote: > hmm, really? out of

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/#review69388 --- out of interest: what's the bool transient about? src/plasma

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 9:39 a.m., Martin Klapetek wrote: > > src/plasma/data/notifications/plasmashell.notifyrc, line 9 > > > > > > You myyybe also want Sound? hmm, really? > On Oct. 29, 2014, 9:39 a.m., Martin

Re: Review Request 120885: basic undo for plasmoids deletion

> On Oct. 29, 2014, 9:39 a.m., Kai Uwe Broulik wrote: > > src/plasma/private/applet_p.cpp, line 240 > > > > > > The notification should have the plasmoid icon, no? indeed. knotification doesn't have api for just

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/#review69385 --- src/plasma/data/notifications/plasmashell.notifyrc

Re: Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/#review69387 --- src/plasma/private/applet_p.cpp

Review Request 120885: basic undo for plasmoids deletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/#review69384 --- No opinion on the patch but please check your coding style.

Review Request 120884: [tabbox] Get DesktopSwitcher from look and feel package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120884/ --- Review request for kwin and Plasma. Repository: kwin Description --

Review Request 120883: Move default DesktopSwitcher from KWin to Look and Feel Package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120883/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 120882: [kcm/lookandfeel] Add support for changing DesktopSwitcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120882/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 120880: Import window switchers from KWin repository

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120880/#review69381 --- related review request for KWin: https://git.reviewboard.kde.o

Review Request 120881: [tabbox] Window Switcher layouts moved to kdeplasma-addons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120881/ --- Review request for kwin and Plasma. Repository: kwin Description --

Review Request 120880: Import window switchers from KWin repository

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120880/ --- Review request for kwin and Plasma. Repository: kdeplasma-addons Descri

Re: Review Request 120849: [tabbox] Try locating the WindowSwitcher QML through configured lnf package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120849/ --- (Updated Oct. 29, 2014, 7:30 a.m.) Status -- This change has been ma

Re: Review Request 120850: Move KWin's window switcher "sidebar" to Look'n'Feel package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/ --- (Updated Oct. 29, 2014, 7:27 a.m.) Status -- This change has been ma

Re: Review Request 120847: [kcm/lookandfeel] Add support for changing WindowSwitcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120847/ --- (Updated Oct. 29, 2014, 7:26 a.m.) Status -- This change has been ma

Re: Review Request 120849: [tabbox] Try locating the WindowSwitcher QML through configured lnf package

> On Oct. 28, 2014, 11:15 p.m., Thomas Lübking wrote: > > tabbox/tabboxhandler.cpp, line 235 > > > > > > why not? (by different name, oc) yep, I was also considering moving the desktop switchers to lnf. - Mart