Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-06 Thread Martin Gräßlin
> On Jan. 5, 2015, 4:19 p.m., David Edmundson wrote: > > applets/notifications/plugin/notificationshelper.cpp, line 111 > > > > > > you're liable to break here. > > > > sometimes you call this directly n

[Breeze] [Bug 342570] New: kde4breeze copies contents of systemwide kdeglobals

2015-01-06 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=342570 Bug ID: 342570 Summary: kde4breeze copies contents of systemwide kdeglobals Product: Breeze Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Se

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121360/#review73307 --- The beta is in two days, can we please get this in? - Martin

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-06 Thread Martin Klapetek
> On Jan. 3, 2015, 9:08 p.m., Kai Uwe Broulik wrote: > > applets/notifications/plugin/notificationshelper.cpp, line 51 > > > > > > Use QScopedPointer > > Martin Klapetek wrote: > What's wrong with properly us

Re: Review Request 121887: Replace Q_WS_* macros in kglobalaccel/

2015-01-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121887/ --- (Updated Jan. 6, 2015, 8:04 p.m.) Status -- This change has been mar

Re: Review Request 121887: Replace Q_WS_* macros in kglobalaccel/

2015-01-06 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121887/#review73298 --- Ship it! Ship It! - Lukáš Tinkl On Led. 6, 2015, 8:19 odp.

Re: Breeze Window Decoration status

2015-01-06 Thread Kai Uwe Broulik
Am Dienstag, 6. Januar 2015, 18:19:55 schrieb Andrew Lake: > The vm installations I've encountered, including my current one [1], don't > have compositing enabled. One less thing to worry about. :-) > > [1] http://wstaw.org/m/2015/01/06/no-composite-problem.png Now that looks very weird, looks li

Re: Review Request 121882: Look for kglobalaccel and don't build the internal copy if >= 5.7

2015-01-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121882/ --- (Updated Jan. 6, 2015, 7:28 p.m.) Status -- This change has been mar

Review Request 121887: Replace Q_WS_* macros in kglobalaccel/

2015-01-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121887/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Breeze Window Decoration status

2015-01-06 Thread Andrew Lake
On Sun Jan 04 2015 at 11:00:49 PM Martin Gräßlin wrote: > I don't want special solutions for compositing disabled any more. It's > too much a corner case nowadays. Compositing works and becomes more and > more a requirement. This was a deliberate design decision when drafting > KDecoration2 as for

Re: Review Request 121807: Call forceActiveWindow on the sidePanel

2015-01-06 Thread Kai Uwe Broulik
> On Jan. 6, 2015, 5:54 nachm., Marco Martin wrote: > > desktoppackage/contents/views/Desktop.qml, line 102 > > > > > > but you are activating.. the desktop window? That's just confused. I added the forceActiveW

Re: Review Request 121807: Call forceActiveWindow on the sidePanel

2015-01-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121807/#review73289 --- desktoppackage/contents/views/Desktop.qml

Re: screenlocker focus questions

2015-01-06 Thread Martin Gräßlin
On Tuesday 06 January 2015 13:45:39 Sebastian Kügler wrote: > Hey, > > So I'm attempting to fix the focus of the screenlocker. When the > screenlocker is started, the focus should be on the password input, so you > can directly type after the machine woke up. This worked previously (I had > alread

Re: Minutes Monday Plasma Hangout

2015-01-06 Thread Marco Martin
On Monday 05 January 2015, Eike Hein wrote: > On 01/05/2015 03:46 PM, Sebastian Kügler wrote: > > Get better! > > Gute Besserung! > we, thanks everybody :) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailm

Re: kpackage bugzilla

2015-01-06 Thread Marco Martin
On Sunday 04 January 2015, David Edmundson wrote: > On it. thanks -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: kcm-touchpad in plasma 5.2?

2015-01-06 Thread Rajeesh K Nambiar
On Sat, Jan 3, 2015 at 7:56 PM, David Edmundson wrote: > > > On Sat, Jan 3, 2015 at 7:07 PM, Rajeesh K Nambiar > wrote: >> >> On Thu, Dec 11, 2014 at 4:30 PM, David Edmundson >> wrote: >> > In general this looks OK, there's some useful features and I can see >> > myself >> > using this. I'd very

Re: Re: kcm-touchpad in plasma 5.2?

2015-01-06 Thread Rajeesh K Nambiar
On Thu, Dec 11, 2014 at 4:30 PM, David Edmundson wrote: > In general this looks OK, there's some useful features and I can see myself > using this. I'd very much like it to become part of Plasma. > > I gave it a review and made some notes below. Thanks for the review. I cannot answer many of the

Re: Plasma naming scheme

2015-01-06 Thread Marco Martin
On Monday 05 January 2015, Aleix Pol wrote: > > For example in release announcement we'd talk about the Plasma 5.2 > > release and when there are shell specific changes we could write "Plasma > > Desktop now has addition X" > > > > Does that make sense to everyone? And if so: Where should we publi

Re: Review Request 121882: Look for kglobalaccel and don't build the internal copy if >= 5.7

2015-01-06 Thread Kai Uwe Broulik
> On Jan. 6, 2015, 5:06 nachm., Kai Uwe Broulik wrote: > > CMakeLists.txt, line 16 > > > > > > Wouldn't that fail in < 5.7 environment? Oh, damn. Nevermind. xD - Kai Uwe --

Re: Review Request 121882: Look for kglobalaccel and don't build the internal copy if >= 5.7

2015-01-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121882/#review73282 --- CMakeLists.txt

Re: Review Request 121882: Look for kglobalaccel and don't build the internal copy if >= 5.7

2015-01-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121882/#review73281 --- Ship it! Ship It! - David Faure On Jan. 6, 2015, 3:05 p.m.

Re: [kde-promo] Plasma naming scheme

2015-01-06 Thread Martin Klapetek
On Tue, Jan 6, 2015 at 5:46 PM, Thomas Pfeiffer wrote: > On Tuesday 06 January 2015 14:11:49 Sebastian Kügler wrote: > > > Does that make sense to everyone? And if so: Where should we publish it > > > and > > > where should we announce it? > > > > This nomenclature sounds fine to my ears. Does th

Re: Plasma naming scheme

2015-01-06 Thread Thomas Pfeiffer
On Tuesday 06 January 2015 14:11:49 Sebastian Kügler wrote: > > Does that make sense to everyone? And if so: Where should we publish it > > and > > where should we announce it? > > This nomenclature sounds fine to my ears. Does this need announcement? I > think the Dot editors have some wiki pages

Review Request 121882: Look for kglobalaccel and don't build the internal copy if >= 5.7

2015-01-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121882/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Plasma 5.2 bits for kdereview

2015-01-06 Thread David Edmundson
On Tue, Jan 6, 2015 at 3:23 PM, Luigi Toscano wrote: > Jonathan Riddell ha scritto: > > Updates on this.. > > > > I plan to ask for Bluedevil and libbluedevil, libkscreen and kscreen, > > libmm-qt and ksshaskpass to be moved. I see some comments that the > > libraries may be used outside of Plasm

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-06 Thread Àlex Fiestas
> On gen. 3, 2015, 8:08 p.m., Kai Uwe Broulik wrote: > > applets/notifications/plugin/notificationshelper.cpp, line 51 > > > > > > Use QScopedPointer > > Martin Klapetek wrote: > What's wrong with properly us

Re: Plasma 5.2 bits for kdereview

2015-01-06 Thread Luigi Toscano
Jonathan Riddell ha scritto: > Updates on this.. > > I plan to ask for Bluedevil and libbluedevil, libkscreen and kscreen, > libmm-qt and ksshaskpass to be moved. I see some comments that the > libraries may be used outside of Plasma but there's no problem with > that happening, they don't quality

Re: Plasma 5.2 bits for kdereview

2015-01-06 Thread Jonathan Riddell
Updates on this.. I plan to ask for Bluedevil and libbluedevil, libkscreen and kscreen, libmm-qt and ksshaskpass to be moved. I see some comments that the libraries may be used outside of Plasma but there's no problem with that happening, they don't quality for frameworks and they already get rele

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121360/ --- (Updated Jan. 6, 2015, 2:32 p.m.) Review request for Plasma and Kai Uwe B

Re: Plasma naming scheme

2015-01-06 Thread Sebastian Kügler
On Saturday, January 03, 2015 18:23:07 Thomas Pfeiffer wrote: > while writing up a vision for Plasma interaction, the VDG noticed that it > was unclear exactly what terms to use when referring to Plasma Desktop > specifically, so we thought it would make sense to clarify this. > > Therefore, we w

screenlocker focus questions

2015-01-06 Thread Sebastian Kügler
Hey, So I'm attempting to fix the focus of the screenlocker. When the screenlocker is started, the focus should be on the password input, so you can directly type after the machine woke up. This worked previously (I had already fixed it twice), but broke again recently. I've tried a few things

Jenkins build is back to normal : plasma-workspace_master_qt5 #1187

2015-01-06 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2015-01-06 Thread Bhushan Shah
> On Jan. 6, 2015, 3:07 p.m., Kai Uwe Broulik wrote: > > CMakeLists.txt, line 13 > > > > > > My CMake complains about this: > > Unknown CMake command "set_package_properties". Fixed in http://commits.kde.o

Build failed in Jenkins: plasma-workspace_master_qt5 #1186

2015-01-06 Thread KDE CI System
See Changes: [kde] Replace MEL by MouseArea -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in works

Build failed in Jenkins: plasma-workspace_master_qt5 #1185

2015-01-06 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER

Re: Review Request 121856: KWindowSystem import for KDeclarative

2015-01-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121856/#review73248 --- Thinking again about it I think methods such as "activeWindow"

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2015-01-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/#review73246 --- CMakeLists.txt

Build failed in Jenkins: plasma-workspace_master_qt5 #1184

2015-01-06 Thread KDE CI System
See Changes: [faure] Allow to compile plasma-workspace without Qt5WebKit installed. -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on Linux