Re: Review Request 122419: [screenlocker] Support global shortcuts in the lock screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122419/ --- (Updated Feb. 5, 2015, 8:58 a.m.) Review request for Plasma. Changes --

Re: Review Request 122432: Add paintedRect and paintedWidth to QImageItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/ --- (Updated Feb. 4, 2015, 8:19 p.m.) Status -- This change has been mar

Re: Review Request 122432: Add paintedRect and paintedWidth to QImageItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/#review75439 --- Ship it! Ship It! - David Edmundson On Feb. 4, 2015, 7:52

Re: Review Request 122432: Add paintedRect and paintedWidth to QImageItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/ --- (Updated Feb. 4, 2015, 7:52 p.m.) Review request for KDE Frameworks and P

Re: Review Request 122432: Add paintedRect and paintedWidth to QImageItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/#review75438 --- src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp

Review Request 122432: Add paintedRect and paintedWidth to QImageItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122432/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 4, 2015, 7:18 p.m.) Status -- This change has been mar

Re: Review Request 122430: add optional properties rangeMax and rangeMin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122430/#review75432 --- Ship it! Ship It! - David Edmundson On Feb. 4, 2015, 5:46

Re: Review Request 122430: add optional properties rangeMax and rangeMin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122430/ --- (Updated Feb. 4, 2015, 5:46 p.m.) Review request for KDE Frameworks and P

Re: Review Request 122430: add optional properties rangeMax and rangeMin

> On Feb. 4, 2015, 5:18 p.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/plotter.cpp, line 363 > > > > > > to match the docs this possibly wants a || autoRange > > > > > > other

Re: Review Request 122430: add optional properties rangeMax and rangeMin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122430/#review75430 --- src/qmlcontrols/kquickcontrolsaddons/plotter.cpp

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

> On Feb. 4, 2015, 2:31 p.m., David Edmundson wrote: > > Code is all fine. > > > > By default each of these shows nothing; showing everything would be a > > better default > > > > The disk usage one doesn't seem to work at all. It's not even remembering > > the options I select > > > > It's

Review Request 122430: add optional properties rangeMax and rangeMin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122430/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

> On Feb. 4, 2015, 4:13 p.m., Martin Gräßlin wrote: > > could the implementation be split in two files: one for legacy, one for > > systemd? I think this could make reading the file easier. > > > > Is it possible to determine at compile time whether the systemd component > > is available? E.g.

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

> On Feb. 4, 2015, 3:13 p.m., Martin Gräßlin wrote: > > could the implementation be split in two files: one for legacy, one for > > systemd? I think this could make reading the file easier. > > > > Is it possible to determine at compile time whether the systemd component > > is available? E.g.

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

> On Feb. 4, 2015, 3:13 p.m., Martin Gräßlin wrote: > > could the implementation be split in two files: one for legacy, one for > > systemd? I think this could make reading the file easier. > > > > Is it possible to determine at compile time whether the systemd component > > is available? E.g.

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

> On Feb. 4, 2015, 8:43 p.m., Martin Gräßlin wrote: > > could the implementation be split in two files: one for legacy, one for > > systemd? I think this could make reading the file easier. > > > > Is it possible to determine at compile time whether the systemd component > > is available? E.g.

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

> On Feb. 4, 2015, 8:43 p.m., Martin Gräßlin wrote: > > could the implementation be split in two files: one for legacy, one for > > systemd? I think this could make reading the file easier. > > > > Is it possible to determine at compile time whether the systemd component > > is available? E.g.

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/#review75415 --- could the implementation be split in two files: one for legacy

Re: Review Request 122402: [clipboard] Show barcodes directly in view

> On Feb. 4, 2015, 3:16 p.m., Kai Uwe Broulik wrote: > > applets/clipboard/contents/ui/BarcodePage.qml, line 54 > > > > > > Redundant tooltip > > > > (I think somewhere there was a guideline saying that w

Re: Review Request 122425: [screenlocker] Fix notifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122425/#review75413 --- Ship it! Ship It! - Martin Klapetek On Feb. 4, 2015, 3:54

Review Request 122425: [screenlocker] Fix notifications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122425/ --- Review request for Plasma and Martin Klapetek. Bugs: 276196 https://b

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

> On Feb. 4, 2015, 2:31 p.m., David Edmundson wrote: > > Code is all fine. > > > > By default each of these shows nothing; showing everything would be a > > better default > > > > The disk usage one doesn't seem to work at all. It's not even remembering > > the options I select > > > > It's

Re: Review Request 122370: Prevent icon transition in tooltip

> On Feb. 2, 2015, 6:26 p.m., David Edmundson wrote: > > So you're basically wiping the source whenever we set it to invisible? > > > > We could do that from in IconItem, and save duplicating this. yeah, i agree it's a thing that looks like it's wanted in general, therefore should go in IconIt

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

> On Feb. 4, 2015, 2:31 p.m., David Edmundson wrote: > > Code is all fine. > > > > By default each of these shows nothing; showing everything would be a > > better default > > > > The disk usage one doesn't seem to work at all. It's not even remembering > > the options I select > > > > It's

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/#review75410 --- Code is all fine. By default each of these shows nothing; sho

Re: Review Request 122402: [clipboard] Show barcodes directly in view

> On Feb. 4, 2015, 2:16 p.m., Kai Uwe Broulik wrote: > > applets/clipboard/contents/ui/BarcodePage.qml, line 104 > > > > > > running: visible ? This is already done in the style RotationAnimator on rota

Re: Review Request 122402: [clipboard] Show barcodes directly in view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122402/#review75407 --- Nice! +1 applets/clipboard/contents/ui/BarcodePage.qml

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

> On Feb. 4, 2015, 2:06 p.m., David Edmundson wrote: > > applets/systemmonitor/common/contents/ui/Applet.qml, line 121 > > > > > > is this needed? > > > > a cycle function is declared twice and seems to

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 4, 2015, 2:10 p.m.) Review request for Plasma. Repository

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/#review75405 --- applets/systemmonitor/common/contents/ui/Applet.qml

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

> On Feb. 4, 2015, 1:49 p.m., David Edmundson wrote: > > applets/systemmonitor/common/contents/ui/Applet.qml, line 164 > > > > > > what colour does the Plotter background default to? > > > > There's pote

Re: Review Request 122312: Use sysconf() instead of relying on UT_NAMESIZE

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122312/#review75402 --- Ship it! Seems sensible. - Vishesh Handa On Jan. 29, 2015,

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 4, 2015, 1:59 p.m.) Review request for Plasma. Repository

Re: Review Request 122314: Sanitize whitespace in notification popups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122314/#review75400 --- Ship it! Ship It! - David Edmundson On Jan. 30, 2015, 11:3

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

> On Feb. 4, 2015, 1:49 p.m., David Edmundson wrote: > > applets/systemmonitor/common/contents/ui/Applet.qml, line 153 > > > > > > I'm lost on something. > > > > Why do we have a component singleValuePlo

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/#review75383 --- applets/systemmonitor/common/contents/ui/Applet.qml

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

> On Feb. 4, 2015, 12:59 p.m., Marco Martin wrote: > > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 115 > > > > > > i'm not sure setting the panted rect in paint changes anything. > > > > s

Re: KDE backward compatibility issue

On Fri, Jan 30, 2015 at 8:04 PM, Martin Graesslin wrote: Hi Martin, > Patches welcome. If you think it's important and that trivial you should be > able to do it, right? Well, my area of expertise is embedded, kernel drivers and bootloaders. But OK, I'll try to implement a xembed tray widget. I

Re: KDE backward compatibility issue

On Fri, Jan 30, 2015 at 6:02 PM, Christoph Feck wrote: > On Friday 30 January 2015 11:41:42 Vasily Khoruzhick wrote: >> I've read [1] and [2] and as far as I understand, dropping xembed >> support was more political decision than technical difficulty. Hi Christoph, > I am sorry to say that you d

Jenkins build is back to normal : plasma-desktop_master_qt5 #980

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

> On Feb. 4, 2015, 12:59 p.m., Marco Martin wrote: > > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 115 > > > > > > i'm not sure setting the panted rect in paint changes anything. > > > > s

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/#review75386 --- Ship it! looks better, tough i think the setPaintRect() can s

Re: Review Request 122402: [clipboard] Show barcodes directly in view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122402/#review75384 --- Ship it! Nice simplification ^_- - Martin Klapetek On Feb.

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 4, 2015, 12:26 p.m.) Review request for Plasma. Changes -

Re: Review Request 122402: [clipboard] Show barcodes directly in view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122402/ --- (Updated Feb. 4, 2015, 1:21 p.m.) Review request for Plasma and Sune Vuor

Re: Review Request 122402: [clipboard] Show barcodes directly in view

> On Feb. 4, 2015, 12:05 p.m., Martin Klapetek wrote: > > applets/clipboard/contents/ui/BarcodePage.qml, lines 103-106 > > > > > > Why not switch the logic and put the show() inside the if? I mean the > > return

Jenkins build is back to normal : plasma-desktop_stable_qt5 #64

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Build failed in Jenkins: plasma-desktop_master_qt5 #979

See Changes: [notmart] allow free resize on desktop [me] Baloo KCM: Show proper icons (porting bug) [kde] Sort apps by name if configured -- [...truncated 851 lines...] [ 21%] Built target

Re: Review Request 122402: [clipboard] Show barcodes directly in view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122402/#review75374 --- Ship it! applets/clipboard/contents/ui/BarcodePage.qml

Build failed in Jenkins: plasma-desktop_stable_qt5 #63

See Changes: [kde] Sort apps by name if configured -- [...truncated 998 lines...] [ 28%] Generating recentadaptor.moc [ 28%] Generating screensaver_interface.moc [ 28%] Generating krunner_inte

Re: Review Request 122411: Prevent notifications from accessing the network

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122411/ --- (Updated Feb. 4, 2015, 11:01 a.m.) Status -- This change has been ma

Re: Review Request 122318: Sort apps by name if configured

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122318/ --- (Updated Feb. 4, 2015, 10:58 a.m.) Status -- This change has been ma

Re: Review Request 122419: [screenlocker] Support global shortcuts in the lock screen

> On Feb. 4, 2015, 11:28 a.m., David Edmundson wrote: > > ksmserver/screenlocker/globalaccel.cpp, line 273 > > > > > > you're not handling emacs style shortcuts here. AFAIK emacs style shortcuts are not supporte

Re: Review Request 122419: [screenlocker] Support global shortcuts in the lock screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122419/#review75369 --- ksmserver/screenlocker/globalaccel.cpp

Re: Review Request 122402: [clipboard] Show barcodes directly in view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122402/ --- (Updated Feb. 4, 2015, 11:21 a.m.) Review request for Plasma and Sune Vuo

Re: Review Request 122318: Sort apps by name if configured

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122318/#review75367 --- Ship it! Ship It! - David Edmundson On Feb. 4, 2015, 9:37

Re: Review Request 122318: Sort apps by name if configured

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122318/ --- (Updated Feb. 4, 2015, 9:37 vorm.) Review request for Plasma. Changes -

Review Request 122419: [screenlocker] Support global shortcuts in the lock screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122419/ --- Review request for Plasma. Bugs: 198097 https://bugs.kde.org/show_bug

Re: Review Request 122318: Sort apps by name if configured

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122318/#review75357 --- applets/kickoff/core/applicationmodel.h

Re: Review Request 122318: Sort apps by name if configured

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122318/#review75356 --- Ship it! Ship It! - David Edmundson On Jan. 29, 2015, 10:0

Re: Review Request 122411: Prevent notifications from accessing the network

> On Feb. 4, 2015, 7:16 vorm., Martin Gräßlin wrote: > > Just wondering: I assume the problem is also because the data is > > interpreted. Is that intended, that applications can send markup which gets > > interpreted? Yes, the specification explicitly allows (and we enforce) a subset of HTML