Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-07 Thread Martin Gräßlin
> On July 7, 2015, 1:06 a.m., Aleix Pol Gonzalez wrote: > > Looks good to me too, as long as it works. > > OTOH, it looks like a bad reason to offer an homogeneous experience, albeit > > being a not really interesting bit of Plasma. > > Hrvoje Senjan wrote: > I submited this patch to upstre

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-07 Thread Aleix Pol Gonzalez
> On July 7, 2015, 1:06 a.m., Aleix Pol Gonzalez wrote: > > Looks good to me too, as long as it works. > > OTOH, it looks like a bad reason to offer an homogeneous experience, albeit > > being a not really interesting bit of Plasma. > > Hrvoje Senjan wrote: > I submited this patch to upstre

Re: Review Request 124280: Only resize plot texture if size actually changes

2015-07-07 Thread Luca Beltrame
> On Lug. 7, 2015, 12:02 p.m., Luca Beltrame wrote: > > I can't comment on the code itself, but from my small unscientific test, > > the CPU usage of the component seems gone. > > Luca Beltrame wrote: > If that's the case (can anyone else confirm), it should also fix bug > 346134. Unfortu

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-07 Thread Hrvoje Senjan
> On July 7, 2015, 1:06 a.m., Aleix Pol Gonzalez wrote: > > Looks good to me too, as long as it works. > > OTOH, it looks like a bad reason to offer an homogeneous experience, albeit > > being a not really interesting bit of Plasma. I submited this patch to upstream due to two reasons: 1) numbe

Re: Review Request 124283: Update kcmstyle docbook to Plasma 5

2015-07-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/#review82188 --- Ship it! Ship It! - Sebastian Kügler On July 7, 2015, 4:47

Review Request 124283: Update kcmstyle docbook to Plasma 5

2015-07-07 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

Re: Review Request 124093: Bug 345405 - Prevent two wallpaper images showing overlayed when "Scaled, Keep Proportions" is chosen

2015-07-07 Thread David Edmundson
> On June 15, 2015, 5:11 p.m., David Edmundson wrote: > > I'm still not super convinced we're not just working round a bug, but I > > couldn't make a test case / fix it any other way after a solid hour of > > trying. > > > > Effect still looks good, if not better so I'm OK shipping this. I'll

Re: Review Request 124093: Bug 345405 - Prevent two wallpaper images showing overlayed when "Scaled, Keep Proportions" is chosen

2015-07-07 Thread William Lieurance
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124093/ --- (Updated July 7, 2015, 4:26 p.m.) Status -- This change has been mar

Re: Review Request 124093: Bug 345405 - Prevent two wallpaper images showing overlayed when "Scaled, Keep Proportions" is chosen

2015-07-07 Thread William Lieurance
> On June 15, 2015, 5:11 p.m., David Edmundson wrote: > > I'm still not super convinced we're not just working round a bug, but I > > couldn't make a test case / fix it any other way after a solid hour of > > trying. > > > > Effect still looks good, if not better so I'm OK shipping this. I'll

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 66 - Failure!

2015-07-07 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/66/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 07 Jul 2015 15:41:50 + Build duration: 11 min CHANGE SET Revision 2b382b3cf19b3fe1234a4629da6a4d9ca88754

Re: Review Request 124273: Unfocus applet when clicking empty desktop area

2015-07-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124273/ --- (Updated July 7, 2015, 3:16 p.m.) Status -- This change has been mar

Re: Review Request 124215: Explicitly look for XKB instead of juggling paths in base of a prefix

2015-07-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124215/ --- (Updated July 7, 2015, 2:41 p.m.) Status -- This change has been mar

Re: Review Request 124246: Improve sticky notes

2015-07-07 Thread Bart Schouten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124246/#review82177 --- Hi, I hope you don't mind my writing again. I think the scope

Re: Review Request 124280: Only resize plot texture if size actually changes

2015-07-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124280/ --- (Updated July 7, 2015, 4:16 p.m.) Review request for Plasma. Bugs: 3461

Re: Review Request 124280: Only resize plot texture if size actually changes

2015-07-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124280/#review82176 --- Ship it! Makes sense. - Aleix Pol Gonzalez On July 7, 2015

Re: Review Request 124280: Only resize plot texture if size actually changes

2015-07-07 Thread Luca Beltrame
> On Lug. 7, 2015, 12:02 p.m., Luca Beltrame wrote: > > I can't comment on the code itself, but from my small unscientific test, > > the CPU usage of the component seems gone. If that's the case (can anyone else confirm), it should also fix bug 346134. - Luca ---

Re: Review Request 124280: Only resize plot texture if size actually changes

2015-07-07 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124280/#review82167 --- I can't comment on the code itself, but from my small unscient

Re: Review Request 124269: [kcms/access] Do nothing on non X11 platforms

2015-07-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124269/ --- (Updated July 7, 2015, 11:42 a.m.) Status -- This change has been ma

Re: Review Request 124270: [kcms/input] Ensure X11 specific code doesn't crash on other platforms

2015-07-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124270/ --- (Updated July 7, 2015, 11:42 a.m.) Status -- This change has been ma

Re: Review Request 124268: [kcms/kcmstyle] Drop setting _QT_DESKTOP_PROPERTIES code path

2015-07-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124268/ --- (Updated July 7, 2015, 11:42 a.m.) Status -- This change has been ma

Re: Review Request 124273: Unfocus applet when clicking empty desktop area

2015-07-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124273/#review82166 --- Ship it! Ship It! - Sebastian Kügler On July 6, 2015, 5:28

Review Request 124280: Only resize plot texture if size actually changes

2015-07-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124280/ --- Review request for Plasma. Repository: kdeclarative Description ---