Re: Review Request 123190: CMakeLists.txt: Install sddm theme to KDE_INSTALL_DATADIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123190/#review84934 --- Ship it! do you have commit access - David Edmundson On Se

Re: Review Request 125038: Make SourceModel writeable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/#review84933 --- src/pulseaudio.cpp (line 379)

Re: Freeze kde-workspace repo for good

On Friday, September 4, 2015 10:31:59 AM CEST Martin Klapetek wrote: > +1, although I don't think it would prevent people from creating > patches...or would RB refuse a patch against those blocked > branches? probably not, but it makes working with those easy: repo frozen, sorry cannot be pushed.

Re: Review Request 125060: Added .gitignore

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125060/#review84931 --- -2: please no .gitignore in repos! If that goes in I always g

Re: Review Request 125061: Moved indexing checkbox to the top of the KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125061/ --- (Updated Sept. 7, 2015, 8:57 a.m.) Status -- This change has been di

Re: Review Request 125061: Moved indexing checkbox to the top of the KCM

> On Sept. 6, 2015, 5:25 p.m., Vishesh Handa wrote: > > I'm fairly against this. Maybe others can chime in? > > > > My rationale is that when configuring Baloo, I don't want the first > > impression to be - Here is how you can disable it. I would prefer it to be > > something along the lines o

Re: Review Request 125061: Moved indexing checkbox to the top of the KCM

> On Sept. 6, 2015, 8:01 p.m., Heiko Tietze wrote: > > The design does not fit the (preliminary) KCM guidelines [1] and has a > > questionale workflow as Vishesh commented wrt. the checkbox plus the > > stacked lists are not a common design. To solve the problkem I'm thinking > > about using t

Re: Review Request 125062: Renamed variable for better description

> On Sept. 6, 2015, 5:26 p.m., Vishesh Handa wrote: > > kcms/baloo/folderselectionwidget.cpp, line 129 > > > > > > Does this actually compile? Because 'folderDisplayName' does not exist > > for me. Oh, my, this

Re: Review Request 123828: Fix KF5 port regression in kcm_standard_actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123828/ --- (Updated Sept. 7, 2015, 2:28 a.m.) Status -- This change has been ma

Re: Review Request 125038: Make SourceModel writeable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/ --- (Updated Sept. 7, 2015, 3:01 a.m.) Review request for Plasma and Harald S

Re: Review Request 124923: Plasma 5 color picker plasmoid

> On Aug. 25, 2015, 9:22 p.m., Thomas Pfeiffer wrote: > > Great work! > > Two points: > > 1. The two icons in the Plasmoid look like they're two separate Plasmoids, > > which is confusing. They should be more visually connected (we're still > > brainstorming ideas for how to do this in the VDG)

Re: Review Request 123190: CMakeLists.txt: Install sddm theme to KDE_INSTALL_DATADIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123190/ --- (Updated Sept. 6, 2015, 9:30 nachm.) Review request for Plasma. Changes

[Powerdevil] [Bug 352235] Screens return from DPMS Suspend Mode to Normal Mode When Receiving Google Hangouts Messages

https://bugs.kde.org/show_bug.cgi?id=352235 Kai Uwe Broulik changed: What|Removed |Added Product|plasmashell |Powerdevil Component|general

Re: Review Request 125073: Support dropping windows onto the pager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125073/ --- (Updated Sept. 6, 2015, 6:52 p.m.) Status -- This change has been ma

Re: Review Request 124923: Plasma 5 color picker plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124923/#review84907 --- I would be for pushing this. I'mnot sure how to solve the disc

Re: Review Request 125073: Support dropping windows onto the pager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125073/#review84906 --- Ship it! Ship It! - Marco Martin On Sept. 6, 2015, 2:36 p.

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

> On Aug. 27, 2015, 7:04 p.m., Thomas Pfeiffer wrote: > > Since this is indeed a very often required feature, why do we keep it > > hidden? If it can have negative side-effects, it we should warn users about > > them, not hide the whole feature from them. > > Thomas Lübking wrote: > or res

Re: Review Request 124923: Plasma 5 color picker plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124923/#review84902 --- Ping - Kai Uwe Broulik On Aug. 26, 2015, 6:07 nachm., Kai U

Re: Review Request 125061: Moved indexing checkbox to the top of the KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125061/#review84901 --- The design does not fit the (preliminary) KCM guidelines [1] a

Review Request 125073: Support dropping windows onto the pager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125073/ --- Review request for Plasma and Martin Gräßlin. Bugs: 352349 https://bu

Re: Review Request 125062: Renamed variable for better description

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125062/#review84898 --- kcms/baloo/folderselectionwidget.cpp (line 129)

Re: Review Request 125061: Moved indexing checkbox to the top of the KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125061/#review84897 --- I'm fairly against this. Maybe others can chime in? My ration

Re: Review Request 125060: Added .gitignore

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125060/#review84895 --- Ship it! - Vishesh Handa On Sept. 5, 2015, 8:01 p.m., Ovidi

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 6, 2015, 2:22 a.m., Thomas Pfeiffer wrote: > > Have you thought of the corner cases? > > These come to my mind: > > - Is it possible to add the same folder to both lists? If so: Which one > > wins? > > - It ist possible to add a folder to index within an excluded folder? If > > so: w

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 6, 2015, 2:22 a.m., Thomas Pfeiffer wrote: > > Have you thought of the corner cases? > > These come to my mind: > > - Is it possible to add the same folder to both lists? If so: Which one > > wins? > > - It ist possible to add a folder to index within an excluded folder? If > > so: w

Re: Review Request 125058: Cleanup and Add directories to index list

> On Sept. 6, 2015, 5:22 a.m., Thomas Pfeiffer wrote: > > Have you thought of the corner cases? > > These come to my mind: > > - Is it possible to add the same folder to both lists? If so: Which one > > wins? > > - It ist possible to add a folder to index within an excluded folder? If > > so: w