Re: Review Request 126301: Add protocol for server side decoration

2015-12-10 Thread Martin Gräßlin
> On Dec. 10, 2015, 3:54 p.m., Marco Martin wrote: > > src/client/protocols/server-decoration.xml, line 45 > > > > > > do clients have to explicitly call that with risks of leaks? sorry I don't get the question?

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-10 Thread Martin Graesslin
On Thursday, December 10, 2015 2:39:36 PM CET Mark Gaiser wrote: > > That is why I don't get your point. It just doesn't make sense to me and > > it > > sounds being based on wrong assumptions. > > Yes, it will. Here is the proof (taking archlinux as example since it is > very much like upstream

Possible issue in breeze 5.5 kstyle

2015-12-10 Thread Sandro Andrade
Hi there, After upgrading plasma to 5.5 I started to notice some weird behaviour in using QQuickView to load a QML document: Ex: m_quickView->setSource(QUrl("qrc:/main.qml")); ... setupGUI(); ... if (!m_initialGroup.exists()) runWizard(); The issue is that no QML content is shown if using b

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-12-10 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #74 from mif...@gmail.com --- bt here - http://pastebin.com/dxUkvRMx kde-frameworks/kded 5.16.0 kde-plasma/plasma-desktop 5.5.0 kde-plasma/powerdevil 5.5.0 -- You are receiving this mail because: You are the assignee for the bug. __

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-10 Thread Martin Gräßlin
> On Dec. 10, 2015, 12:03 a.m., Rex Dieter wrote: > > I (still) think it should be renamed and Wayland mentioned *somewhere*. > > Not all login managers distinguish wayland sessions like sddm does. > > David Edmundson wrote: > Though if you do SDDM will say: > > Plasma (wayland) (

Re: Review Request 126244: Let containments override CompactApplet.qml

2015-12-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126244/ --- (Updated Dec. 10, 2015, 10:10 p.m.) Status -- This change has been m

Re: Review Request 126244: Let containments override CompactApplet.qml

2015-12-10 Thread Marco Martin
> On Dec. 4, 2015, 4:28 p.m., David Edmundson wrote: > > src/plasma/private/packages.cpp, line 128 > > > > > > Having the content structure change when you load a specific package is > > going to result in weird

Re: Review Request 126244: Let containments override CompactApplet.qml

2015-12-10 Thread Marco Martin
> On Dec. 4, 2015, 4:28 p.m., David Edmundson wrote: > > src/plasma/private/packages.cpp, line 128 > > > > > > Having the content structure change when you load a specific package is > > going to result in weird

Re: Review Request 126244: Let containments override CompactApplet.qml

2015-12-10 Thread Marco Martin
> On Dec. 4, 2015, 4:28 p.m., David Edmundson wrote: > > src/plasma/private/packages.cpp, line 128 > > > > > > Having the content structure change when you load a specific package is > > going to result in weird

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

2015-12-10 Thread Martin Klapetek
Hey, On Thu, Dec 10, 2015 at 2:54 PM, Maximiliano Curia wrote: > Hi, > > Sorry that I haven't seen this review before plasma 5.5 was released > (containing this change), but pam modules are traditionally installed in > /lib, > that is, with an empty prefix. In the same CMakeLists.txt you can rea

Re: Review Request 126244: Let containments override CompactApplet.qml

2015-12-10 Thread David Edmundson
> On Dec. 4, 2015, 4:28 p.m., David Edmundson wrote: > > src/plasma/private/packages.cpp, line 128 > > > > > > Having the content structure change when you load a specific package is > > going to result in weird

Re: Review Request 124962: Fix CMAKE_INSTALL_LIBDIR not respecting installation prefix

2015-12-10 Thread Maximiliano Curia
Hi, On 28/08/15 04:39, Pinak Ahuja wrote: > https://git.reviewboard.kde.org/r/124962/ > By Pinak Ahuja. > > /Updated Aug. 28, 2015, 7:39 a.m./ > > *Repository: * kwallet-pam > > pam_kwallet5.so was being installed to /lib(64) irrespective of what the > installation prefix was set to. This patch

Re: Review Request 126244: Let containments override CompactApplet.qml

2015-12-10 Thread Marco Martin
> On Dec. 4, 2015, 4:28 p.m., David Edmundson wrote: > > src/plasma/private/packages.cpp, line 128 > > > > > > Having the content structure change when you load a specific package is > > going to result in weird

Re: Review Request 126244: Let containments override CompactApplet.qml

2015-12-10 Thread David Edmundson
> On Dec. 4, 2015, 4:28 p.m., David Edmundson wrote: > > src/plasma/private/packages.cpp, line 128 > > > > > > Having the content structure change when you load a specific package is > > going to result in weird

Re: Review Request 126246: Add test for dynamically changing file definitions

2015-12-10 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126246/#review89314 --- +1 I don't know this package, but the change "looks ok" to me

Re: Review Request 126246: Add test for dynamically changing file definitions

2015-12-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126246/#review89312 --- ping? - Marco Martin On Dec. 4, 2015, 6:23 p.m., Marco Mart

Re: Review Request 126302: [GCI] Make "comment" section of the timezones configuration searchable

2015-12-10 Thread Imran Tatriev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126302/ --- (Updated Dec. 10, 2015, 3:37 p.m.) Status -- This change has been ma

Re: Review Request 126302: [GCI] Make "comment" section of the timezones configuration searchable

2015-12-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126302/#review89310 --- Ship it! Nice work. - David Edmundson On Dec. 10, 2015, 2:

Re: Review Request 126244: Let containments override CompactApplet.qml

2015-12-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126244/#review89311 --- ping? - Marco Martin On Dec. 4, 2015, 6:24 p.m., Marco Mart

Re: Review Request 126301: Add protocol for server side decoration

2015-12-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126301/#review89309 --- src/client/protocols/server-decoration.xml (line 45)

Review Request 126302: [GCI] Make "comment" section of the timezones configuration searchable

2015-12-10 Thread Imran Tatriev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126302/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-10 Thread Aleix Pol Gonzalez
> On Dec. 10, 2015, 12:03 a.m., Rex Dieter wrote: > > I (still) think it should be renamed and Wayland mentioned *somewhere*. > > Not all login managers distinguish wayland sessions like sddm does. > > David Edmundson wrote: > Though if you do SDDM will say: > > Plasma (wayland) (

Re: Review Request 126301: Add protocol for server side decoration

2015-12-10 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126301/#review89307 --- src/client/protocols/server-decoration.xml (line 38)

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-10 Thread Martin Klapetek
> On Dec. 10, 2015, 12:03 a.m., Rex Dieter wrote: > > I (still) think it should be renamed and Wayland mentioned *somewhere*. > > Not all login managers distinguish wayland sessions like sddm does. > > David Edmundson wrote: > Though if you do SDDM will say: > > Plasma (wayland) (

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-10 Thread Kai Uwe Broulik
Hi,Mark, I think you completely misunderstood what move to kde/workspace means. This is not a repository, nobody wants to move that stuff into plasma-workspace. It just has semantic relevance, ie. no frameworks AB

Review Request 126301: Add protocol for server side decoration

2015-12-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126301/ --- Review request for Plasma and Sebastian Kügler. Repository: kwayland De

Review Request 126300: Plasma Search KCM: display the runner descriptions

2015-12-10 Thread Jonathan Marten
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126300/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-10 Thread Mark Gaiser
On Thu, Dec 10, 2015 at 10:20 AM, Martin Graesslin wrote: > On Thursday, December 10, 2015 9:54:15 AM CET Mark Gaiser wrote: > > On Thu, Dec 10, 2015 at 8:07 AM, Martin Graesslin > > > > wrote: > > > On Wednesday, December 9, 2015 4:03:24 PM CET Aleix Pol wrote: > > > > On Wed, Dec 9, 2015 at 3:

Re: [plasma-devel] Re: 5.5 video

2015-12-10 Thread Sebastian Kügler
On Wednesday, December 09, 2015 02:55:12 PM Mario Fux wrote: > Am Tuesday 08 December 2015, 09.21:05 schrieb Lucas S: > > Hi, > > Morning Lucas > > > -Fixed a typo "managment" => "management". > > > > > > > > Thanks for spotting this > > > > > > > > Link > > https://youtu.be/3wFTo34mCj0 > > So

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

2015-12-10 Thread Fabian Köster via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354250 --- Comment #8 from Fabian Köster --- The problem still occurs with Plasma 5.5.0 (and powerdevil 5.5.0) on Gentoo. Maybe the fix was not sufficient? -- You are receiving this mail because: You are the assignee for the bug.

Re: Review Request 126296: [Window Thumbnails] Don't crash if Composite is disabled

2015-12-10 Thread Kai Uwe Broulik
> On Dez. 10, 2015, 7:27 vorm., Martin Gräßlin wrote: > > How is it possible to have damage enabled, but composite disabled? If you manually disable Composite in your xorg.conf - Kai Uwe --- This is an automatically generated e-mail. To

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-10 Thread Martin Graesslin
On Thursday, December 10, 2015 9:54:15 AM CET Mark Gaiser wrote: > On Thu, Dec 10, 2015 at 8:07 AM, Martin Graesslin > > wrote: > > On Wednesday, December 9, 2015 4:03:24 PM CET Aleix Pol wrote: > > > On Wed, Dec 9, 2015 at 3:56 PM, Mark Gaiser wrote: > > > > On Wed, Dec 9, 2015 at 8:24 AM, Mart

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-10 Thread Mark Gaiser
On Thu, Dec 10, 2015 at 8:07 AM, Martin Graesslin wrote: > On Wednesday, December 9, 2015 4:03:24 PM CET Aleix Pol wrote: > > On Wed, Dec 9, 2015 at 3:56 PM, Mark Gaiser wrote: > > > On Wed, Dec 9, 2015 at 8:24 AM, Martin Graesslin > wrote: > > >> On Tuesday, December 8, 2015 6:03:47 PM CET Mar