Re: Review Request 126462: [Task Manager] Drop application name from "Recent Documents" heading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126462/#review89881 --- Ship it! Ship It! - Eike Hein On Dec. 21, 2015, 8:46 p.m.,

Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/ --- Review request for Plasma and David Edmundson. Bugs: 345545 http://bu

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126319/#review89878 --- I quite like it. +1 What's the sources? (i.e. if someone want

Re: Review Request 126381: kwayland backend for libkscreen

> On Dec. 21, 2015, 5:15 p.m., Daniel Vrátil wrote: > > Since the last few rounds were only coding style nitpicks, I think it's > > time to merge this :) > > > > Thanks a lot for you work, you rock! Thank you, Martin and Kai Uwe and Johan for the reviews! I'm happy that we got another pretty

Re: Review Request 126381: kwayland backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/ --- (Updated Dec. 21, 2015, 11:46 p.m.) Status -- This change has been m

Re: Review Request 126149: [Icon widget] Bring back properties dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/ --- (Updated Dez. 21, 2015, 11:31 nachm.) Review request for KDE Frameworks a

Re: Review Request 126463: Allow applets to set full ToolTip item

> On Dez. 21, 2015, 10:39 nachm., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/appletinterface.h, line 407 > > > > > > what would happen if the tooltipItem object gets deleted by the > > plasmoid af

Re: Review Request 126373: change the taskbar color from blue to gray

> On Dec. 20, 2015, 8:45 p.m., Eike Hein wrote: > > General PSA: I will soon push a fixed-up version of tasks.svgz to the repo > > that cleans up all the random margins and inconsistent corner styles in it > > that currently mess up alignments inside and outside of task buttons as > > well as

Re: Review Request 126373: change the taskbar color from blue to gray

> On Dec. 20, 2015, 8:45 p.m., Eike Hein wrote: > > General PSA: I will soon push a fixed-up version of tasks.svgz to the repo > > that cleans up all the random margins and inconsistent corner styles in it > > that currently mess up alignments inside and outside of task buttons as > > well as

Re: Review Request 126463: Allow applets to set full ToolTip item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126463/#review89868 --- src/scriptengines/qml/plasmoid/appletinterface.h (line 407) <

Re: Plasma Mobile package deb source repository

Thanks! I was starting to worry I'd be using a gross hack involving kdesrc-build to compile everything, fix up the installed paths and call it packaging. Being able to 'borrow' actual packaging code is much more appealing. :) On Mon, Dec 21, 2015 at 11:53 AM, Harald Sitter wrote: > On Fri, Dec 1

Re: Review Request 126463: Allow applets to set full ToolTip item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126463/#review89867 --- +1 src/scriptengines/qml/plasmoid/appletinterface.h (line 10

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126464/#review89866 --- desktoppackage/contents/applet/CompactApplet.qml (line 37)

Review Request 126463: Allow applets to set full ToolTip item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126463/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126464/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126461/#review89861 --- Ship it! Ship It! - David Edmundson On Dec. 21, 2015, 8:56

Re: Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126461/ --- (Updated Dec. 21, 2015, 9:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

> On Dec. 21, 2015, 8:38 p.m., David Edmundson wrote: > > This does seem like a much better way to handle the grouping, so I'll +1 > > this. > > > > But as for the actual bug that brought you here: > > Why are we getting two notifications for everything from Plasma in the > > first place? > >

Review Request 126462: [Task Manager] Drop application name from "Recent Documents" heading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126462/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop Des

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

> On Dec. 21, 2015, 9:38 p.m., David Edmundson wrote: > > This does seem like a much better way to handle the grouping, so I'll +1 > > this. > > > > But as for the actual bug that brought you here: > > Why are we getting two notifications for everything from Plasma in the > > first place? Tho

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126460/#review89855 --- This does seem like a much better way to handle the grouping,

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126460/#review89856 --- Ship it! dataengines/notifications/notificationsengine.cpp (

Review Request 126461: Use the SkipGrouping flag for the "widget deleted" notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126461/ --- Review request for KDE Frameworks and Plasma. Bugs: 356653 http://bug

Review Request 126460: Honor SkipGrouping hint from KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126460/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 126443: Fix memleak in Plasma framework's PackageUrlInterceptor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126443/ --- (Updated Dec. 21, 2015, 7:39 p.m.) Status -- This change has been ma

[Breeze] [Bug 356940] kalarm crash on start up

https://bugs.kde.org/show_bug.cgi?id=356940 Martin Klapetek changed: What|Removed |Added Assignee|plasma-devel@kde.org|hugo.pere...@free.fr Component|gener

[Breeze] [Bug 356940] kalarm crash on start up

https://bugs.kde.org/show_bug.cgi?id=356940 David Jarvie changed: What|Removed |Added Component|general |general Assignee|djar...@kde.org

Re: Review Request 126381: kwayland backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/#review89839 --- Ship it! Since the last few rounds were only coding style nit

[ksystraycmd] [Bug 344168] there is no ksystray for plasma5

https://bugs.kde.org/show_bug.cgi?id=344168 --- Comment #25 from Rex Dieter --- Plasma 5.5 included legacy systray icon support via xembedsniproxy only. No work has been done to implement ksystraycmd (yet) -- You are receiving this mail because: You are on the CC list for the bug. __

[ksystraycmd] [Bug 344168] there is no ksystray for plasma5

https://bugs.kde.org/show_bug.cgi?id=344168 Juan Simón changed: What|Removed |Added CC||deced...@gmail.com --- Comment #24 from Juan Simón

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Dec. 21, 2015, 2:51 p.m.) Review request for Plasma, Ashish Bans

Re: systemsettings, kde-cli-tools and other plasma components on non-Plasma/non-X11 platforms

Aleix Pol wrote: > It's a matter of what we expose I'd say, though, as you only want to > change application-specific settings within the application. Yes, I guess you're right about that. Some applications provide a palette selector (but no way to edit palettes), most if not all a language sel

Re: Review Request 126449: Containment: Don't emit appletCreated with null applet

> On Dec. 21, 2015, 1:54 p.m., David Edmundson wrote: > > Thanks! > > > > This will fix https://bugs.kde.org/show_bug.cgi?id=356428 right? > > David Rosca wrote: > It should, according to the backtrace. > > David Edmundson wrote: > at which point can you cherry-pick it to the 5.5 branc

Re: Review Request 126449: Containment: Don't emit appletCreated with null applet

> On Dec. 21, 2015, 1:54 p.m., David Edmundson wrote: > > Thanks! > > > > This will fix https://bugs.kde.org/show_bug.cgi?id=356428 right? > > David Rosca wrote: > It should, according to the backtrace. > > David Edmundson wrote: > at which point can you cherry-pick it to the 5.5 branc

Re: Review Request 126449: Containment: Don't emit appletCreated with null applet

> On Dez. 21, 2015, 1:54 nachm., David Edmundson wrote: > > Thanks! > > > > This will fix https://bugs.kde.org/show_bug.cgi?id=356428 right? > > David Rosca wrote: > It should, according to the backtrace. > > David Edmundson wrote: > at which point can you cherry-pick it to the 5.5 bra

Re: systemsettings, kde-cli-tools and other plasma components on non-Plasma/non-X11 platforms

On Mon, Dec 21, 2015 at 2:53 PM, René J. V. wrote: > David Edmundson wrote: > > >>> address space of an application other than kcmshell or systemsettings. >>> >>> They can be run in application space. >> There's a class to load them easily as widgets. See KCMUtils framework >> (KSettings::Dialog i

Re: Review Request 126449: Containment: Don't emit appletCreated with null applet

> On Dec. 21, 2015, 1:54 p.m., David Edmundson wrote: > > Thanks! > > > > This will fix https://bugs.kde.org/show_bug.cgi?id=356428 right? > > David Rosca wrote: > It should, according to the backtrace. > > David Edmundson wrote: > at which point can you cherry-pick it to the 5.5 branc

Re: Review Request 126449: Containment: Don't emit appletCreated with null applet

> On Dec. 21, 2015, 1:54 p.m., David Edmundson wrote: > > Thanks! > > > > This will fix https://bugs.kde.org/show_bug.cgi?id=356428 right? > > David Rosca wrote: > It should, according to the backtrace. at which point can you cherry-pick it to the 5.5 branch too please? and close that bug

Re: Review Request 126449: Containment: Don't emit appletCreated with null applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126449/ --- (Updated Dec. 21, 2015, 2:01 p.m.) Status -- This change has been ma

Re: systemsettings, kde-cli-tools and other plasma components on non-Plasma/non-X11 platforms

David Edmundson wrote: >> address space of an application other than kcmshell or systemsettings. >> >> They can be run in application space. > There's a class to load them easily as widgets. See KCMUtils framework > (KSettings::Dialog in particular) I take it that's how the Notifications and Sho

Re: Review Request 126449: Containment: Don't emit appletCreated with null applet

> On Dec. 21, 2015, 1:54 p.m., David Edmundson wrote: > > Thanks! > > > > This will fix https://bugs.kde.org/show_bug.cgi?id=356428 right? It should, according to the backtrace. - David --- This is an automatically generated e-mail. To

Re: systemsettings, kde-cli-tools and other plasma components on non-Plasma/non-X11 platforms

Hi René, On Monday, December 21, 2015 14:02:59 René J. V. Bertin wrote: > Sebastian Kügler wrote: > > Did you check of X11 dependencies? At least some of the font settings > > depend on X11. > > Thanks, will do. Makes sense: hinting and AA settings are moot outside of > X11. However: my Linux bu

Re: Review Request 126449: Containment: Don't emit appletCreated with null applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126449/#review89825 --- Ship it! Thanks! This will fix https://bugs.kde.org/show_bug

Re: systemsettings, kde-cli-tools and other plasma components on non-Plasma/non-X11 platforms

On Mon, Dec 21, 2015 at 1:22 PM, René J. V. wrote: > Aleix Pol wrote: > > >> kde-cli-tools and systemsettings5 are required to configure > >> 1 wallet settings (regardless of whether KWallet uses native KDE > wallets or > >> an OS X keychain backend) > > Makes sense, probably should be moved to K

Re: systemsettings, kde-cli-tools and other plasma components on non-Plasma/non-X11 platforms

Aleix Pol wrote: >> kde-cli-tools and systemsettings5 are required to configure >> 1 wallet settings (regardless of whether KWallet uses native KDE wallets or >> an OS X keychain backend) > Makes sense, probably should be moved to KWallet? Probably. >> 2 cookies and other html/browser related se

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89823 --- bump? - Aleix Pol Gonzalez On Dec. 15, 2015, 4:24 p.m., Ale

Re: Review Request 126381: kwayland backend for libkscreen

> On Dec. 20, 2015, 3:40 p.m., Kai Uwe Broulik wrote: > > autotests/testconfigserializer.cpp, line 161 > > > > > > Why this change? Oversight from a temporary change, fixed now. - Sebastian -

Re: Review Request 126381: kwayland backend for libkscreen

> On Dez. 20, 2015, 10:38 vorm., Daniel Vrátil wrote: > > tests/kwayland/waylandconfigreader.cpp, line 110 > > > > > > No need for .toList(), Q_FOREACH can iterate over values of a map. > > Sebastian Kügler wrot

Re: systemsettings, kde-cli-tools and other plasma components on non-Plasma/non-X11 platforms

Sebastian Kügler wrote: > Did you check of X11 dependencies? At least some of the font settings depend > on X11. Thanks, will do. Makes sense: hinting and AA settings are moot outside of X11. However: my Linux build should pick up all required X11 deps so something else must be going on too. >

Re: Review Request 126381: kwayland backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126381/ --- (Updated Dec. 21, 2015, 12:59 p.m.) Review request for Plasma, Solid, Dan

Re: Review Request 126381: kwayland backend for libkscreen

> On Dec. 20, 2015, 3:47 p.m., Kai Uwe Broulik wrote: > > backends/kwayland/waylandconfig.cpp, lines 115-117 > > > > > > qDeleteAll (I think this requires Qt 5.6 to work though) Seems to work fine with 5.5.1.

Re: Review Request 126381: kwayland backend for libkscreen

> On Dec. 20, 2015, 6:14 p.m., Kai Uwe Broulik wrote: > > backends/kwayland/waylandconfig.cpp, line 222 > > > > > > Out of curiosity, why do you always check explicitly for nullptr and > > false? We don't assum

Re: Review Request 126381: kwayland backend for libkscreen

> On Dec. 20, 2015, 10:38 a.m., Daniel Vrátil wrote: > > tests/kwayland/waylandconfigreader.cpp, line 110 > > > > > > No need for .toList(), Q_FOREACH can iterate over values of a map. Nope: /home/sebas/kf5/qt

Re: systemsettings, kde-cli-tools and other plasma components on non-Plasma/non-X11 platforms

On Mon, Dec 21, 2015 at 12:05 PM, René J.V. wrote: > Hello, > > This has been pending for a while, ever since we (= KDE/Mac) learned that the > kde4-workspace package was split up and integrated into KF5 Plasma, but it > may actually be relevant beyond "Plasma vs. the rest of the world" question

Re: Review Request 126418: Add KWin/Decoration support to plasmapkg

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126418/#review89816 --- Ship it! Ship It! - Sebastian Kügler On Dec. 18, 2015, 6:3

Re: systemsettings, kde-cli-tools and other plasma components on non-Plasma/non-X11 platforms

On Monday, December 21, 2015 12:05:26 René J.V. Bertin wrote: > I'm surprised that I don't see any of the fonts/palettes/style controls; > those are probably in a separate package? Did you check of X11 dependencies? At least some of the font settings depend on X11. I didn't have time to address

Review Request 126449: Containment: Don't emit appletCreated with null applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126449/ --- Review request for Plasma. Repository: plasma-framework Description ---

systemsettings, kde-cli-tools and other plasma components on non-Plasma/non-X11 platforms

Hello, This has been pending for a while, ever since we (= KDE/Mac) learned that the kde4-workspace package was split up and integrated into KF5 Plasma, but it may actually be relevant beyond "Plasma vs. the rest of the world" questions. I hope this can be discussed with a sufficient amount of

Re: Plasma Mobile package deb source repository

On Fri, Dec 18, 2015 at 7:12 PM, Johan Ouwerkerk wrote: > Does anybody know where I can find the sources (Debian control files > etc.) for the packaging of the reference image for Plasma Mobile? http://anonscm.debian.org/cgit/?q=pkg-kde partially overridden by https://github.com/plasma-phone-pac

Re: Review Request 126438: Fix bug 356946 - user avatar in Phonon isn't shrinked

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126438/#review89812 --- Could you attach before/after screenshots, please? - Sebastia

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Dec. 21, 2015, 8:39 a.m.) Review request for Plasma, Ashish Bans