Re: Review Request 126732: a plymouth theme for breeze

2016-01-13 Thread Martin Gräßlin
> On Jan. 13, 2016, 3:55 p.m., andreas kainz wrote: > > Hi, > > > > for me it look to "boring". I'm working on a cooperate design from grub to > > the shutdown menue. and plymouth is one part of it. > > > > I made a grub theme and some mockups you can get everything in the > > share.kde.org a

[Differential] [Accepted] D807: Fix for Bug 357684

2016-01-13 Thread Martin Gräßlin
graesslin added a subscriber: graesslin. graesslin accepted this revision. graesslin added a reviewer: graesslin. INLINE COMMENTS src/platformtheme/kdeplatformfiledialoghelper.cpp:275 small nitpick: you could const the bool confirmOverwrite REPOSITORY rPLASMAINTEGRATION Integration for Qt ap

Re: Review Request 126740: Add a script for optimizing svgs

2016-01-13 Thread Dirk Hohndel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91046 --- I think this is a good idea - but just a small side note, this

Review Request 126740: Add a script for optimizing svgs

2016-01-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/ --- Review request for KDE Frameworks and Plasma. Repository: breeze-icons

[Differential] [Accepted] D807: Fix for Bug 357684

2016-01-13 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D807 EMAIL PREFERENCES https://phabri

Re: Review Request 126730: cleanup sddm kcm

2016-01-13 Thread Heiko Tietze
> On Jan. 13, 2016, 9:52 a.m., Heiko Tietze wrote: > > Yes, this KCM is not designed according the HIG. It could look like this > > http://i.imgur.com/TVAZBFl.png. Enhancement idea to the existing HIG is a > > horizontal splitter left of "more" that allows to enlarge either the upper > > area

Re: Review Request 126689: Change minimum Size of Calendar

2016-01-13 Thread andreas kainz
> On Jan. 13, 2016, 9:06 nachm., Martin Klapetek wrote: > > I'm not entirely sure why, but this change breaks the applet switching. > > > > Marco? maybe I should stop my work at the plasmoids. I don't have luck - andreas --- This is a

Re: Review Request 126689: Change minimum Size of Calendar

2016-01-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126689/#review91032 --- I'm not entirely sure why, but this change breaks the applet s

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 362 - Fixed!

2016-01-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/362/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jan 2016 20:24:37 + Build duration: 7 min 19 sec CHANGE SET Revision 284cc9b99b1864268a444f6faba5fe2

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 362 - Fixed!

2016-01-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/362/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jan 2016 20:24:37 + Build duration: 7 min 19 sec CHANGE SET Revision 284cc9b99b1864268a444f6faba5fe2

Re: Review Request 126689: Change minimum Size of Calendar

2016-01-13 Thread Martin Klapetek
> On Jan. 13, 2016, 9:04 p.m., andreas kainz wrote: > > any feedback. as you see in the screenshot it works now on the desktop, the > > panel and on a sidebar panel Ah yes, sorry, my system is currently in a bit broken state, let me try to fix it now and get back asap. - Martin ---

Re: Review Request 126689: Change minimum Size of Calendar

2016-01-13 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126689/#review91030 --- any feedback. as you see in the screenshot it works now on the

Re: Review Request 126730: cleanup sddm kcm

2016-01-13 Thread andreas kainz
> On Jan. 13, 2016, 9:52 a.m., Heiko Tietze wrote: > > Yes, this KCM is not designed according the HIG. It could look like this > > http://i.imgur.com/TVAZBFl.png. Enhancement idea to the existing HIG is a > > horizontal splitter left of "more" that allows to enlarge either the upper > > area

Re: Review Request 126730: cleanup sddm kcm

2016-01-13 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126730/ --- (Updated Jan. 13, 2016, 7:50 p.m.) Status -- This change has been ma

Re: Review Request 126719: tasks.svgz: Add "progress" frame

2016-01-13 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126719/#review91028 --- Ship it! Ship It! - andreas kainz On Jan. 11, 2016, 5:29 p

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 45 - Still Failing!

2016-01-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/45/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jan 2016 19:36:12 + Build duration: 1 min 25 sec CHANGE SET Revision c1a7d61fbab7620f9f9

Re: Review Request 126727: [plasmaquick/dialog] Don't use KWindowEffects for Notification window type

2016-01-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126727/ --- (Updated Jan. 13, 2016, 7:37 p.m.) Status -- This change has been ma

Re: Review Request 126668: [notifications] Place the popup directly when it is displayed

2016-01-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126668/ --- (Updated Jan. 13, 2016, 7:35 p.m.) Status -- This change has been ma

[Differential] [Request, 5 lines] D807: Fix for Bug 357684

2016-01-13 Thread danielsabo (Daniel Sabo)
danielsabo created this revision. danielsabo added a reviewer: Plasma. danielsabo set the repository for this revision to rPLASMAINTEGRATION Integration for Qt applications in Plasma. danielsabo added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY The existing code

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

2016-01-13 Thread Joshua Noack
> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote: > > sddmauthhelper.cpp, line 74 > > > > > > Ideally we should check the *calling* user can read this file, as you > > technically have a security bug. > >

Re: Review Request 126732: a plymouth theme for breeze

2016-01-13 Thread Marco Martin
> On Jan. 13, 2016, 2:55 p.m., andreas kainz wrote: > > Hi, > > > > for me it look to "boring". I'm working on a cooperate design from grub to > > the shutdown menue. and plymouth is one part of it. > > > > I made a grub theme and some mockups you can get everything in the > > share.kde.org a

Re: Review Request 126732: a plymouth theme for breeze

2016-01-13 Thread Eike Hein
> On Jan. 13, 2016, 2:55 p.m., andreas kainz wrote: > > Hi, > > > > for me it look to "boring". I'm working on a cooperate design from grub to > > the shutdown menue. and plymouth is one part of it. > > > > I made a grub theme and some mockups you can get everything in the > > share.kde.org a

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 361 - Failure!

2016-01-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/361/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 13 Jan 2016 15:14:06 + Build duration: 30 sec CHANGE SET Revision 2c56715c93cb439df77f29260e3bfc9cbd76e

Re: Review Request 126732: a plymouth theme for breeze

2016-01-13 Thread andreas kainz
> On Jan. 13, 2016, 2:55 nachm., andreas kainz wrote: > > Hi, > > > > for me it look to "boring". I'm working on a cooperate design from grub to > > the shutdown menue. and plymouth is one part of it. > > > > I made a grub theme and some mockups you can get everything in the > > share.kde.org

Re: Review Request 126732: a plymouth theme for breeze

2016-01-13 Thread Matthias Klumpp
> On Jan. 13, 2016, 2:55 nachm., andreas kainz wrote: > > Hi, > > > > for me it look to "boring". I'm working on a cooperate design from grub to > > the shutdown menue. and plymouth is one part of it. > > > > I made a grub theme and some mockups you can get everything in the > > share.kde.org

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

2016-01-13 Thread David Edmundson
> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote: > > sddmauthhelper.cpp, line 74 > > > > > > Ideally we should check the *calling* user can read this file, as you > > technically have a security bug. > >

Re: Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126731/ --- (Updated Jan. 13, 2016, 3:13 p.m.) Status -- This change has been ma

Re: Review Request 126732: a plymouth theme for breeze

2016-01-13 Thread Kai Uwe Broulik
> On Jan. 13, 2016, 2:55 nachm., andreas kainz wrote: > > Hi, > > > > for me it look to "boring". I'm working on a cooperate design from grub to > > the shutdown menue. and plymouth is one part of it. > > > > I made a grub theme and some mockups you can get everything in the > > share.kde.org

Re: Review Request 126732: a plymouth theme for breeze

2016-01-13 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126732/#review91012 --- Hi, for me it look to "boring". I'm working on a cooperate de

Re: Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126731/#review91011 --- Ship it! Ship It! - Eike Hein On Jan. 13, 2016, 2:36 p.m.,

Re: Review Request 126732: a plymouth theme for breeze

2016-01-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126732/#review91010 --- CMakeLists.txt (line 29)

Re: Review Request 126732: a plymouth theme for breeze

2016-01-13 Thread Sebastian Kügler
> On Jan. 13, 2016, 2:36 p.m., Sebastian Kügler wrote: > > plymouth/CMakeLists.txt, line 1 > > > > > > What about systems without plymouth? > > > > I'm not sure if it's a good idea to make this a mandatory

Re: Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126731/ --- (Updated Jan. 13, 2016, 2:35 p.m.) Review request for Plasma. Repositor

Re: Review Request 126732: a plymouth theme for breeze

2016-01-13 Thread Jonathan Riddell
> On Jan. 13, 2016, 2:36 p.m., Sebastian Kügler wrote: > > plymouth/CMakeLists.txt, line 1 > > > > > > What about systems without plymouth? > > > > I'm not sure if it's a good idea to make this a mandatory

Re: Review Request 126732: a plymouth theme for breeze

2016-01-13 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126732/#review91006 --- plymouth/CMakeLists.txt (line 1)

Re: Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126731/ --- (Updated Jan. 13, 2016, 2:36 p.m.) Review request for Plasma. Bugs: 346

Review Request 126732: a plymouth theme for breeze

2016-01-13 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126732/ --- Review request for Plasma. Repository: breeze Description --- a pl

Re: Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread David Rosca
> On Jan. 13, 2016, 1:48 p.m., Bhushan Shah wrote: > > Fixes: https://bugs.kde.org/show_bug.cgi?id=346815 ? > > David Rosca wrote: > Yes, almost. > > Some applets (eg. color picker) somehow ends not being in `resultsFlow` > children, so their position is not stored in `LayoutManage

Re: Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread David Rosca
> On Jan. 13, 2016, 1:48 p.m., Bhushan Shah wrote: > > Fixes: https://bugs.kde.org/show_bug.cgi?id=346815 ? Yes, almost. Some applets (eg. color picker) somehow ends not being in `resultsFlow` children, so their position is not stored in `LayoutManager.positions` array (see containments/deskt

Re: Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126731/#review91002 --- Fixes: https://bugs.kde.org/show_bug.cgi?id=346815 ? - Bhusha

Review Request 126731: Fix calculation of availableSpace for applets

2016-01-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126731/ --- Review request for Plasma. Repository: plasma-desktop Description -

[kio-extras] [Bug 351309] kio-fish doesn't delete files

2016-01-13 Thread Victor B . Gonzalez via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=351309 --- Comment #6 from Victor B. Gonzalez --- (In reply to Antonio Rojas from comment #5) > Fix is in KDE Applications 15.08.2, released 3 months ago. It seems even with the latest Fedora updates, I'm still at 15.08.1. So, I'm .1 short of the fix. Thanks

[kio-extras] [Bug 351309] kio-fish doesn't delete files

2016-01-13 Thread Antonio Rojas via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=351309 --- Comment #5 from Antonio Rojas --- Fix is in KDE Applications 15.08.2, released 3 months ago. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma

[kio-extras] [Bug 351309] kio-fish doesn't delete files

2016-01-13 Thread Victor B . Gonzalez via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=351309 --- Comment #4 from Victor B. Gonzalez --- (In reply to David Edmundson from comment #2) > Git commit 311f7e124e49b81a37fd49b3ef20e9ca65c8567a by David Edmundson. > Committed on 02/10/2015 at 21:09. > Pushed by davidedmundson into branch 'Applications/1

[kio-extras] [Bug 351309] kio-fish doesn't delete files

2016-01-13 Thread Emmanuel Pescosta via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=351309 Emmanuel Pescosta changed: What|Removed |Added CC||bugs.kde.org.id324@vbgunz.c

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

2016-01-13 Thread Jens Reuterberg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126632/#review90998 --- If I could take this, steal it away on a summer cruise, propos

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

2016-01-13 Thread Marco Martin
> On Jan. 11, 2016, 12:14 p.m., David Edmundson wrote: > > >Gwenview switches to a dark palette when in fullscreen mode for instance > > > > and how does this help solve that? There's no method to get a palette from > > a ColorSet > > Marco Martin wrote: > that may be useful to add then?

Re: Review Request 126719: tasks.svgz: Add "progress" frame

2016-01-13 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126719/#review90990 --- Big +1 :) - Mark Gaiser On jan 11, 2016, 5:29 p.m., Kai Uwe

Re: Review Request 126730: cleanup sddm kcm

2016-01-13 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126730/#review90988 --- Yes, this KCM is not designed according the HIG. It could look

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

2016-01-13 Thread Joshua Noack
> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote: > > sddmauthhelper.cpp, line 74 > > > > > > Ideally we should check the *calling* user can read this file, as you > > technically have a security bug. > >