[kio-extras] [Bug 366638] [16.04] sftp stuck operations. Can operate only if reopening Dolphin

2016-10-26 Thread Germano Massullo
https://bugs.kde.org/show_bug.cgi?id=366638 --- Comment #5 from Germano Massullo --- Confirming on 16.08.1 / 5.26.0 / Plasma 5.7.5 -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

2016-10-26 Thread drosca (David Rosca)
drosca added a comment. In https://phabricator.kde.org/D2314#58816, @Zren wrote: > All I did was copy the Menu widget's pattern (sorta) since it was the first example I could find. Yeah, PlasmaComponents.ContextMenu sucks but if possible, I would prefer the declarative approach

[Differential] [Commented On] D3166: make sure containment actions config is up to date

2016-10-26 Thread mart (Marco Martin)
mart added a comment. in this version, i'm rebuilding everything on scriptengine teardown, this should make work correctly even if one adds a new plugin, or removes one. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3166 EMAIL PREFERENCES

[Differential] [Updated, 42 lines] D3166: make sure containment actions config is up to date

2016-10-26 Thread mart (Marco Martin)
mart updated this revision to Diff 7679. mart added a comment. - move the config syncing in ~ScriptEngine() REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3166?vs=7672=7679 BRANCH arcpatch-D3166 REVISION DETAIL

[Differential] [Updated] D3168: Use microphone volume icon for capture devices/streams in applet

2016-10-26 Thread drosca (David Rosca)
drosca added a reviewer: Plasma: Design. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3168 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, #plasma:_design Cc: andreaska, plasma-devel,

[Differential] [Updated, 68 lines] D3159: Set wayland output scale

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 7677. davidedmundson added a comment. Restricted Application edited projects, added KWin; removed Plasma. qvector::fill REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3159?vs=7666=7677 BRANCH master REVISION

[Differential] [Updated, 2,277 lines] D3169: Implementation of PointerGestures protocol

2016-10-26 Thread Martin Gräßlin
graesslin updated this revision to Diff 7676. graesslin added a comment. Fix comments. Apparently I also need to try to compile after adding documentation... REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3169?vs=7675=7676 BRANCH

[Differential] [Request, 2,277 lines] D3169: Implementation of PointerGestures protocol

2016-10-26 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY Pointer gestures are created for a pointer and there are two types of gestures:

[Differential] [Commented On] D3168: Use microphone volume icon for capture devices/streams in applet

2016-10-26 Thread drosca (David Rosca)
drosca added a comment. F379870: Spectacle.M21792.png REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3168 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca,

[Differential] [Request, 62 lines] D3168: Use microphone volume icon for capture devices/streams in applet

2016-10-26 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. drosca added a subscriber: andreaska. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It doesn't make sense to show speaker volume icon for capture streams

[Differential] [Commented On] D3166: make sure containment actions config is up to date

2016-10-26 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3166#58841, @davidedmundson wrote: > Also this script is making an optimistic assumption that in the script where you might be modding containment configs, you'd create a containment instance. That's not always true (like from the

[Differential] [Requested Changes To] D3166: make sure containment actions config is up to date

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision now requires changes to proceed. Edit, I think I understand. So the script is modifying the actions not through some actions part of the API,

[Differential] [Commented On] D3166: make sure containment actions config is up to date

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. > If the containment actions plugins have been configured in the startup script, their config must be reloaded when the script ends, That part makes sensebut why is this code in the containment destructor? REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Request, 21 lines] D3166: make sure containment actions config is up to date

2016-10-26 Thread mart (Marco Martin)
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY if the containment actions plugins have been configured in the startup script, their config must be reloaded

[Differential] [Accepted] D3163: Remove deprecated useraccount

2016-10-26 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3163 EMAIL PREFERENCES

[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

2016-10-26 Thread Zren (Chris Holland)
Zren added a comment. > Do we need to do it programatically? All I did was copy the Menu widget's pattern (sorta) since it was the first example I could find. It would need to populate hundreds of menu's (most unused), so that makes sense that it would do things dynamically. Not

[Differential] [Request, 1 line] D3165: Remove line that does nothing

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY AppletInterface is designed to expose Applet methods to QML space. Emitting a signal on

Re: Review Request 129263: Don't show "Alternatives" menu by default

2016-10-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129263/ --- (Updated Oct. 26, 2016, 1:37 p.m.) Status -- This change has been

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread Marco Martin
> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `Applet::contextualActionsAboutToShow`

Re: Review Request 129263: Don't show "Alternatives" menu by default

2016-10-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129263/#review100297 --- Ship it! Ship It! - Marco Martin On Oct. 26, 2016,

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Edmundson
> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `Applet::contextualActionsAboutToShow`

Review Request 129263: Don't show "Alternatives" menu by default

2016-10-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129263/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Rosca
> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `Applet::contextualActionsAboutToShow`

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Edmundson
> On Oct. 26, 2016, 10:36 a.m., David Rosca wrote: > > This made the Alternatives action visible in toolbox menu. > > > > The problem is that toolbox tries to emit `contextualActionsAboutToShow` on > > `AppletInterface`, but the connection between > > `Applet::contextualActionsAboutToShow`

Re: Review Request 129086: Update applet alternatives menu entry visibility on demand

2016-10-26 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129086/#review100291 --- This made the Alternatives action visible in toolbox menu.

[Differential] [Changed Subscribers] D3159: Set wayland output scale

2016-10-26 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > x11windowed_backend.cpp:477-480 > +QVector ret; > +for (auto it = m_windows.constBegin(); it != m_windows.constEnd(); ++it) > { > +ret << initialOutputScale(); > +} QVector ::fill(const T , int size = -1) Assigns value to

[Differential] [Updated, 70 lines] D3159: Set wayland output scale

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 7666. davidedmundson marked 3 inline comments as done. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. int -> real REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3159: Set wayland output scale

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in main_wayland.cpp:638 > hmm I'm not sure whether we should implement it as an int factor. Even if > Wayland only supports integer scaling, I think that's a bad idea and we > should rather go with fractal scaling from the

[Differential] [Commented On] D3089: WIP: Restore global menu support

2016-10-26 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > abstract_client.h:667 > +void applicationMenuActiveChanged(bool); > +void requestShowApplicationMenu(); > is that a signal (context is missing in diff)? If yes it sounds more like a slot. > abstract_client.h:1017 > + > +bool

[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

2016-10-26 Thread somnium
https://bugs.kde.org/show_bug.cgi?id=371276 somnium changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED

[Differential] [Request, 1,233 lines] D3163: Remove deprecated useraccount

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It was only kept behind to install some pictures, which are now installed by user-manager.

Re: Review Request 129255: Fixed unrar version check.

2016-10-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129255/#review100290 --- Ship it! Ship It! - Marco Martin On Oct. 24, 2016,

Re: Minutes Monday Plasma Meeting

2016-10-26 Thread Marco Martin
On Monday 24 October 2016, Sebastian Kügler wrote: > Plasma meeting (IRC), 24-10-2016 > > Present: mgraesslin, romangg, bshah, d_ed, Sho, sebas been away on monday and tuesday, adding my stuff for last week: * port all output in libplasma to QCDebug/QCWarning * prototype of a more

Re: moving kdepasswd to plasma-desktop/kcms/useraccount?

2016-10-26 Thread Marco Martin
On Monday 24 October 2016, Aleix Pol wrote: > I don't think this addresses David's question. > > "weird politics" is a bad explanation (I'm unaware of the back story). > > Does that mean we can remove it then? indeed, it's time for a final decision on this -- Marco Martin

[Differential] [Updated, 299 lines] D3089: WIP: Restore global menu support

2016-10-26 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 7664. broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Rebase on master - Implement ShellClient so it reads the property from Wayland windows The menu button shows up on Wayland but the menu itself

[Differential] [Commented On] D3159: Set wayland output scale

2016-10-26 Thread Martin Gräßlin
graesslin added a comment. I suggest to also implement in the virtual platform in order to be able to auto-test it. INLINE COMMENTS > main_wayland.cpp:528 > +i18n("The scale for windowed mode. > Default value is 1."), > +

[Differential] [Commented On] D3162: Pass a desktopfile name to kcmshell5

2016-10-26 Thread Martin Gräßlin
graesslin added a comment. F379470: kwin_screenshot_ri2629.png REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3162 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Request, 70 lines] D3159: Set wayland output scale

2016-10-26 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Provides a virtual method in Screens where backends can supply the scale of each screen,

[Differential] [Updated] D3160: [kcmshell] set application data only after parsing command line

2016-10-26 Thread Martin Gräßlin
graesslin added a dependent revision: D3161: [kcmshell] Use desktop file name of module as app's desktop file. REPOSITORY rKDECLITOOLS KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D3160 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 10 lines] D3161: [kcmshell] Use desktop file name of module as app's desktop file

2016-10-26 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY By default kcmshell5 registers as org.kde.kcmshell5, but such a desktop file does not exist. Which

[Differential] [Commented On] D3161: [kcmshell] Use desktop file name of module as app's desktop file

2016-10-26 Thread Martin Gräßlin
graesslin added a comment. F379454: kwin_screenshot_QZ2629.png Desktop Effect settings show proper icon on Wayland instead of generic one. REPOSITORY rKDECLITOOLS KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D3161 EMAIL

[Differential] [Request, 6 lines] D3160: [kcmshell] set application data only after parsing command line

2016-10-26 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KAboutData provides some information needed for the output of the command line options like version.

[Differential] [Updated] D3161: [kcmshell] Use desktop file name of module as app's desktop file

2016-10-26 Thread Martin Gräßlin
graesslin added a dependency: D3160: [kcmshell] set application data only after parsing command line. REPOSITORY rKDECLITOOLS KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D3161 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

[Differential] [Request, 8 lines] D3162: Pass a desktopfile name to kcmshell5

2016-10-26 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY In order to have a proper window icon for kcmshell5 on Wayland KWin