[Differential] [Requested Changes To] D4093: Initialise array variable

hein requested changes to this revision. hein added a reviewer: hein. hein added a comment. This revision now requires changes to proceed. Hmm, weird. I remember seeing that warning and changing the condition to cachedRectangleSelection && cachedRectangleSelection.length, but somehow it

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

hein added a comment. I'm against reducing opacity, using a fade-out for something that's "on" gets us into design trouble when we want to use fade out to say "off". I'm OK with reducing size a bit, but I also don't have a problem with the version on master personally. If we do resize size,

[Differential] [Closed] D4081: [libinput] Connection object in main thread for DBus connection

This revision was automatically updated to reflect the committed changes. Closed by commit R108:ffa60dfef1c0: [libinput] Connection helper class for DBus connection (authored by subdiff). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4081?vs=10035=10086

Re: Crash in new connections KCM

I'm not sure they're the same. Jan's crash is a double delete in QMenuProxy (qmenu.cpp in p-f) and QApplication. QApplication::~QApplication deletes all QWidgets that don't have a parent That creates a list of QWidgets including our QML scene and a QMenu and itterates through them Deleting our

[Differential] [Commented On] D4092: Part Revert "[Units] Make iconSizes property constant"

apol added a comment. In https://phabricator.kde.org/D4092#76633, @davidedmundson wrote: > In https://phabricator.kde.org/D4092#76611, @apol wrote: > > > I don't get it. If it changes, why is it constant? > > > The icon sizes change > > These are exposed in a QQmlPropertyMap

[Differential] [Commented On] D4092: Part Revert "[Units] Make iconSizes property constant"

davidedmundson added a comment. In https://phabricator.kde.org/D4092#76611, @apol wrote: > I don't get it. If it changes, why is it constant? The icon sizes change These are exposed in a QQmlPropertyMap The address of that QQmlPropertyMap is always the same REPOSITORY

[Differential] [Commented On] D4092: Part Revert "[Units] Make iconSizes property constant"

apol added a comment. I don't get it. If it changes, why is it constant? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4092 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma,

[Differential] [Request, 2 lines] D4093: Initialise array variable

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Some code later calls cachedRectangleSelection.length which gives a warning. REPOSITORY

[Differential] [Request, 6 lines] D4092: Part Revert "[Units] Make iconSizes property constant"

davidedmundson created this revision. davidedmundson added reviewers: Plasma, Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Though we can make the property constant, some applications still use

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

apol added a comment. In https://phabricator.kde.org/D4090#76560, @broulik wrote: > Just tried your patch, here it's so small I can hardly see it now. F2004967: Screenshot_20170111_201649.png Should I try a different multiplier? 0.8 instead

[Differential] [Closed] D3993: disable logging to kscreen.log by default

This revision was automatically updated to reflect the committed changes. Closed by commit R110:cea4c63f8465: disable logging to kscreen.log by default (authored by sebas). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3993?vs=9804=10078 REVISION

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

broulik added a comment. What about reducing opacity to minimize the attention it draws? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, jensreuterberg

[Differential] [Closed] D4086: If we changed containment with the config open, relaunch the config dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8e086d25b57a: If we changed containment with the config open, relaunch the config dialog (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4086?vs=10062=10072#toc

[Differential] [Closed] D4087: panel alignment/visibility not resolution dependent

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8d58eefc5580: panel alignment/visibility not resolution dependent (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4087?vs=10070=10071

[Differential] [Updated, 18 lines] D4087: panel alignment/visibility not resolution dependent

mart updated this revision to Diff 10070. mart added a comment. - avoid storing in temporaries REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4087?vs=10063=10070 BRANCH phab/panelalignment REVISION DETAIL https://phabricator.kde.org/D4087

[Differential] [Accepted] D4086: If we changed containment with the config open, relaunch the config dialog

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4086 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D4081: [libinput] Connection object in main thread for DBus connection

graesslin added a comment. Just tested on my system: looks good, I didn't get a crash when going to DPMS. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4081 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #kwin,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 548 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/548/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 Jan 2017 19:09:40 + Build duration: 5 min 39 sec CHANGE SET Revision

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

broulik added a comment. Just tried your patch, here it's so small I can hardly see it now. F2004967: Screenshot_20170111_201649.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES

[Differential] [Updated] D4089: Add support for skipCloseAnimation for internal windows

graesslin added a dependent revision: D4091: Add support for skip close animation to OnScreenMessage. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4089 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Updated] D4091: Add support for skip close animation to OnScreenMessage

graesslin added a dependency: D4089: Add support for skipCloseAnimation for internal windows. REVISION DETAIL https://phabricator.kde.org/D4091 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin,

[Differential] [Request, 71 lines] D4091: Add support for skip close animation to OnScreenMessage

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This change adds support for marking the OnScreenMessage as it

[Differential] [Updated] D4090: Don't let the sound indicator get as big as the task icon

apol added a reviewer: jensreuterberg. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, jensreuterberg Cc: broulik, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

apol added a comment. before F2004962: Spectacle.M31405.png after F2004958: Spectacle.Z31190.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

broulik added a comment. +1 for the verticalCenter change nonetheless, though REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma Cc: broulik, plasma-devel,

[Differential] [Commented On] D4090: Don't let the sound indicator get as big as the task icon

broulik added a comment. Can you make a screenshot? It's intentional, at least for regular task manager to be the same size. Icon tasks situation isn't ideal, though. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4090 EMAIL PREFERENCES

[Differential] [Request, 6 lines] D4090: Don't let the sound indicator get as big as the task icon

apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise it gets too relevant and takes some of the actual task prominence REPOSITORY R119 Plasma Desktop

[Differential] [Accepted] D4087: panel alignment/visibility not resolution dependent

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH phab/panelalignment REVISION DETAIL https://phabricator.kde.org/D4087 EMAIL PREFERENCES

[Differential] [Commented On] D4087: panel alignment/visibility not resolution dependent

davidedmundson added a comment. If you want to do this without casting another approach is to load the legacy version as the default config().parent().readEntry("panelVisibility", config.readEntry(, NormalPanel)); REPOSITORY R120 Plasma Workspace REVISION DETAIL

[Differential] [Closed] D1770: [OSD] Allow disabling OSD through config file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:15172a6fc78d: [OSD] Allow disabling OSD through config file (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1770?vs=9995=10067

[Differential] [Closed] D4088: Don't pass immutable properties from updateAction

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6042e8feb94d: Don't pass immutable properties from updateAction (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4086: If we changed containment with the config open, relaunch the config dialog

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in desktopview.cpp:267 > this should be disconnected somewhere.. > wouldn't this always show the config dialog after the first time, regardless > the config dialog is open or not? (ie, activity switch) The third argument is the

[Differential] [Request, 46 lines] D4089: Add support for skipCloseAnimation for internal windows

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY We need this to use the new OnScreenNotification in the screenshot

[Differential] [Accepted] D4088: Don't pass immutable properties from updateAction

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4088 EMAIL PREFERENCES

[Differential] [Request, 7 lines] D4088: Don't pass immutable properties from updateAction

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY See comment at the top of createAction Reduces the number of warnings in updateAction about

[Differential] [Changed Subscribers] D4086: If we changed containment with the config open, relaunch the config dialog

mart added inline comments. INLINE COMMENTS > desktopview.cpp:267 > m_configView = new ContainmentConfigView(cont); > +//if we changed containment with the config open, relaunch the > config dialog but for the new containment > +connect(this, ::containmentChanged, >

[Differential] [Request, 24 lines] D4087: panel alignment/visibility not resolution dependent

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY panel size and position in pixel is dependent from screen resolution, this saved in different config groups, as

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 547 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/547/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 Jan 2017 18:08:50 + Build duration: 5 min 52 sec CHANGE SET Revision

[Differential] [Updated, 4 lines] D4086: If we changed containment with the config open, relaunch the config dialog

davidedmundson updated this revision to Diff 10062. davidedmundson added a comment. Ninja fix. Only when we're actually configuring the desktop though REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4086?vs=10060=10062 BRANCH master REVISION

[Differential] [Request, 5 lines] D4086: If we changed containment with the config open, relaunch the config dialog

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If we changed containment with the config open, relaunch the config dialog but for the new

[Differential] [Closed] D4085: Fix crash during crash acrobatics.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fc8ce43ac026: Fix crash during crash acrobatics. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4085?vs=10059=10061 REVISION DETAIL

[Differential] [Accepted] D4085: Fix crash during crash acrobatics.

davidedmundson accepted this revision. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, mart, davidedmundson Cc: plasma-devel, lesliezhai,

[Differential] [Accepted] D4085: Fix crash during crash acrobatics.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D4081: [libinput] Connection object in main thread for DBus connection

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. For future reference, it's possible to auto generate adaptors from an XML file. Though that's mostly useful if your

[Differential] [Request, 8 lines] D4085: Fix crash during crash acrobatics.

hein created this revision. hein added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Mark drag in progress earlier and use it to avoid queuing two drags, avoid nesting QDrag::exec.

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 546 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/546/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 Jan 2017 17:25:24 + Build duration: 15 min CHANGE SET Revision

[Differential] [Closed] D4038: [Task Manager] Only match application name if we never managed to match PID

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d62619ced16c: [Task Manager] Only match application name if we never managed to match PID (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4038?vs=9897=10058#toc

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 545 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/545/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 Jan 2017 15:31:37 + Build duration: 9 min 39 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 605 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/605/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 Jan 2017 15:43:58 + Build duration: 1 min 28 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 605 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/605/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 Jan 2017 15:43:58 + Build duration: 1 min 28 sec CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Accepted] D4034: Show descriptive text when changing containment plugins

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. let's go for it, tough i really fear the pain a real solution may be :) REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

[Differential] [Closed] D4034: Show descriptive text when changing containment plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3851de096f02: Show descriptive text when changing containment plugins (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4034?vs=9886=10057#toc REPOSITORY R119

Jenkins-kde-ci: plasma-tests master kf5-qt5 » Linux,gcc - Build # 604 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-tests%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/604/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 Jan 2017 15:27:17 + Build duration: 1 min 39 sec CHANGE SET No changes

[Differential] [Closed] D4070: Changes to global menu applet

chinmoyr closed this revision. chinmoyr added a comment. Closed with commit https://phabricator.kde.org/R120:fa06aac99b2fdec758a3854d3a9c61d8ef69ba59 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4070 EMAIL PREFERENCES

[Differential] [Closed] D4082: parse the desktop file 2 times

This revision was automatically updated to reflect the committed changes. Closed by commit R244:2a9b56e93407: parse the desktop file 2 times (authored by mart). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4082?vs=10054=10055 REVISION DETAIL

[Differential] [Accepted] D4070: Changes to global menu applet

broulik accepted this revision. broulik added a reviewer: broulik. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4070 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: chinmoyr, davidedmundson, broulik Cc: broulik,

[Differential] [Updated, 140 lines] D4082: parse the desktop file 2 times

mart updated this revision to Diff 10054. mart added a comment. - add an autotest for a list item before the servicetypes definition REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4082?vs=10045=10054 BRANCH phab/prse2servicetypes REVISION DETAIL

[Differential] [Updated, 105 lines] D4070: Changes to global menu applet

chinmoyr updated this revision to Diff 10053. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4070?vs=10051=10053 REVISION DETAIL https://phabricator.kde.org/D4070 AFFECTED FILES applets/appmenu/lib/CMakeLists.txt

[Differential] [Accepted] D4084: Add unit test for desktopToJson being called without an explicit serviceType

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4084 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson,

[Differential] [Accepted] D4082: parse the desktop file 2 times

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH phab/prse2servicetypes REVISION DETAIL https://phabricator.kde.org/D4082 EMAIL PREFERENCES

[Differential] [Commented On] D4082: parse the desktop file 2 times

davidedmundson added a comment. See https://phabricator.kde.org/D4084 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4082 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, dfaure, davidedmundson Cc: apol,

[Differential] [Request, 76 lines] D4084: Add unit test for desktopToJson being called without an explicit serviceType

davidedmundson created this revision. davidedmundson added reviewers: Plasma, Frameworks. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4084

[Differential] [Commented On] D4070: Changes to global menu applet

broulik added a comment. I just noticed when I change the setting in the KCM the icon changes to the warning icon but the button stays enabled, only if I restart plasma the button is disabled INLINE COMMENTS > appmenuapplet.h:69 > +bool appletEnabled() const; > +void

Re: Crash in new connections KCM

On 11.01.2017 08:51, Jan Grulich wrote: Hi, I'm experiencing a crash when closing (using cancel button) the new connections KCM (from plasma-nm) and I'm not able to find out why this is happening. Don't worry, happens with all KCM modules that use QML, see

[Differential] [Accepted] D4070: Changes to global menu applet

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4070 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: chinmoyr, davidedmundson Cc:

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 544 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/544/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 Jan 2017 14:10:17 + Build duration: 15 min CHANGE SET Revision

[Differential] [Commented On] D4082: parse the desktop file 2 times

apol added a comment. How about adding a test? Other than that, the patch looks good. It's horrible that we need to do so, but I guess it's the price of backwards compatibility. There's the possibility of doing the processing in two steps (desktop to pairs, pairs to json), but we

[Differential] [Updated, 75 lines] D4070: Changes to global menu applet

chinmoyr updated this revision to Diff 10051. chinmoyr added a comment. got rid of all useless config props REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4070?vs=10042=10051 REVISION DETAIL https://phabricator.kde.org/D4070 AFFECTED FILES

[Differential] [Closed] D4083: Add layout template to create an "Application Menu Bar"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d5148a0febed: Add layout template to create an "Application Menu Bar" (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4062: Simplify AppMenu menu management

This revision was automatically updated to reflect the committed changes. Closed by commit R120:109b0882da77: Simplify AppMenu menu management (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4062?vs=9963=10046 REVISION

[Differential] [Closed] D3706: WIP: Global Menu Applet

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5b8380b604ff: Global Menu Applet (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3706?vs=9788=10049 REVISION DETAIL

[Differential] [Closed] D4057: Reuse QAction and QMenu items on updates

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1754c135c134: Reuse QAction and QMenu items on updates (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4057?vs=10043=10048

[Differential] [Closed] D4059: Replace recursive layout loading with dynamic loading

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e872d1cd4640: Replace recursive layout loading with dynamic loading (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4059?vs=9954=10047#toc REPOSITORY R120

[Differential] [Commented On] D4082: parse the desktop file 2 times

davidedmundson added a comment. +1 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4082 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, dfaure, davidedmundson Cc: plasma-devel, #frameworks, lesliezhai,

[Differential] [Updated, 109 lines] D4082: parse the desktop file 2 times

mart updated this revision to Diff 10045. mart marked an inline comment as done. mart added a comment. - don't load servicetypes a second time REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4082?vs=10044=10045 BRANCH phab/prse2servicetypes REVISION

[Differential] [Updated, 102 lines] D4082: parse the desktop file 2 times

mart updated this revision to Diff 10044. mart added a comment. - don't close/reopen the file REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4082?vs=10039=10044 BRANCH phab/prse2servicetypes REVISION DETAIL https://phabricator.kde.org/D4082

[Differential] [Updated, 49 lines] D4057: Reuse QAction and QMenu items on updates

davidedmundson updated this revision to Diff 10043. davidedmundson added a comment. Changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4057?vs=9988=10043 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4057 AFFECTED FILES

[Differential] [Accepted] D4083: Add layout template to create an "Application Menu Bar"

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4083 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Updated, 91 lines] D4070: Changes to global menu applet

chinmoyr updated this revision to Diff 10042. chinmoyr added a comment. addressed Kai's concerns REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4070?vs=9981=10042 REVISION DETAIL https://phabricator.kde.org/D4070 AFFECTED FILES

[Differential] [Updated] D4082: parse the desktop file 2 times

davidedmundson added a comment. Also you can remove the lines } else if (key == QByteArrayLiteral("X-KDE-ServiceTypes") || key == QByteArrayLiteral("ServiceTypes")) { const auto services = deserializeList(value); - for(const auto : services) { - // some .desktop files

[Differential] [Updated] D3706: WIP: Global Menu Applet

broulik added a dependent revision: D4083: Add layout template to create an "Application Menu Bar". REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3706 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson,

[Differential] [Request, 22 lines] D4083: Add layout template to create an "Application Menu Bar"

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R119 Plasma Desktop. broulik added a dependency: D3706: WIP: Global Menu Applet. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.

[Differential] [Closed] D3085: Use DBusMenu if available

This revision was automatically updated to reflect the committed changes. Closed by commit R135:14a546e53bfa: Use DBusMenu if available (authored by davidedmundson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4082: parse the desktop file 2 times

davidedmundson added inline comments. INLINE COMMENTS > desktopfileparser.cpp:541 > +lineNr=0; > +df.close(); > +readUntilDesktopEntryGroup(df, src, lineNr); We don't need to close readUntilDesktopEntryGroup() auto pos = dr.pos(); while() { } dr.seek(pos); while() { } REPOSITORY

[Differential] [Commented On] D4082: parse the desktop file 2 times

mart added inline comments. INLINE COMMENTS > desktopfileparser.cpp:237 > > +bool tokenizeKeyValue(QFile , const QString , QByteArray , > QString , int ) > +{ maybe instead a bool it could have error codes to more easily assure the behavior is 100% the same as before REPOSITORY R244

[Differential] [Request, 102 lines] D4082: parse the desktop file 2 times

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Search for the ServiceTypes key in the desktop file before parsing it "for real", because

[Differential] [Updated] D4082: parse the desktop file 2 times

mart added reviewers: davidedmundson, dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D4082 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, davidedmundson, dfaure Cc: plasma-devel, #frameworks, lesliezhai,

[Differential] [Commented On] D4070: Changes to global menu applet

broulik added inline comments. INLINE COMMENTS > appmenuapplet.h:36 > > +Q_PROPERTY(bool useApplet READ useApplet NOTIFY useAppletChanged) > + Maybe "applicationMenuAppletEnabled" or something like that? > main.qml:76 > + > +PlasmaCore.ToolTipArea { > + visible:

Re: [plasma-devel] Plasma 5.9 Beta announce

On Tue, Jan 10, 2017 at 10:57:38PM +0100, Łukasz Sawicki wrote: > Please replace video from announcement (Look and Feel ) with this one > https://youtu.be/RX5HwumKPP8. I edited it a bit (removed buggy part) > and also uploaded to official KDE YouTube channel. announcement updated thanks

[Differential] [Closed] D4067: add a small preview

This revision was automatically updated to reflect the committed changes. Closed by commit R526:fd60b4a6dcf2: add a small preview (authored by mart). REPOSITORY R526 Breeze theme for Plymouth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4067?vs=10028=10037 REVISION DETAIL

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 543 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/543/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 Jan 2017 11:08:42 + Build duration: 5 min 59 sec CHANGE SET Revision

[Differential] [Commented On] D4081: [libinput] Connection object in main thread for DBus connection

subdiff added a comment. Note, that the Wayland Touchpad KCM won't work without this patch. So it's rather important. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4081 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff,

[Differential] [Request, 73 lines] D4081: [libinput] Connection object in main thread for DBus connection

subdiff created this revision. subdiff added a reviewer: KWin. subdiff set the repository for this revision to R108 KWin. subdiff added projects: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The last patch

[Differential] [Closed] D3216: WIP: Restore Menubar style config in application style

This revision was automatically updated to reflect the committed changes. Closed by commit R119:856e2edb030f: Restore Menubar style config in application style (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3216?vs=7786=10036#toc REPOSITORY R119 Plasma Desktop

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 542 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/542/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 Jan 2017 11:01:37 + Build duration: 5 min 49 sec CHANGE SET Revision

[Differential] [Closed] D3617: [Touchpad KCM] New KWin Wayland version

This revision was automatically updated to reflect the committed changes. subdiff marked an inline comment as done. Closed by commit R119:3db456588d0d: [Touchpad KCM] New KWin Wayland version (authored by subdiff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3617?vs=9495=10034#toc

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 541 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/541/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 11 Jan 2017 10:28:52 + Build duration: 5 min 49 sec CHANGE SET Revision

[Differential] [Accepted] D4067: add a small preview

sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R526 Breeze theme for Plymouth BRANCH arcpatch-D4067_1 REVISION DETAIL https://phabricator.kde.org/D4067 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart,

[Differential] [Closed] D3969: Kill audioplayercontrolrunner

This revision was automatically updated to reflect the committed changes. Closed by commit R114:4f464465489b: Kill audioplayercontrolrunner (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3969?vs=9724=10031#toc REPOSITORY R114 Plasma Addons CHANGES SINCE LAST

[Differential] [Closed] D3968: [Fifteen Puzzle] Start timer on tile click, stop timer on shuffle

This revision was automatically updated to reflect the committed changes. Closed by commit R114:70d8a2aa8b51: [Fifteen Puzzle] Start timer on tile click, stop timer on shuffle (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

  1   2   >