davidedmundson created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
Making QActions with the Connection as a parent is dangerous as it gets
moved to a new thread, moving all child objects to th
Zren added inline comments.
INLINE COMMENTS
> sebas wrote in natgeoprovider.cpp:96
> Why this change? Moving away from https to http seems backward...
The https redirects to http (HTTP 302 temp move), then redirects to add the
trailing slash (HTTP 301 Perm Move).
F3744087: 2017-05-06___19-22-2
https://bugs.kde.org/show_bug.cgi?id=379593
Bug ID: 379593
Summary: git master fails to build: plasma_version.h not found
Product: kio-extras
Version: unspecified
Platform: Other
OS: Linux
Status: UNCONFIRMED
luebking accepted this revision.
luebking added a comment.
This revision is now accepted and ready to land.
Matter of semantics only (if you would want to use the XCB_CURRENT_TIME
symbol wrt backend abstraction matters and readability - the invalidity isn't
implicitly explained, maybe read as
vitali planned changes to this revision.
vitali added inline comments.
INLINE COMMENTS
> natgeoprovider.cpp:61
> +
> +
> re.setPattern("^$");
> +
An alternative regex may be
`"^$"`, so to match any
possible future fields before `property`, and between `property` and `content`.
> sebas wro
sebas added subscribers: luebking, sebas.
sebas added a comment.
@luebking can you have a look?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5731
To: graesslin, #kwin, #plasma
Cc: sebas, luebking, plasma-devel, kwin, ZrenBot, spstarr, progwolff,
lesliezhai, ali-moha
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Change
https://phabricator.kde.org/R108:0bec9ad7337536e319c17c5684d97e1156399fdb
introduced a regrssion
on Wayland. On Wayland getTime
graesslin added a comment.
New version at https://phabricator.kde.org/D5731
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5726
To: graesslin, #kwin, #plasma, sebas
Cc: luebking, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai,
ali-mohamed, hardening, jens
Am 2017-05-06 11:37, schrieb Ben Cooksley:
This is the second point that requires your attention. If your
development process is dependent on using the latest development
version of something which is located in another product, then we will
need to add that to your Product. If this affects you,
graesslin abandoned this revision.
graesslin added a comment.
Going for Thomas's suggestion to check in setX11Time
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5726
To: graesslin, #kwin, #plasma, sebas
Cc: luebking, plasma-devel, kwin, ZrenBot, spstarr, progwolff, le
sebas added inline comments.
INLINE COMMENTS
> natgeoprovider.cpp:96
> {
> -const QUrl url( QLatin1String(
> "https://www.nationalgeographic.com/photography/photo-of-the-day"; ) );
> +const QUrl url( QLatin1String(
> "http://www.nationalgeographic.com/photography/photo-of-the-day/"; )
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/742/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 16:16:50 +
Build duration: 6 min 5 sec
CHANGE SET
Revision 65a42d8a2be1145a9bf29c97a3ed471
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:65a42d8a2be1: Adding an option to show popular
documents/apps for Kickoff (authored by ivan).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5620?vs=13879&id
ivan added a comment.
Not sure I'd rush it for 5.11. I'll probably have to tweak the formula
coefficients for the score - how much deterioration over time it should have,
... (this is the main reason I'm making the graphs - to be able to easier debug
the stats - having it in a user applicati
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/880/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 06 May 2017 14:20:47 +
Build duration: 6 min 5 sec
CHANGE SET
Revision 16629c8ea8e2caca93d4c8ae22b74
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:16629c8ea8e2: DBusMenuImporter: Use unique connection for
QMenu::aboutToHide (authored by drosca).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5706?vs=1
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:cb52cc8826d4: Move all streams when changing default
device (authored by drosca).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5684?vs=14067&id
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:462628981947: Preserve channel balance when changing
volume (authored by drosca).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5546?vs=13711&id=14205#toc
REPOSITORY
R115 Plasma Audio Volum
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:d78689251344: Applet: Automatically raise maximum volume
when over defined maximum volume (authored by drosca).
REPOSITORY
R115 Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabric
drosca added inline comments.
INLINE COMMENTS
> sebas wrote in ListItemBase.qml:282
> Should be "volume", since that's the property. Or perhaps we don't need
> "volume" or "Volume".
"Volume" is a role from the model, so assigning to the "volume" property
instead only makes it go through one in
sebas added a comment.
You're right, forgot to submit the cosmetical comment.
INLINE COMMENTS
> ListItemBase.qml:282
> +if (!slider.forceRaiseMaxVolume && Volume >
> PulseAudio.NormalVolume) {
> +Volume = PulseAudio.NormalVolume;
> +}
Shou
drosca added a comment.
In https://phabricator.kde.org/D5695#106996, @sebas wrote:
> Cosmetical comment aside, looks good.
What's that cosmetical comment? Did you forget to send it?
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
auto-raise-volume (branched from master)
RE
https://bugs.kde.org/show_bug.cgi?id=379003
--- Comment #10 from Juri Vitali ---
(In reply to Sebastian Kügler from comment #9)
Sure thing!
I cleaned the patch up a bit, and posted it on Phabricator.
Here it is: https://phabricator.kde.org/D5729
--
You are receiving this mail because:
You are
sebas accepted this revision.
sebas added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> context.h:97
> if (channel == -1) { // -1 all channels
> +qint64 diff = newVolume - pa_cvolume_avg(&cVolume);
> for (int i = 0; i < newCV
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R115 Plasma Audio Volume Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5684
To: drosca, #plasma, sebas
Cc: Zren, plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed,
jensre
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
fix-timestamp-regression-5.8
REVISION DETAIL
https://phabricator.kde.org/D5726
To: graesslin, #kwin, #plasma, sebas
Cc: luebking, plasma-devel, kwin, spstarr, progwolff, Zren, leslie
vitali created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The current parsing mechanism to obtain the current NatGeo POTD based on XML
is broken, this patch proposes an alternative mechanism using
QRe
cfeck added a comment.
In https://phabricator.kde.org/D5723#107203, @davidedmundson wrote:
> add bug mentioned by cfeck
Uhm, where did you add it?
REPOSITORY
R130 Frameworks integration plugin using KWayland
REVISION DETAIL
https://phabricator.kde.org/D5723
To: davidedmundso
graesslin added a comment.
I had already investigated the problem, pushed a change and reverted it. I
think the qstyle gets destroyed too early.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5728
To: davidedmundson, #plasma, hpereiradacosta
Cc: graesslin, cfeck, pla
davidedmundson added a comment.
I uploaded to make it easier for someone to test a patch. It didn't work.
That's why I'm closing it.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5728
To: davidedmundson, #plasma, hpereiradacosta
Cc: cfeck, plasma-devel, spstarr, pro
cfeck added a reviewer: hpereiradacosta.
cfeck added a comment.
Probably needs a similar fix in Oxygen. And if "Registry" is related to
pixmap/tile caches, it might even fix the shutdown crashes we got there, e.g.
bug 331260.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde
davidedmundson abandoned this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5728
To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, Zren, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Otherwise we get a double release as the QPA releases the wl_display
which deletes the registry.
BUG:
REPOSITORY
R31 Breeze
B
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:149d281277df: fish ioslave: Port away from
KDELibs4Support (authored by marten).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5562?vs=13743&id=14192
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:26f76fc64bae: recentdocuments ioslave: Port away from
KDELibs4Support (authored by marten).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5566?vs=13748&id=14194
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:11df45b3d216: SFTP ioslave: Port away from
KDELibs4Support (authored by marten).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5568?vs=14036&id=14196
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:b0b12086e786: Thumbnail ioslave: Port away from
KDELibs4Support (authored by marten).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5569?vs=13752&id=14197
REVI
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:cefa4de62964: Man ioslave: Port away from KDELibs4Support
(authored by marten).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5564?vs=13744&id=14191
REVISION D
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:117e6235ce81: Settings ioslave: Port away from
KDELibs4Support (authored by marten).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5567?vs=13750&id=14195
REVIS
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:17effe0d9f73: Network ioslave: Port away from
KDELibs4Support (authored by marten).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5565?vs=13746&id=14193
REVISI
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:bbd3d8feb250: Archive: Port away from KDELibs4Support
(authored by marten).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5560?vs=13741&id=14189
REVISION DETAI
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:c285acd05e32: filter: Port away from KDELibs4Support
(authored by marten).
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5561?vs=13742&id=14190
REVISION DETAIL
https://bugs.kde.org/show_bug.cgi?id=379003
Sebastian Kügler changed:
What|Removed |Added
CC||se...@kde.org
--- Comment #9 from Sebastian
On sabato 6 maggio 2017 11:37:51 CEST, Ben Cooksley wrote:
Hi everyone,
This is going to be quite a long email, my apologies in advance for that.
If you use the CI system regularly as part of your development flow it
is important you read this email in it's entirety as your action will
probably
On Sat, May 6, 2017 at 10:15 PM, Elvis Angelaccio
wrote:
> On sabato 6 maggio 2017 11:37:51 CEST, Ben Cooksley wrote:
>>
>> Hi everyone,
>>
>> This is going to be quite a long email, my apologies in advance for that.
>> If you use the CI system regularly as part of your development flow it
>> is i
On Saturday May 06 2017 22:01:58 Ben Cooksley wrote:
>On Sat, May 6, 2017 at 9:58 PM, René J.V. Bertin wrote:
>> On Saturday May 06 2017 21:37:51 Ben Cooksley wrote:
>>
>>>'Platforms' on which they build. At the moment we have three Platforms
>>>available: Ubuntu Xenial Qt 5.7, Windows Qt 5.7 and
On Sat, May 6, 2017 at 9:58 PM, René J.V. Bertin wrote:
> On Saturday May 06 2017 21:37:51 Ben Cooksley wrote:
>
>>'Platforms' on which they build. At the moment we have three Platforms
>>available: Ubuntu Xenial Qt 5.7, Windows Qt 5.7 and FreeBSD Qt 5.7.
>>Adding additional Platforms to this mix
On Saturday May 06 2017 21:37:51 Ben Cooksley wrote:
>'Platforms' on which they build. At the moment we have three Platforms
>available: Ubuntu Xenial Qt 5.7, Windows Qt 5.7 and FreeBSD Qt 5.7.
>Adding additional Platforms to this mix is fairly easy, as long as the
>code can be built there. Qt wil
Hi everyone,
This is going to be quite a long email, my apologies in advance for that.
If you use the CI system regularly as part of your development flow it
is important you read this email in it's entirety as your action will
probably be required. If you are aware of a list I have missed in the
hein added a comment.
Sounds good to me ... bit worried about people missing their history though,
we might get some angry feedback.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5620
To: ivan, hein, mart, sebas
Cc: plasma-devel, spstarr, progwolff, Zren, l
This revision was automatically updated to reflect the committed changes.
Closed by commit R258:1d7e4cc7c7be: Remove unused dependencies. (authored by
palimaka).
REPOSITORY
R258 Plymouth KCM
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5649?vs=13956&id=14185
REVISION DETAIL
http
mart added a comment.
yes, the idea is to have only the popular documents tab by default in 5.11,
then the history one can still be manualy enabled by the user
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5620
To: ivan, hein, mart, sebas
Cc: plasma-devel,
This revision was automatically updated to reflect the committed changes.
Closed by commit R130:34fc30c4f7ca: Cleanup wayland resources used in
kwindowsystem before they're deleted by QPA (authored by davidedmundson).
REPOSITORY
R130 Frameworks integration plugin using KWayland
CHANGES SINCE L
luebking added a comment.
0L is XCB_CURRENT_TIME iow "kinda invalid", so it's sane to block that in
setX11Time()
Also: a conditional early return? In a four line function? Really? ;-P
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5726
To: graesslin, #kwin, #plas
54 matches
Mail list logo
