This revision was automatically updated to reflect the committed changes.
Closed by commit R128:472f9a7446da: Fix using avatars from the gallery and from
local files (authored by ngraham).
REPOSITORY
R128 User Manager
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8793?vs=22377&id=22
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
No for the same reason.
INLINE COMMENTS
> themeconfig.cpp:90
> +QMimeDatabase db;
> +const auto mime = db.mimeTypeForFile(mBackgroundPath);
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
If someone wants to make a theme with videos they can do so.
I am not ok with polluting the default theme with every possible option
someone could want.
REPOS
apol created this revision.
apol added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
So far people were doing it wrong, modifying files locally and there's
no good reason for it.
REP
apol created this revision.
apol added reviewers: Plasma, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
At the moment we already allowed it, we just always marked them as "image",
now it will depend on
broulik abandoned this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5109
To: broulik, #plasma, hein
Cc: sefaeyeoglu, rkflx, smartins, ngraham, davidedmundson, plasma-devel,
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
ngraham added a comment.
Yeah, putting workarounds everywhere isn't so appealing. My preference would
be for a Qt fix, otherwise we'll be playing whack-a-mole here forever.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D5109
To: broulik, #plasma, hein
Cc: se
graesslin added a comment.
In https://phabricator.kde.org/D8396#168165, @davidedmundson wrote:
> I think we need some big discussion about how powerdevil inhbitions, logind
inhibitions and this are all going to fit together in a clear coherent way.
yeah. I'm not happy with this pr
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in mock_drm.h:1
> I assume this is just phab being stupid?
yes or git being stupid. I did not copy any files around but created a new
empty file. Ok, I admit I copied the copyright header, but certainly one with
my copyrig
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D6567
To: madcatx, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apo
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
autotests-ecm-in-dir
REVISION DETAIL
https://phabricator.kde.org/D7543
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
I think we need some big discussion about how powerdevil inhbitions, logind
inhibitions and this are all going to fit together in a clear coherent way.
But given there a
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
belong-to-same-application-5.11
REVISION DETAIL
https://phabricator.kde.org/D8661
To: graesslin, #kwin, #plasma, davidedmundson
Cc: plasma-devel, kwin, bwowk, ZrenBot, progw
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> mock_drm.h:1
> /
> KWin - the KDE window manager
I assume this is just phab being
mart updated this revision to Diff 22410.
mart added a comment.
- && means we want & and not a mnemonic
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8641?vs=22401&id=22410
BRANCH
mart/formlayout
REVISION DETAIL
https://phabricator.kde.org/D8641
AF
mart updated this revision to Diff 22409.
mart added a comment.
- && means we want & and not a mnemonic
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8827?vs=22402&id=22409
BRANCH
mart/mnemonics
REVISION DETAIL
https://phab
mart added inline comments.
INLINE COMMENTS
> mart wrote in Button.qml:43
> eww, even worse, in Qt 5.10 the mnemonics are removed in setText so is
> impossible to know what the original text was /o\
which, they noticed it was terrible and reverted in Qt 5.11, but 5.10 is still
meh, so the best
mart added inline comments.
INLINE COMMENTS
> mart wrote in Button.qml:43
> hm, yeah, will be terrible :/
eww, even worse, in Qt 5.10 the mnemonics are removed in setText so is
impossible to know what the original text was /o\
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETA
mart added inline comments.
INLINE COMMENTS
> broulik wrote in Button.qml:43
> How does it behave if text contains an `&&` ie. user explicitly wants an
> ampersand but not a mnemonic?
hm, yeah, will be terrible :/
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://
broulik added inline comments.
INLINE COMMENTS
> ToolButton.qml:36
>
> hoverEnabled: true //Qt.styleHints.useHoverEffects TODO: how to make
> this work in 5.7?
>
Btw probably
Qt.styleHints.hasOwnProperty("useHoverEffects") ?
Qt.styleHints.useHoverEffects : true
REPOSITORY
R858 Q
broulik added inline comments.
INLINE COMMENTS
> Button.qml:43
> +//in case of explicit & the button manages it by itself
> +enabled: controlRoot.text.indexOf("&") == -1
> +sequence: controlRoot.Kirigami.MnemonicData.sequence
How does it behave if text contains an `&&` ie
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:a4aa09ef9a83: Honour the preferred mode flag in the
kwayland backend (authored by fvogt).
REPOSITORY
R110 KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8828?vs=22403&id=22
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R110 KScreen Library
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8828
To: fvogt, #plasma, sebas, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuter
fvogt created this revision.
fvogt added reviewers: Plasma, sebas.
Restricted Application added a project: Plasma.
REVISION SUMMARY
BUG: 386900
TEST PLAN
Ran plasma on wayland in virtio, instead of switching to 4096x2160@60
it stays at the right resolution of 1024x768@60 on startup and kscr
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
use auto mnemonics for common widgets as buttons,
checkboxes and tabs
A feature similar to KXMLGui apps
TEST P
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in mnemonicattached.cpp:49
> Note that the alt to show is a Breeze special feature for widgets.
i think it's fine assuming the style supports that... (and assume that the one
which is really supported is breeze) i wouldn't know
graesslin added a comment.
As I just made my kwin crash just to get the backtrace I'm adding
nevertheless:
(gdb) bt
#0 0x7f8d550626b0 in KWayland::Client::Compositor::operator
wl_compositor*() () at /workspace/build/src/client/compositor.cpp:131
#1 0x7f8d428b377d in
mart updated this revision to Diff 22401.
mart added a comment.
- mnemoinictext property, which always has the &
- support mnemonics in the global drawer
- different weigths for differnt control types
- filter on the window not the app
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDAT
davidedmundson added a comment.
Got it, thanks.
REPOSITORY
R108 KWin
BRANCH
windowgeometry-delay-effectframe
REVISION DETAIL
https://phabricator.kde.org/D8821
To: graesslin, #kwin, #plasma, broulik
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-moh
graesslin added a comment.
In https://phabricator.kde.org/D8821#168053, @davidedmundson wrote:
> > New test case added which crashes without this fix.
>
> I wanted to see the backtrace of what we're working round, so applied just
the test and not the changes to the effect.
> It did
davidedmundson abandoned this revision.
davidedmundson added a comment.
> Worst still it highlights a bug when using text with Qt.NativeRendering
AFAIK this is fixed.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D1971
To: davidedmundson, #plasma, graessl
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:e96f2bff11da: Split init'ing the wayland output from
init (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8794?vs=22280&id=22400
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:6325749f2117: Avoid hypothetical crash if output->init
fails (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8779?vs=22247&id=22399
REVIS
davidedmundson planned changes to this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8159
To: davidedmundson, #plasma, graesslin
Cc: graesslin, broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin,
progwolff, lesliezhai, ali-mohamed, jensreuterberg
davidedmundson added a comment.
What's the status of this?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3209
To: broulik, #plasma, mck182, mart
Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, s
ngraham added a comment.
Thanks for the approval. I'll land this, then the refactoring onto my to-do
list. I agree that the current code is a bit stinky and could benefit from a
more direct approach.
REPOSITORY
R128 User Manager
BRANCH
arcpatch-D8793_2
REVISION DETAIL
https://phabric
davidedmundson closed this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3754
To: mvourlakos, #plasma, davidedmundson, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3c5df91dd1a9: Support Qt scaling in wallpaper loading
(authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8826?vs=22396&id=22398#toc
REPOSITORY
R120 Plasma Workspace
davidedmundson accepted this revision.
davidedmundson added a comment.
No objections. It fixes a bug...
But, if you have the time, I'm sure we could come up wtih something much more
elegant with some refactoring.
(like storing the pixmap in infToSave, and then just writing it into .f
This revision was automatically updated to reflect the committed changes.
Closed by commit R122:d492dc57eeb3: Prefer an algorithm over an explicit for
loop (authored by jkt, committed by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2660?vs=7144&id=22397#toc
REPOSITORY
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> main.qml:38
> property bool ready: false
> +property var sourceSize: Qt.size(root.width * Screen.devicePixelRatio,
> root.height * Screen.devicePixelRatio)
>
davidedmundson abandoned this revision.
davidedmundson added a comment.
Can't remember what the state of this is, and the original code probably
changed. Closing.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1986
To: davidedmundson, #plasma
Cc: mart, pla
davidedmundson added a comment.
> New test case added which crashes without this fix.
I wanted to see the backtrace of what we're working round, so applied just
the test and not the changes to the effect.
It didn't crash. Any ideas?
REPOSITORY
R108 KWin
BRANCH
windowgeometry-delay
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
On wayland we're using Qt scaling.
This normally handles most scaling stuff itself, except be
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> x11mousebackend.cpp:186
> +m_supportedAccelerationProfiles.clear();
> +bool adaptiveAvaiable = false;
> +bool flatAvailable = false;
adaptiveAva
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:09efedec8c71: Don't notify about value changes if we
are still in the constructor (authored by apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8820?vs=22368&
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8820
To: apol, #frameworks, davidedmundson
Cc: davidedmundson, broulik, plasma-devel, apol, mart, hein
apol added a comment.
> If you're emitting something in the constructor, how could a UI be
connected to it?
There's a timer.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8820
To: apol, #frameworks
Cc: davidedmundson, broulik, plasma-devel, apol, mart, hein
davidedmundson added a comment.
> it will make the UI react to it at some point
If you're emitting something in the constructor, how could a UI be connected
to it?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8820
To: apol, #frameworks
Cc: davidedmundson, b
amantia added inline comments.
INLINE COMMENTS
> mwolff wrote in screenmapper.cpp:41
> this is a pretty arbitrary timer, can you add a comment on why 100ms is
> better than going through the eventloop once via QMetaObject::invokeMethod
> with the delayed flag set?
Done. InvokeMethod would not
amantia updated this revision to Diff 22387.
amantia marked 2 inline comments as done.
amantia added a comment.
Fix for some of Milian's comments (rest later, need to move to different
computer)
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0e4484b6feb1: [Activity KCM] Disallow adding/removing
activity when restricted (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8026?vs=
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e8c4c3953d4e: Use Qt.callLater instead of creating a
Timer (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8744?vs=22145&id=22381
REVI
mwolff added inline comments.
INLINE COMMENTS
> foldermodeltest.cpp:48
> +
> +void FolderModelTest::initTestCase()
> +{
remove the init and cleanup if both are empty?
> screenmappertest.cpp:36
> +
> +void ScreenMapperTest::cleanupTestCase()
> +{
remove if empty
> screenmappertest.cpp:45
> +
>
https://bugs.kde.org/show_bug.cgi?id=304696
--- Comment #12 from da-kdebugs...@abelonline.de ---
This is still open. Setting "Dim screen" to "3 min" makes the display dim after
90s (instead of 180s). Unchecking "Dim screen" disables dimming, so it is
likely due to this setting.
System settings 5.
https://bugs.kde.org/show_bug.cgi?id=304696
da-kdebugs...@abelonline.de changed:
What|Removed |Added
CC||da-kdebugs...@abelonline.de
--- Co
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b985b7432ef9: Cleanup: use temp variables instead of
querying properties repeatedly (authored by mwolff).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8597
dfaure added a comment.
In https://phabricator.kde.org/D8421#158352, @davidedmundson wrote:
> Have you added it to the panel?
What should happen when I do? Surely a webview won't fit there...
REPOSITORY
R114 Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D8421
To:
58 matches
Mail list logo