D10425: Improve appearance of the logout dialog on wayland

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10425 To: fvogt, #plasma, graesslin, davidedmundson, bshah Cc: ngraham, bshah, plasma-devel, ZrenBot,

Re: Closing old Plasma 4 bugs

On Sun, Feb 11, 2018 at 4:06 PM, Nate Graham wrote: > + kde-devel to widen the conversation Hi Nate, > > > On 02/10/2018 05:48 PM, Nicolás Alvarez wrote: >> >> Meanwhile... maybe you can do some loud blog posts calling for triagers? >> :) > > > Sounds good. Before then,

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 138 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/138/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Feb 2018 04:10:05 + Build duration: 3 min 45 sec and counting CONSOLE

Re: Closing old Plasma 4 bugs

+ kde-devel to widen the conversation On 02/10/2018 05:48 PM, Nicolás Alvarez wrote: Meanwhile... maybe you can do some loud blog posts calling for triagers? :) Sounds good. Before then, we need to clean up the wiki page for this: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Re: Closing old Plasma 4 bugs

The only thing we have is a way to do mass-edits without sending any email. That doesn't seem suitable for mass-closing; it's more for things like reassigning lots of bugs to another product. For closing I assume you do want to send email to the reporters. Maybe we can do some script to close the

D10434: Changed hexadecimal system to decimal for Binary Clock widget

piotrkakol edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10434 To: piotrkakol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10434: Changed hexadecimal system to decimal for Binary Clock widget

piotrkakol edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10434 To: piotrkakol Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10434: Changed hexadecimal system to decimal for Binary Clock widget

piotrkakol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. piotrkakol requested review of this revision. REVISION SUMMARY Hours, minutes and seconds are in hexadecimal system. I don't know if it was intended or

D7085: Fix issue where notifications will show as 1 pixel line

davidedmundson abandoned this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7085 To: davidedmundson, #plasma Cc: plasma-devel,

KDE CI: Plasma plasma-integration kf5-qt5 FreeBSDQt5.9 - Build # 14 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-integration%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Plasma plasma-integration kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Feb 2018 22:46:58 + Build duration: 7 min 21 sec and counting

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 137 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/137/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Feb 2018 22:46:56 + Build duration: 3 min 54 sec and counting CONSOLE

D10429: Disable the title bar separator by default

anthonyfieroni added a comment. -1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt, #vdg, #plasma, ngraham Cc: anthonyfieroni, januz, rikmills, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10429: Disable the title bar separator by default

januz added a comment. I can't +1 this hard enough. There's no point in having a line separating the titlebar from the window. For users that want their titlebars the same color as the window it just gets in the way, and for users that want a clear separation it adds nothing (since there's

D10425: Improve appearance of the logout dialog on wayland

fvogt edited the summary of this revision. fvogt edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10425 To: fvogt, #plasma, graesslin, davidedmundson, bshah Cc: ngraham, bshah, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10425: Improve appearance of the logout dialog on wayland

fvogt updated this revision to Diff 26891. fvogt added a comment. Use a different workaround: wl-shell instead of xdg-shell. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10425?vs=26874=26891 BRANCH Plasma/5.12 REVISION DETAIL

Re: Closing old Plasma 4 bugs

+ sysad...@kde.org KDE Sysadmins, is there anything special we need to do before doing a mass bug close? around 2,500 bugs would be closed in a short period of time. Martin, good idea. I'll remove that line. Nate On 02/10/2018 01:42 PM, Martin Flöser wrote: Am 2018-02-10 21:24, schrieb

Re: Closing old Plasma 4 bugs

Am 2018-02-10 21:24, schrieb Nate Graham: Hello folks, We have more than 2,500 Plasma 4 bugzilla tickets that we don't intend to look at or triage. We've already prevented new tickets from being filed, but it doesn't do anyone any good to just have the old ones sitting there. My sense is that

Closing old Plasma 4 bugs

Hello folks, We have more than 2,500 Plasma 4 bugzilla tickets that we don't intend to look at or triage. We've already prevented new tickets from being filed, but it doesn't do anyone any good to just have the old ones sitting there. My sense is that most of the relevant bugs and wishlist

D10431: Properly handle move during touch events

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D10425: Improve appearance of the logout dialog on wayland

graesslin added a comment. In https://phabricator.kde.org/D10425#204000, @fvogt wrote: > In https://phabricator.kde.org/D10425#203972, @graesslin wrote: > > > I'm against this change. The window is set to fullscreen, but that doesn't work due to a Qt bug. > > > Is the

D10429: Disable the title bar separator by default

rikmills added a comment. +1 for turning off by default or removing altogether. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt, #vdg, #plasma, ngraham Cc: rikmills, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10429: Disable the title bar separator by default

ngraham added a comment. If we turn it off by default, the set of people who will deliberately go and turn it on will be so small that it might make more sense to just remove it entirely. The only people who seem to notice and/of care seem to be people using Breeze Dark or another

D10429: Disable the title bar separator by default

anemeth added a comment. Strawpoll linked from this reddit post : http://www.strawpoll.me/15036330/r Looks like the majority does not like the separator. REPOSITORY R31 Breeze REVISION

D10429: Disable the title bar separator by default

fvogt created this revision. fvogt added reviewers: VDG, Plasma, ngraham. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Since the removal of the heuristics this seems to be very much disliked by many. As there is now a configuration

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10425: Improve appearance of the logout dialog on wayland

fvogt added a comment. In https://phabricator.kde.org/D10425#203972, @graesslin wrote: > I'm against this change. The window is set to fullscreen, but that doesn't work due to a Qt bug. Is the referenced patch enough to make it work? AFAICT it would also need a change in

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ijanssen added a comment. In https://phabricator.kde.org/D10114#203996, @ngraham wrote: > To commit this for you, I need an email address. Can you provide one? alave...@gmail.com REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma,

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ngraham added a comment. To commit this for you, I need an email address. Can you provide one? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff,

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ngraham added a comment. Thanks. Confirmed the fix, BTW. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc: ngraham, aacid, broulik, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

Re: Fullscreen and skip taskbar window

Am 2018-02-10 14:53, schrieb Bhushan Shah: Hello, so in plasma-phone shell, we have this code, https://cgit.kde.org/plasma-phone-components.git/tree/components/fullscreenpanel.cpp Which essentially sets window to fullscreen and the skiptaskbar, but this results in weird plasmashell "hang"

D7849: Fix the tray icon scaling on HiDPI screens

pgkos added a comment. In my opinion, roundToIconSize should operate on scaled units - it is used multiple times in a few plasmoids - all calls from them to roundToIconSize assume it will operate on scaled units. The method, as it is now, is useless, because QML code has no access to

D7849: Fix the tray icon scaling on HiDPI screens

pgkos updated this revision to Diff 26878. pgkos added a comment. This is a simpler implementation - the diff changes roundToIconSize so it uses scaled units. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7849?vs=19612=26878 REVISION

D10425: Improve appearance of the logout dialog on wayland

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I'm against this change. The window is set to fullscreen, but that doesn't work due to a Qt bug. Let's not work around Qt bugs: https://bugreports.qt.io/browse/QTBUG-63748

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ijanssen added a comment. In https://phabricator.kde.org/D10114#203764, @ngraham wrote: > It doesn't merge cleanly on master. Can you re-base it? I've updated diff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10114 To: ijanssen, #plasma, dfaure Cc:

D10114: Fix bug #382437 "Regression in kdialog causes wrong file extension"

ijanssen updated this revision to Diff 26877. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10114?vs=25981=26877 REVISION DETAIL https://phabricator.kde.org/D10114 AFFECTED FILES src/filewidgets/kfilewidget.cpp To: ijanssen, #plasma, dfaure Cc: ngraham,

Plasma Maniphest tasks

Howdy Plasma folks, I'm noticing that the Plasma Maniphest tasks (https://phabricator.kde.org/project/view/35/) that have been completed aren't actually closed, just moved to a "done" category. What's the reason for this, and can we close them instead? Nate

D10426: Applet: Fix accessing SourceModel from main item

drosca updated this revision to Diff 26876. drosca added a comment. Rename to paSourceModel + paSinkModel REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10426?vs=26875=26876 BRANCH Plasma/5.12 REVISION DETAIL

D10425: Improve appearance of the logout dialog on wayland

fvogt added a comment. > OSD might work, but those don't normally accept input. "normally" = "it shouldn't, but when testing it it does accept input just fine" @graesslin is it a bug that `setRole(OnScreenDisplay);` makes it work exactly like on X11 on wayland? i.e. is it

D10425: Improve appearance of the logout dialog on wayland

bshah accepted this revision as: bshah. bshah added a comment. +1 from me, if you want wait for review from others. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10425 To: fvogt, #plasma, graesslin, davidedmundson, bshah Cc: ngraham, bshah, plasma-devel,

D10426: Applet: Fix accessing SourceModel from main item

drosca created this revision. drosca added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. REVISION SUMMARY BUG: 390161 FIXED-IN: 5.12.1 TEST PLAN Pressed micmute

D10425: Improve appearance of the logout dialog on wayland

fvogt retitled this revision from "Fix appearance of the logout dialog on wayland" to "Improve appearance of the logout dialog on wayland". fvogt edited the summary of this revision. fvogt edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10425: Fix appearance of the logout dialog on wayland

fvogt updated this revision to Diff 26874. fvogt added a comment. Don't use the setRole(Notification) hack. That causes it to be drawn below fullscreen windows. OSD might work, but those don't normally accept input. So for now just use setSkipTaskbar(true); REPOSITORY R120 Plasma

D10425: Fix appearance of the logout dialog on wayland

bshah requested changes to this revision. bshah added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > shutdowndlg.cpp:256 > m_shellSurface->setPosition(geometry().topLeft()); > +m_shellSurface->setRole(PlasmaShellSurface::Role::Notification); > }

D10425: Fix appearance of the logout dialog on wayland

fvogt created this revision. fvogt added reviewers: Plasma, graesslin, davidedmundson. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY The logout dialog has a taskbar entry and appears like a regular window on wayland. By setting its

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.9 - Build # 11 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.9/11/ Project: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Feb 2018 13:54:56 + Build duration: 2 min 58 sec and counting

Fullscreen and skip taskbar window

Hello, so in plasma-phone shell, we have this code, https://cgit.kde.org/plasma-phone-components.git/tree/components/fullscreenpanel.cpp Which essentially sets window to fullscreen and the skiptaskbar, but this results in weird plasmashell "hang" when used on phone with top panel. So I tried

D10407: Disable positioning in popup folderviews

amantia added a comment. Yes, I have commit access since some time. ;) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10407 To: amantia, hein Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10148: KCM: Show only available device profiles

drosca added a comment. @ngraham It needs "better" filtering as suggested in the bugreport. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D10148 To: drosca, #plasma, nicolasfella Cc: ngraham, nicolasfella, broulik, plasma-devel, ZrenBot,

D10148: KCM: Show only available device profiles

This revision was automatically updated to reflect the committed changes. Closed by commit R115:1e644e5723df: KCM: Show only available device profiles (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10148?vs=26480=26865

KDE CI: Plasma plasma-integration kf5-qt5 SUSEQt5.9 - Build # 39 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-integration%20kf5-qt5%20SUSEQt5.9/39/ Project: Plasma plasma-integration kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Feb 2018 09:06:33 + Build duration: 16 min and counting JUnit Tests

KDE CI: Plasma kwayland kf5-qt5 SUSEQt5.9 - Build # 86 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20kwayland%20kf5-qt5%20SUSEQt5.9/86/ Project: Plasma kwayland kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Feb 2018 09:02:31 + Build duration: 6 min 37 sec and counting JUnit Tests Name: