D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Henrik Fehlauer
rkflx added a comment. @ngraham I've got a couple of questions regarding your RFC: > It's notable that all other desktop operating systems use at least 11pt as the size of their UI font, and some go much larger. The experiment has already been done for us and the results appear to have b

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Max Harmathy
harmathy added a comment. Just to add another fact to the discussion: The metric pt is an absolute measure for the size. In computing we use the desktop publishing point which is 1/72 inch (see https://en.wikipedia.org/wiki/Typographic_unit). Therefore ideally 10 pt sized font should

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Rik Mills
rikmills added a comment. Increasing the default font size was suggested for Kubuntu in T7864 I have the same concerns/objections as I did then. As has been mentioned this scales other UI elements like kicker. Having also tested at the time with

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Safa Alfulaij
safaalfulaij added a comment. I use an old laptop with 1280×800 display (not like you should really count for it, this is old). Noto Sans 10, good readable (but ugly for Arabic): F6198491: Screenshot_٢٠١٨٠٨١٦_١٠٤٨٣٢.png Noto Sans 11, huge (and u

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Rik Mills
rikmills added a comment. In D14869#309949 , @rkflx wrote: > I fear this will make it better for some people and worse for others, creating nothing but churn. Did you test this with several of said displays? I would agree with that to a l

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Filip Fila
filipf added a comment. Even in your screenshots 11pt looks too big and 13pt titlebars are just obscene. There are a few use cases where it pays of to have 11pt fonts - namely when you have a full HD laptop screens that would require 1.2 scaling and you'd prefer to do it the fonts way.

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.10 - Build # 147 - Failure!

2018-08-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.10/147/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 16 Aug 2018 09:04:47 + Build duration: 1.3 sec and counting CONSOLE OUTPUT Started by an

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.10 - Build # 158 - Failure!

2018-08-16 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.10/158/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 16 Aug 2018 09:04:57 + Build duration: 1.1 sec and counting CONSOLE OUTPUT

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Filip Fila
filipf added a comment. Have a look at maybe one of the worse scenarios where this change would reflect itself - a measly 19" 1280x1080 monitor (kind of obsolete sure, so this is more for illustrative purposes): F6198603: Screenshot_20180816_110753.png

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Filip Fila
filipf added a comment. As an alternative solution maybe you could consider changing the default font DPI from 96 to 102. This would be a much subtler change and yet the fonts are bit bigger and look nicer. Before: F6198629: Screenshot_20180816_112404.png

D14243: Fix bad model hygiene in Positioner::move()

2018-08-16 Thread Eike Hein
hein added a comment. I'll take this back up in September after my vacation (unless I get bored inbetween which is unlikely). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14243 To: hein, davidedmundson Cc: ngraham, broulik, plasma-devel, ragreen, Pitel, Zr

D14243: Fix bad model hygiene in Positioner::move()

2018-08-16 Thread Kai Uwe Broulik
broulik added a comment. Alright, just important to get this fixed for 5.14, if all else fails we can still revert this, as it only asserts on debug builds REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14243 To: hein, davidedmundson Cc: ngraham, broulik, pl

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 169 - Still unstable!

2018-08-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.10/169/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 Date of build: Thu, 16 Aug 2018 09:04:57 + Build duration: 32 min and counting JUnit Tests Na

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

2018-08-16 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=375840 Elvis Angelaccio changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

2018-08-16 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good to me. I was thinking about using it already some time ago, but didn't really find time to change that so thank you for implementing it. Actually, I think it was not possible

D14243: Fix bad model hygiene in Positioner::move()

2018-08-16 Thread Eike Hein
hein added a comment. Oh shit, I forgot it was already commmitted, I though it was still stuck in review. This patch is also on the 5.12 and 5.13 branches, so this makes fixing it a bit more urgent. Kai/David, can I delegate this to you due to my vacation? Either fix or revert befo

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

2018-08-16 Thread Jan Grulich
jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. Hmm, taking it back, actually this cannot be used as it requires NM 1.4 and newer and we require NM 1.0 and newer. REPOSITORY R116 Plasma Network Management Applet REVISION

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

2018-08-16 Thread Ovidiu Chi
https://bugs.kde.org/show_bug.cgi?id=375840 --- Comment #11 from Ovidiu Chi --- (In reply to Elvis Angelaccio from comment #10) > The MTP issues here are probably related to bug #396527, closing as > duplicate for now. > > *** This bug has been marked as a duplicate of bug 396527 *** Indeed, f

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

2018-08-16 Thread Jan Grulich
jgrulich added a comment. I assume we can bump requirements to NM 1.4, even Debian stable is now using NM 1.6. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14835 To: volkov, #plasma, jgrulich Cc: broulik, plasma-devel, ragreen, Pitel, Zre

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Root
rooty added a comment. nah, it's too disproportionate with regard to the sliders and bars in all the Qt apps that use the fonts, (it's just too big, pun intended) 10pt is the best, as well as 9pt for Hack REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14869

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Chris Rizzitello
rizzitello added a comment. > How does your suggestion relate to both the DPI value of your hardware and what Xorg uses? Do we actually set a higher DPI value for Hi(gher)DPI hardware automatically, so the actual size to the eye is independent of the display in use? If not, why not? I h

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

2018-08-16 Thread Alexander Volkov
volkov added a comment. Unfortunately KDE Neon is based on Ubuntu 16.04 (Xenial) which is using NM 1.2: https://packages.ubuntu.com/source/xenial/network-manager REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D14835 To: volkov, #plasma, jgru

D14737: Move "update" button from the left side to the right side in NIC module

2018-08-16 Thread Stefan Champailler
schampailler updated this revision to Diff 39851. schampailler added a comment. removed modifications which were not 100% related to the patch, as proposed by @ngraham . REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14737?vs=39430&id=39851 REVISION D

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Filip Fila
filipf added a comment. > After digging around I checked on windows 7 the default for is 9pt. every thing with a font. I was not able to find that box on the windows 10 machine tried on. They removed that particular configuration box back in Windows 8. Anyway, this is Windows 10: F

D14836: Kicker: Reset re-used menu width to default one

2018-08-16 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R119:5dd480208afc: Kicker: Reset re-used menu width to default one (authored by aacid). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14836?vs=39699&id=39858 RE

KDE CI: Plasma systemsettings kf5-qt5 SUSEQt5.10 - Build # 42 - Fixed!

2018-08-16 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.10/42/ Project: Plasma systemsettings kf5-qt5 SUSEQt5.10 Date of build: Thu, 16 Aug 2018 14:30:27 + Build duration: 1 min 56 sec and counting JUnit Tests

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.10 - Build # 87 - Still unstable!

2018-08-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.10/87/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.10 Date of build: Thu, 16 Aug 2018 15:01:43 + Build duration: 12 min and counting JUnit Tests

KDE CI: Plasma plasma-sdk kf5-qt5 SUSEQt5.10 - Build # 30 - Fixed!

2018-08-16 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20plasma-sdk%20kf5-qt5%20SUSEQt5.10/30/ Project: Plasma plasma-sdk kf5-qt5 SUSEQt5.10 Date of build: Thu, 16 Aug 2018 15:01:57 + Build duration: 12 min and counting JUnit Tests Name: (root)

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.10 - Build # 60 - Still unstable!

2018-08-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.10/60/ Project: Plasma plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 16 Aug 2018 15:01:50 + Build duration: 12 min and counting JUnit Tests

Re: KDE CI: Dependency Build Extragear kf5-qt5 SUSEQt5.9 - Build # 121 - Still Failing!

2018-08-16 Thread David Edmundson
We discussed this in a BOF. Conclusion was that anyone using plasma-workspace in extragear is always wrong and won't be supported by us. Mycroft: Not actually used, now fixed! plasma-sdk: Not actually used, now fixed! Apper: Uses kworkspace to shutdown Could direct QDBus? This needs doing by so

D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-16 Thread Nathaniel Graham
ngraham added a comment. In D14830#308707 , @ngraham wrote: > In D14830#308703 , @broulik wrote: > > > In D14830#308693 , @ngraham wrote: > > > > > The

D14857: Label job notifications with destination file name

2018-08-16 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, dest filename makes more sense IMHO. Semantically, the whole point of the move or copy operation is to end up with a destination file, so that's the file that should be focused on--wh

D14243: Fix bad model hygiene in Positioner::move()

2018-08-16 Thread Nathaniel Graham
ngraham added a comment. Since this is on the stable branches, IMHO we should really revert it before it accidentally makes it into a release. 5.13.5 is scheduled for release in two weeks, and 5.12.7 in five. Any objections? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabri

D14857: Label job notifications with destination file name

2018-08-16 Thread Andres Betts
abetts accepted this revision. abetts added a comment. +1 REVISION DETAIL https://phabricator.kde.org/D14857 To: karthikp, #vdg, ngraham, abetts Cc: abetts, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14857: Label job notifications with destination file name

2018-08-16 Thread Karthik Periagaram
karthikp added a comment. Noob question (this is my first patch through phabricator and I don't have commit rights, naturally): How does one normally proceed now, do I mail or attach here, the patch (as in `git format-patch`) so someone can `git am -s` it into the next release's dev branch

D14857: Label job notifications with destination file name

2018-08-16 Thread Nathaniel Graham
ngraham added a comment. So now that it's gone through the VDG (Visual Design Group) review, it should go through a code review and final sign-off by the maintainer. Looks like Kai has already done the former, so if he's satisfied now, I'd say it can land! Because you submitted this patch us

D14857: Label job notifications with destination file name

2018-08-16 Thread Karthik Periagaram
karthikp added a comment. I see, thanks! Here's my name and email, Karthik Periagaram karthik.periaga...@gmail.com REVISION DETAIL https://phabricator.kde.org/D14857 To: karthikp, #vdg, ngraham, abetts Cc: abetts, ngraham, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14857: Label job notifications with destination file name

2018-08-16 Thread Nathaniel Graham
ngraham added a comment. Thank you very much! I'll let @broulik or any of the other #plasma developers take this show from here. :) REVISION DETAIL https://phabricator.kde.org/D14857 To: karthikp, #vdg, ngraham, abetts Cc: abetts, ngraham, broulik