D16241: [Folder View] Improve layout and formatting of Icons page

ngraham added a subscriber: mart. ngraham added a comment. Kirigami FormLayout is a really nice control to work with. I'm a big fan. This port was easy peasy and I can't wait to do more of these! The double `Kirigami.Separator` items are to approximate what's wanted for

D16241: [Folder View] Improve layout and formatting of Icons page

ngraham updated this revision to Diff 43835. ngraham added a comment. No more ugly hacks: port the whole thing to use a Kirigami FormLayout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16241?vs=43758=43835 BRANCH icons-page-tweaks (branched

D16287: [Comics & Weather widgets] give "Configure..." buttons icons

ngraham updated this revision to Diff 43832. ngraham added a comment. Do that correctly REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16287?vs=43831=43832 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16287 AFFECTED FILES

D16287: [Comics & Weather widgets] give "Configure..." buttons icons

ngraham updated this revision to Diff 43831. ngraham added a comment. Rebase on master REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16287?vs=43830=43831 BRANCH configure-icons (branched from Plasma/5.14) REVISION DETAIL

D16287: [Comics & Weather widgets] give "Configure..." buttons icons

ngraham added a subscriber: mart. ngraham added a comment. Nice catch, it looks like that's exactly right. Rebasing on master. @mart, any thoughts on https://bugs.kde.org/show_bug.cgi?id=399952? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D16287 To:

D16287: [Comics & Weather widgets] give "Configure..." buttons icons

kossebau added a comment. Not exactly sure, but: Icons for buttons might be a newer property than the min one for kdeplasma-addons 5.14 (which seems KF 5.50): The property seems only present since KF 5.51: https://phabricator.kde.org/R242:85cab5772c560ea248c490d9d58db87296dec06b

D16287: [Comics & Weather widgets] give "Configure..." buttons icons

ngraham created this revision. ngraham added reviewers: Plasma, kossebau. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch gives the Comics and Weather widgets appropriate icons for their

D16219: [Lock Screen] Do not try to unlock when unvisible

This revision was automatically updated to reflect the committed changes. Closed by commit R120:754efdedd4ee: [Lock Screen] Do not try to unlock when unvisible (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16284: do not force text for ToolButton

astippich added a comment. I noticed this while porting from qqc1 to qqc2 for #Elisa , as the qqc2 ToolButton did not behave as expected. I don't know the reason why this was added and also have no clue about the implications this change may have.

D16284: do not force text for ToolButton

astippich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY Do not force to display text besides the icon for the ToolButton REPOSITORY R858 Qt Quick Controls 2: Desktop Style

D14542: KCM using new virtual desktops DBus interface

hein updated this revision to Diff 43814. hein edited the summary of this revision. hein added a comment. Drop the TODO note from the message. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=43315=43814 BRANCH arcpatch-D14542 REVISION DETAIL

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 43811. hein added a comment. Remove two arg() fixes in the diff that should be in the other containment action diff REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15599?vs=43810=43811 BRANCH arcpatch-D15599

D15599: Port the "Switch Desktop" containment action to libtaskmanager

hein updated this revision to Diff 43810. hein added a comment. - Fix another arg() call - Do delete+remove in one step with take() - Fix loop condition Addressing other review comments: - More change tracking is not needed because of the later loop that indiscriminately calls

D16277: [ksmserver] Split xsession logout and shutdown into separate classes

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This commit splits ksmserver's xsession shutdown logic from performing the

D16275: don't set a user if there is no user

This revision was automatically updated to reflect the committed changes. Closed by commit R119:efd4c22bbe60: dont set a user if there is no user (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16275?vs=43798=43799#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE

D16275: don't set a user if there is no user

sitter added a comment. I think ... since this gets put into the desktop file via `toDisplayString` and `toDisplayString` has the behavior that > With the default options, the resulting QString can be passed back to a QUrl later on, but any password that was present initially will be

Plasma 5.15 Kickoff Meeting Minutes

People: kbroulik fvogt acheronuk sho d_ed apol tsimonq2 nicofee Aix notmart leszek bshah pepo ivan (late to the party) ripper17 * 5.14 review Smooth release, no major problems, nice additions. Lack of bling new features for a nice video but polish is more important. Jonathan told not to snapshot

D16275: don't set a user if there is no user

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. I wonder why `QUrl` doesn't clean that up on its own INLINE COMMENTS > knetattach.cpp:204 > url.setHost(_host->text().trimmed()); > -

D16275: don't set a user if there is no user

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY it doesn't have technical downsides but ends up creating urls of the type scheme://@host/path

D16273: port knetattach from kurl to qurl

This revision was automatically updated to reflect the committed changes. Closed by commit R119:53255b7854eb: port knetattach from kurl to qurl (authored by sitter). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16273?vs=43794=43797 REVISION DETAIL

D16219: [Lock Screen] Do not try to unlock when unvisible

ngraham added a comment. Let's land this on the `Plasma/5.14` branch and then merge to master. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 REPOSITORY R120 Plasma Workspace BRANCH arc_enterpressed (branched from master) REVISION DETAIL

D16219: [Lock Screen] Do not try to unlock when unvisible

abetts added a comment. +1 for the idea! REPOSITORY R120 Plasma Workspace BRANCH arc_enterpressed (branched from master) REVISION DETAIL https://phabricator.kde.org/D16219 To: thsurrel, #plasma, #vdg, ngraham Cc: ngraham, davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel,

D16273: port knetattach from kurl to qurl

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY kurl is deprecated. - s/kurl/qurl - non-existent functions ported per deprecation recommendation - fileEncoding replaced

D16219: [Lock Screen] Do not try to unlock when unvisible

thsurrel updated this revision to Diff 43792. thsurrel added a comment. Do not access parent property directly Thanks for the comment davidedmundson REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16219?vs=43644=43792 BRANCH arc_enterpressed

D16219: [Lock Screen] Do not try to unlock when unvisible

davidedmundson added a comment. It's ok as-is, there's a code change that would make things a bit better. INLINE COMMENTS > MainBlock.qml:65 > +onAccepted: { > +if (lockScreenRoot.uiVisible) { > +startLogin(); It's generally bad practice to reference

Re: Willing to contribute

On Mon, Oct 15, 2018 at 12:51:54AM +0200, Aleix Pol wrote: > On Sat, Oct 13, 2018 at 5:05 PM Antoon BERES wrote: > > > > Hello, > > > > I'm pretty new to opensource projects etc in general, nevertheless, as a > > novice programmer the plasma-mobile project grabbed my interest. I am a > >

meeting in 10 minutes

https://notes.kde.org/p/plasma-5.15-kickoff #plasma

D15093: Add WireGuard capability.

jgrulich added inline comments. INLINE COMMENTS > CMakeLists.txt:8 > +wireguardauth.cpp > +wireguardadvancedwidget.cpp > +) Missing wireguardkeyvalidator.cpp > CMakeLists.txt:29 > +KF5::KIOWidgets > +KF5::CoreAddons > +) Linking against following ones is enough:

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:71833088fb26: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator (authored by andersonbruce, committed

D15520: Upgrade SimpleIpV4AddressValidator and SimpleIpV6AddressValidator

jgrulich accepted this revision. jgrulich added a comment. Thanks for the contribution. I'll push this change and do just some minor changes to the tests so you don't have to again go through review. INLINE COMMENTS > CMakeLists.txt:99 > add_subdirectory(vpn) > +add_subdirectory(tests) >

D16231: [ksmserver] Rewrite Startup

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in startup.cpp:94-95 > Can these happen in parallel? In the old code (as far as I can understand it) > it did auto start first and then kcminit phase 1? or does `addSubjob` queue > them one after the other (doesn't look like

D16269: Show correct current download and upload speed

This revision was automatically updated to reflect the committed changes. Closed by commit R116:c5593b02df38: Show correct current download and upload speed (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.11 - Build # 7 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.11/7/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Wed, 17 Oct 2018 08:52:37 + Build duration: 1 min 45 sec and counting JUnit Tests

D16269: Show correct current download and upload speed

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY After recent change to use NM::DeviceStatistics instead of plasma dataengine, this part of code wasn't changed and instead of

D16231: [ksmserver] Rewrite Startup

broulik added a comment. Pretty cool! INLINE COMMENTS > startup.cpp:94-95 > +qCDebug(KSMSERVER) << "Phase 0"; > +addSubjob(new AutoStartAppsJob(0)); > +addSubjob(new KCMInitJob(1)); > +} Can these happen in parallel? In the old code (as far as I can understand