D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

ltoscano added a comment. Thanks, I will keep an eye on the review. REPOSITORY R119 Plasma Desktop BRANCH move-showdesktop-applet (branched from master) REVISION DETAIL https://phabricator.kde.org/D20818 To: GB_2, #plasma, #vdg, ngraham, apol Cc: apol, ltoscano, ngraham, #vdg,

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

filipf added a comment. In D20598#456330 , @meven wrote: > I don't see those buttons, I guess you need a remote mouse or something similar to have them. Yeah you would need 2 devices I guess. I have my laptop's battery and the wireless

D20830: Add hack to unbreak audio playback through pure JS via new Audio()

fvogt added a comment. I'm not sure why this is necessary - during `new Audio` the created object can't play anything by itself as `src` is not set. If just doing `createdAudio.paused = false` after the removeChild is not enough, is that because the DOM modifications are queued and

D20829: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e39aed6f167f: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

ngraham added inline comments. INLINE COMMENTS > meven wrote in main.qml:21 > I might be too aggressive here, what would be the best version to set here ? 2.5 is always a safe bet. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20598 To: meven, ngraham, broulik,

D20829: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham added inline comments. INLINE COMMENTS > filipf wrote in configGeneral.qml:50 > Compact version is maybe a bit vague, but I can't think of anything better > honestly. Yeah me neither. :/ REPOSITORY R120 Plasma Workspace BRANCH modernize-calendar-widget-settings-window (branched

D20829: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham updated this revision to Diff 56995. ngraham marked an inline comment as done. ngraham added a comment. Delete trailing space REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20829?vs=56993=56995 BRANCH

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

meven added a comment. In D20598#456309 , @filipf wrote: > Works for me, nice work with aligning the layouts. > > I'm a bit conflicted, but I think visually the issue is how these buttons look like with the port, as well as their icons

D20830: Add hack to unbreak audio playback through pure JS via new Audio()

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Let the comment in the code speak for itself. Now, where is my jug of disinfecting

D20829: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI

filipf accepted this revision. filipf added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > configGeneral.qml:27 > id: generalPage > > +anchors.left: parent.left trailing space > configGeneral.qml:50 > +QtControls.RadioButton { > +

D20598: [WIP] Port kcm energy info to kirigami 2, fix colors issues

filipf added a comment. Works for me, nice work with aligning the layouts. I'm a bit conflicted, but I think visually the issue is how these buttons look like with the port, as well as their icons (but that was a problem before as well): F6793389: image.png

D20829: [Calendar] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style - Adjust some strings to be more natural - Use

D20828: Correctly show memory sizes > 4 GiB on 32 bit Linux

cfeck created this revision. cfeck added a reviewer: Plasma. cfeck added a project: Plasma. Herald added a subscriber: plasma-devel. cfeck requested review of this revision. REVISION SUMMARY BUG: 406351 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D20828

D20386: Change TreeItem Compare function from < operator to QString::localeAwareCompare

This revision was automatically updated to reflect the committed changes. Closed by commit R103:fb171dff39c7: Fix sorting to use locale-aware comparisons (authored by jen6, committed by cfeck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20386?vs=55792=56990#toc REPOSITORY R103

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b8d753f4f00f: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. Perfect. REPOSITORY R119 Plasma Desktop BRANCH modernize-pager-settings-window (branched from master) REVISION DETAIL https://phabricator.kde.org/D20796 To: ngraham,

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. Can you please update this patch? It doesn't apply anymore. It would also be nice if you used Arcanist/`arc` in the future: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches REPOSITORY R119 Plasma Desktop REVISION DETAIL

D20819: Make really sure we show an error message in case saving failed

fvogt requested changes to this revision. fvogt added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > options.js:174 > +// When the extension is reloaded, any call to > extension APIs throws, make sure we show at least some form of

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

apol added subscribers: ltoscano, apol. apol accepted this revision. apol added a comment. Looks good to me. Will have to move the (few) translations with it. @ltoscano REPOSITORY R119 Plasma Desktop BRANCH move-showdesktop-applet (branched from master) REVISION DETAIL

D20810: Fix launcher URL comparison

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ContextMenu.qml:279 > > -enabled: visualParent && get(atm.LauncherUrlWithoutIcon) !== "" > +enabled: visualParent && get(atm.LauncherUrlWithoutIcon) != ""

D20820: Add Show Desktop applet to default panel

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. Please wait for a #plasma review too. :) It would also be nice if we can find a way to make this monochrome by default so it matches

D20818: Add the Show Desktop applet (moved from kdeplasma-addons)

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. Please wait for a #plasma review too. :) REPOSITORY R119 Plasma Desktop BRANCH move-showdesktop-applet (branched from master)

D20817: Remove the Show Desktop applet (it's in plasma-desktop now)

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. Please wait for a #plasma review too. :) REPOSITORY R114 Plasma Addons BRANCH move-showdesktop-applet (branched from master)

D20820: Add Show Desktop applet to default panel

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY T7917 TEST PLAN The default panel should now have a Show

D20819: Make really sure we show an error message in case saving failed

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When the extension is reloaded, its context is invalidated and any call to an extension

D20818: [plasma-desktop] Move the Show Desktop applet

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Move the Show Desktop applet from `kdeplasma-addons` to `plasma-desktop`, so it can be added to the

D20817: [kdeplasma-addons] Move the Show Desktop applet

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Move the Show Desktop applet from `kdeplasma-addons` to `plasma-desktop`, so it can be added to the

D20787: process: add support for cgroups

topimiettinen added a comment. It looks like the CGroup rows are visually not vertically aligned to center like other cells, but instead they are aligned to the top. However, I'd expect that the default item of switch in ProcessModel.cpp:1693 should implement this, like it does for e.g.

D20810: Fix launcher URL comparison

broulik created this revision. broulik added reviewers: Plasma, hein, ngraham, mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Launcher URL is a `QUrl` which doesn't strictly map empty `string`. TEST

Re: App Stores in Plasma

On Thu, 25 Apr 2019 at 00:23, Aleix Pol wrote: > Having a recommendation could make sense, but it's more a policy that > the distro should have more than Plasma, given we cannot regulate > something that isn't in our control. > We do already have a recommendation which is our default install,

D20804: RFC: Try getting the X keyboard grab multiple times

davidedmundson added a comment. > Shouldn't this and the above function name start with small letter? DBus methods and signals tend to start with an upper case. Though interface already consists of a mixture :/ Classes using Qt generated DBus adaptors have to match the interface

D20804: RFC: Try getting the X keyboard grab multiple times

shubham added inline comments. INLINE COMMENTS > interface.h:116 > > +void AboutToLock(); > + Shouldn't this and the above function name start with small letter? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D20804 To: davidedmundson, #plasma, #kwin Cc:

D20804: RFC: Try getting the X keyboard grab multiple times

broulik added a comment. +1 REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D20804 To: davidedmundson, #plasma, #kwin Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20804: RFC: Try getting the X keyboard grab multiple times

davidedmundson created this revision. davidedmundson added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Right now when the screen locker starts it tries to grab the keyboard

D20803: Send vivaldi-stable as DesktopEntry

This revision was automatically updated to reflect the committed changes. Closed by commit R856:04d079f57858: Send vivaldi-stable as DesktopEntry (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20803?vs=56947=56948

D20803: Send vivaldi-stable as DesktopEntry

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. The RPM as well (luckily, that would've been a mess otherwise) REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D20803 To: broulik, #plasma, fvogt

D20803: Send vivaldi-stable as DesktopEntry

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is what the official deb package I downloaded from their website uses TEST PLAN I