D23018: [notifications] Remove unread counter, use icon instead

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c4b360dda360: [notifications] Remove unread counter, use icon instead (authored by ndavis). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23018?vs=63373=63389#toc REPOSITORY R120 Plasma

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20FreeBSDQt5.13/21/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 09 Aug 2019 05:03:58 + Build duration: 3 min 21 sec and counting CONSOLE

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 147 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/147/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 09 Aug 2019 05:03:58 + Build duration: 2 min 49 sec and counting CONSOLE OUTPUT

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

lisin added a comment. Yes, getting into it was pretty straightforward and quick, KDE team did a great job! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22988 To: lisin, #plasma, hein, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 146 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/146/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Fri, 09 Aug 2019 02:03:30 + Build duration: 9 min 45 sec and counting CONSOLE OUTPUT

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

ngraham added a comment. Very nice job! May it be the first of many. :) I hope the process wasn't too difficult. We're trying to make it smoother for new contributors. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22988 To: lisin, #plasma, hein, ngraham

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 FreeBSDQt5.13 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20FreeBSDQt5.13/20/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 09 Aug 2019 02:03:30 + Build duration: 3 min 17 sec and counting CONSOLE

D23033: [notifications] Change default icon to notification-inactive

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4c11f4cd2e92: [notifications] Change default icon to notification-inactive (authored by ndavis). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

lisin added a comment. Thank you, this was my first ever contribution to FOSS! I have submitted the fix for the TabBar here: https://phabricator.kde.org/D23036 I'm not quite sure about who to add as reviewers though. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D23018: [notifications] Remove unread counter, use icon instead

ngraham accepted this revision. ngraham added a comment. LGTM for master branch. REPOSITORY R120 Plasma Workspace BRANCH notification-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D23018 To: ndavis, #vdg, #plasma, ngraham Cc: ngraham, broulik, plasma-devel,

D23033: [notifications] Change default icon to notification-inactive

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This is for sure the more appropriate icon IMO as 1) it's what we used for notifications in all other contexts and 2) it's the monochrome version of the colorful bell icon used in the

D23033: [notifications] Change default icon to notification-inactive

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY Currently, it uses `notification-disabled for a non-disabled state REPOSITORY R120 Plasma

D23018: [notifications] Remove unread counter, use icons instead

ndavis updated this revision to Diff 63373. ndavis added a comment. - Don't change default icon I'll put this in a separate patch so that it can be landed on stable. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23018?vs=63336=63373 BRANCH

D23021: [Image Wallpaper] Use layer.enabled during transition to avoid background glimpsing through

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Can confirm that it fixes the bug and looks nicer. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23021 To: broulik, #plasma, ngraham Cc: ngraham,

D23018: [notifications] Remove unread counter, use icons instead

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM for Plasma 5.17 in conjunction with whatever gets decided for D23019 . REPOSITORY R120 Plasma Workspace BRANCH notification-icon (branched

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

ngraham added a comment. Now we just need that plasma-frameworks patch to also fix https://bugs.kde.org/show_bug.cgi?id=395390. :) Let me know if you need a hand. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22988 To: lisin, #plasma, hein, ngraham

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2054d9be40bc: Fix incorrect Kickoff tab bar layout for vertical panels (authored by lisin, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

ngraham added a comment. Thanks very much! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22988 To: lisin, #plasma, hein, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

lisin updated this revision to Diff 63369. lisin edited the summary of this revision. lisin edited the test plan for this revision. lisin added a comment. Removed line 435. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22988?vs=63264=63369

D22866: [Kickoff] Always select previous category in Applications View when navigating backwards

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f9e7316448ce: [Kickoff] Always select previous category in Applications View when navigating… (authored by akozlovskiy, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D22925: Fix POTD doesn't update

ngraham added a comment. Great, I'll test for a few days as well. The code looks sane. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22925 To: guoyunhe, #plasma Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22316: Avoid garbling the sound if the volume slider is moved fast

This revision was automatically updated to reflect the committed changes. Closed by commit R115:a420dd6be1a9: Avoid garbling the sound if the volume slider is moved fast (authored by Kezi Olio keziolio...@gmail.com, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES

D22540: Port ResultDelegate to use PlasmaComponents 3.0

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Selection highlights have regressed and text is no longer elided if it's too long, it just overflows. F7179198: Screenshot_20190808_102830.png

D23031: more control on what shell is loaded

This revision was automatically updated to reflect the committed changes. Closed by commit R120:69451047c0a3: more control on what shell is loaded (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23031?vs=63358=63367 REVISION

D4785: Add a small test application for kcheckpass

jfranklin added a comment. Greetings, I'm working on a machine that uses kcheckpass with libpam-poldi for authentication. This allows for the usage of GPG smart cards at login. There is a bug somewhere at the boundary of kcheckpass and libpam-poldi that I can't pinpoint without

D23031: more control on what shell is loaded

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I like it much better INLINE COMMENTS > main.cpp:92 > + > +KSharedConfig::Ptr startupConf = > KSharedConfig::openConfig(QStringLiteral("plasmarc")); > +KConfigGroup

D23031: more control on what shell is loaded

mart added a comment. alternative to https://phabricator.kde.org/D23023 not sure what's better REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23031 To: mart, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23023: more control on what shell is loaded

mart added a comment. https://phabricator.kde.org/D23031 has a config file approach REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23023 To: mart, #plasma Cc: apol, bshah, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D23031: more control on what shell is loaded

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Since shellManager was removed, we have a quite big regressions of any other shell that isn't the

D23023: more control on what shell is loaded

mart updated this revision to Diff 63357. mart added a comment. - name it KDE_PLASMA_DEFAULT_SHELLPACKAGE REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23023?vs=63343=63357 BRANCH phab/plasmashellenv REVISION DETAIL

D23023: more control on what shell is loaded

mart added a comment. While i wouldn't mind for that feature to get back, using a temporary file wouldn't work, because as soon you have a crash and auto restart you get again on the default desktop shell. to make the env var more clear, i would call it KDE_PLASMA_DEFAULT_SHELLPACKAGE

D22925: Fix POTD doesn't update

guoyunhe added a comment. It works now. Tested with several different POTD providers. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D22925 To: guoyunhe, #plasma Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

Notification Popup Focus

Hi, I'm working on a quick reply feature for notifications where you get a textfield inside notifications. [1] However, notifications can never get focus. The question is: why? I agree that notifications should never be able to steal focus but if you explicitly click on them, what speaks

D23028: Wayland: set KWayland outputs data in output class

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY When sending a new config to KWayland set the output specific data of the configuration in

D23023: more control on what shell is loaded

broulik added a comment. > if we end up supporting changing shells We did, it got removed, because it wasn't used at all. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23023 To: mart, #plasma Cc: apol, bshah, broulik, plasma-devel, LeGast00n,

D23023: more control on what shell is loaded

apol added a comment. This will always have this environment variable set up, which could become a bit weird if we end up supporting changing shells, because we'd have a value in the environment variable but the shell in another. How about passing it through a file? INLINE COMMENTS >

D23026: Wayland: unfriend config and output classes

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY It is not necessary for these two classes to be friends. TEST PLAN Compiles. REPOSITORY

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 added inline comments. INLINE COMMENTS > broulik wrote in SidebarMode.cpp:570 > Not a huge fan of this. > Can this be done in qqc2-desktop-style to be generic and fix every `Menu` and > `ComboBox` popup? Not really, seems like the KQuickStyleItem only has access to the QML window of the

D23025: Wayland: set output device name through create function

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY With saving the pointers it is not necessary anymore to save the Wayland name in WaylandOutput

D23023: more control on what shell is loaded

mart updated this revision to Diff 63343. mart added a comment. - KDE_PLASMA_SHELLPACKAGE REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23023?vs=63340=63343 BRANCH phab/plasmashellenv REVISION DETAIL https://phabricator.kde.org/D23023

D23024: Wayland: save pointers in initializing list

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Instead of saving the names of the initializing outputs save the pointers directly what is

D23004: Wayland: manage outputs without id mapping

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:6f5acdf2e6d7: Wayland: manage outputs without id mapping (authored by romangg). REPOSITORY R110 KScreen Library

D23023: more control on what shell is loaded

bshah added inline comments. INLINE COMMENTS > bshah wrote in main.cpp:91 > MAY I SUGGEST RENAMING TO kde_plasma_shellpackage? whoops sorry for caps. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23023 To: mart, #plasma Cc: bshah, broulik, plasma-devel,

D23023: more control on what shell is loaded

bshah added inline comments. INLINE COMMENTS > main.cpp:91 > > +QString defaultShell = qgetenv("KDE_PLASMA_SHELL"); > +if (defaultShell.isEmpty()) { MAY I SUGGEST RENAMING TO kde_plasma_shellpackage? REPOSITORY R120 Plasma Workspace REVISION DETAIL

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 145 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/145/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 08 Aug 2019 07:36:43 + Build duration: 1 hr 43 min and counting CONSOLE OUTPUT

D23023: more control on what shell is loaded

broulik added a comment. Please don't forget to document this: https://userbase.kde.org/KDE_System_Administration/Environment_Variables#Look_and_feel REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23023 To: mart, #plasma Cc: broulik, plasma-devel,

D23023: more control on what shell is loaded

mart created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Since shellManager was removed, we have a quite big regressions of any other shell that isn't the desktop one not loading in any way

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

broulik added inline comments. INLINE COMMENTS > SidebarMode.cpp:570 > emit changeToolBarItems(BaseMode::NoItems); > +} else if (watched->inherits("QWidgetWindow") && event->type() == > QEvent::MouseButtonPress) { > +QMetaObject::invokeMethod(d->quickWidget->rootObject(),

D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

GB_2 updated this revision to Diff 63338. GB_2 added a comment. Rebase on master REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22896?vs=63180=63338 BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from

KDE CI: Plasma » sddm-kcm » kf5-qt5 SUSEQt5.12 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/sddm-kcm/job/kf5-qt5%20SUSEQt5.12/49/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 08 Aug 2019 07:35:45 + Build duration: 1 hr 6 min and counting JUnit Tests Name: (root) Failed: 0

D23018: [notifications] Remove unread counter, use icons instead

broulik added a comment. +1 Seems to work fine even with the old icons, except maybe the default state is now black instead of the usual gray. But given the unread notifications case is blue now, should be alright. Also works well with Air, Adapta, Arc. Except for the do not disturb

D23018: [notifications] Remove unread counter, use icons instead

ndavis updated this revision to Diff 63336. ndavis added a comment. - Hide label by default Sometimes it likes to show up either over or under the icon REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23018?vs=63331=63336 BRANCH

D23018: [notifications] Remove unread counter, use icons instead

broulik added a comment. Can you test with other themes, like Air, and maybe some common third party ones. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23018 To: ndavis, #vdg, #plasma Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D23021: [Image Wallpaper] Use layer.enabled during transition to avoid background glimpsing through

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Opacity affects each item individually, so during the transition, you have an `Image` with a

D23020: Use QQuickWidget instead of a QQuickView placed into QWidget BUG: 410703

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH use-qquickwidget REVISION DETAIL https://phabricator.kde.org/D23020 AFFECTED FILES

D23018: [notifications] Remove unread counter, use icons instead

ndavis updated this revision to Diff 63331. ndavis added a comment. - Undo DND icon change For some reason, the new icon is displayed at larger size than the original even though they should be exactly the same. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE