D24483: [Weather data engine] Handle windy conditions in NOAA backend

ngraham added a comment. In D24483#544500 , @spstarr wrote: > 'breez' or breeze' just curious here That's to match both "breeze" and "breezy". I'll wait to land this until we get a real `weather-wind` icon. REPOSITORY R120 Plasma

D24276: Add text to speech functionality to klipper.

whiting updated this revision to Diff 67585. whiting added a comment. - Add speech synthesis engine selection combobox to general klipper settings page. Rebased on master. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24276?vs=66980=67585

D24471: [KRDB] Remove Oxygen-era colour exporting code

cblack planned changes to this revision. cblack added a comment. So it turns out I ran into an unrelated bug that at first glance appeared to be the linked bug with my setup, but in reality, it's actually unrelated. Regarding that, I'm not sure how useful this patch actually is in terms

D24483: [Weather data engine] Handle windy conditions in NOAA backend

spstarr added a comment. We do need another icon, Wind would be generic for Dust storm, or Blowing smoke, Blowing snow in this case. REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau,

D24483: [Weather data engine] Handle windy conditions in NOAA backend

spstarr added a comment. 'breez' or breeze' just curious here REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev,

D24483: [Weather data engine] Handle windy conditions in NOAA backend

spstarr added a comment. No degree, but I have been following weather for years and on some mailing lists with meteorologists. 'Wind' can be a weather condition especially if its a dust storm. If NOAA lists it as a weather condition. I think this is fine. In Canada we do have Wind

D24474: Show menu items tooltip text

This revision was automatically updated to reflect the committed changes. Closed by commit R169:0993c1c70678: Show menu items tooltip text (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24474?vs=67449=67583#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Overall this doesn't look like the proper fix to me. A setter should not do anything if we pass the current value to it. From your description it seems to indicate that a call to

D24519: Delegate KCM cursor theme config management to KConfigXT

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmcursortheme.cpp:335 > > +int CursorThemeConfig::cursorSizeIndex(const int cursorSize) const > +{ int, not const inst > kcmcursortheme.cpp:349 > > -void

D24518: On KCM cursor theme update attribute name

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmcursortheme.cpp:383 > { > +m_settings->load(); > // Get the name of the theme KDE is configured to use This seems unrelated to that change. Did

D24517: Port kcm cursor to KConfigXT

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:22 > Can you also add > > install(FILES kded/touchpaddaemon.kcfg > DESTINATION ${KDE_INSTALL_KCFGDIR}) > >

D24516: Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Some might consider it a nitpick, but I like a history as clean as possible. ;-) INLINE COMMENTS > kcmcursortheme.cpp:51 > > +//#include "cursorthemesettings.h" > #include

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! Would be nice to fix some of these bugs in follow-up patches too: https://bugs.kde.org/buglist.cgi?component=kcm_baloo_id=1669138=systemsettings=--- REPOSITORY R119 Plasma

D24523: Disable dragging global drawer when in menu mode

nicolasfella created this revision. nicolasfella added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY When the drawer is in menu mode it is still possible to drag the drawer open from

D24224: Start of the accessibility KCM

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Why is `kcms/colors/CMakeLists.txt` being changed? Looks unrelated. As a general UI principle, whenever you have a group of controls that's mostly checkboxes, don't use

D24519: Delegate KCM cursor theme config management to KConfigXT

bport added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:99 > I think this will be broken if you change this combo box, then change theme. > > When a user explicitly changes this combo box this binding gets broken with > currentIndex now reflecting an explicit number. >

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67572. tcanabrava added a comment. - Fix Strings - Fix margins REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=67568=67572 BRANCH kcm_baloo_qml REVISION DETAIL

D24224: Start of the accessibility KCM

tcanabrava added a comment. this now depends on https://phabricator.kde.org/D23835 - There's an issue with saving (the save is not activated for some reason, I need to investigate. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24224 To: tcanabrava Cc:

D24224: Start of the accessibility KCM

tcanabrava updated this revision to Diff 67571. tcanabrava added a comment. - Use Plasma KCM - Adapt to FormLayout - Fix label - Space every tab equally - Form layout port - FormLayout - Simplify Qml - Port to Form Layout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D24359: Fix a number of issues found by the OpenSuse security team in networkhelper

This revision was automatically updated to reflect the committed changes. Closed by commit R106:e358aa840a34: Fix a number of issues found by the OpenSuse security team in networkhelper (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D24514: [XembedSNIProxy] Do not crash on null pointer

ngraham added a comment. Does this really fix 356937? That seems to be about something other than a crash. Did you mean 409652 instead? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24514 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson Cc:

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added a comment. Almost done, just a tiny bit of polish is needed! See inline comments: INLINE COMMENTS > kcm.cpp:61 > KAboutData* about = new KAboutData( > QStringLiteral("kcm_baloofile"), i18n("Configure File Search"), > QStringLiteral("0.1"), QString(),

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava marked 2 inline comments as done. tcanabrava added a comment. I still need to play a bit with the folder save / load. the code from the old kcm is quite strange. it saves "included folders", but there's nothing using that. perhaps it's safer if we just remove everything that's not

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67568. tcanabrava added a comment. - fix Comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=67567=67568 BRANCH kcm_baloo_qml REVISION DETAIL https://phabricator.kde.org/D23718 AFFECTED

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67567. tcanabrava marked 7 inline comments as done. tcanabrava added a comment. - Simplify Checkboxes - Fix previouslyEnabled logic - Tell Qml that we have the values - Move code around - Fix QSet math - Qml gives us a Url, we want the Local

D24483: [Weather data engine] Handle windy conditions in NOAA backend

ngraham added a comment. I'm not sure I really understand the proposal. As far as I'm aware, you're the maintainer, so I'll accept with your wishes. All I really care about is that my weather forecast stops looking like this all the time: :-) F7557163: Screenshot_20191009_095550.png

D24483: [Weather data engine] Handle windy conditions in NOAA backend

kossebau added a comment. In D24483#544263 , @ngraham wrote: > To me it makes conceptual sense to display windiness when it's not including other severe weather conditions. In those cases, you care more about the other conditions than the fact

D24359: Fix a number of issues found by the OpenSuse security team in networkhelper

maltek accepted this revision. maltek added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks for the quick reaction (and sorry for my slow one!) > Which is a bit different, as it implies (to me) that the loop will still exit the next time the thread is

D24265: support global edit mode

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, I have some UX concerns here after trying it out: If I invoke Present Windows to see the desktop so that I can right-click on it to enter edit mode, when I exit the

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. See inline comments. Also functionality-wise there are some problems: 1. When a new entry is added, if the KCM is closed and re-opened, the new entry has been

D24265: support global edit mode

mart added a comment. latest version of D24264 does show the desktop when in edit mode (and as sideeffect edit mode doesn't close when the widget explorer is closed) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265

D24519: Delegate KCM cursor theme config management to KConfigXT

davidedmundson added inline comments. INLINE COMMENTS > main.qml:99 > textRole: "display" > +currentIndex: > kcm.cursorSizeIndex(kcm.cursorThemeSettings.cursorSize); > onActivated: { I think this will be broken if you change this

D24264: edit mode action and dbus

mart updated this revision to Diff 67564. mart added a comment. - show desktop when in edit mode REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24264?vs=67518=67564 BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24264

D24483: [Weather data engine] Handle windy conditions in NOAA backend

ngraham added a comment. To me it makes conceptual sense to display windiness when it's not including other severe weather conditions. In those cases, you care more about the other conditions than the fact that it's also windy. For example if the wind accompanies rain or a storm, the fact

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't understand this patch in relation to the title. If no-one uses this property this shouldn't make a difference? REPOSITORY R119 Plasma Desktop

D24517: Port kcm cursor to KConfigXT

bport added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:22 > Can you also add > > install(FILES kded/touchpaddaemon.kcfg > DESTINATION ${KDE_INSTALL_KCFGDIR}) > > This doesn't explicitly do anything useful, but it allows future metadata > extraction

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 67563. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml - Name fixes - Move ui/main to contents - Fix wrong types in Qml - Plug the controllers - Link to the save button - Fix

D24483: [Weather data engine] Handle windy conditions in NOAA backend

kossebau added a comment. In D24483#544189 , @ngraham wrote: > Where I live (in the desert), we often have days that are very windy with no clouds or rain, especially in the springtime. On such days, the data engine always falls back to

D24517: Port kcm cursor to KConfigXT

davidedmundson added inline comments. INLINE COMMENTS > CMakeLists.txt:22 > set(kcm_cursortheme_PART_SRCS kcmcursortheme.cpp ${libnoinst_SRCS}) > - > +kconfig_add_kcfg_files(kcm_cursortheme_PART_SRCS cursorthemesettings.kcfgc > GENERATE_MOC) > add_library(kcm_cursortheme MODULE

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 216 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/216/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 09 Oct 2019 14:41:14 + Build duration: 2 min 58 sec and counting CONSOLE OUTPUT [...truncated 113

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

bport created this revision. bport added reviewers: Plasma, mart, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24520 AFFECTED FILES

D24519: Delegate KCM cursor theme config management to KConfigXT

bport created this revision. bport added reviewers: Plasma, mart, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24519 AFFECTED FILES

D24518: On KCM cursor theme update attribute name

bport created this revision. bport added reviewers: Plasma, mart, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Rename m_model to m_themeModel and selectedIndex to themeSelectedIndex to avoid confusion

D24517: Port kcm cursor to KConfigXT

bport created this revision. bport added reviewers: Plasma, mart, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY - Allow code reuse REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24516: Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method

bport created this revision. bport added reviewers: Plasma, mart, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24516 AFFECTED FILES

D24483: [Weather data engine] Handle windy conditions in NOAA backend

ngraham added a comment. Where I live (in the desert), we often have days that are very windy with no clouds or rain, especially in the springtime. On such days, the data engine always falls back to `IonInterface::NotAvailable`, which is not accurate; a forecast //is// available, but we're

D24483: [Weather data engine] Handle windy conditions in NOAA backend

kossebau added a comment. Disclaimer: nowhere a meteorologist myself, kitchen talk quality at best :) I have to tell I have no idea how "wind" actually matches the category and what general cloud/sky conditions could be derived. Where I have lived, wind as in: fast moving air masses

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 215 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/215/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 09 Oct 2019 14:04:29 + Build duration: 1 min 11 sec and counting CONSOLE OUTPUT [...truncated 113

D24499: Do not warn about LayoutDirection in SearchField

This revision was automatically updated to reflect the committed changes. Closed by commit R169:0115ad12b25a: Do not warn about LayoutDirection in SearchField (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24499?vs=67541=67553

D24498: Properly check enabled state of Action for ActionToolBar buttons

This revision was automatically updated to reflect the committed changes. ahiemstra marked an inline comment as done. Closed by commit R169:4479e865be45: Properly check enabled state of Action for ActionToolBar buttons (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST

D24501: Use MenuItem's action property directly in ActionMenuItem

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a1773a7d42c7: Use MenuItems action property directly in ActionMenuItem (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D24469: Allow the global drawer to become a menu if desired

This revision was automatically updated to reflect the committed changes. Closed by commit R169:64c8bde7ea6c: Allow the global drawer to become a menu if desired (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24469?vs=67549=67550

D24469: Allow the global drawer to become a menu if desired

nicolasfella updated this revision to Diff 67549. nicolasfella added a comment. - Remove unused import REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24469?vs=67548=67549 BRANCH toolbarmenu REVISION DETAIL https://phabricator.kde.org/D24469

D24469: Allow the global drawer to become a menu if desired

nicolasfella updated this revision to Diff 67548. nicolasfella added a comment. - Rename property - Use privateActionToolbutton REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24469?vs=67434=67548 BRANCH toolbarmenu REVISION DETAIL

D24499: Do not warn about LayoutDirection in SearchField

ognarb accepted this revision. ognarb added a comment. Thanks REPOSITORY R169 Kirigami BRANCH searchfield_nowarning REVISION DETAIL https://phabricator.kde.org/D24499 To: ahiemstra, #kirigami, broulik, ognarb Cc: ognarb, broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D24514: [XembedSNIProxy] Do not crash on null pointer

kmaterka added a comment. +few minor code style changes REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24514 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D24514: [XembedSNIProxy] Do not crash on null pointer

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY XCB may return null pointer as a response. Add a check to

D24499: Do not warn about LayoutDirection in SearchField

ahiemstra updated this revision to Diff 67541. ahiemstra added a comment. - Use "edit-clear-locationbar-{rtl,ltr}" as icon to match widgets style REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24499?vs=67502=67541 BRANCH searchfield_nowarning REVISION

D24501: Use MenuItem's action property directly in ActionMenuItem

ahiemstra updated this revision to Diff 67544. ahiemstra added a comment. - Simplify visible binding REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24501?vs=67504=67544 BRANCH simpleactionmenuitem REVISION DETAIL https://phabricator.kde.org/D24501

D24498: Properly check enabled state of Action for ActionToolBar buttons

ahiemstra updated this revision to Diff 67543. ahiemstra added a comment. - Do not implicitly convert float to bool REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24498?vs=67501=67543 BRANCH actiontoolbar_enable REVISION DETAIL

D24498: Properly check enabled state of Action for ActionToolBar buttons

ahiemstra marked an inline comment as done. ahiemstra added inline comments. INLINE COMMENTS > apol wrote in ActionToolBar.qml:126 > I'd do the enabled && opacity, it feels very wrong using a real number as a > boolean >.<. Agreed. I made the opacity check more explicit. REPOSITORY R169

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 214 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/214/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 09 Oct 2019 11:36:10 + Build duration: 2 min 46 sec and counting CONSOLE OUTPUT [...truncated 113

D24500: Be more explicit about action property types

This revision was automatically updated to reflect the committed changes. Closed by commit R169:2b7683fe9db9: Be more explicit about action property types (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24500?vs=67503=67542 REVISION

D24265: support global edit mode

mart added a comment. In D24265#543873 , @ngraham wrote: > I would tend to agree. If we feel that it's too difficult to exit this mode, maybe we should make it more obvious, like changing the X button in the toolbox to a toolbutton with the

D24265: support global edit mode

GB_2 added a comment. In D24265#544016 , @mart wrote: > this happens because some other window gets focus (that behavior in somewhere deep in kwin and i think makes sense). > Would you keep edit mode active when the focus goes to another app?

D24265: support global edit mode

mart added a comment. this happens because some other window gets focus (that behavior in somewhere deep in kwin and i think makes sense). Would you keep edit mode active when the focus goes to another app? I'm very hesitant about that and don't really like the concept... REPOSITORY

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 439 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/439/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 09 Oct 2019 08:40:49 + Build duration: 58 sec and counting CONSOLE OUTPUT [...truncated

D24486: [Notifications] Report effective Inhibited state on DBus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bb0e4208c86c: [Notifications] Report effective Inhibited state on DBus (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24486: [Notifications] Report effective Inhibited state on DBus

broulik updated this revision to Diff 67525. broulik added a comment. - Let applet write `inhibited` directly with no side-effects REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24486?vs=67481=67525 REVISION DETAIL

D24486: [Notifications] Report effective Inhibited state on DBus

broulik planned changes to this revision. broulik added a comment. Right. Given it's the applet's responsibility to enforce the inhibition, makes sense it is the only and direct governor of that property. REPOSITORY R120 Plasma Workspace REVISION DETAIL