D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

miraiko added a comment. Thank you for the review. In D24711#548523 , @ngraham wrote: > Did this change recently? According to xf86-input-libinput git, this has been since 2015.

D24721: Bug 399530

brunogoncalves created this revision. brunogoncalves added a reviewer: Discover Software Store. brunogoncalves added a project: Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. brunogoncalves requested review of this revision. REVISION SUMMARY

D24706: Don't use focus color on checkable button backgrounds

ndavis added a comment. In D24706#548676 , @ngraham wrote: > Hmm, I'm not sure it's working then. Focused pushbuttons still get a blue background. I didn't change the diff yet REPOSITORY R31 Breeze REVISION DETAIL

D24687: [KCM] Add output selector ComboBox

romangg added inline comments. INLINE COMMENTS > Panel.qml:33 > +level: 2 > +// FIXME i18n change text in master > +text: i18n("Settings for %1", " ") what does this FIXME mean? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24687

D24719: Fix laptop screen being off when opening the lid

romangg requested changes to this revision. romangg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > config.cpp:88 > { > -const QString openLidFilePath = filePath() % > QStringLiteral("_lidOpened"); > +const QString openLidFilePath = id() %

D24712: [Updates page] Add text to the checkbox instead of putting it in a separate label

This revision was automatically updated to reflect the committed changes. Closed by commit R134:eac67d4fad3b: [Updates page] Add text to the checkbox instead of putting it in a separate… (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

ngraham added a comment. @aspotashev is a translator and he's approved, so I'd say you're good to go. REPOSITORY R119 Plasma Desktop BRANCH revert-force-stripes-string-change (branched from master) REVISION DETAIL https://phabricator.kde.org/D24534 To: filipf, #plasma, #vdg,

D24706: Don't use focus color on checkable button backgrounds

ngraham added a comment. Hmm, I'm not sure it's working then. Focused pushbuttons still get a blue background. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24706: Don't use focus color on checkable button backgrounds

ndavis added a comment. In D24706#548444 , @ngraham wrote: > Oh nice, lol. Could you do the same thing for pushbuttons and non-checked toggle buttons and comboboxes too? That way the focus behavior for checked toggle buttons wouldn't become

D24720: [applets/systemtray] Rewrite popups with layouts

filipf added a comment. The paddings issue is actually the same as with notifications (D21813 ). We can tweak it here and then alter it for all desktop themes, some of which already add extra padding on their own. This means we're messing with their

D24534: [applets/taskmanager] Revert "forceStripes" checkbox string change

filipf added a comment. Do we have a green light for 5.17.1? How do I tag the translators? REPOSITORY R119 Plasma Desktop BRANCH revert-force-stripes-string-change (branched from master) REVISION DETAIL https://phabricator.kde.org/D24534 To: filipf, #plasma, #vdg, aspotashev, ngraham

D24567: WIP: Implement sidebar mode for system tray plasmoid popups

filipf abandoned this revision. filipf added a comment. Yeah, can't get this to work properly anyway. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24567 To: filipf, #vdg, #plasma, mart Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24720: [applets/systemtray] Rewrite popups with layouts

filipf updated this revision to Diff 68103. filipf added a comment. remove useless leftover stuff from WIP versions REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24720?vs=68102=68103 BRANCH popup-rewrite (branched from master) REVISION DETAIL

D24720: [applets/systemtray] Rewrite popups with layouts

filipf added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:93 > +icon.name: "window-pin" > +//tooltip: i18n("Keep Open") > +} How do I use tooltips with PC3 here again? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D24720: [applets/systemtray] Rewrite popups with layouts

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Currently the code that draws plasmoid popups utilizes an anchor based approach. I think layouts are a more elegant solution so

D23330: Make manual control compatible with redshift >= 1.12

This revision was automatically updated to reflect the committed changes. Closed by commit R885:898c3a4cfc6c: Make manual control compatible with redshift = 1.12 (authored by vermeeren, committed by ngraham). REPOSITORY R885 Redshift Control for Plasma CHANGES SINCE LAST UPDATE

D24718: [wayland] Don't init m_internalConfig twice

This revision was automatically updated to reflect the committed changes. Closed by commit R110:f948b5bcedbb: [wayland] Dont init m_internalConfig twice (authored by nicolasfella). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24718?vs=68097=68100

D24719: Fix laptop screen being off when opening the lid

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY filePath() returns the full path to the config file. readFile() then prepends

D24712: [Updates page] Add text to the checkbox instead of putting it in a separate label

ngraham added a comment. Thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24712 To: ngraham, apol, #discover_software_store, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D24713: [RFC] [Updates page] use fancier logic for handling elided Old+New version strings

ngraham updated this revision to Diff 68098. ngraham added a comment. Make it display REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24713?vs=68088=68098 BRANCH fancier-long-version-string-handling (branched from master) REVISION DETAIL

D24712: [Updates page] Add text to the checkbox instead of putting it in a separate label

apol added a comment. You can test using `--backends dummy`. To enable the build of the dummy backend, you pass -DBUILD_DummyBackend=ON to cmake. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24712 To: ngraham, apol, #discover_software_store Cc:

D24717: [Advanced Settings] Clean up UI file

davidedmundson added a comment. Looks the same. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D24717 To: broulik, #plasma, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D24718: [wayland] Don't init m_internalConfig twice

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY It it initialized 4 lines prior. Once should be enough. TEST PLAN

D24634: [WIP] Allow contextualActions to flow into the header toolbar

ahiemstra added a comment. > now has the order main action, left, right. before was left, main right. > it does change a bit the behavior, tough i see the point of making sure that the main action is always the last being hidden (i wonder how it would be making it hide last even if not

D24717: [Advanced Settings] Clean up UI file

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Remove pointless outer layout and spacer items. BUG: 412971 FIXED-IN:

D24715: Show a message indicating that no TB devices are connected when the list is empty

ngraham created this revision. ngraham added reviewers: VDG, Plasma, dvratil. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY ...Otherwise the user might think that it's just broken. TEST PLAN Before:

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

ngraham added a comment. Thanks for submitting this patch! What exactly do you mean by "now"? Did this change recently? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24711 To: miraiko, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24713: [RFC] [Updates page] use fancier logic for handling elided Old+New version strings

ngraham created this revision. ngraham added reviewers: apol, broulik, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY @broulik taught me how to do this! It's more robust than the

D24712: [Updates page] Add text to the checkbox instead of putting it in a separate label

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN Can't test; no updates available right now REPOSITORY R134 Discover Software

D24488: [kcm] Don't transform button to show rotated icon

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ae555055b2ea: [kcm] Dont transform button to show rotated icon (authored by davidedmundson). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24488?vs=68085=68086

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

miraiko created this revision. miraiko added a reviewer: Plasma. miraiko added a project: Plasma. miraiko requested review of this revision. REVISION SUMMARY LIBINPUT_PROP_ACCEL_PROFILE_ENABLED now contains two values, valueWriterPart function didn't handle it correctly. REPOSITORY R119

D24488: [kcm] Don't transform button to show rotated icon

davidedmundson updated this revision to Diff 68085. davidedmundson added a comment. Use units Use rotation directly REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24488?vs=68077=68085 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24488

KDE CI: Plasma » kscreen » stable-kf5-qt5 SUSEQt5.12 - Build # 26 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20SUSEQt5.12/26/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 16 Oct 2019 20:26:21 + Build duration: 3 min 24 sec and counting JUnit Tests Name:

D24488: [kcm] Don't transform button to show rotated icon

broulik added inline comments. INLINE COMMENTS > RotationButton.qml:41 > +source: "view-preview" > +transform: Rotation { > +origin { why not just use `rotation` property? REPOSITORY R104 KScreen BRANCH master REVISION DETAIL

D24483: [Weather data engine] Handle windy conditions in NOAA backend

This revision was automatically updated to reflect the committed changes. Closed by commit R120:03ce6234aa96: [Weather data engine] Handle windy conditions in NOAA backend (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24706: Don't use focus color on checkable button backgrounds

ndavis added a comment. I feel like the hover effect is not obvious enough though. In the future, I might want to make it so that the hover color is mixed with the current background color. That way it will be more visually related to whatever the toggled/untoggled state is. I might need to

D24706: Don't use focus color on checkable button backgrounds

ngraham added a comment. Oh nice, lol. Could you do the same thing for pushbuttons and non-checked toggle buttons and comboboxes too? That way the focus behavior for checked toggle buttons wouldn't become inconsistent with the focus behavior for those other items. REPOSITORY R31 Breeze

D24706: Don't use focus color on checkable button backgrounds

ndavis added a comment. Same thing, but with the toggle button focused and toggled. F7609177: Screenshot_20191016_153732.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: ngraham,

D24706: Don't use focus color on checkable button backgrounds

ndavis added a subscriber: ngraham. ndavis added a comment. In D24706#548392 , @ngraham wrote: > I see what you're trying to do here, and I approve. But I think it might make more sense to more generally rethink how we indicate focus for

D24488: [kcm] Don't transform button to show rotated icon

ngraham added a comment. 5.17? REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D24488 To: davidedmundson, #plasma, ngraham Cc: romangg, mart, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D24488: [kcm] Don't transform button to show rotated icon

ngraham accepted this revision. ngraham added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > RotationButton.qml:59 > > -implicitWidth: 45 > -implicitHeight: 45 > +implicitWidth: contentItem.implicitWidth + 2 * 4 > +implicitHeight:

D24488: [kcm] Don't transform button to show rotated icon

davidedmundson added a comment. If Kai says this is the right approach, it probably is REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24488 To: davidedmundson, #plasma Cc: romangg, mart, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24488: [kcm] Don't transform button to show rotated icon

davidedmundson updated this revision to Diff 68077. davidedmundson added a comment. update2 REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24488?vs=68076=68077 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24488 AFFECTED FILES

D24488: [kcm] Don't transform button to show rotated icon

davidedmundson updated this revision to Diff 68076. davidedmundson edited the summary of this revision. davidedmundson added a comment. update REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24488?vs=67488=68076 BRANCH master REVISION DETAIL

D24706: Don't use focus color on checkable button backgrounds

ngraham added a comment. I see what you're trying to do here, and I approve. But I think it might make more sense to more generally rethink how we indicate focus for buttons. IMO we should draw a highlight around the edges rather than changing the background color, for the following

D24488: [kcm] Don't transform button to show rotated icon

broulik added a comment. I would still suggest overriding the `contentItem` of the `Button` and put a rotated `Kirigami.Icon` in there without actually transforming the entire button. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24488 To: davidedmundson,

D24483: [Weather data engine] Handle windy conditions in NOAA backend

ngraham added a comment. Nice. The icons should go in today, after which I'll land this. REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg,

D24488: [kcm] Don't transform button to show rotated icon

ngraham added a comment. I agree with roman that the rotated icons are preferable from a usability perspective. Maybe we need new icons then? #VDG REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24488 To: davidedmundson,

D24706: Don't use focus color on checkable button backgrounds

ndavis added a comment. The hover color is still kind of an issue, but less of an issue. It looked really stiff and unnatural without something to indicate that it can be hovered. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc:

D24706: Don't use focus color on checkable button backgrounds

ndavis updated this revision to Diff 68070. ndavis added a comment. Wait no, I got it - Don't use HighlightedText if sunken REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=68069=68070 BRANCH focus-toggle-button (branched from master)

D14245: Use '-P' option to properly adjust color temperature in manual mode

ngraham abandoned this revision. ngraham added a comment. Superseded by D23330 . REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D14245 To: ngraham, martinkostolny, andrewc Cc: plasma-devel, LeGast00n,

D23401: Fix scroll control (add -P option)

ngraham abandoned this revision. ngraham added a comment. Superseded by D23330 . REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D23401 To: ngraham, martinkostolny, srenaud Cc: ngraham, plasma-devel, LeGast00n,

D14068: add -P switch to one-shot redshift call

ngraham abandoned this revision. ngraham added a comment. Superseded by D23330 . REPOSITORY R885 Redshift Control for Plasma REVISION DETAIL https://phabricator.kde.org/D14068 To: ngraham, #plasma, romangg, martinkostolny, grmat Cc: davidedmundson,

D24634: [WIP] Allow contextualActions to flow into the header toolbar

ngraham accepted this revision as: ngraham. ngraham added a comment. This revision is now accepted and ready to land. This works really well in Discover, Kamoso, and kirigami-gallery. Still a big thumbs-up from me. REPOSITORY R169 Kirigami BRANCH contextactions_in_toolbar REVISION

D24706: Don't use focus color on checkable button backgrounds

ndavis added a comment. Darn, I just realized the text still uses the highlight text color. Not sure how to fix that besides changing the color in the colorscheme. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: plasma-devel,

D24706: Don't use focus color on checkable button backgrounds

ndavis updated this revision to Diff 68069. ndavis removed a subscriber: ngraham. ndavis added a comment. Change the style of the if else in the AnimationHover section REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=68068=68069 BRANCH

D24706: Don't use focus color on checkable button backgrounds

ngraham added a comment. Before/after images or video? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf,

D24706: Don't use focus color on checkable button backgrounds

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY This fixes a usability problem where it was hard to tell whether or not a focused and checkable

D24208: [Notifications] Dodge Plasma dialogs

ngraham added a comment. In D24208#548315 , @meven wrote: > In D24208#548272 , @ngraham wrote: > > > In D24208#548153 , @broulik wrote: > > > > >

D24276: Add text to speech functionality to klipper.

whiting added a comment. In D24276#548330 , @mart wrote: > this only affects the old standalone executable, right? Um, I guess so. I didn't realize there was something else... REPOSITORY R120 Plasma Workspace REVISION DETAIL

KDE CI: Plasma » kscreen » stable-kf5-qt5 SUSEQt5.12 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kscreen/job/stable-kf5-qt5%20SUSEQt5.12/25/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Wed, 16 Oct 2019 16:47:00 + Build duration: 2 min 48 sec and counting CONSOLE OUTPUT

D24276: Add text to speech functionality to klipper.

mart added a comment. this only affects the old standalone executable, right? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24276 To: whiting, davidedmundson, gladhorn, #plasma_accessibility, #plasma Cc: mart, ndavis, plasma-devel, LeGast00n,

D24208: [Notifications] Dodge Plasma dialogs

broulik added a comment. > Hidding the notification behind a popup is at best a workaround. It is. > What if you receive an email while changing your audio setup ? Then you close the popup and get the notification, I don't see an issue with that. It's not like you fiddle with

D24704: [KCM] Show the same name in the replication model that's shown in the title

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ba20c56a724f: [KCM] Show the same name in the replication model thats shown in the title (authored by ngraham). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D24208: [Notifications] Dodge Plasma dialogs

meven added a comment. In D24208#548272 , @ngraham wrote: > In D24208#548153 , @broulik wrote: > > > Bluetooth could provide some better feedback inside the plasmoid. > > > Agreed,

D24704: [KCM] Show the same name in the replication model that's shown in the title

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. 5.17 confirmed REPOSITORY R104 KScreen BRANCH replica-output-names (branched from Plasma/5.17) REVISION DETAIL https://phabricator.kde.org/D24704 To: ngraham, romangg, #vdg Cc:

D24704: [KCM] Show the same name in the replication model that's shown in the title

ngraham created this revision. ngraham added reviewers: romangg, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch makes the name shown in the combobox match the name shown for each individual

D24224: Start of the accessibility KCM

ngraham added a comment. In D24224#547897 , @tcanabrava wrote: > F7605185: kcm_access.png Lists such as these always need frames and backgrounds, like how it looks in the Notifications KCM. Just

D24687: [KCM] Add output selector ComboBox

ngraham added a comment. This is a big improvement IMO. You can also remove the little dots at the bottom too. +1 for getting it into 17.1. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24687 To: broulik, #plasma, #vdg, romangg Cc: ngraham, mart, plasma-devel,

D24666: Be explicit about X11 or Wayland for the dev session names

This revision was automatically updated to reflect the committed changes. Closed by commit R120:63dca8847085: Be explicit about X11 or Wayland for the dev session names (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24208: [Notifications] Dodge Plasma dialogs

ngraham added a comment. In D24208#548153 , @broulik wrote: > Bluetooth could provide some better feedback inside the plasmoid. Agreed, notifications shouldn't be used when the app/window/UI/whatever is still open; feedback should be

D24701: Notify about change after cursor config is saved

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Before that patch the cursor change signal was only transmitted after a configuration was applied on a fly. Because the cursor

D24688: [KCM] Disallow dropping screen outside of reachable area

ngraham added inline comments. INLINE COMMENTS > broulik wrote in Screen.qml:83 > Suggestions? IMO magic numbers are probably okay here, but 20 is pretty similar to GridUnit so maybe just use multiples of that instead? REPOSITORY R104 KScreen REVISION DETAIL

D24567: WIP: Implement sidebar mode for system tray plasmoid popups

ngraham added a comment. I agree that it would probably make more sense to allow the system tray popup to be arbitrarily resized, and use a panel instead when you wand a vertical sidebar type of UI. The issues with using a panel to accomplish that are discussed in

D24127: Fix toggle button colours

ngraham added a comment. I think this patch needs some changes (outlined above). REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24127 To: cblack, #breeze, ndavis, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24668: Simplify kcms cmake file

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c72a1d5ce982: Simplify kcms cmake file (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24668?vs=67987=68056 REVISION DETAIL

D24670: KCM fonts : Rearrange code

This revision was automatically updated to reflect the committed changes. Closed by commit R119:36d8d9e32351: KCM fonts : Rearrange code (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24670?vs=67989=68058 REVISION DETAIL

D24669: Port fonts KCM to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a4d23764ea46: Port fonts KCM to KConfigXT (authored by bport). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24669?vs=67988=68057#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D24698: Leverage latest KConfig changes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:05ec670029db: Leverage latest KConfig changes (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24698?vs=68047=68054 REVISION DETAIL

D24699: Disable the module if the setting is locked down

This revision was automatically updated to reflect the committed changes. Closed by commit R119:77cfc0dc78fd: Disable the module if the setting is locked down (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24699?vs=68048=68055

D24634: [WIP] Allow contextualActions to flow into the header toolbar

ngraham added a comment. In D24634#548229 , @mart wrote: > In D24634#547077 , @ngraham wrote: > > > Oh, this is so nice! > > > can you test/qa some existing apps? (at least discover and kamoso

D24634: [WIP] Allow contextualActions to flow into the header toolbar

mart added a comment. In D24634#547077 , @ngraham wrote: > Oh, this is so nice! can you test/qa some existing apps? (at least discover and kamoso ?) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24634 To:

D24634: [WIP] Allow contextualActions to flow into the header toolbar

mart added a comment. testing it i did find a major problem: if i resize the window quickly (kirigami gallery 2 columns mode) when it goes from icon+text to just icon, the window freezes for an instant, seems quite expensive, while before didn't do that REPOSITORY R169 Kirigami REVISION

D24634: [WIP] Allow contextualActions to flow into the header toolbar

mart added a comment. now has the order main action, left, right. before was left, main right. it does change a bit the behavior, tough i see the point of making sure that the main action is always the last being hidden (i wonder how it would be making it hide last even if not the last)

D24373: [KCM] Limit scale factor increment to 6.25% on X11

This revision was automatically updated to reflect the committed changes. Closed by commit R104:2b23256b0a47: [KCM] Limit scale factor increment to 6.25% on X11 (authored by ngraham). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24373?vs=68051=68053

D24373: [KCM] Limit scale factor increment to 6.25% on X11

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Thank you Nate. master branch only. REPOSITORY R104 KScreen BRANCH 0625-increment-on-x11 REVISION DETAIL https://phabricator.kde.org/D24373 To: ngraham, #plasma, romangg, mart

D24373: [KCM] Limit scale factor increment to 6.25% on X11

ngraham updated this revision to Diff 68051. ngraham added a comment. Update message REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24373?vs=68050=68051 BRANCH 0625-increment-on-x11 REVISION DETAIL https://phabricator.kde.org/D24373 AFFECTED FILES

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

ngraham updated this revision to Diff 68050. ngraham added a comment. Rebase REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24373?vs=67226=68050 BRANCH 0625-increment-on-x11 REVISION DETAIL https://phabricator.kde.org/D24373 AFFECTED FILES

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

romangg added a comment. Actually I would like to expose the fact that we are doing that only on X11. People not knowing what this is can ignore it. Also it is a single factor, not multiple as with multi output DPI scaling on Wayland. How about: The global scale factor is limited

D24370: [KCM] Display scale factor as a percentage, not a decimal

This revision was automatically updated to reflect the committed changes. Closed by commit R104:0f52663c7829: [KCM] Display scale factor as a percentage, not a decimal (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24370?vs=67215=68049#toc REPOSITORY R104

D24699: Disable the module if the setting is locked down

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Cool! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24699 To: ervin, #plasma, mart, broulik Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24699: Disable the module if the setting is locked down

ervin created this revision. ervin added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY In this case we simply disable the whole module since it manages only a single key really. We

D24698: Leverage latest KConfig changes

ervin created this revision. ervin added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY - Use the ctor with parent (no need to call setParent anymore) - Use isSaveNeeded on the

D24324: [GTK2] Add program to libexec for GTK2 recoloration

ngraham added a comment. How about calling this new one "Breeze" and renaming the old one "Breeze (fixed colors)" or something like that? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24324 To: cblack, #breeze Cc: ngraham, ndavis, plasma-devel, LeGast00n,

D24677: Add `sudo` to the lines in install-sessions.sh that need it so you don't need to sudo the whole thing

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c12befa1c65b: Add `sudo` to the lines in install-sessions.sh that need it so you dont need… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18299: ComboBox: fix default delegate

broulik added a comment. I checked Qt source code and Qt indeed should handle this on its own, it also works fine hwere without the code. Worse, the explicit assignment from QML breaks any binding set on `currentIndex`. In the handler that's called when the delegate model creates a

D24208: [Notifications] Dodge Plasma dialogs

broulik added a comment. Bluetooth could provide some better feedback inside the plasmoid. Pointless confirmation notifications in plasma-nm were the main reason for this patchset. Sliding could be done but is a lot more complicated than this patchset since the dialogs are individual,

D23578: Before requesting a scan, check the time threshold

meven added inline comments. INLINE COMMENTS > meven wrote in main.qml:77 > I removed this because > > 1: > Request scan failure should never happen anymore because the handler makes > sure never to call requestScan too often. > The timer can just constantly ask for request scans it does not

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson, fvogt, ngraham Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24687: [KCM] Add output selector ComboBox

broulik added a comment. > I thought about showing some mini-symbols for disabled outputs on one of the sides of the overview at a fixed position. What do you need a proxy model for that? The outputs are part of the model, just `visible: model.enabled`. You could just have the delegate

  1   2   >