D24706: [RFC] Change button style

ndavis added a comment. Should be fixed now. I forgot to add that to the diff here after I made the video. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: bodoeggert, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konk

D24905: Use return early

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY Makes the code more readable by reducing the indentation depth REPOSITORY R116 Plasm

D24706: [RFC] Change button style

ngraham added a comment. I do like how obvious it makes the selected button, but by doing this, it visually overwhelms and destroys the concept of the default button (which is supposed to be the most visually distinctive button). IMO it also interferes with the the checked and hover states I

D24893: [Lock Screen] Add option to hide clock when idle

ngraham added a comment. This should make a lot of people happy. :) Is there a way to suppress these settings when you're using a theme that doesn't make the clock and media controls optional? INLINE COMMENTS > config.qml:5 > > -RowLayout { > +ColumnLayout { > +property alias cfg_

D24899: Remove commented out code

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH comm REVISION DETAIL https://phabricator.k

D24706: [RFC] Change button style

ngraham added a comment. Well that changed things, but it didn't fully fix the issue: F7659135: demo-2019-10-23_14.39.54.webm REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: bodoeggert, ngraham

D24900: [mobile/wifi] Remove special font style for active connection

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY Now that the lsit is grouped by connection state we don't need to use font tweaks to e

D24706: [RFC] Change button style

ngraham added a comment. In general +1, I think this is an improvement. However something seems off about the text colors for focused buttons: F7659086: demo-2019-10-23_14.25.10.webm REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde

D24706: [RFC] Change button style

ndavis added a comment. In D24706#552980 , @ngraham wrote: > Combobox still affected: F7659165: Screenshot_20191023_145546.png > > Icons on focused buttons (ToolButtons as well as PushButtons) still have

D24706: [RFC] Change button style

ngraham added a comment. Nice, this is looking better now. I'm gonna use it full time for a while. I'm wondering if we might want to increase the thickness of the focus effect. It's maybe a bit too subtle now. In Adwaita, the focus outline around, say, spinboxes is quite chunky. But I th

D24901: [sidebar] Add a hover effect to intro page icons

filipf updated this revision to Diff 68641. filipf added a comment. also make the effect appear on activeFocus (tabbing) REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24901?vs=68639&id=68641 BRANCH hover-effect-intro-page-icons (branched from ma

D24894: notifier: Make action buttons translatable

aspotashev created this revision. aspotashev added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aspotashev requested review of this revision. TEST PLAN it compiles REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.

D24706: [RFC] Change button style

ngraham added a comment. Combobox still affected: F7659165: Screenshot_20191023_145546.png Icons on focused buttons (ToolButtons as well as PushButtons) still have reversed colors: F7659169: Screenshot_20191023_145628.png

D24706: [RFC] Change button style

ndavis updated this revision to Diff 68632. ndavis added a comment. - Don't use HightlightedText on PushButton labels REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=68584&id=68632 BRANCH ndavis/pushbutton-style (branched from master) REVISION DET

D24706: [RFC] Change button style

ndavis added a comment. In D24706#552849 , @bodoeggert wrote: > /me thinks that hover colors are more confusing than helpful, especially if they are similar / mixed with the "pressed" color. I have a mouse cursor to indicate the position of the

D24901: [sidebar] Add a hover effect to intro page icons

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY There is currently no hover effect on the intro page. This patch makes the icons themselves produce the effect on mouse hover. R

D24808: [mobile/wifi] Group networks by connection state

This revision was automatically updated to reflect the committed changes. Closed by commit R116:cca7e8d08d42: [mobile/wifi] Group networks by connection state (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D24897: [mobile/wifi] Remove broken confirmation dialog when forgetting a connection

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY The confirmation is broken and doesn't appear at

D24899: Remove commented out code

nicolasfella updated this revision to Diff 68636. nicolasfella added a comment. - Remove more REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24899?vs=68635&id=68636 BRANCH comm REVISION DETAIL https://phabricator.kde.org/D2489

D24901: [sidebar] Add a hover effect to intro page icons

ngraham added a comment. I wouldn't even be in favor of that, FWIW. I think the animated hover transitions in the sidebar are quite distracting, and inconsistent with the hover effects everywhere else. I'd like to make the hover effects instant, not animated. REPOSITORY R124 System Settin

D24706: [RFC] Change button style

ndavis added a comment. I still prefer having the focus background. It's a distinct feature of Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: bodoeggert, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinart

D24706: [RFC] Change button style

ndavis updated this revision to Diff 68645. ndavis added a comment. - Don't use QIcon::Selected on non-flat focused buttons REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=68637&id=68645 BRANCH ndavis/pushbutton-style (branched from master) REVISI

D24901: [sidebar] Add a hover effect to intro page icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. 5.17 REPOSITORY R124 System Settings BRANCH hover-effect-intro-page-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24901 To: filipf, #plasma, #vdg, ngra

D24906: [KCMs/Night Color] Explain Night Color feature inline

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I was going to suggest that we use the module subtitle for this, but it looks like we don't use those anymore. REPOSITORY R119 Plasma Desktop BRANCH explain-night-color (branched from

D24894: notifier: Make action buttons translatable

aspotashev updated this revision to Diff 68625. aspotashev added a comment. oops, sent wrong patch REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24894?vs=68624&id=68625 BRANCH notifier-i18n REVISION DETAIL https://phabricator.kde.org/

D24893: [Lock Screen] Add option to hide clock when idle

broulik added a comment. > Is there a way to suppress these settings when you're using a theme that doesn't make the clock and media controls optional? That's the trick! The config comes *from the theme* (similar to how plasmoids do it), so only our theme will have those check boxes. IN

D24733: feedback kcm: Make it about Plasma

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2dd40cfb21b4: feedback kcm: Make it about Plasma (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24733?vs=68620&id=68621 REVISION DETAI

D24706: [RFC] Change button style

bodoeggert added a comment. /me thinks that hover colors are more confusing than helpful, especially if they are similar / mixed with the "pressed" color. I have a mouse cursor to indicate the position of the mouse. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D2470

D24893: [Lock Screen] Add option to hide clock when idle

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This allows to use it for a slideshow or something. TEST PLAN F7658739: Screenshot_20191023

D24901: [sidebar] Add a hover effect to intro page icons

filipf added a comment. In D24901#553008 , @ngraham wrote: > 5.17 Awesome. Leaving open for 24 hrs from submission time in case of extra comments, if not will land it then. REPOSITORY R124 System Settings BRANCH hover-effect-intro-p

D24901: [sidebar] Add a hover effect to intro page icons

filipf added a comment. In D24901#553055 , @KonqiDragon wrote: > Is it possible to make a smooth effect animation? Like in sidebar. I think that require changes in Kirigami.Icon so not in this patch. REPOSITORY R124 System Settings BR

D24706: [RFC] Change button style

ndavis added a comment. Looks like that's because those were ToolButtons and I only changed PushButtons REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: bodoeggert, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkina

D24706: [RFC] Change button style

ndavis updated this revision to Diff 68637. ndavis added a comment. - Don't use HighlightedText for focused non-flat toolbuttons REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=68632&id=68637 BRANCH ndavis/pushbutton-style (branched from master) R

D24901: [sidebar] Add a hover effect to intro page icons

KonqiDragon added a comment. Is it possible to make a smooth effect animation? Like in sidebar. REPOSITORY R124 System Settings BRANCH hover-effect-intro-page-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24901 To: filipf, #plasma, #vdg, ngraham Cc: KonqiDr

D24706: [RFC] Change button style

bodoeggert added a comment. The confusing thing about focus / hover colors is having to move away the mouse in order to see weather it's focused or toggled. I need to know: This button is pressed or not, that button will be interacted when I press space/enter. Highlighting the button und

D24903: Don't reset model when activeconnectionstate changed

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY resetting the model when a single property changes is using a sledgehammer to crack a

D24706: [RFC] Change button style

ndavis added a comment. In D24706#552981 , @ndavis wrote: > In D24706#552980 , @ngraham wrote: > > > Combobox still affected: F7659165: Screenshot_20191023_145546.png

D24893: [Lock Screen] Add option to hide clock when idle

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh nice! Shipit! Works great. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24893 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, LeGas

D24906: [KCMs/Night Color] Explain Night Color feature inline

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY All the other platforms that have implemented this feature offer a little inline explanatio

D24905: Use return early

broulik added a comment. I think all of thise `breaks` in loops must be `continue`s? INLINE COMMENTS > networkmodel.cpp:457 > +if (item->itemType() != NetworkModelItem::AvailableConnection) > +break; > + Shouldn't this be a `continue`? > networkmodel.cpp:843 > +i

D24894: notifier: Make action buttons translatable

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. 5.17 branch please. While you cannot change strings, you can make previously accidentally untranslated strings translatable. REPOSITORY R134 Discover Software Store BRANCH notifier-i

Night Color Widget (adapt Redshift Control Widget to kwin's Night Color functionality)

Hey guys! I was thinking about resurrecting the Redshift Control Widget, as apparently there are users (including me) that find it very convenient to be able to enable/disable Night Color with just a click. Anyway I have some questions that I hope you might be able to answer. Currently R

D24905: Use return early

jgrulich added a comment. In D24905#553119 , @broulik wrote: > I think all of thise `breaks` in loops must be `continue`s? Good catch. REPOSITORY R116 Plasma Network Management Applet BRANCH returnearly REVISION DETAIL https://pha

Night Color Widget (Redshift Control Widget adapt to kwin's Night Color)

Hey guys! I was thinking about resurrecting the Redshift Control Widget, as apparently there are users (including me) that find it very convenient to be able to enable/disable Night Color with just a click. Anyway I have some questions that I hope you might be able to answer. Currently R

D24906: [KCMs/Night Color] Explain Night Color feature inline

zzag added a comment. > [KCMs/Night Color] Plasma folks don't use such scopes. They prefer, correct me if I'm wrong, something like "[Night Color KCM]". REPOSITORY R119 Plasma Desktop BRANCH explain-night-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D24893: [Lock Screen] Add option to hide clock when idle

davidedmundson added inline comments. INLINE COMMENTS > WallpaperFader.qml:145 > target: clock.shadow > -opacity: 1 > +opacity: wallpaperFader.alwaysShowClock ? 1 : 0 > +} Why are we changing this line? > config.qml:21 > +

D24893: [Lock Screen] Add option to hide clock when idle

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in WallpaperFader.qml:145 > Why are we changing this line? The clock shadow effectively renders the clock (shader effect with source hidden), so it has to be hidden. > davidedmundson wrote in config.qml:21 > One thing Thomas

D24906: [KCMs/Night Color] Explain Night Color feature inline

davidedmundson added a comment. > They prefer, correct me if I'm wrong, something like "[Night Color KCM]". REPOSITORY R119 Plasma Desktop BRANCH explain-night-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D24906 To: ngraham, #vdg, #plasma, ndavis, zzag Cc:

D24906: [KCMs/Night Color] Explain Night Color feature inline

davidedmundson added a comment. > They prefer, correct me if I'm wrong, something like "[Night Color KCM]". Plasma folks don't really have a good style sorted. You can find examples of 3 different styles. It is a good point that we miss a consistency :/ but it also means no individ

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka added a comment. It looks like there are some review changes required in D24798 . Maybe I can commit my changes first? D24798 needs changes anyway and it would be good to split QCC1 -> QCC2 migration from layou

D24897: [mobile/wifi] Remove broken confirmation dialog when forgetting a connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b83e86d817bc: [mobile/wifi] Remove broken confirmation dialog when forgetting a connection (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE ht

D24900: [mobile/wifi] Remove special font style for active connection

This revision was automatically updated to reflect the committed changes. Closed by commit R116:5e9ff384b503: [mobile/wifi] Remove special font style for active connection (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricat

D24899: Remove commented out code

This revision was automatically updated to reflect the committed changes. Closed by commit R116:33991d909626: Remove commented out code (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24899?vs=68636&id=68654#toc REPOSITORY R116 Plasma Network Management Apple

D24903: Don't reset model when activeconnectionstate changed

This revision was automatically updated to reflect the committed changes. Closed by commit R116:4627aaf6f066: Don't reset model when activeconnectionstate changed (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D24905: Use return early

nicolasfella updated this revision to Diff 68658. nicolasfella added a comment. - s/break/continue - Fixup REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24905?vs=68644&id=68658 BRANCH returnearly REVISION DETAIL https://pha

D24905: Use return early

This revision was automatically updated to reflect the committed changes. Closed by commit R116:f301f1ead38a: Use return early (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24905?vs=68658&id=68659 REVISION

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 136 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/136/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 24 Oct 2019 10:27:18 + Build duration: 1 min 29 sec and counting CONSOLE OUTPUT [...truncated 484

D24910: Fix build

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH fix REVISION DETAIL https://phabricator.kd

D24906: [KCMs/Night Color] Explain Night Color feature inline

ahiemstra added a comment. Hmm, I feel the text here is a bit vague... "can make" should probably be "makes". Also, do people understand what "making colours warmer" means? REPOSITORY R119 Plasma Desktop BRANCH explain-night-color (branched from master) REVISION DETAIL https://phabric

D24910: Fix build

This revision was automatically updated to reflect the committed changes. Closed by commit R116:ba142dd7125c: Fix build (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24910?vs=68660&id=68661 REVISION DETAIL

D24910: Fix build

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. You could just push this without me doing review :). REPOSITORY R116 Plasma Network Management Applet BRANCH fix REVISION DETAIL https://phabricator.kde.org/D24910 To: nicolasfe

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 137 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/137/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 24 Oct 2019 10:35:30 + Build duration: 9 min 16 sec and counting JUnit Tests Name: (root) Failed:

D24894: notifier: Make action buttons translatable

apol accepted this revision. apol added a comment. Good catch! I wonder how that happened :/ REPOSITORY R134 Discover Software Store BRANCH notifier-i18n REVISION DETAIL https://phabricator.kde.org/D24894 To: aspotashev, apol, broulik Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS

D24913: Converts a couple foreach

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24913 AFFECTED FILES

D24913: Converts a couple foreach

meven added inline comments. INLINE COMMENTS > view.cpp:224 > > -Q_FOREACH (QScreen* screen, QGuiApplication::screens()) { > +const auto screens = QGuiApplication::screens(); > +for (QScreen* screen : screens) { screens currently returns QList and QList should get deprecated in Qt

D24917: KCM Style port to KConfigXT

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24917 AFFECTED FILES kcms/style/CMakeLists.txt kcms/style/kcmstyle.

D24916: KCM style : fix combobox that weren't updated after user made change

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. TEST PLAN Inside Configure Icons and Toolbars popup menu, change some value in combobox, hit apply

D24918: Fix issue when there is no WidgetStyle value in kdeglobals

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY KConfig XT does not store default values in conf files. KCM Style applying defaul

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68673. jgrulich added a comment. - Add border around the view and use small radius around for item highlight REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68502&id=68673 B

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#552239 , @ngraham wrote: > There still isn't a border around the inner view. That's what I'm trying to get there. Otherwise it doesn't look like an inner view; it looks like a floating rectangle. Solve

D24913: Converts a couple foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1f95ea34ac40: Converts a couple foreach (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24913?vs=68668&id=68675 REVISION DETAIL http

D24919: Don't reset model when device state changes

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY same resoning as in D24903 TEST PLAN Toggled Wi

D24920: Add missing role changes

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY A few roles were not marked as changed properly. TEST PLAN Builds REPOSITORY R116

D24922: Don't reset model when available connection appears

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY addAvailableConnection() does the proper row/data update handling already Depends

D24923: Use more return early

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH ret REVISION DETAIL https://phabricator.kd

D24924: Don't reset model when adding an active connection

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY same resoning as in D24903 REPOSITORY R116 Plas

D24925: KCM KSplash port to ManagedConfigModule

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24925 AFFECTED FILE

D24923: Use more return early

crossi requested changes to this revision. crossi added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > networkmodel.cpp:402 > // Check whether the connection is already in the model to avoid > duplicates, but this shouldn't happen > -if (!m_list.contai

D24924: Don't reset model when adding an active connection

jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > networkmodel.cpp:313 > +int row = m_list.indexOf(item); > +Q_EMIT dataChanged(index(row, 0), index(row, 0)); > } Shouldn't you add it

D24920: Add missing role changes

This revision was automatically updated to reflect the committed changes. Closed by commit R116:17e4fd449991: Add missing role changes (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24920?vs=68678&id=68687

D24919: Don't reset model when device state changes

jgrulich accepted this revision. jgrulich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > networkmodel.cpp:830 > +int row = m_list.indexOf(item); > +Q_EMIT dataChanged(index(row, 0), index(row, 0)); > // qCDebug(PLASMA_NM) <<

D24923: Use more return early

jgrulich accepted this revision. jgrulich added inline comments. INLINE COMMENTS > crossi wrote in networkmodel.cpp:402 > Code style : Use curly braces even when the body of a conditional statement > contains only one line. I think this is a valid Qt coding style, it was just my obsession to u

D24922: Don't reset model when available connection appears

This revision was automatically updated to reflect the committed changes. Closed by commit R116:d971703e1df5: Don't reset model when available connection appears (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D24923: Use more return early

nicolasfella updated this revision to Diff 68689. nicolasfella added a comment. - Conding style REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24923?vs=68680&id=68689 BRANCH ret REVISION DETAIL https://phabricator.kde.org/D249

D24923: Use more return early

crossi resigned from this revision. crossi added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > jgrulich wrote in networkmodel.cpp:402 > I think this is a valid Qt coding style, it was just my obsession to use > curly braces everywhere, even for single line b

D24923: Use more return early

nicolasfella added inline comments. INLINE COMMENTS > jgrulich wrote in networkmodel.cpp:402 > I think this is a valid Qt coding style, it was just my obsession to use > curly braces everywhere, even for single line body. As much as I hate it, crossi is right. https://community.kde.org/Policie

D24925: KCM KSplash port to ManagedConfigModule

davidedmundson added inline comments. INLINE COMMENTS > kcm.cpp:148 > +ManagedConfigModule::defaults(); > setNeedsSave(m_settings->isSaveNeeded()); > } doesn't managed module take care of this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24925 To:

D24923: Use more return early

This revision was automatically updated to reflect the committed changes. Closed by commit R116:c56f00b52786: Use more return early (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24923?vs=68689&id=68690 REV

D24924: Don't reset model when adding an active connection

nicolasfella updated this revision to Diff 68691. nicolasfella added a comment. - Only emit changed roles REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24924?vs=68681&id=68691 BRANCH updavail REVISION DETAIL https://phabricat

D24924: Don't reset model when adding an active connection

jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. Actually, I just checked our code and we use updateItem(item) function, which does the emitting and will clear the roles automatically. REPOSITORY R116 Plasma Network Manage

D24924: Don't reset model when adding an active connection

jgrulich added a comment. In D24924#553460 , @jgrulich wrote: > Actually, I just checked our code and we use updateItem(item) function, which does the emitting and will clear the roles automatically. Can you change it in other PRs too and

D24926: [ResultsView] Expose limit

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Lets the user of the view decide how many items they want TEST PLAN - Can have more than the de

D24925: KCM KSplash port to ManagedConfigModule

crossi added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:148 > doesn't managed module take care of this? it needs an explicit call, like load() and save() REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24925 To: crossi, #plasma, ervin, m

D24919: Don't reset model when device state changes

nicolasfella updated this revision to Diff 68693. nicolasfella added a comment. - Only emit changed roles REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24919?vs=68677&id=68693 BRANCH noreset2 REVISION DETAIL https://phabricat

D24926: [ResultsView] Expose limit

broulik closed this revision. broulik added a comment. https://cgit.kde.org/milou.git/commit/?id=eda3d274da1d502e61e24fa41f6b23b9f236baed REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D24926 To: broulik, #plasma, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-

D24853: [DigitalClock] Fix layout and QML warnings

ngraham added a comment. Fair enough, that seems reasonable. INLINE COMMENTS > configTimeZones.qml:58 > +Layout.fillWidth: true > +Layout.margins: 1 > Don't use hardcoded margins. This should be `Kirigami.Units.smallSpacing` REPOSITORY R120 Plasma Workspace REVISION DET

D24919: Don't reset model when device state changes

jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > networkmodel.cpp:829 > item->invalidateDetails(); > +int row = m_list.indexOf(item); > +Q_EMIT dataChanged(index(row, 0), index(ro

D24919: Don't reset model when device state changes

nicolasfella updated this revision to Diff 68694. nicolasfella added a comment. - Only emit changed roles - Use updateItem REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24919?vs=68693&id=68694 BRANCH noreset2 REVISION DETAIL

D24924: Don't reset model when adding an active connection

nicolasfella updated this revision to Diff 68695. nicolasfella added a comment. - Only emit changed roles - Use updateItem REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24924?vs=68691&id=68695 BRANCH updavail REVISION DETAIL

D24927: Use updateItem

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH uu REVISION DETAIL https://phabricator.kde

  1   2   >