D25807: Allow to set the available screen rect/region from outside through dbus

trmdi updated this revision to Diff 71488. trmdi added a comment. - Improve comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25807?vs=71408&id=71488 BRANCH add-otherShellHelper (branched from master) REVISION DETAIL https://phabricator.

D25889: Polish the "review this review" UI and presentation

ndavis added a comment. I don't find this better than the current form: F7817345: Screenshot_20191214_002245.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25889 To: ngraham, #vdg, apol, #discover_softwar

D24238: Port the pager applet away from QtWidgets

dfaure added a comment. Fix pushed https://commits.kde.org/plasma-desktop/2b5e86323f180f0c51ef9af898a69a522bc379ad after the bug reporter confirmed it fixes the bug. Reopening this after it was committed is a bit weird. I can't close it, please do. REPOSITORY R119 Plasma Desktop REV

D25973: Make the theme info QuickWidget transparent

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Shipit! Stable branch please. BTW, GridViewKCM, SimpleKCM, and ScrollViewKCM seem like they needs the same treatment, now that I'm navigating System Settings with the Oxygen style to

D25973: Make the theme info QuickWidget transparent

filipf updated this revision to Diff 71485. filipf added a comment. - downgrade Rectangle to Item since we don't need anything fancy anymore (good tip @ngraham) REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25973?vs=71484&id=71485

D25973: Make the theme info QuickWidget transparent

ngraham added a comment. Excellent solution. Question: do we even need a `Rectangle` at all if it's going to be transparent? Can it just be an `Item`? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D25973 To: filipf, #plasma, davidedmundson Cc

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ndavis added a comment. In D19890#577221 , @hpereiradacosta wrote: > Confused about 2: I thought icon size was the same for flat and non flat toolbuttons (see oxygen-demo5, buttons tab) Most normal buttons use 16px icons while flat butto

D25973: Make the theme info QuickWidget transparent

filipf updated this revision to Diff 71484. filipf added a comment. - remove old hack comment REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25973?vs=71483&id=71484 BRANCH transparent-quick-widget (branched from master) REVISION D

D25973: Make the theme info QuickWidget transparent

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY We're currently using an ugly hack in our main.qml file to make the QuickWidget that shows> The hack is not only ugly but totall

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ndavis added a comment. We could also do these things: - In Dolphin, mimic the back/forward buttons in Firefox/Chromium/Falkon by making the right click menu provide the history instead of the normal menu for manipulating the toolbar. Inconsistent with what we normally do, but not unexp

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

hpereiradacosta added a comment. In D19890#577204 , @ndavis wrote: > Ok, so there is an overlap problem, but it's quite rare. It happens when an icon uses 100% of the available space in the bottom right corner (or left with RTL, I think). > H

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham added a comment. I honestly think ignoring the problem is the best solution, because it's not even really a problem in practice: the vast, overwhelming majority of icons use correct margins, especially action icons which are going to be the ones used 99.9% of the time in buttons that

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ndavis added a comment. Ok, so there is an overlap problem, but it's quite rare. It happens when an icon uses 100% of the available space in the bottom right corner (or left with RTL, I think). Here I changed the stop icon in KDevelop to the icon for Codelite: F7817068: Screenshot_20191213

D25971: Use text color for "No preview image" text

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. clearly correct, stable branch please REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH text-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D25971 To

D25971: Use text color for "No preview image text"

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The text that shows up as the theme preview when no image preview is available was always just black. That's not great for dark

D25947: Add applet for controlling Night Color

ngraham added a comment. Thanks, that fixed it. I haven't noticed any shifting of the plasmoid in the system tray, but if you want to minimize that, you can add `X-Plasma-NotificationAreaCategory=SystemServices` to the `metadata.desktop` file. See D11352

D25947: Add applet for controlling Night Color

zzag updated this revision to Diff 71479. zzag added a comment. Revert applet visibility changes. Unfortunately, this may cause unnecessary shuffling of system tray items. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25947?vs=71477&id=71479 BR

D24238: Port the pager applet away from QtWidgets

dfaure added a comment. Further research leads to this possible patch http://www.davidfaure.fr/2019/windowmodel.cpp.diff REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24238 To: dfaure, hein, apol Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-De

D25947: Add applet for controlling Night Color

ngraham added a comment. Hmm, that last change broke clicking on the applet. Now it does nothing. +1 for the general ideal behind it though. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25947 To: zzag, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham added a comment. All right, if you're working on it, I won't bug you. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham, abetts, ndavis Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, jr

D25969: No longer vertically flip the shade icon when toggled

ngraham added subscribers: ndavis, ngraham. ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. @ndavis? REPOSITORY R31 Breeze BRANCH no-flip-for-shade-button REVISION DETAIL https://phabricator.kde.org/D25969 To: andykluger, #bree

D25970: [applet] Make details text fully opaque and normal style

ndavis accepted this revision. ndavis added a comment. +1 for readability REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D25970 To: ngraham, #vdg, jgrulich, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fba

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ndavis added a comment. In D19890#577135 , @ngraham wrote: > I'm not sure how to do that in the Breeze style here; can you show me? Ehh, I'm already working on it and figuring it out as I go. I have to move points in a vector around, whic

D25970: [applet] Make details text fully opaque and normal style

ngraham added a comment. Will do. I didn't even know they used the same style. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D25970 To: ngraham, #vdg, jgrulich Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D25970: [applet] Make details text fully opaque and normal style

broulik added a comment. Make sure that whatever you decide on is also applied to Bluetooth plasmoid REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D25970 To: ngraham, #vdg, jgrulich Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jra

D25970: [applet] Make details text fully opaque and normal style

ngraham created this revision. ngraham added reviewers: VDG, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. ngraham requested review of this revision. REVISION SUMMARY There isn't any need to make the labels bold

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ndavis added a comment. One problem I see with this is that the tops of the down arrows are a bit blurry. The way to fix that is to increase the size just enough that they fill the pixel. The bottom point should also have a MiterJoin so that it isn't a horizontal flat tip on high DPI screens

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham added a comment. I'm not sure how to do that in the Breeze style here; can you show me? REPOSITORY R31 Breeze BRANCH draw_small_arrow (branched from master) REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham, abetts Cc: ndavis, abetts, hperei

D25947: Add applet for controlling Night Color

zzag updated this revision to Diff 71477. zzag added a comment. Display the applet in the system tray when Night Color is inhibited. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25947?vs=71474&id=71477 BRANCH nightcolor-applet REVISION DETAIL

D25969: No longer vertically flip the shade icon when toggled

andykluger created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. andykluger requested review of this revision. REVISION SUMMARY Now that it gets color-inverted, there's no need to (and some say it should not) get flipped. As discussed in D14389

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

abetts accepted this revision. abetts added a comment. Love it! Move forward! REPOSITORY R31 Breeze BRANCH draw_small_arrow (branched from master) REVISION DETAIL https://phabricator.kde.org/D19890 To: hallas, #vdg, #breeze, ngraham, abetts Cc: abetts, hpereiradacosta, plasma-devel, L

D25947: Add applet for controlling Night Color

ngraham accepted this revision as: VDG. ngraham added a comment. UI and interactivity seems spot-on to me now. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25947 To: zzag, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampa

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

ngraham reopened this revision. ngraham added a comment. This revision is now accepted and ready to land. In retrospect, I think I reverted this too quickly in response to concerns. As expected, we have been receiving user complaints that the arrows in the corners of Dolphin's back and forwar

D25947: Add applet for controlling Night Color

zzag updated this revision to Diff 71474. zzag added a comment. Nate's suggestion. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25947?vs=71438&id=71474 BRANCH nightcolor-applet REVISION DETAIL https://phabricator.kde.org/D25947 AFFECTED FILES

D25967: Emit panelTakesFocus for other plamsashell types

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The semantics of a window taking focus on user interaction apply to more ro

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2a42a15cdf68: [KCMs/Night Color] Make activation criteria and times more obvious (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

filipf accepted this revision. filipf added a comment. Looks good. I just realized that maybe the message at the top could be an info inline message, but I see how that could be too much. REPOSITORY R119 Plasma Desktop BRANCH polish-nightcolor-ui (branched from master) REVISION DETAIL

D25947: Add applet for controlling Night Color

ngraham added a comment. This is fantastic! My on UI suggestion is to only the applet in the system tray (when using "Auto" visibility) only when Night Color is actually activated or activating. People who want it in their tray all the time can manually set it to "shown". The one exception w

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Don't require KWallet, and require KAccounts and libaccounts-Qt5 Link and use includes from new requirements Remove KWallet

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71461. ngraham added a comment. Address other VDG comments from chatroom (add time labels to main formlayout and align) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71460&id=71461 BRANCH polish-nig

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 314 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/314/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Dec 2019 17:14:35 + Build duration: 3 min 18 sec and counting CONSOLE OUTPUT [...truncated 26

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71460. ngraham added a comment. Address VDG review comments from here REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71430&id=71460 BRANCH polish-nightcolor-ui (branched from master) REVISION DETAIL

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham added a comment. In D25920#576966 , @abetts wrote: > Suggestions: > > "To reduce eye strain, Night Color makes the colors on the screen warmer at the time of your choosing" > > Change to: > > "Night Color makes the screen colo

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

abetts added a comment. Suggestions: "To reduce eye strain, Night Color makes the colors on the screen warmer at the time of your choosing" Change to: "Night Color makes the screen colors warmer to reduce eye strain" "Night color temperature" Change to: "Temperatu

D25940: Add support for custom display components to Action

This revision was automatically updated to reflect the committed changes. Closed by commit R169:22d31898ae0b: Add support for custom display components to Action (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25940?vs=71418&id=71459

D25844: Don't compress tasks before grouping, when task manager is vertical

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, now the bug and the fix are very clear! LGTM! @hein and/or #plasma people, what do you think? REVISION DETAIL https://phabricator.

D25959: [applets/taskmanager] Add highlight effect for hovered tooltip

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Looks better now, and matches the hover effect for the close button. TEST PLAN F781: de

D25936: [Desktop Containment] Hide tooltip while rotating the widget

This revision was automatically updated to reflect the committed changes. Closed by commit R119:115a3e1aeede: [Desktop Containment] Hide tooltip while rotating the widget (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25936?vs=714

D25932: [Task Manager] Better align badge in tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R119:67d86068d7f2: [Task Manager] Better align badge in tooltip (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25932?vs=71384&id=71455#toc REPOSITORY R119 Plasma Desktop C

D25944: Let the other components grow if there's more things on the header

This revision was automatically updated to reflect the committed changes. Closed by commit R169:3aa7f59f9ebe: Let the other components grow if there's more things on the header (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25944?vs=71422&

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 313 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/313/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 13 Dec 2019 14:44:04 + Build duration: 6 min 25 sec and counting CONSOLE OUTPUT [...truncated 26

D25950: Add specialized notification for Bluetooth battery

ngraham added a comment. Maybe this should be a critical notification? If it's your mouse or a device you're using to present with, that's not something you want to miss. :) REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D25950 To: broulik, #plasma, #vdg Cc: ngra

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

ngraham created this revision. ngraham added reviewers: Plasma, VDG, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The tooltip already stays open when you click on the close button, to allow you to clos

D25951: Show peripheral low battery notification for NoCharge

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BlueZ doesn't report charge state, only percentage, so it is unfortunately always `NoCharge` for

D25950: Add specialized notification for Bluetooth battery

broulik updated this revision to Diff 71439. broulik added a comment. - Drop odd parentheses REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25950?vs=71437&id=71439 REVISION DETAIL https://phabricator.kde.org/D25950 AFFECTED FILES daemon/powerdevilc

D25950: Add specialized notification for Bluetooth battery

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since we have a type for generic Bluetooth devices now, add a specialized notification for it

D25947: Add applet for controlling Night Color

zzag updated this revision to Diff 71438. zzag added a comment. Delete stray include. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25947?vs=71433&id=71438 BRANCH nightcolor-applet REVISION DETAIL https://phabricator.kde.org/D25947 AFFECTED FI

D25947: Add applet for controlling Night Color

zzag added a comment. This patch depends on D25946 and D25786 . REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25947 To: zzag, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jral

D25947: Add applet for controlling Night Color

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The new applet allows to temporarily disable Night Color, for example if one wants to edit a video or an

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71430. ngraham added a comment. Put the separator in the formlayout for more simplicity REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71429&id=71430 BRANCH polish-nightcolor-ui (branched from master)

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71429. ngraham added a comment. Restore original import order for timings view now that we don't need layouts anymore REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25920?vs=71428&id=71429 BRANCH polish-night

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71428. ngraham added a comment. Put the labels back in a FormLayout to align the times, but don't align the formlayout itself with the top one or else the whole thing is too far over to the left REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDAT

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham added a comment. This idea was to have a top-to-bottom flow. First you turn it on, then you select the activation mode, then you manipulate the controls specific to that mode (if applicable), then you see the times that result from those settings. I think it makes logical sense. If y

D25945: Sync dark theme preference for GTK3 applications

gikari created this revision. gikari added reviewers: apol, cblack, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Previously preference of dark GTK3 theme was set by checkbox in GTK KCM. Now, the che

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

romangg added a comment. Sorry, but I don't like how the text is "hanging in the air" and how it is jumping around when changing the setting. REPOSITORY R119 Plasma Desktop BRANCH polish-nightcolor-ui (branched from master) REVISION DETAIL https://phabricator.kde.org/D25920 To: ngrah

D25944: Let the other components grow if there's more things on the header

ngraham added a comment. Much better, this fixes the issue for me. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25944 To: apol, #kirigami Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mart, hein

D25942: Instead of just delaying, compress calls to update

apol abandoned this revision. apol added a comment. It was quite wrong REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25942 To: apol, #kirigami Cc: mart, ngraham, broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, hein

D25944: Let the other components grow if there's more things on the header

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D25944 AFFECTED FILES src/co

D25844: Don't compress tasks before grouping, when task manager is vertical

ngraham added a comment. I'm not sure how to reproduce the issue that this patch is fixing. Can you add more detail to the Test Plan section maybe? REVISION DETAIL https://phabricator.kde.org/D25844 To: gvgeo, #plasma, #vdg, hein Cc: davidedmundson, GB_2, ngraham, broulik, plasma-devel, Le

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

ngraham added a comment. In D25728#572362 , @manueljlin wrote: > I though that would just affect every app's titlebar without actually checking if the app has a toolbar, etc etc and just add/remove the divider everywhere and be done with it. Ho

D25943: Expose ActionToolBar's overflow button icon name

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This exposes the ActionToolBar overflow button's icon name as a property on ActionTool

D25920: [KCMs/Night Color] Make activation criteria and times more obvious

ngraham updated this revision to Diff 71419. ngraham added a comment. Polish everything even more to ensure a consistent top-to-bottom workflow. To do this I had to do a lot of refactoring that also has the side effect of making the UI a lot more declarative. REPOSITORY R119 Plasma Des

D25940: Add support for custom display components to Action

ahiemstra updated this revision to Diff 71418. ahiemstra added a comment. - Add missing @since REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25940?vs=71415&id=71418 BRANCH action_displaycomponent REVISION DETAIL https://phabricator.kde.org/D25940 A

D25942: Instead of just delaying, compress calls to update

mart added inline comments. INLINE COMMENTS > ActionToolBarLayoutDetails.qml:106 > +id: delayUpdate > +interval: 200 > +onTriggered: update() i suppose if the delay is 0 it starts to jump again? > broulik wrote in ActionToolBarLayoutDetails.qml:110 > How can this even wo

D25940: Add support for custom display components to Action

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > Action.qml:151 > + * A Component that should be preferred when displaying this Action. > + */ > +property Component displayComponent: null @since 2.12 @since 5.

D25942: Instead of just delaying, compress calls to update

ngraham added a comment. This does not actually fix the vibrating label for me. It's still going, as fast as ever: F7816236: Peek 2019-12-13 10-59.gif REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25942 To: apol, #kirigami

D25942: Instead of just delaying, compress calls to update

broulik added inline comments. INLINE COMMENTS > ActionToolBarLayoutDetails.qml:110 > + > +onWidthChanged: { delayUpdate.start = true } > +Component.onCompleted: { delayUpdate.start = true } How can this even work? `start` is a method. You probably meant `running = true`? or `start()` w

D25942: Instead of just delaying, compress calls to update

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Fixes an issue I was seeing where the size kept changing between updates. TEST PLAN Now the ActionTo

D25941: Add a page to display ActionToolBar and some of its features

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY ActionToolBar has gained quite a lot of functionality. So add a page to highlig

D25940: Add support for custom display components to Action

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a "displayComponent" property to Action, which allows specifying a component

D25908: Lock screen by default, on mobile

This revision was automatically updated to reflect the committed changes. Closed by commit R122:0f75d80f23e8: Lock screen by default, on mobile (authored by apol). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25908?vs=71320&id=71414 REVISION DETAIL htt

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

broulik updated this revision to Diff 71413. broulik added a comment. - Restore condition REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25917?vs=71412&id=71413 REVISION DETAIL https://phabricator.kde.org/D25917 AFFECTED FILES applets/notific

D25917: [Notifications] Show hint if notifications aren't available or provided by someone else

broulik updated this revision to Diff 71412. broulik added a comment. - Cleanup REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25917?vs=71350&id=71412 REVISION DETAIL https://phabricator.kde.org/D25917 AFFECTED FILES applets/notifications/pac