D26646: [Applet Configuration] Work around bad kerning in sidebar labels

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I added a test case to https://bugreports.qt.io/browse/QTBUG-49646, BTW. Maybe that will help the Qt folks find the source of the issue. REPOSITORY R119 Plasma Desktop BRANCH

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

ngraham added subscribers: davidedmundson, mart. ngraham added a comment. Yes you would need to add the margins by reducing the size of the minimum width. Since we found a reliable workaround, I wonder if we should just use that data to pinpoint the problem in Qt and fix it there...

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

filipf updated this revision to Diff 73474. filipf removed subscribers: mart, davidedmundson. filipf added a comment. - make it work with multi line strings - restore side margins REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26646?vs=73473=73474

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

filipf added a comment. Oops, looks like it breaks those smallSpacing margins as well: F7881860: image.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26646 To: filipf, #plasma, ngraham Cc: plasma-devel,

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This workaround breaks with multi-line strings: F7881852: Screenshot_20200113_164236.png REPOSITORY R119 Plasma Desktop REVISION

D22176: Rework system tray settings

ngraham added a comment. Oops. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plasma, #vdg Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY One way that https://bugreports.qt.io/browse/QTBUG-49646 manifests itself is when we have single line labels centered using

D22176: Rework system tray settings

kmaterka added a comment. @ngraham You commented in wrong revision, this was is abandoned :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plasma, #vdg Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n,

D26586: [SystemTray] Rework system tray settings

kmaterka updated this revision to Diff 73470. kmaterka added a comment. Fixes for column size, it is calculated dynamically now REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26586?vs=73414=73470 BRANCH master REVISION DETAIL

D26643: [windowsystem] Fix compilation with no-deprecated build of KWindowSystem

zzag added a comment. See D26633 REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D26643 To: zzag, #kwin Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26643: [windowsystem] Fix compilation with no-deprecated build of KWindowSystem

zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY This change ensures that kwayland-integration can be built with a version of KWS that doesn't have any

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

ngraham added inline comments. INLINE COMMENTS > colors.cpp:128 > > -const auto newEntries = m_newStuffDialog->installedEntries(); > -// If one new theme was installed, select the first color file > in it > -if (newEntries.count() == 1) { > -

D22176: Rework system tray settings

ngraham added inline comments. INLINE COMMENTS > ConfigGeneral.qml:23 > +import QtQuick 2.5 > +import QtQuick.Controls 1.4 as QQC1 > +import QtQuick.Controls 2.5 as QQC2 there are no longer any QQC1 items here; you can remove this import entirely > ConfigGeneral.qml:65 > +

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#593549 , @ngraham wrote: > The alignment for items with shortcuts is a bit odd: F7881593: Screenshot_20200113_130125.png Yes, I know. Shortcuts can be really

D26640: [applets/weather] Port weather station picker to QQC2+ListView

ngraham updated this revision to Diff 73464. ngraham added a comment. Re-add busy indicator REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26640?vs=73459=73464 BRANCH port-to-listview-in-scrollview (branched from master) REVISION DETAIL

D26636: [Widget Explorer] Work around bad kerning

filipf updated this revision to Diff 73463. filipf added a comment. don't repeat the same code twice REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26636?vs=73462=73463 BRANCH widget-explorer-kerning-fix (branched from master) REVISION DETAIL

D26636: [Widget Explorer] Work around bad kerning

filipf updated this revision to Diff 73462. filipf added a comment. remove added whitespace REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26636?vs=73447=73462 BRANCH widget-explorer-kerning-fix (branched from master) REVISION DETAIL

D26640: [applets/weather] Port weather station picker to QQC2+ListView

ngraham added a comment. For me it was instant after this patch. But I'll re-add it. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D26640 To: ngraham, #vdg, #plasma, broulik Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26640: [applets/weather] Port weather station picker to QQC2+ListView

fvogt added a comment. When I tested this, there was a very noticable delay (~10s) between starting the search and items appearing, so the busy indicator is IMO necessary. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D26640 To: ngraham, #vdg, #plasma,

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

This revision was automatically updated to reflect the committed changes. Closed by commit R31:3e9cd8d1e551: Make checkboxes/radiobuttons use Window Background in windows and View… (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D26640: [applets/weather] Port weather station picker to QQC2+ListView

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This fixes the bug I introduced when I fixed 414442 in the wrong way, makes the UI

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. In D26639#593537 , @ndavis wrote: > In D26572#593511 , @hpereiradacosta wrote:

D26271: [Applet]Update layout based on T10470

cfeck added a comment. The radio stream I use (via mpv) shows the interpret and title information for all titles it plays. Also, when mpv plays a local file, ttitle information about the file is added there. I don't use any other media streams, so I cannot comment on the general

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #49 from Rolf Eike Beer --- My battery is "gone" from the panel, so I started plasmoidviewer. It just shows a blank square, but when I click on it it shows the battery with 51%, which sounds plausible. When I click on the "empty" (= "no

D26627: Mark applications that play audio for small panels.

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM for short panels when using both an IOTM and a regular Task Manager. @broulik, you good with this now? REPOSITORY R119 Plasma Desktop BRANCH audiosize (branched from master)

D26586: [SystemTray] Rework system tray settings

ngraham added a comment. Ah, I see it now. The alignment for items with shortcuts is a bit odd: F7881593: Screenshot_20200113_130125.png Maybe for the combobox item texts, try this: - Shown when relevant - Always shown - Always hidden

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

ndavis updated this revision to Diff 73458. ndavis added a comment. Fix formatting REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26639?vs=73457=73458 BRANCH checkbox-radiobutton (branched from master) REVISION DETAIL https://phabricator.kde.org/D26639

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

ngraham accepted this revision as: VDG. ngraham added a comment. Visually +1, fixes the minor background color bug that came from the last commit. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26639 To: ndavis, #vdg, #breeze, hpereiradacosta, ngraham Cc:

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

ndavis added a comment. After this patch, should I remove `isSelectedItem()`? It's currently unused. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26639 To: ndavis, #vdg, #breeze, hpereiradacosta, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

ndavis added a comment. In D26572#593511 , @hpereiradacosta wrote: > > Otherwise, it should be Window Background. Doing it that way would preserve the original look in most cases. > > This would lead to some regression (I think) for

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REPOSITORY R31 Breeze BRANCH checkbox-radiobutton (branched from master) REVISION DETAIL

D26572: Always render checkbox/radiobutton background

hpereiradacosta added a comment. In D26572#593496 , @ndavis wrote: > What I meant is that I did not change the color of the checkbox background in this patch. I only made it so that the background would always be rendered. Clear enough.

D26572: Always render checkbox/radiobutton background

ndavis added a comment. What I meant is that I did not change the color of the checkbox background in this patch. I only made it so that the background would always be rendered. It seems like it might be a good idea to detect whether or not the button is being rendered in a view area

D26636: [Widget Explorer] Work around bad kerning

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY One way that https://bugreports.qt.io/browse/QTBUG-49646 manifests itself is when we have single line labels centered using

D26572: Always render checkbox/radiobutton background

hpereiradacosta added a comment. In D26572#593442 , @ndavis wrote: > In D26572#593379 , @hpereiradacosta wrote: > > > in more detail: imagine a color scheme where window background is black, window

D26572: Always render checkbox/radiobutton background

ndavis added a comment. In D26572#593379 , @hpereiradacosta wrote: > in more detail: imagine a color scheme where window background is black, window text is white, view background is white view text is black. > you will get a white square

D26531: [Wallpaper] Show author as subtitle in configuration

ngraham added a comment. Submitted a patch to fix it: D26634 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma, #vdg Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D26572: Always render checkbox/radiobutton background

hpereiradacosta added a comment. in more detail: imagine a color scheme where window background is black, window text is white, view background is white view text is black. you will get a white square on a white background for unchecked checkbox ... REPOSITORY R31 Breeze REVISION

D26572: Always render checkbox/radiobutton background

hpereiradacosta added a comment. I would strongly object to that: first that is a visual change unrelated to the issue this patch adress second this is semantically wrong, and this will break on some color theme. Things should be kept consistent. If you change the background role, you

D26621: [kstyle] Drop Qt 4 style plugin

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Seems we got the go-ahead from kde-distro-packagers ML so ++ After 5.18 forks please REPOSITORY R113 Oxygen Theme BRANCH port-to-shadows-api REVISION DETAIL

D26392: Add option to easily configure and start a hotspot

jgrulich updated this revision to Diff 73437. jgrulich marked an inline comment as done. jgrulich added a comment. Address review comments: 1. Add text to the toolbutton and make it checkable 2. Allow to create hotspot only if WiFi is available or it's not used as primary connection

D26530: ScrollView: Do not overlay scrollbars over contents

mart added a comment. ok for it, provided it still has overlay scrollbars on tablet mode INLINE COMMENTS > ScrollView.qml:47 > + > +readonly property bool _backgroundVisible: background && > background.visible > +readonly property real _verticalScrollBarWidth: >

D26392: Add option to easily configure and start a hotspot

apol added a comment. > What about allowing to create a hotspot if the WiFi is in use, but it's not used as primary connection (e.g. Ethernet or Mobile connections are used primarily). In that case the user wouldn't be without connection if we disconnect him. Surely. And if the laptop

D26632: Fix warning on ScrollablePage

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e2ebbe6f4ac9: Fix warning on ScrollablePage (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26632?vs=73431=73433 REVISION DETAIL

D26632: Fix warning on ScrollablePage

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY At the moment we'll be going through all of the children objects and reassigning the overlay as the

D26622: RFC: [Notifications] Raise application window if no default action is provided

ngraham added a comment. +1 conceptually. I think this is a nice default behavior for the apps that haven't implemented nicer behaviors themselves, or refuse to. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26622 To: broulik, #plasma, #vdg, hein, mart

D26631: [kstyle] Update blur region even if Breeze has no X11 support

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY KWindowEffects provides a platform-independent API for enabling blur, which requires neither Xlib nor

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73429. gikari added a comment. Replace themeUpdate redundant signal with direct load call. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73425=73429 BRANCH gtk-style-page REVISION DETAIL

D26530: ScrollView: Do not overlay scrollbars over contents

ahiemstra added a comment. Also, just want to reiterate that I actually don't really care about how things look, what I care about is the amount of workarounds that are introduced by the scrollbar behaviour as it is. One current example is D26586 but I

D26583: [Application Style] Add GTK Application Style Page

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Visually and behaviorally, this is great. Probably needs a #plasma review too. REPOSITORY R119 Plasma Desktop BRANCH gtk-style-page

D26630: Fix warning

This revision was automatically updated to reflect the committed changes. Closed by commit R169:ec3b2d53d853: Fix warning (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26630?vs=73422=73427 REVISION DETAIL

D26628: Specify where the code is coming from as the URL

This revision was automatically updated to reflect the committed changes. Closed by commit R169:dee14718ceb4: Specify where the code is coming from as the URL (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26628?vs=73424=73426 REVISION

D26628: Specify where the code is coming from as the URL

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. <3 REPOSITORY R169 Kirigami BRANCH arcpatch-D26628 REVISION DETAIL https://phabricator.kde.org/D26628 To: apol, #kirigami, mart Cc: mart, plasma-devel, fbampaloukas, GB_2, domson,

D26628: Specify where the code is coming from as the URL

apol updated this revision to Diff 73424. apol added a comment. consistency REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26628?vs=73420=73424 BRANCH arcpatch-D26628 REVISION DETAIL https://phabricator.kde.org/D26628 AFFECTED FILES

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73425. gikari added a comment. Undo previous hasty decision REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73390=73425 BRANCH gtk-style-page REVISION DETAIL https://phabricator.kde.org/D26583

D26630: Fix warning

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY columnview.cpp:7: TypeError: Cannot read property 'contentX' of null TEST PLAN Used to get it all

D26628: Specify where the code is coming from as the URL

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Makes it much simpler to see where warnings are coming from if we get to see a file name. TEST PLAN

D26530: ScrollView: Do not overlay scrollbars over contents

ahiemstra added a comment. > yes, i'm saying that the patch besides putting the separation in the frame, it also reintroduces the frame by default, which is unrelated (and i think it should be avoided) The patch as-is does not, what you see is the default scrollview background that I

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top of its category

broulik updated this revision to Diff 73419. broulik retitled this revision from "[Notifications KCM] Move Plasma Workspace "service" to the top" to "[Notifications KCM] Move Plasma Workspace "service" to the top of its category". broulik edited the summary of this revision. broulik edited the

D22382: Add global shortcuts for switching to the previous/next activity

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1d6b5376eaa7: Add global shortcuts for switching to the previous/next activity (authored by muesli). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26572: Always render checkbox/radiobutton background

ndavis added a comment. Oh, I should have brought this up before landing, but any opinions about always using `QPalette::Base` (View Background) for the background color? I asked on the VDG channel and people seemed to be unanimously in favor of using View Background as the background

D26572: Always render checkbox/radiobutton background

This revision was automatically updated to reflect the committed changes. Closed by commit R31:98781f18df86: Always render checkbox/radiobutton background (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26572?vs=73234=73417 REVISION DETAIL

D26572: Always render checkbox/radiobutton background

hpereiradacosta accepted this revision. hpereiradacosta added a comment. ship it. No strong feeling. REPOSITORY R31 Breeze BRANCH checkbox-radiobutton-background (branched from master) REVISION DETAIL https://phabricator.kde.org/D26572 To: ndavis, #vdg, #breeze, #plasma,

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

ngraham accepted this revision. ngraham added a comment. Lovely. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26506 To: broulik, #plasma, #vdg, mart, ngraham Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

aleksejshilin added a comment. In D26582#592469 , @meven wrote: > We may want to change KRun::runUrl when a native binary is to be run but with runExecutable is false, around line 400: > > } else if (isNativeBinary) { > // Show

D22382: Add global shortcuts for switching to the previous/next activity

ngraham accepted this revision. ngraham added a comment. I think so! REPOSITORY R120 Plasma Workspace BRANCH shortcut-prevnext-activity (branched from master) REVISION DETAIL https://phabricator.kde.org/D22382 To: muesli, apol, davidedmundson, #vdg, #plasma, ngraham Cc: ngraham,

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. @mart @ngraham I see heated discussion in D26530 . What should I do with scrollbars? I can change it to something like this: F7880950: image.png REPOSITORY R120 Plasma Workspace

D26624: [Workspace Behavior KCM] Add "animation speed" keyword

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6f1de8e8f0d3: [Workspace Behavior KCM] Add animation speed keyword (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26586: [SystemTray] Rework system tray settings

kmaterka updated this revision to Diff 73414. kmaterka added a comment. Removed feature that allowed to hide whole category. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26586?vs=73395=73414 BRANCH master REVISION DETAIL

D25925: Mark applications that play audio, for all task icon sizes

gvgeo marked an inline comment as done. gvgeo added a comment. D26627 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25925 To: gvgeo, #vdg, #plasma, ndavis, ngraham, hein Cc: broulik, plasma-devel, hein, ngraham,

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#593154 , @ngraham wrote: > There are no sections and everything's disabled. Hmm, there is one small change in the C++ model (category added), maybe you need to restart/logout so that C++ library is

D22382: Add global shortcuts for switching to the previous/next activity

muesli added a comment. Alright, I think this looks sane again. @ngraham Mind if I land this in its current state? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22382 To: muesli, apol, davidedmundson, #vdg, #plasma Cc: ngraham, romangg, ivan,

D26627: Mark applications that play audio for small panels.

gvgeo added a comment. I was not so fond of limiting when small, but was trying to avoid this. F7880898: Screenshot_20200113_163105.png Didn't notice that for classic panel is more visible at the same size. F7880901: Screenshot_20200113_163136.png

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. In D26530#593152 , @mart wrote: > yes, i'm saying that the patch besides putting the separation in the frame, it also reintroduces the frame by default, which is unrelated (and i think it should be avoided)

D26627: Mark applications that play audio for small panels.

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, hein, ngraham, broulik. gvgeo added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Don't limit audio playing indicator. Display icon even if tasks are too

D26586: [SystemTray] Rework system tray settings

ngraham added a comment. When I try this out, here's what I see: F7880888: Screenshot_20200113_072934.png There are no sections and everything's disabled. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26586

D26530: ScrollView: Do not overlay scrollbars over contents

mart added a comment. i'm giving a try to give breeze qstyle that look, then we can revisit this REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D26530 To: ahiemstra, #plasma, #goal_consistency, mart Cc: kmaterka, mart, ndavis, IlyaBizyaev,

D26530: ScrollView: Do not overlay scrollbars over contents

mart added a comment. In D26530#593123 , @ngraham wrote: > In D26530#592999 , @mart wrote: > > > It would already be much better if the track was actually very visible, visually delimiting the space

D22382: Add global shortcuts for switching to the previous/next activity

muesli updated this revision to Diff 73412. muesli added a comment. Hopefully fix phabricator getting out of sync with the changeset. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22382?vs=73354=73412 BRANCH shortcut-prevnext-activity

D26565: KCM/Component Revamp email config

ngraham added a comment. In D26565#592891 , @meven wrote: > It means we will need to write .desktop file on the fly which KOpenWithDialog can do. > Do we want the previously entered commands to appear in the list ? I think so. We

D26392: Add option to easily configure and start a hotspot

ngraham added a comment. If we use an icons-only button/checkbox, then this can't go in without the icon, which means it's deferred to Plasma 5.19. There's still (barely) time to get it into 5.18 if we make sure that we use a UI that has both icons and text. REPOSITORY R116 Plasma Network

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. In D26586#593114 , @mart wrote: > fine for me too. OK, I will remove this feature. INLINE COMMENTS > mart wrote in ConfigEntries.qml:114 > this should never be necessary and will probably cause bugs. > It looks

D26572: Always render checkbox/radiobutton background

ngraham accepted this revision as: VDG, ngraham. ngraham added a comment. This revision is now accepted and ready to land. Purely in terms of visuals, I think so. It clearly fixes a bug. REPOSITORY R31 Breeze BRANCH checkbox-radiobutton-background (branched from master) REVISION DETAIL

D26586: [SystemTray] Rework system tray settings

ngraham added a comment. In D26586#593114 , @mart wrote: > the reason for it in the beginning was t just be able to say "i don't want normal apps to be able to spam my systray" tough probably things aren't categorize well enough to be able to

D26531: [Wallpaper] Show author as subtitle in configuration

ngraham added a comment. I'll look into it, yeah. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma, #vdg Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26530: ScrollView: Do not overlay scrollbars over contents

ngraham added a comment. In D26530#592999 , @mart wrote: > It would already be much better if the track was actually very visible, visually delimiting the space > F7880630: image.png I think it

D26586: [SystemTray] Rework system tray settings

mart added a comment. on the code side, i have mainly only one gripe INLINE COMMENTS > ConfigEntries.qml:114 > +Layout.fillHeight: true > +QQC2.ScrollBar.vertical: scrollView.QQC2.ScrollBar.vertical // > For Kirigami.AbstractListItem > this should never be

D26271: [Applet]Update layout based on T10470

ndavis added a subscriber: cfeck. ndavis added a comment. Since it's @cfeck's bug report, I'll add him to the subscribers. REPOSITORY R115 Plasma Audio Volume Applet BRANCH layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D26271 To: gvgeo, #vdg, #plasma,

D26271: [Applet]Update layout based on T10470

ndavis added a comment. In D26271#593013 , @gvgeo wrote: > Found this request to display the name of the stream https://bugs.kde.org/show_bug.cgi?id=409453 . > Which was done, but remove here. Maybe should leave it too? > With a quick

D26586: [SystemTray] Rework system tray settings

mart added a comment. In D26586#593025 , @kmaterka wrote: > Final decision: should I remove feature which allows to hide whole category? fine for me too. the reason for it in the beginning was t just be able to say "i don't want normal

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir updated this revision to Diff 73409. leinir added a comment. As discussed above, we need to be able to build against an older version of Frameworks than 5.67. As such, wrap up the bits that aren't available before then in some compile-time checks. - Wrap the new requirements up

D26624: [Workspace Behavior KCM] Add "animation speed" keyword

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since that's where the animation speed slider is now in REPOSITORY R119 Plasma Desktop

D25925: Mark applications that play audio, for all task icon sizes

broulik added inline comments. INLINE COMMENTS > AudioStream.qml:92 > +// Do not display the indicator if the icons are too small. > +visible: opacity > 0 && Math.min(iconBox.width, iconBox.height) >= > units.iconSizes.small > This breaks displaying the icon on small panels like

D24192: WIP: Active page follow the focus

mart added a comment. any update on it? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24192 To: ognarb, #kirigami, #plasma_accessibility Cc: broulik, mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, hein

D26531: [Wallpaper] Show author as subtitle in configuration

mart added a comment. In D26531#592814 , @broulik wrote: > > can you look into that? > > Perhaps @ngraham can. In any case, if this were fixed, it would not make it for 5.18. no biggie. let's put it in as soon as the new cycle starts

D26622: RFC: [Notifications] Raise application window if no default action is provided

broulik created this revision. broulik added reviewers: Plasma, VDG, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 416107 TEST PLAN - Clicked Thunderbird notification, got Thunderbird window

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added inline comments. INLINE COMMENTS > davidedmundson wrote in main.cpp:254 > FWIW, there is an alternative approach that we do in plasma-workspace > (shell/containmentconfigview.cpp) for reloading wallpapers types. > > kpackage emits a DBus signal when it performs an action, models

D26120: [Wizard] Show notification instead of finished page when pairing succeeds

This revision was automatically updated to reflect the committed changes. Closed by commit R97:5101d7902f9f: [Wizard] Show notification instead of finished page when pairing succeeds (authored by broulik). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE

D25860: [plasmoid] Show device battery percentage

This revision was automatically updated to reflect the committed changes. Closed by commit R97:3686a5acf6cf: [plasmoid] Show device battery percentage (authored by broulik). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25860?vs=71216=73397 REVISION DETAIL

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. Final decision: should I remove feature which allows to hide whole category? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26586 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham Cc: meven, nicolasfella,

  1   2   >