D27470: Set good default value for cursor theme and size in KRDB

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ca9f0eeb9b53: Set good default value for cursor theme and size in KRDB (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27470?vs=75892&id=

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi added a comment. In D27329#611907 , @mvourlakos wrote: > In D27329#611906 , @trmdi wrote: > > > How about this? > > F8104781: image.png > > > You

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

trmdi updated this revision to Diff 75959. trmdi added a comment. - Increase the height a bit more, the last effort. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27329?vs=75486&id=75959 BRANCH adjust-size-of-tooltip (branched from master) REVIS

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 266 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/266/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Feb 2020 23:37:10 + Build duration: 7 min 0 sec and counting JUnit Tests Na

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 59 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/59/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Feb 2020 23:37:14 + Build duration: 1 min 50 sec and counting JUnit Tests Na

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/36/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 18 Feb 2020 23:37:15 + Build duration: 1 min 52 sec and counting JUnit Tests

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 100 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/100/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Feb 2020 23:37:08 + Build duration: 1 min 40 sec and counting JUnit Tests N

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 53 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/53/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Feb 2020 23:37:09 + Build duration: 1 min 42 sec and counting JUnit Tests Name:

D27462: Include comment for translators for Power Down

This revision was automatically updated to reflect the committed changes. Closed by commit R122:6d063a82ca2a: Include comment for translators for Power Down (authored by apol). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27462?vs=75836&id=75947 REVISION

D27422: [KCM]Update Device item layout based on applet

davidedmundson added inline comments. INLINE COMMENTS > DeviceListItem.qml:32 > id: delegate > +spacing: units.smallSpacing * 2 > width: parent.width Kirigami.Units.smallSpacing please (for all units in KCM code) again, for complex reasons, sorry. > DeviceListItem.qml:106 > +

D27422: [KCM]Update Device item layout based on applet

ngraham added a comment. You might be hitting https://bugs.kde.org/show_bug.cgi?id=356446 REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 To: gvgeo, #plasma, drosca, ngraham, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Fe

Plasma 5.18.1

Plasma 5.18.1 is now released https://www.kde.org/announcements/plasma-5.18.1.php

Re: 2 kirigami fixes for a point release

On 2/18/20 1:37 PM, Albert Astals Cid wrote: I still don't see why this is a problem, as said Plasma depends on a myriad of libraries that are building each with their own release model, most probably with no bugfix releases at all either. The "we don't control the whole stack" argument does

Re: 2 kirigami fixes for a point release

On 2/18/20 2:13 PM, Luca Beltrame wrote: In data martedì 18 febbraio 2020 19:26:21 CET, Nate Graham ha scritto: Neon is already an OS, whether or not you want to admit it. It's installed from an ISO. A hardware vendor (Slimbook) is shipping it on Erm, where did I say that in my reply? ;)

Re: 2 kirigami fixes for a point release

In data martedì 18 febbraio 2020 19:26:21 CET, Nate Graham ha scritto: > Neon is already an OS, whether or not you want to admit it. It's > installed from an ISO. A hardware vendor (Slimbook) is shipping it on Erm, where did I say that in my reply? ;) I merely say that going "Neon or else unsup

D27462: Include comment for translators for Power Down

aacid added a comment. i think it's better than nothing yes REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D27462 To: apol, broulik, aacid Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen

Re: 2 kirigami fixes for a point release

El dimarts, 18 de febrer de 2020, a les 4:03:05 CET, Nate Graham va escriure: > On 2020-02-16 14:43, Albert Astals Cid wrote: > > Maybe i explain myself wrongly, i'm not blaming distros at all. > > > > They made a decision, we/I may agree with them or not, that's *my/our* > > problem, what I was

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. Although this is a general problem, just to be clear. Without Plasma Components I don't get any scaling. F8111566: Screenshot_20200218_214017.png REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports2 REVISION DETAIL

D27316: [Folder view]Make shadow scale aware

gvgeo added a comment. It was more of a general question... Anyway I tried, nothing happens. I Believe it uses the qmlc files. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27316 To: gvgeo, #plasma, #vdg, apol, ngraham, davidedmundson Cc: davidedmundson

D27316: [Folder view]Make shadow scale aware

davidedmundson added a comment. I don't know You can find ./qml/QtGraphicalEffects/private/DropShadowBase.qml somewhere in /usr on your local system, add in some console.log lines and see what's happening. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabri

D27316: [Folder view]Make shadow scale aware

gvgeo added a comment. I use arch's Qt 5.14.1 Any chance I only have this problem? My build is not exactly stable. Btw found some places that use radius spallSpacing or gridUnit, like knewstuff. I wonder how that look, with that commit. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27316: [Folder view]Make shadow scale aware

davidedmundson added a comment. That commit has been there since 5.12.5 So I imagine you have it on your system. It's possible it doesn't work correctly, but it needs some investigation. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27316 To: gvgeo,

D27316: [Folder view]Make shadow scale aware

davidedmundson added a comment. See https://code.qt.io/cgit/qt/qtgraphicaleffects.git/commit/src/effects/private/DropShadowBase.qml?id=f9664053132affe48a069235eb6561a32d38b2a7 You're about double it twice REPOSITORY R119 Plasma Desktop BRANCH shadow2 (branched from master) REVISION

Re: 2 kirigami fixes for a point release

> > IMHO distributions using Plasma LTS, Plasma team & other stakeholders should > > team up here and maintain a matching LTS branch of Frameworks together at > > the > > central KDE repos together. Well, and a version also satisfying other > > clients > > of KF, like non-workspace applications f

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

ngraham added a comment. One would expect that, yes. But one would be expecting too much of Phabricator. :) REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D27362 To: jakobkummerow, davidedmundson, ahiemstra Cc: ngraham, ahiemstra, cfeck, plasma-devel, Orage, LeGas

D27316: [Folder view]Make shadow scale aware

ngraham accepted this revision. ngraham added a comment. So I guess we do need to do this in all places where we use drop shadows, urgh. Any chance you'd be interested in tackling that, @gvgeo? As for this patch, seems like a candidate for the stable branch. REPOSITORY R119 Plasma

D27408: Fix build with Qt 5.15.0

ngraham added a comment. Yes I at least look at all new patches for Plasma, Frameworks, and many KDE apps. If I'm capable of reviewing them, I do. If not, I try to add people to the reviewers list who I think can, if they're not already marked as reviewers. We can add you as a reviewer f

D27408: Fix build with Qt 5.15.0

mlaurent added a comment. So you review all patch from all repo ? :) awesome ! I am not able to do it! And I don't want to do it otherwise no possible to work on my projects. But I am happy that you do it ! :) So for sure I will not review all patchs from framework/plasma, but I am not

Re: 2 kirigami fixes for a point release

On 2/16/20 2:55 PM, Friedrich W. H. Kossebau wrote: Yes, this has been questioned a few times. Also seeing Plasma LTS used together with a non-LTS Qt is a bit strange. But somehow it seems there has not been enough pain for those using the Plasma LTS to change something. Possibly because distribu

Re: How to close PMC?

What is PMC? Plasma Media Center? Something else? Nate On 2/15/20 4:47 AM, Peter Lorenz wrote: Hi all, I' wondering: How do I close the PMC? I can't find anything to do this. I am running PMC on a laptop with arch linux. And have always the newest builds installed. It seems, all I can do i

Re: 2 kirigami fixes for a point release

On 2/16/20 2:55 PM, Friedrich W. H. Kossebau wrote: Yes, this has been questioned a few times. Also seeing Plasma LTS used together with a non-LTS Qt is a bit strange. But somehow it seems there has not been enough pain for those using the Plasma LTS to change something. Possibly because distribu

Re: 2 kirigami fixes for a point release

On 2/17/20 11:08 PM, Luca Beltrame wrote: In data martedì 18 febbraio 2020 04:03:05 CET, Nate Graham ha scritto: think KDE software should be presented to users. Basically, we acknowledge that Neon is already an actual OS--the "KDE OS"--and we Please don't suggest such downstream-hostile solu

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 75935. gvgeo added a comment. More style fixes. (indentation restore) REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=75820&id=75935 BRANCH kcmports2 REVISION DETAIL https://phabricator.kd

D27316: [Folder view]Make shadow scale aware

gvgeo added inline comments. INLINE COMMENTS > FolderItemDelegate.qml:435 > +radius: Math.round(5 * units.devicePixelRatio) > +samples: radius * 2 + 1 > spread: 0.05 And I ate the "one" `Ideally, this value should be twice

D27316: [Folder view]Make shadow scale aware

gvgeo added inline comments. INLINE COMMENTS > FolderItemDelegate.qml:435 > +radius: Math.round(5 * units.devicePixelRatio) > +samples: radius * 2 + 1 > spread: 0.05 https://doc.qt.io/qt-5/qml-qtgraphicaleffects-dropshadow.

D27316: [Folder view]Make shadow scale aware

apol added a comment. +1 patch makes sense to me INLINE COMMENTS > FolderItemDelegate.qml:435 > +radius: Math.round(5 * units.devicePixelRatio) > +samples: radius * 2 + 1 > spread: 0.05 Why's the + 1? REPOSITORY R119

D27482: Update kdeglobals config file for Breeze widgetStyle

ngraham added a comment. In D27482#613714 , @crossi wrote: > In D27482#613699 , @ngraham wrote: > > > How do I trigger this to get run? Restarting plasmashell or opening the Style KCM didn't seem to

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added a comment. This fix the issue for Breeze theme, but according to bug description (https://bugs.kde.org/show_bug.cgi?id=417515) some configuration file may also have `oxygen` instead of `Oxygen` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2748

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added a comment. In D27482#613699 , @ngraham wrote: > How do I trigger this to get run? Restarting plasmashell or opening the Style KCM didn't seem to do it. To run the update script, just apply the patch and rebuild plasma-desktop

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks like a sane clean-up to me. #konsole and.or #plasma folks? REPOSITORY R114 Plasma Addons BRA

D27088: [applets/SystemTray] Implement sorting in the model

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. The role names part is nice. I have one major-ish comment, and 2 pendantic comments that I don't really care about. INLINE COMMENTS > sortedsystemtraymodel.c

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch please. :) Oh and the syntax is `BUG: 397595` (note the colon) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27483 To: crossi, ervin,

D27482: Update kdeglobals config file for Breeze widgetStyle

ngraham added a comment. How do I trigger this to get run? Restarting plasmashell or opening the Style KCM didn't seem to do it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27482 To: crossi, ngraham, ervin, bport, meven, #plasma Cc: plasma-devel, Orage, L

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

crossi updated this revision to Diff 75933. crossi added a comment. restore blank line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27483?vs=75932&id=75933 REVISION DETAIL https://phabricator.kde.org/D27483 AFFECTED FILES kcms/lookandfeel/kcm

D27481: [WIP]Panel spacer that can center things

ngraham added a comment. Super cool feature! This was one of the things I was missing for D24223 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27481 To: mart, #plasma, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27408: Fix build with Qt 5.15.0

ngraham added a comment. In D27408#613637 , @mlaurent wrote: > no each reviews but when you create a patch for qt5.15 as I was the only dev which worked on qt5.15 it was logical to add me. > I will not subscribe for each commit in plasma/frame

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY BUG 397595 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27483 AFFECTED FILES kcms/lookandfeel/

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Following D27407 provide kconf update script to fix user configuration for widgetStyle when Bree

D27422: [KCM]Update Device item layout based on applet

ngraham added a comment. You're welcome! REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 To: gvgeo, #plasma, drosca, ngraham, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalouk

D26806: [Applets/Power Manager] Update layout based on T10470

ngraham added a comment. We're waiting for @davidedmundson to re-review it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeG

D27316: [Folder view]Make shadow scale aware

ngraham added a comment. I don't know enough to say whether it makes sense to fix this here, or in Qt. I'd like a #plasma or maybe #kwin person to weigh in. REPOSITORY R119 Plasma Desktop REVISION DETAIL h

D27316: [Folder view]Make shadow scale aware

gvgeo added a comment. Can I close this patch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27316 To: gvgeo, #plasma, #vdg Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexey

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo added a comment. Is there any problem with this patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeGast00n, The-Fer

D27470: Set good default value for cursor theme and size in KRDB

ngraham added a comment. Can you run `arc amend` on your local branch to pick up the changes I just made to the description, and then land this on the stable branch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27470 To: bport, #plasma, broulik, ervin, mev

D27422: [KCM]Update Device item layout based on applet

gvgeo added a comment. Thanks Nate, both for explaining and taking care of the patches yesterday. REPOSITORY R115 Plasma Audio Volume Applet BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.org/D27422 To: gvgeo, #plasma, drosca, ngraham, #vdg Cc: plasma-devel, Orage, LeGast00n

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

alex updated this revision to Diff 75930. alex added a comment. Rebase patch as requested REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27098?vs=75724&id=75930 BRANCH konsole_bugfix (branched from master) REVISION DETAIL https://phabricator.kde

D27408: Fix build with Qt 5.15.0

mlaurent added a comment. no each reviews but when you create a patch for qt5.15 as I was the only dev which worked on qt5.15 it was logical to add me. I will not subscribe for each commit in plasma/framework, for sure after 20-30 commits I will not read them. I have ~ 200 mails by days, so

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

ngraham added a comment. Can you rebase this patch now? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27098 To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, za

D27365: fix condition in KonsoleProfiles::run

This revision was automatically updated to reflect the committed changes. Closed by commit R114:f0431c95a895: fix condition in KonsoleProfiles::run (authored by McPain, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27365?vs=75596&

D27365: fix condition in KonsoleProfiles::run

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks for your patch @alex. However since this is a targeted bugfix, I would like to land it now on the stable branch. Since your patch includes refactoring, it needs to go into the next

D27367: fix activity runner

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2a979a4bbebe: fix activity runner (authored by McPain, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27367?vs=75900&id=75928 REVIS

D27408: Fix build with Qt 5.15.0

apol added a comment. In D27408#613598 , @mlaurent wrote: > Just a question: How I can see it if nobody adds me as reviewer (if I remember I was the only one guys who works against qt5.15 from several months so why don't add me as reviewer ? )?

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven updated this revision to Diff 75926. meven added a comment. Make validLastCurrentIndex const, newline before { REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27395?vs=75920&id=75926 BRANCH arcpatch-D27395 REVISION DETAIL https://phabricat

D27481: [WIP]Panel spacer that can center things

mart added a comment. Implementation-wise could make sense for the implementation be in the panel itself, tough it may be difficult to control from the external panel configuration tool Usability-wise i think would be fine if the first spacer is added at the end of the panel, and the se

D27481: [WIP]Panel spacer that can center things

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY - Make the panel spacer take a lot more space when is in expanding mode, so much to "win" against

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

anthonyfieroni added inline comments. INLINE COMMENTS > componentchooser.h:51 > > +int validLastCurrentIndex() { > +// m_currentIndex == -1 means there are no previously saved value { in new line, add const REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kd

D27408: Fix build with Qt 5.15.0

mlaurent added a comment. In D27408#613565 , @ngraham wrote: > @mlaurent ^^ Just a question: How I can see it if nobody adds me as reviewer (if I remember I was the only one guys who works against qt5.15 from several months so why don't

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > meven wrote in DeviceAutomounterKCM.cpp:57 > Just waiting for this review then, I am preparing the next patch D27480 REPOSITORY R119 Plasma Desktop REVISION DETAIL ht

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

meven created this revision. meven added reviewers: ervin, crossi, bport, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Depends on D27127 REPOSITORY R119 Plasma De

D27470: Set good default value for cursor theme and size in KRDB

ngraham added a comment. This probably fixes at least one of these: - https://bugs.kde.org/show_bug.cgi?id=385920 - https://bugs.kde.org/show_bug.cgi?id=413783 - https://bugs.kde.org/show_bug.cgi?id=382604 - https://bugs.kde.org/show_bug.cgi?id=414109 REPOSITORY R119 Plasma Deskto

D27408: Fix build with Qt 5.15.0

ngraham added subscribers: mlaurent, ngraham. ngraham added a comment. @mlaurent ^^ REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D27408 To: apol, #plasma Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh

D27457: Move kcminit_startup and kded to plasma-session

apol added a comment. Both the isServiceRegistered and the env changes make sense to me. INLINE COMMENTS > startup.cpp:232 > connect(loginSound, &NotificationThread::finished, loginSound, > &NotificationThread::deleteLater); > loginSound->start();}); > Unrelated change.

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven marked 4 inline comments as done. meven added inline comments. INLINE COMMENTS > ervin wrote in DeviceAutomounterKCM.cpp:57 > Sure, moving away from a singleton is always intrusive (just like moving away > from a global variable which it is really). Let's aim for it in a different > speci

D27411: Port away from deprecated API

apol abandoned this revision. apol added a subscriber: mlaurent. apol added a comment. @mlaurent did the same but he doesn't put his patches through review. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D27411 To: apol, jgrulich C

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

ngraham accepted this revision. ngraham added a reviewer: Plasma. ngraham added a comment. This revision is now accepted and ready to land. LGTM. #plasma folks, is this all technically correct? REPOSITORY R120 Plasma Workspace BRANCH D27465 (bran

D27358: Sync ("Wayland") appending to match SDDM

fvogt added a comment. Note that this behaviour of sddm is not in any release yet - only in git. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27358 To: davidedmundson, #plasma, ngraham Cc: fvogt, ngraham, plasma-devel, Orage, LeGast00n, The-

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

meven updated this revision to Diff 75920. meven marked 2 inline comments as done. meven added a comment. Add a validLastCurrentIndex function, check emailClientService is not null before using it REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27395

D27424: Add missing cursors for Chromium-based apps

guilhermesilva added a comment. Absolutely! Thank you very much. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27424 To: guilhermesilva, #breeze, broulik, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27408: Fix build with Qt 5.15.0

apol abandoned this revision. apol added a comment. Abandoned because @lmontel just commits changes instead of reviewing other people's patches. :( REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D27408 To: apol, #plasma Cc: plasma-devel, Orage,

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 75913. The-Feren-OS-Dev added a comment. Updated diff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75912&id=75913 BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 AFFECTED FILES

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 75912. The-Feren-OS-Dev added a comment. Updated diff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75873&id=75912 BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 AFFECTED FILES

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

The-Feren-OS-Dev updated this revision to Diff 75911. The-Feren-OS-Dev marked an inline comment as done. The-Feren-OS-Dev added a comment. Moved baseSize declaration and changed it to a standard variable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D27407: Breeze widgetStyle value is Breeze

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c7c190488e46: Breeze widgetStyle value is Breeze (authored by crossi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27407?vs=75699&id=75909 REVISION DET

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 265 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/265/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Feb 2020 12:50:28 + Build duration: 11 min and counting CONSOLE OUTPUT [...

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 99 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/99/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Feb 2020 12:43:47 + Build duration: 15 min and counting CONSOLE OUTPUT [...t

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 52 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/52/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Feb 2020 12:43:33 + Build duration: 14 min and counting CONSOLE OUTPUT [...trunc

D27457: Move kcminit_startup and kded to plasma-session

davidedmundson updated this revision to Diff 75908. davidedmundson added a comment. rebase and squash changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27457?vs=75901&id=75908 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27

D27472: [plasma-session] Cleanup StartServiceJob

davidedmundson abandoned this revision. davidedmundson added a comment. Turns out this is fixing up something that changed in the non-merged patch. I may as well squash it there. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27472 To: davidedmundson,

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 264 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/264/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Feb 2020 12:41:21 + Build duration: 8 min 57 sec and counting CONSOLE OUTPUT

D27471: [plasma-session] Avoid potential race condition starting a service

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in startup.cpp:429 > Could probably use an `m_service.isEmpty()` check since it will still > needlessly do a `NameHasOwner` call All usages of this class (which is just the 1 case to start ksmserver!) have a name passed. Wi

D27471: [plasma-session] Avoid potential race condition starting a service

broulik added inline comments. INLINE COMMENTS > startup.cpp:429 > { > +if > (QDBusConnection::sessionBus().interface()->isServiceRegistered(m_serviceId)) > { > +qCDebug(PLASMA_SESSION) << m_process << "already running"; Could probably use an `m_service.isEmpty()` check since it w

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 35 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/35/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 18 Feb 2020 12:38:29 + Build duration: 4 min 9 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/4/ Project: stable-kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 18 Feb 2020 12:38:22 + Build duration: 3 min 11 sec and counting CONSOLE OUTPUT

D27471: [plasma-session] Avoid potential race condition starting a service

This revision was automatically updated to reflect the committed changes. Closed by commit R120:854b64fc130b: [plasma-session] Avoid hypothetical race condition starting a service (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27471?vs=75902&id=75907#toc REP

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 58 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/58/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 18 Feb 2020 12:38:32 + Build duration: 1 min 29 sec and counting CONSOLE OUTPUT

D27472: [plasma-session] Cleanup StartServiceJob

davidedmundson added inline comments. INLINE COMMENTS > apol wrote in startup.cpp:438 > Are you sure showing an error message on error is not useful anymore? we have one on the startDetached retun value. once we double fork and detach I didn't think we would get any other warnings. REPOSITORY

D27472: [plasma-session] Cleanup StartServiceJob

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > startup.cpp:438 > - > -connect(p, &QProcess::errorOccurred, this, [this] > (QProcess::ProcessError error) { > -qCWarning(PLASMA_SESSION) << "error on process" <

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. The worst problem I could found, by ignoring the margins. Theme "Underworld". F8110467: Screenshot_20200218_134914.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. 1 picture, 1 problem, 2 issues. F8110442: Screenshot_20200218_124006.png I understand why margins exist. But this, is wrong. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D271

D27199: [Applet]Update layout based on T10470

gvgeo updated this revision to Diff 75906. gvgeo edited the test plan for this revision. gvgeo added a dependency: D27392: [Applet]Add info messages.. gvgeo added a comment. TODO from the last update. Improved comments. Removed fill anchor from listview. REPOSITORY R116 Plasma Network Ma

  1   2   >