D27457: Move kcminit_startup and kded to plasma-session

davidedmundson added a comment. > As there's no reason to clear the environment, wouldn't it be more useful if StartServiceJob would only allow adding/overwriting variables? Possibly. My logic was that I didn't want to lose the possibility to unset something. REPOSITORY R120 Plasma Wo

D27472: [plasma-session] Cleanup StartServiceJob

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Mostly just a code cleanup, also uses the correct version of startDetached

D27457: Move kcminit_startup and kded to plasma-session

fvogt added a comment. As there's no reason to clear the environment, wouldn't it be more useful if `StartServiceJob` would only allow adding/overwriting variables? `StartProcessJob` does not need an option to set the environment at all AFAICT. REPOSITORY R120 Plasma Workspace REVISION

D27471: [plasma-session] Avoid potential race condition starting a service

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY If for some reason a service is started before StartServiceJob runs, we wil

D27471: [plasma-session] Avoid potential race condition starting a service

davidedmundson added a comment. I think for 5.18 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27471 To: davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D27457: Move kcminit_startup and kded to plasma-session

davidedmundson updated this revision to Diff 75901. davidedmundson added a comment. Fix process env Correctly wait for kcminit phase 0 to finish REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27457?vs=75834&id=75901 BRANCH master REVISION DET

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

ervin added inline comments. INLINE COMMENTS > meven wrote in DeviceAutomounterKCM.cpp:57 > Please beware this will make my patch quite a lot more intrusive, DeviceModel > for instance, will need a field to keep some reference to the > AutomounterSettings Sure, moving away from a singleton is

D27367: fix activity runner

McPain updated this revision to Diff 75900. McPain marked an inline comment as done. McPain added a comment. removed 2nd hunk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27367?vs=75605&id=75900 REVISION DETAIL https://phabricator.kde.org/D27367 AFFECTED FILES runners/activit

D27470: Set good default value for cursor theme and size in KRDB

bport added a comment. This is not a KCM, and because of how stuff works with KRDB we can't reuse kcfg easily there (because build by 5 or 6 kcm) About the 0 as default value, perhaps we can change that but it's totally unrelated to this patch, goal there is only to honor default value as s

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven added inline comments. INLINE COMMENTS > ervin wrote in DeviceAutomounterKCM.cpp:57 > I tend to consider this as a step back to be honest. Singletons tend to be > more trouble down the line when something goes wrong. Please beware this will make my patch quite a lot more intrusive, Device

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

ervin added inline comments. INLINE COMMENTS > meven wrote in DeviceAutomounterKCM.cpp:57 > I removed the m_settings instead, relying solely on the singleton. I tend to consider this as a step back to be honest. Singletons tend to be more trouble down the line when something goes wrong. REPOSI

D27420: [Applet]Improvements for unavailable port.

gvgeo updated this revision to Diff 75899. gvgeo added a comment. Rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27420?vs=75817&id=75899 BRANCH FreeThePort3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D27470: Set good default value for cursor theme and size in KRDB

davidre added a comment. In D27470#613348 , @meven wrote: > This looks like a good kcms to convert to KConfigXT... This isn't even a kcm :D See Kai's mail to plasma-devel https://mail.kde.org/pipermail/plasma-devel/2020-February/110655

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

wstephenson updated this revision to Diff 75898. wstephenson added a comment. Removed debug statement; Added changed qml file to diff. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27353?vs=75562&id=75898 REVISION DETAIL https://phabricator.kde

D27467: make sure ifa_addr isn't null

This revision was automatically updated to reflect the committed changes. Closed by commit R102:8cb749531a3c: make sure ifa_addr isn't null (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27467?vs=75865&id=75896 REVISION DETAIL http

D27470: Set good default value for cursor theme and size in KRDB

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. This looks like a good kcms to convert to KConfigXT... INLINE COMMENTS > krdb.cpp:756 > + QString theme = mousecfg.readEntry("cursorTheme", > QString("breeze_cursors")); > + QString size

D27470: Set good default value for cursor theme and size in KRDB

bport created this revision. bport added reviewers: Plasma, broulik, ervin, meven, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27470 AFFEC

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven added inline comments. INLINE COMMENTS > bport wrote in DeviceAutomounterKCM.cpp:84 > We can also change kcfgc to add parent in constructor It would imply make AutomounterSettings not-static. I would need to change the DeviceModel that uses AutomounterSettings static functions as well. >

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven updated this revision to Diff 75891. meven marked an inline comment as done. meven added a comment. Remove m_settings AutomounterSettings member from DeviceAutomounterKCM REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27127?vs=75845&id=75891 B

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75890. bport added a comment. fix build. KRDB can't use Kxftconfig directly so we can't avoid stuff in kdeglobals REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75844&id=75890 REVISION DETAIL https://p

D27457: Move kcminit_startup and kded to plasma-session

fvogt added inline comments. INLINE COMMENTS > davidedmundson wrote in startup.cpp:211 > StartProcessJob I think is fine. It's not set, so it'll inherit. > > It's the extra arg to StartServiceJob that has potential to wipe the env. > > It defaults to empty > > and we do p->setEnvironment(m

D27457: Move kcminit_startup and kded to plasma-session

davidedmundson added inline comments. INLINE COMMENTS > fvogt wrote in startup.cpp:211 > This (and below) are started with an empty environment, which means that > neither `DISPLAY`, `WAYLAND_DISPLAY` or `XAUTHORITY` are set. So everything > breaks horribly, as seen by @lbeltrame and openQA. S

D27457: Move kcminit_startup and kded to plasma-session

fvogt reopened this revision. fvogt added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > startup.cpp:211 > +const QVector sequence = { > +new StartProcessJob(QStringLiteral("kcminit_startup"), {}), > +new StartServiceJob(QStringLiteral("kde

Re: 2 kirigami fixes for a point release

Sorry, no time to rewrite to make this short. Am Mittwoch, 12. Februar 2020, 21:59:32 CET schrieb Nate Graham: > [+ frameworks and plasma mailing lists] > > On 2020-02-12 11:31, Albert Astals Cid wrote: > > El dimecres, 12 de febrer de 2020, a les 15:37:09 CET, Nate Graham va escriure: > >> On a

Re: 2 kirigami fixes for a point release

Am Dienstag, 18. Februar 2020, 04:03:05 CET schrieb Nate Graham: > On 2020-02-16 14:43, Albert Astals Cid wrote: > > Maybe i explain myself wrongly, i'm not blaming distros at all. > > > > They made a decision, we/I may agree with them or not, that's *my/our* > > problem, what I was disagreeing is

How to close PMC?

Hi all, I' wondering: How do I close the PMC? I can't find anything to do this. I am running PMC on a laptop with arch linux. And have always the newest builds installed. It seems, all I can do is restart the computer. Can somebody help with this? Thanks in advance! Peter Lorenz

<    1   2