D27645: [KCM]Align volume controls row

gvgeo updated this revision to Diff 76519. gvgeo added a comment. Removed workaround. (It would be nice to mention breeze theme.) REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27645?vs=76353&id=76519 BRANCH scaleM (branched from

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

bport updated this revision to Diff 76516. bport marked 19 inline comments as done. bport added a comment. cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27503?vs=76385&id=76516 REVISION DETAIL https://phabricator.kde.org/D27503 AFFECTED

D27199: [Applet]Update layout based on T10470

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. It will need rebase, there are some changes in master now which will be conflicting. Other than that I think it looks good, but I would like Nate to approve this from the UI point of vi

D27661: wireguard: Trim IP list before submitting to NM

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b7daee75ee0e: wireguard: Trim IP list before submitting to NM (authored by Haochen Tong , committed by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE L

D27666: Support WPA3-SAE in the applet popup

This revision was automatically updated to reflect the committed changes. Closed by commit R116:764cb342ea1b: Support WPA3-SAE in the applet popup (authored by Haochen Tong , committed by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

gvgeo added inline comments. INLINE COMMENTS > main.qml:46 > > +readonly property bool plasmaPaAvailable: > Qt.createComponent("PulseAudio.qml").status === Component.Ready > + I get a feeling there are 2 instances now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricat

D27645: [KCM]Align volume controls row

gvgeo added a comment. Should I remove the slider workaround? And leave it with 2 pixel offset? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27645 To: gvgeo, #plasma, #vdg, drosca, ngraham Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-O

D27199: [Applet]Update layout based on T10470

gvgeo added a comment. ping REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, rag

D26806: [Applets/Power Manager] Update layout based on T10470

gvgeo added a comment. @davidedmundson ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26806 To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76510. cblack added a comment. Handle stacked toolbars better REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76509&id=76510 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTE

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76509. cblack added a comment. Set window colour so separators are coloured more accurately REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76508&id=76509 BRANCH cblack/toolsarea REVISION DETAIL https://phabr

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76508. cblack added a comment. Recolour toolbar icons REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76507&id=76508 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D27669: WIP: [kstyle] Tools area

ngraham added a comment. Okular and Gwenview are now fixed for me. KMag and Filelight still consider the toolbar to be outside of the Tools Area for some reason. Awesome progress though. It looks so good! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cbla

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. In D27380#618599 , @gikari wrote: > So, I need to mention two bug reports: Qt one and GTK one. And should I create both of them? In case of GTK everything is somewhat clear, but in case of Qt I do not even know what to r

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76507. cblack added a comment. Check that widget isn't nullptr REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76506&id=76507 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECT

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76506. cblack added a comment. Better toolbar heuristics (fixes Okular) REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76496&id=76506 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D2766

D27669: WIP: [kstyle] Tools area

cblack added a comment. In D27669#618395 , @ngraham wrote: > Looks like there are some QWidgets apps that aren't getting the new style. > > Kate's toolbar doesn't get the new color: F8133352: Screenshot_20200226_073753.png

D27689: Use correct connections for QQC2 controls

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We only want to trigger things on user actions, not on value changes TEST PL

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

gikari added a comment. In D27380#618545 , @IlyaBizyaev wrote: > In D27380#618531 , @ngraham wrote: > > > The problem being solved here is that starting with 5.18, style names were being localized,

D27686: Fix connection to invalid signal

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY Don't do an = when we have a binding that does the same thing TEST PLAN I have NOT tested this actually works better than it did with

D27669: WIP: [kstyle] Tools area

cblack updated this revision to Diff 76496. cblack added a comment. Mutate toolbar palette REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=76436&id=76496 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

ngraham updated this revision to Diff 76495. ngraham added a comment. Brain fart; do it right REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27684?vs=76494&id=76495 BRANCH show-mute-feature-even-when-audio-indicators-are-disabled (branched from m

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

ngraham updated this revision to Diff 76494. ngraham added a comment. Also check `audioIndicatorsEnabled` for safety REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27684?vs=76492&id=76494 BRANCH show-mute-feature-even-when-audio-indicators-are-dis

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

gvgeo added inline comments. INLINE COMMENTS > Task.qml:230 > +onAudioIndicatorsEnabledChanged: { > +audioStreamIconLoader.active = audioIndicatorsEnabled; > } Better include hasAudioStream too, or will be active for all tasks, even if it is not visible. REPOSITORY R119 Plas

D27685: Remove extra top and bottom padding from dock widgets

ngraham created this revision. ngraham added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This extra padding was no big deal when using the current Breeze style, where scrollable vi

D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY There is a checkbox in the Task Manager settings with the text "Mark applications that play aud

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

IlyaBizyaev added a comment. In D27380#618531 , @ngraham wrote: > The problem being solved here is that starting with 5.18, style names were being localized, which GTK doesn't understand, causing it to fall back to the default font. This patch f

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. In D27380#618528 , @IlyaBizyaev wrote: > In D27380#618526 , @ngraham wrote: > > > Prior to 5.18, you had to set the GTK font separately; now it's auto-synced. > > > R

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

IlyaBizyaev added a comment. In D27380#618526 , @ngraham wrote: > Prior to 5.18, you had to set the GTK font separately; now it's auto-synced. Right, so that's the difference in font style names between Qt and GTK that caused the problem?

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. Prior to 5.18, you had to set the GTK font separately; now it's auto-synced. Were you able to use an italic/bold/etc GTK font in 5.17 or earlier? I must admit I never tried, so if not being able to now is a regression, that's why I never noticed. :( REPOSITORY

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

IlyaBizyaev added a comment. I am missing context on this bug, but I wonder why there were no issues with font configuration prior to 5.18 Was there a different workaround then? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27380 To: gikari,

D24706: [RFC] Change button style

ndavis updated this revision to Diff 76490. ndavis added a comment. Update REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=73742&id=76490 BRANCH ndavis/pushbutton-style (branched from master) REVISION DETAIL https://phabricator.kde.org/D24706 A

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

ngraham added a comment. Agreed. Otherwise it does work and fixes the bug, and the code looks sensible to me. However I know what @davidedmundson is going to say: "Working around Qt bugs requires a code comment mentioning the Qt bug report." :) So let's add that. Also I could not fi

D27673: [applets/notes] Fix drag&drop links and cursor shape regression

ngraham added a comment. Nice job, and nice first patch! May it be the first of many. :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27673 To: luca, #plasma, ngraham Cc: plasma-devel, ngraham, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, f

D27673: [applets/notes] Fix drag&drop links and cursor shape regression

This revision was automatically updated to reflect the committed changes. Closed by commit R114:b03539a0d8d3: [applets/notes] Fix drag&drop links and cursor shape regression (authored by Luca Pedrielli , committed by ngraham). Herald added a subscriber: plasma-devel. RE

D27166: Refactor converter runner

alex updated this revision to Diff 76487. alex added a comment. Support combination of currency symbols and letters Now queries like `4us$>ca$` are supported. Every currency from the QLocale API which has a currency symbol and support in the unit conversion backend can be used in this r

D27435: Move checked menu item always into range

This revision was automatically updated to reflect the committed changes. Closed by commit R169:cd124d4251f6: Move checked menu item always into range (authored by cordlandwehr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27435?vs=75780&id=76486#toc REPOSITORY R169 Kirigami CHANGE

D27650: ItemContainer: disconnect signals in destructor

davidedmundson added a comment. > No, AFAIK I don't have commit access. Can I have your full name + email address please. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27650 To: alnikiforov, ngraham, davidedmundson, mart Cc: anthonyfieroni, plasma-dev

D27364: Kirigami: Convert license headers to SPDX markers

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8d09d66f5fd3: Kirigami: Convert license headers to SPDX markers (authored by cordlandwehr). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27364?vs=75595&id=76484

D27364: Kirigami: Convert license headers to SPDX markers

cordlandwehr added a comment. @mart the main argument chain here is: we need machine readable license identifiers to enable tooling -> SPDX markers are the way to go -> having both license statements and SPDX markers in the same file will ultimately lead to ambiguous licenses, since people w

D27648: [KCM]Set implicitWidth for main page

This revision was automatically updated to reflect the committed changes. Closed by commit R115:8dea974eacf0: [KCM]Set implicitWidth for main page (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27648?vs=76358&id=76480 R

D27458: Set a better position for Krunner in wayland

trmdi added a comment. In D27458#618437 , @davidedmundson wrote: > Idea is nice. > > > Does this not jitter on first load? Starting off in 0,0 then moving across? > We now have position async() but we're doing that after we've shown

D27420: [Applet]Improvements for unavailable port.

This revision was automatically updated to reflect the committed changes. Closed by commit R115:ada3385d04c3: [Applet]Improvements for unavailable port. (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27420?vs=75899&id=76

D27595: Watch for language change events, and forward those to the QML engine

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9b7cae898ed7: Watch for language change events, and forward those to the QML engine (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27595?vs=

D27525: Support Qt 5.14 on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8bf5b4675186: Support Qt 5.14 on Android (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27525?vs=76060&id=76477 REVISION DETAIL https://p

D27422: [KCM]Update Device item layout based on applet

gvgeo updated this revision to Diff 76475. gvgeo added a comment. Hide portbox if window is too small. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27422?vs=76093&id=76475 BRANCH kcmports2 REVISION DETAIL https://phabricator.kde.o

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

ivan added a comment. This looks cool. The thing I'm missing (correct me if I'm wrong - I'm yet to test the patch) is for it to open the switcher when dragging the window over the switcher applet icon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27353 To

D27458: Set a better position for Krunner in wayland

davidedmundson added a comment. >> Does this not jitter on first load? Starting off in 0,0 then moving across? >> We now have position async() but we're doing that after we've shown the window. > > I don't think so. The `show()` is in the callback. /A/ show() is there. It se

D27458: Set a better position for Krunner in wayland

meven added a comment. In D27458#618437 , @davidedmundson wrote: > Idea is nice. > > > Does this not jitter on first load? Starting off in 0,0 then moving across? > We now have position async() but we're doing that after we've shown

D26934: KCM/Autostart Add a model to separate logic from UI

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > ervin wrote in autostart.cpp:87 > Unrelated right? Where do this come from? The current default size was not very appropriate. I took the liberty of changing this as well. Before: F8133214: Screenshot_2020022

D27458: Set a better position for Krunner in wayland

davidedmundson added a comment. Idea is nice. Does this not jitter on first load? Starting off in 0,0 then moving across? We now have position async() but we're doing that after we've shown the window. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2

D27458: Set a better position for Krunner in wayland

meven added a comment. ping @davidedmundson REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27458 To: trmdi, #plasma, davidedmundson Cc: meven, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, Zr

D27679: [emojier] Set minimum window height and width

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch REPOSITORY R119 Plasma Desktop BRANCH emojier-minimum-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D27679 To: filipf, apol, #plasma, #vdg,

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 76470. meven marked 40 inline comments as done. meven edited the test plan for this revision. meven added a comment. Review processing, thanks @ervin ;) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=74413

D27679: [emojier] Set minimum window height and width

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY There are two problems right now with the emojier's window: - when shrinking the window a scrollbar is drawn *over* the category

D27669: WIP: [kstyle] Tools area

ngraham added a comment. Looks like there are some QWidgets apps that aren't getting the new style. Kate's toolbar doesn't get the new color: F8133352: Screenshot_20200226_073753.png KWrite is fine, interestingly though: F8133374: Screenshot_20

D27577: [KCM]Fix content below scrollbars

gvgeo updated this revision to Diff 76467. gvgeo added a comment. Added item as a proxy for the devices and applications. This fixed the vertical binding loop. And made scrollbar touch the top and botoom edges. With this patch content is closer, by smallSpacing, to the frame. And cont

D27674: feat(kcm): show resolution aspect ratio

romangg added a comment. Do you have an example? Name the product. I know it should be easy technically, but my question is if it makes sense. A mode is a combination of resolution and refresh rate. So I could imagine there are products that prefer higher refresh rate over resolution. Bu

D27674: feat(kcm): show resolution aspect ratio

broulik added a comment. Projectors and VMs can be weird. We already have the concept of `preferredMode`, so adding an asterisk should be easy. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D27674 To: broulik, romangg, #vdg Cc: apol, plasma-devel, Orage, LeGast00n,

D27674: feat(kcm): show resolution aspect ratio

romangg added a comment. Do you have an example in the wild where the "default resolution" should be something else than the one with highest pixel count? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D27674 To: broulik, romangg, #vdg Cc: apol, plasma-devel, Orage,

D27674: feat(kcm): show resolution aspect ratio

apol added a comment. Out of scope for the patch, but it should also show the default resolution of the display. It's also important for choosing the right aspect ratio. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D27674 To: broulik, romangg, #vdg Cc: apol, plasm

D27364: Kirigami: Convert license headers to SPDX markers

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. so in the end is decided that the human readable format should be removed from the header? to me either is fine, just to know what to do in future files REPOSITORY R169 Kirigami BRANCH s

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

ahiemstra added inline comments. INLINE COMMENTS > ognarb wrote in ActionToolBarLayoutDetails.qml:126 > I think this can be simplified to > > return !modelData.hasOwnProperty("displayHint") || > !modelData.displayHintSet(Kirigami.Action.DisplayHint.AlwaysHide; The reason I'm expanding these

D27650: ItemContainer: disconnect signals in destructor

alnikiforov updated this revision to Diff 76462. alnikiforov edited the summary of this revision. alnikiforov added a comment. Got rid of two disconnects and updated summary formatting. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27650?vs=76439&

D27674: feat(kcm): show resolution aspect ratio

This revision was automatically updated to reflect the committed changes. Closed by commit R104:62042a990525: feat(kcm): show resolution aspect ratio (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27674?vs=76454&id=76461#toc REPOSITORY R104 KScreen CHANGES SINCE

D27650: ItemContainer: disconnect signals in destructor

davidedmundson added a comment. > No, AFAIK I don't have commit access. Ok, well I hope this is the first of many patches. I like working with people who can use gdb! Good stuff. INLINE COMMENTS > alnikiforov wrote in itemcontainer.cpp:68 > Should I remove these 2 disconnects or le

D27643: FileChooser: download remote files to a cache location to open them through the portal

fvogt added a comment. In D27643#618310 , @jgrulich wrote: > In D27643#618132 , @fvogt wrote: > > > In D27643#618125 , @jgrulich wrote: > > > > > I have

D27643: FileChooser: download remote files to a cache location to open them through the portal

jgrulich abandoned this revision. jgrulich added a comment. In D27643#618132 , @fvogt wrote: > In D27643#618125 , @jgrulich wrote: > > > I have never used fuse. I see you can use kio-fuse over dbus t

D27677: feat: fix build after EDID changes in libkscreen

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D27677 AFFECTED FILES co

D10042: Parse EDID on the backend side

dvratil updated this revision to Diff 76459. dvratil added a comment. - Rebased on master REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10042?vs=25805&id=76459 BRANCH arcpatch-D10042 REVISION DETAIL https://phabricator.kde.org/D10042 AFFECTE

D27675: feat: avoid duplicated text when assembling user-facing output names

dvratil added a comment. This is needed for D10042 (which I'm rebasing right now) when even on KWayland the `KScreen::Output` will have EDID attached (assembled from information provided by KWayland/KWin). Since on KWayland the output name already is `Ven

D27100: [GTK Config] Parameterise GTK config editing

gikari added a comment. In D27100#617732 , @cblack wrote: > There's a lot of string concatenation going on. I would replace a lot of the instances where you concat more than 2 strings with QString's arg function for readability purposes.

D27675: feat: Avoid duplicated text when assembling user-facing output names

romangg added a comment. Can you give an example? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D27675 To: dvratil, #plasma Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himce

D27674: feat(kcm): show resolution aspect ratio

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Nice tight implementation. INLINE COMMENTS > output_model.cpp:497 > +const QString text = i18nc("Width x height (aspect ratio)", "%1x%2 > (%3:%4)", > +

D27675: feat: Avoid duplicated text when assembling user-facing output names

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY The string format by default is `Vendor Model (output)`, where `Vendor` and `Model` are read fro

D27621: [startkde] Rename method startKSMServer to reflect real behaviour

This revision was automatically updated to reflect the committed changes. Closed by commit R120:657f520c819d: [startkde] Rename method startKSMServer to reflect real behaviour (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D27457: Move kcminit_startup and kded to plasma-session

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:c673a8322630: Move kcminit_startup and kded to plasma-session (authored by davidedmundson). REPOSITORY R120 Plasma W

D27674: feat(kcm): Show resolution aspect ratio

broulik created this revision. broulik added reviewers: romangg, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY With a special case to prefer common "16:10" over "8:5" TEST PLAN F8133072: Screenshot_202

D27650: ItemContainer: disconnect signals in destructor

alnikiforov added inline comments. INLINE COMMENTS > davidedmundson wrote in itemcontainer.cpp:68 > Right, this one line makes a lot of sense. > > I can imagine QQuickItem::~QuickItem changes parent, and calling > ItemContainer::setLayout after we've run our ItemContainers destructor means > a

D27650: ItemContainer: disconnect signals in destructor

alnikiforov added a comment. In D27650#618207 , @davidedmundson wrote: > > And this used QWeakPointer leads to premature destruction of object m_layout points to. > > Do you have commit access? Yep, original description was not entir

D27650: ItemContainer: disconnect signals in destructor

davidedmundson added a comment. > And this used QWeakPointer leads to premature destruction of object m_layout points to. Do you have commit access? INLINE COMMENTS > itemcontainer.cpp:68 > +disconnect(m_editModeTimer, &QTimer::timeout, this, nullptr); > +disconnect(this, &QQuic

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

ahmadsamir updated this revision to Diff 76447. ahmadsamir added a comment. target_link_libraries() KGuiAddons in the sysetmsettings5 target REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27518?vs=76355&id=76447 BRANCH l-khelp (branched from mast

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

meven added a comment. Seems ready to land REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27156 To: bport, #plasma, ervin, crossi, meven Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBo

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

gikari marked 4 inline comments as done. gikari added a comment. I have just tested a couple of fonts. 1. I've only tested Monospaced font with Russian locale, so I do not know it other ones work. Qt just ignores style string and any style of Monospaced is just `Monospaced, 10` in the c

D27667: Align wallpaper dialog button to bottom

This revision was automatically updated to reflect the committed changes. Closed by commit R123:541d8adc5f14: Align wallpaper dialog button to bottom (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27667?vs=76431&id=

D27669: WIP: [kstyle] Tools area

niccolove added a comment. It should not be the window decoration theme to draw the line, as the user might want to change the decoration whilst preserving the tools area appearance. I'm not sure how Kvantum does it, but it's able to draw 1px lines on apps: F8132802: Screenshot_20200226_09

D27643: FileChooser: download remote files to a cache location to open them through the portal

fvogt added a comment. In D27643#618125 , @jgrulich wrote: > I have never used fuse. I see you can use kio-fuse over dbus to mount a file, but you still have to unmount it, which will be a problem, because from the portal I don't know whether th

D27643: FileChooser: download remote files to a cache location to open them through the portal

jgrulich added a comment. I have never used fuse. I see you can use kio-fuse over dbus to mount a file, but you still have to unmount it, which will be a problem, because from the portal I don't know whether the app is still using it or not. If anyone is familiar with fuse and have solut

D27650: ItemContainer: disconnect signals in destructor

anthonyfieroni added inline comments. INLINE COMMENTS > itemcontainer.cpp:66 > { > +disconnect(m_sizeHintAdjustTimer, &QTimer::timeout, this, > &ItemContainer::sizeHintsChanged); > +disconnect(m_editModeTimer, &QTimer::timeout, this, nullptr); You can translate this calls to `m_sizeHin

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

leinir added inline comments. INLINE COMMENTS > nicolasfella wrote in kdeplatformdependent.cpp:165 > This sounds like a use case for KCMultiDialog, like e.g. in > https://invent.kde.org/kde/kdeconnect-kde/-/blob/master/settings/main.cpp That certainly could be! i'll take a look, thanks for the

D27650: ItemContainer: disconnect signals in destructor

alnikiforov added a comment. Fix consists of following line: disconnect(this, &QQuickItem::parentChanged, this, nullptr); Two other disconnects are just in case of similar issues arising and for code consistency. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabri

D27650: ItemContainer: disconnect signals in destructor

alnikiforov updated this revision to Diff 76439. alnikiforov retitled this revision from "Don't use guarded pointers for AppletsLayout" to "ItemContainer: disconnect signals in destructor". alnikiforov edited the summary of this revision. alnikiforov added a comment. Uploaded updated change R

D27650: Don't use guarded pointers for AppletsLayout

alnikiforov added a comment. In D27650#617550 , @davidedmundson wrote: > > This function takes a plain pointer and wraps it into weak shared pointer. > > That's QWeakPointer. > > QPointer is something else that doesn't have an equivalent