Re: New lockscreen

2013-01-11 Thread Aaron J. Seigo
would have been the right choice. agreed. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New lockscreen

2013-01-11 Thread Aaron J. Seigo
On Friday, January 11, 2013 10:01:58 Martin Sandsmark wrote: On Thu, Jan 10, 2013 at 09:57:30PM +0100, Aaron J. Seigo wrote: reverting is not going to happen at this point. Fair point, as it now seems to both have maintainers aware of its bugzilla component and is getting its bugs fixed

Re: krunner qml

2013-01-11 Thread Aaron J. Seigo
an even more prominent area for it. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: reflecting on 4.10

2013-01-11 Thread Aaron J. Seigo
-kickoff-bugs@, plasma-taskbar-bugs@, plasma-pager-bugs@, plasma-battery-bugs@, etc . if someone wants to take one of these on over the long term, that's great, and we could accomodate that with CC's on the BR (bugzilla supports this). history shows, however, that people don't. -- Aaron J. Seigo

Re: reflecting on 4.10

2013-01-11 Thread Aaron J. Seigo
at things, indeed. they will catch things and be able to test more configurations than we can. at the same time, we also need people who know what the code base looks like, what is changing, who is changing it and what our goals our. it's both/and. -- Aaron J. Seigo signature.asc Description

Re: reflecting on 4.10

2013-01-11 Thread Aaron J. Seigo
On Friday, January 11, 2013 18:37:44 Alex Fiestas wrote: If we want to discuss this, we should start another thread for not going off topic. imho it's completely on topic. In the workspace sprint we had some ideas about this. please share them :) -- Aaron J. Seigo signature.asc

Re: reflecting on 4.10

2013-01-11 Thread Aaron J. Seigo
. in part, that's us on this list; it should also be, as you note, a larger group of people who we build a well known means of communication with; which would be bugs.kde.org. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: krunner qml

2013-01-10 Thread Aaron J. Seigo
On Thursday, January 10, 2013 04:49:15 Aleix Pol wrote: Good stuff, I'd say it's really important, I'm really sad for not having found the time to push it further. that's why there are many of us, of course. :) no one person can do more than one person can do. but together we somehow manage

Re: krunner qml

2013-01-10 Thread Aaron J. Seigo
to me seems pretty decent. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: krunner qml

2013-01-10 Thread Aaron J. Seigo
On Thursday, January 10, 2013 17:49:48 Martin Gräßlin wrote: Am 2013-01-10 16:07, schrieb Aaron J. Seigo: on that note, startup stuff should probably move into kwin since it also provides the visual effect for it. it's probably also more future proof with Wayland's security model coming

Re: Review Request: fix layout, resize for pager plasmoid

2013-01-10 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108329/#review25178 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 10, 2013, 6:05

Re: Review Request: port from radioButton*Checked to radioButtonChecked

2013-01-10 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108128/#review25194 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 9, 2013, 4:37

Re: Review Request: Show album art in krunner results.

2013-01-10 Thread Aaron J. Seigo
toLocalFile() - Aaron J. Seigo On Jan. 10, 2013, 5:35 a.m., Emil Sedgh wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316

Re: Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

2013-01-09 Thread Aaron J. Seigo
for Plasma, Cedric Bellegarde and Aaron J. Seigo. Description --- copy dialogshadows to icontasks, and use DialogShadows to handle icon tasks shadow. This is a different solution of https://git.reviewboard.kde.org/r/108241/ , I guess this is what it should be. (remove halo part

Re: Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo

2013-01-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108265/#review25059 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 8, 2013, 2:06

Re: Review Request: fix random battery cumulative data error update upon resume

2013-01-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108280/#review25060 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 8, 2013, 10:29

krunner qml

2013-01-09 Thread Aaron J. Seigo
. (super cool would be to allow entering the username and password inline to avoid having to call up the DM itself, but i doubt that's realistic.) i hope to have the krunner QML stuff up and useful by sometime next week. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message

Re: Review Request: use Plasma::Dialog for brightness osd

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24870 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 6, 2013, 11:53

Re: Review Request: use Plasma::Dialog for kmix osd

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108223/#review24871 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 6, 2013, 11:52

Re: KDEREVIEW: share like connect and plasmate

2013-01-07 Thread Aaron J. Seigo
On Monday, January 7, 2013 22:58:12 Ben Cooksley wrote: On Sun, Jan 6, 2013 at 2:10 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, January 3, 2013 09:56:47 Ben Cooksley wrote: What about Share-Like-Connect? i was waiting until i was back in the office with time to work on it again

Re: Review Request: fix kwin tabbox shadow

2013-01-07 Thread Aaron J. Seigo
, Aaron J. Seigo, and Martin Gräßlin. Description --- use the same technique for krunner and some plasma to brought back tabbox shadow. Diffs - kwin/CMakeLists.txt 62e9964 kwin/kcmkwin/kwintabbox/CMakeLists.txt 72a6b72 kwin/tabbox/declarative.h e36e67b kwin

Re: Review Request: Plasmate: Remove PasswordAsker class

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108207/#review24873 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 5, 2013, 5:46

Re: Review Request: Plasmate: Display an error message when signingwidget is failing to generate a new key

2013-01-07 Thread Aaron J. Seigo
://git.reviewboard.kde.org/r/108205/#comment19099 needs i18n - Aaron J. Seigo On Jan. 5, 2013, 5:30 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108205

Re: Review Request: move away the git related stuff from Timeline::loadTimeLine

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108129/#review24875 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 3, 2013, 3:57

Re: Review Request: port from radioButton*Checked to radioButtonChecked

2013-01-07 Thread Aaron J. Seigo
group, all this setting false is not necessary - just set the correct one to checked and the others should all turn off automatically. - Aaron J. Seigo On Jan. 3, 2013, 3:56 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically

Re: Review Request: support svg and svgz files in imageloader

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108127/#review24877 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 3, 2013, 3:54

Re: Review Request: port internal pointer to data query

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108126/#review24878 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 3, 2013, 3:53

Re: Review Request: port branchdialog to KInputDialog

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108125/#review24879 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 3, 2013, 3:52

Re: Review Request: Translate \n into br/ for error messages

2013-01-07 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108123/#review24881 --- Ship it! Ship It! - Aaron J. Seigo On Jan. 3, 2013, 3:33

Re: Review Request: Plasmate: Replace QDialogButtonBox with QVBoxLayout

2013-01-07 Thread Aaron J. Seigo
it. there were a few other issues in the code there that also needed fixing (like exposing widgets as public members of the class) and various usability issues (button naming, etc). so this is already handled in master. - Aaron J. Seigo On Jan. 5, 2013, 4:18 p.m., Antonis Tsiapaliokas wrote

Re: Review Request: Rename krunner plugin konsolesessions to konsoleprofiles

2013-01-07 Thread Aaron J. Seigo
to provide an upgrade path, etc. so imo only the user visible strings should be altered and the reset should remain as-is. - Aaron J. Seigo On Dec. 31, 2012, 6:58 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail

Re: Review Request: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2013-01-07 Thread Aaron J. Seigo
functionality. - Aaron J. Seigo On Dec. 31, 2012, 7:12 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107868

Re: Review Request: Expose default Plasma theme to QML based KSplash

2013-01-07 Thread Aaron J. Seigo
element from PlasmaCore components? - Aaron J. Seigo On Dec. 19, 2012, 6:30 p.m., Nuno Bento wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105761

Re: Review Request: fix kwin tabbox shadow

2013-01-07 Thread Aaron J. Seigo
should not get a shadow, anything which would enforce the usage of Shadows is wrong. It needs to be done in a way as Thomas suggests. If that's not possible than we have to live with a regression. Aaron J. Seigo wrote: I don't like having a link dependency on plasmagenericshell

Re: Review Request: Keep placeholder text visible when empty and focused

2013-01-07 Thread Aaron J. Seigo
On Dec. 13, 2012, 4:32 p.m., Aaron J. Seigo wrote: as this is indeed a rather widely shifting style (far beyond KDE), as long as it is consistent with kdelibs and Qt i'm ok with this. and consistency is the hard bit. yes, there is 107678 for kdelibs (which is half the battle

Re: Review Request: Expose default Plasma theme to QML based KSplash

2013-01-07 Thread Aaron J. Seigo
On Jan. 7, 2013, 10:59 a.m., Aaron J. Seigo wrote: wouldn't it make more sense to simply use the Theme QML element from PlasmaCore components? Marco Martin wrote: yes, either that or if org.kde.plasma.core is imported, a global theme element is already registered, so there isn't

Re: Review Request: Fix dismissing LastNotificationPopup often failing

2013-01-07 Thread Aaron J. Seigo
, but marco should also give it a thumbs-up before committing. - Aaron J. Seigo On Dec. 25, 2012, 2:43 p.m., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107908

Re: Review Request: Fix bug 289427 - plasma-desktop freezes when selecting fixed-size fonts in the clock widget

2013-01-07 Thread Aaron J. Seigo
/clock.cpp http://git.reviewboard.kde.org/r/108102/#comment19113 the opening { should be on the same line as the if statement, like all other if statements in this file :) - Aaron J. Seigo On Jan. 5, 2013, 3:14 a.m., Chao Feng wrote

Re: Review Request: fix kwin tabbox shadow

2013-01-07 Thread Aaron J. Seigo
On Monday, January 7, 2013 07:43:22 Weng Xuetian wrote: Well.. since my mail to kcd is still being moderated I guess I'd also post this patch here. looks nice and straighforward. huzzah. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Review Request: Rename krunner plugin konsolesessions to konsoleprofiles

2013-01-07 Thread Aaron J. Seigo
On Jan. 7, 2013, 10:49 a.m., Aaron J. Seigo wrote: i can understand changing the visible name, but why change the plugin name and the rest of it? that's an implementation detail, and while the name used may be technically wrong it is both a smaller change as well as a safer change

Re: Review Request: use Plasma::Dialog for icontasks tooltips

2013-01-07 Thread Aaron J. Seigo
: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108241/ --- (Updated Jan. 7, 2013, 1:53 p.m.) Review request for Plasma and Aaron J. Seigo. Description

Re: KDEREVIEW: share like connect and plasmate

2013-01-06 Thread Aaron J. Seigo
sorts of useful in its current state. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: plasma and new shadow mess

2013-01-05 Thread Aaron J. Seigo
, it is shared between applications in kde-workspace. it is not a public library. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: KDEREVIEW: share like connect and plasmate

2013-01-05 Thread Aaron J. Seigo
of decisions. if those decisions were in violation of some kde policy (e.g. must be translatable), fine; but they aren't in that category of issues. instead, it's mostly this could be better or i don't like how that particular block of code has been written. thanks. -- Aaron J. Seigo signature.asc

Re: KDEREVIEW: share like connect and plasmate

2013-01-05 Thread Aaron J. Seigo
as well as for touch devices and while not all of our (internal) API modifications are where we want them to be, it is sufficiently developed for another proper release ... (we've already made 3 releases of it with Plasma Active, fww) thanks in advance :) -- Aaron J. Seigo signature.asc

Re: Panel placement problems

2013-01-05 Thread Aaron J. Seigo
initial position performed? void DesktopCorona::addPanel(const QString plugin) in kde- workspace/plasma/desktop/shell/desktopcorona.cpp -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma

Re: Plasma2 sprint in March / April?

2013-01-05 Thread Aaron J. Seigo
to happen until we move there, such as how do we add widgets? so the scope, while it may sound a bit narrow, is actually huge and probably everyone who works on plasma related code will find their areas of interest get touched on. -- Aaron J. Seigo signature.asc Description

Re: Review Request: load the images for the themes correctly

2012-12-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106680/#review24243 --- Ship it! Ship It! - Aaron J. Seigo On Dec. 23, 2012, 3:23

Re: Review Request: load the images for the themes correctly

2012-12-21 Thread Aaron J. Seigo
On Nov. 29, 2012, 1:53 p.m., Aaron J. Seigo wrote: plasmate/packagemodel.cpp, line 544 http://git.reviewboard.kde.org/r/106680/diff/5/?file=93807#file93807line544 Plasma/Theme should not appear in this file. Giorgos Tsiapaliokas wrote: the colors file isn't

Re: RSS Launcher plasmoid

2012-12-20 Thread Aaron J. Seigo
dialogs and load them from the plasmoid's package. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: Application wide shortcuts in QML

2012-12-13 Thread Aaron J. Seigo
this component as a desktop component only? Is there any way to enforce that? currently, no. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Switch and Checkbox items

2012-12-13 Thread Aaron J. Seigo
our mind in the future, all that work needs to be re-done I currently favour the second solution (making Switch a Checkbox on desktop), but would like to hear your thoughts so we can make the best decision possible together. -- Aaron J. Seigo signature.asc Description: This is a digitally

Re: Switch and Checkbox items

2012-12-13 Thread Aaron J. Seigo
to be re-done * relies on people caring about and implementing HIG-compliant UIs (this is the big problem IMHO) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request: Change Battery Percentage step of battery plasmoid

2012-12-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107612/#review23419 --- Ship it! Ship It! - Aaron J. Seigo On Dec. 6, 2012, 7:04

Re: Review Request: Plasmate: Hide hide the default buttons from KDialog and don't removal the all the projects

2012-12-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107660/#review23420 --- Ship it! Ship It! - Aaron J. Seigo On Dec. 10, 2012, 8:26

Re: Review Request: Revert fix compilation with debian qjson

2012-12-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107669/#review23421 --- Ship it! Ship It! - Aaron J. Seigo On Dec. 11, 2012, 9:05

Re: Review Request: remove duplication of code in jade files

2012-12-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107697/#review23424 --- Ship it! Ship It! - Aaron J. Seigo On Dec. 13, 2012, 11:15

Re: RFC: Application wide shortcuts in QML

2012-12-11 Thread Aaron J. Seigo
in a shared- space formfactor (vertical, horizontal, planar..); these need to be able to be kept manageable so plasmoids don't capture the same shortcuts (easy when you can have more than one instance of the plasmoid :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message

Re: How is plasma active handling copy/paste in QML?

2012-12-07 Thread Aaron J. Seigo
On Wednesday, December 5, 2012 19:46:00 Mark wrote: Can you point me to some service examples currently living in the KDE codebase that is also used in QML? http://techbase.kde.org/Development/Tutorials/Plasma/QML/API#Service -- Aaron J. Seigo signature.asc Description: This is a digitally

Re: Confused on Activities' behaviour in concert with browsers

2012-12-07 Thread Aaron J. Seigo
- in the case of rekonq it is saving the session for ALL windows ... not just the windows in the current activity. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Moving screen locking away from krunner

2012-12-07 Thread Aaron J. Seigo
reduced ... but that's a different matter. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Moving screen locking away from krunner

2012-12-07 Thread Aaron J. Seigo
. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: How is plasma active handling copy/paste in QML?

2012-12-05 Thread Aaron J. Seigo
://techbase.kde.org/Development/Tutorials/Plasma/Services That could be useful if you use a dataengine services do not require a dataengine; rather dataengines are often much more handy when they have services :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Review Request: [rssnow] Revert the commit of merging left right arrows into one

2012-12-03 Thread Aaron J. Seigo
. the reason for the merge is obvious - fewer svg files to open and parse. looks like the code using these arrows wasn't. this will eventually get replaced with a QML version in any case. - Aaron J. Seigo On Dec. 2, 2012, 9:16 p.m., Jekyll Wu wrote

Re: Moving screen locking away from krunner

2012-12-03 Thread Aaron J. Seigo
On Monday, December 3, 2012 15:42:53 Davide Bettio wrote: Hello, Quoting Marco Martin notm...@gmail.com: in 4.10 is moved in ksmserver Nice, I missed that change. Is it possible to backport any fix for plasma-netbook? no; use 4.10. -- Aaron J. Seigo signature.asc Description

Re: Review Request: populate the settings of the rssnow-qml plasmoid

2012-11-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106582/#review22741 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 26, 2012, 2:45

Re: Review Request: fixed comic tooltip and buttons bar display

2012-11-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107444/#review22742 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 24, 2012, 1:33

Re: Review Request: Move the plasmapkg doc into kde-runtime

2012-11-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107449/#review22743 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 24, 2012, 5:13

Re: Review Request: Plasmate: on SigningDialog::validateParams() replace QRegExp with KPIMUtils::isValidSimpleAddress

2012-11-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107470/#review22744 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 26, 2012, 10:36

Re: Review Request: Save and restore position of widgets in vertically-oriented FlowGroup

2012-11-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107477/#review22745 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 26, 2012, 4:56

Re: Review Request: Set history size before reading history so that all history can be loaded

2012-11-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107499/#review22746 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 28, 2012, 1:34

Re: Bug component for lockscreen?

2012-11-29 Thread Aaron J. Seigo
-qml component in kscreenlocker. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Move the docs of the plasma tools into plasmate

2012-11-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107448/#review22752 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 24, 2012, 5:03

Re: Review Request: kconfigxteditor refactor

2012-11-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107394/#review22753 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 20, 2012, 2:33

Re: Review Request: load the images for the themes correctly

2012-11-29 Thread Aaron J. Seigo
/#comment17387 should not have anything in here specific to a given package type, in this case Plasma/Theme. plasmate/packagemodel.cpp http://git.reviewboard.kde.org/r/106680/#comment17388 Plasma/Theme should not appear in this file. - Aaron J. Seigo On Nov. 5, 2012, 5:51 p.m., Giorgos

Re: Review Request: support the 404 error

2012-11-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107184/#review22755 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 2, 2012, 8:10

Re: How is plasma active handling copy/paste in QML?

2012-11-29 Thread Aaron J. Seigo
++ that provides access to KIO's copy and trash methods. so either there needs to be some C++ in your project, or a QML plugin written in C++ the bridges to KIO needs to be written. a Plasma::Service would probably do the trick quite nicely as those can be loaded into QML .. -- Aaron J. Seigo

Re: Review Request: Plasmate:Remove cmake-install functionality from Publisher

2012-11-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107512/#review22761 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 29, 2012, 1:56

[Bug 310871] Screen always locks (requires password) even if not supposed to

2012-11-29 Thread Aaron J . Seigo
https://bugs.kde.org/show_bug.cgi?id=310871 --- Comment #1 from Aaron J. Seigo ase...@kde.org --- indeed, the password dialog is always started / shown no matter the setting. -- You are receiving this mail because: You are the assignee for the bug

[Bug 310871] Screen always locks (requires password) even if not supposed to

2012-11-29 Thread Aaron J . Seigo
https://bugs.kde.org/show_bug.cgi?id=310871 Aaron J. Seigo ase...@kde.org changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0

Re: [RFC] New (QML) Desktop Containment

2012-11-23 Thread Aaron J. Seigo
this angle, would probably also mean to streamline which actions are offered in which mode. or just don't have modes. all the problems you enumerate come from trying to solve the problems of movement and applet handles are not pretty with modes. -- Aaron J. Seigo signature.asc Description

Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-23 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107413/#review22419 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 23, 2012, 11:12

Re: Review Request: Plasmate: Make Publisher able to remove the packages which have been installed with the cmake method

2012-11-23 Thread Aaron J. Seigo
On Nov. 23, 2012, 12:06 a.m., Aaron J. Seigo wrote: why would Publish do the exact opposite and uninstall something? shouldn't this be a different function? in which case is it needed / desired to even do this from plasmate? Antonis Tsiapaliokas wrote: Yes, you have right

Re: Review Request: plasmoid currentappconrol - max width of dropdown

2012-11-23 Thread Aaron J. Seigo
() oh, and maxwidth can be const :) - Aaron J. Seigo On Nov. 23, 2012, 10:27 a.m., Greg T wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107433

Re: Review Request: simplify the qinstallmsghandler code

2012-11-22 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107395/#review22369 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 20, 2012, 3 p.m

Re: Review Request: [High-dpi issues] Fix panelcontroller Screen Edge/Height icons fixed size

2012-11-22 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107414/#review22371 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 22, 2012, 9:16

Re: [RFC] New (QML) Desktop Containment

2012-11-22 Thread Aaron J. Seigo
.. the good: * alignment made easy * it's very fluid looking * QML ftw :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: [RFC] New (QML) Desktop Containment

2012-11-22 Thread Aaron J. Seigo
. however, that seems like a bit too obvious of an answer, so i think i may be missing the meaning of your question. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel

Re: Homerun sources and Plasma runners

2012-11-22 Thread Aaron J. Seigo
On Wednesday, November 21, 2012 13:57:10 Aurélien Gâteau wrote: Le mardi 20 novembre 2012 20:16:17 Aaron J. Seigo a écrit : the question is which of the following makes sense: * AbstractRunner should be a model (BIC) * AbstractRunner should export a model (SC BC) * RunnertContext

Re: [RFC] New (QML) Desktop Containment

2012-11-22 Thread Aaron J. Seigo
works as intended when done so in strictly divided modes. can we imagine any way to make interacting with the system more baroque, less discoverable and more labor intensive? -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: [RFC] New (QML) Desktop Containment

2012-11-22 Thread Aaron J. Seigo
it accomplishes this with overly complex code. :P -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] New (QML) Desktop Containment

2012-11-22 Thread Aaron J. Seigo
that can be done to work towards accomplishing both of the above. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] New (QML) Desktop Containment

2012-11-22 Thread Aaron J. Seigo
of solutions; the problem is that unlocked is the default is not a problem statment, it's a solution statement disguised as one -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma

Re: [RFC] New (QML) Desktop Containment

2012-11-22 Thread Aaron J. Seigo
in mind that while we're focusing hard on this area of the UI, nobody using it should ;) we're not making a painting app, but a way to (experentially) loosely arrange items on screen. i'd give up some level of customiation here if it results in a large speed boost in usage. -- Aaron J. Seigo

Re: Review Request: hide save and save as actions in every language

2012-11-22 Thread Aaron J. Seigo
actions don't have a non-translated identifier :/ looks good except for some minor ws issues, e.g. if (names.contains (e.attribute (name))) { should be if (names.contains(e.attribute(name))) { fix up the ws and shipit :) - Aaron J. Seigo On Nov. 22, 2012, 11:59 a.m., Giorgos Tsiapaliokas

Re: Review Request: Add the plasmagik icon into the plasmate's repo

2012-11-22 Thread Aaron J. Seigo
elsewhere now. no point in needlessly breaking things. see: http://lxr.kde.org/search?filestring=string=plasmagik - Aaron J. Seigo On Nov. 22, 2012, 1:03 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail

Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-22 Thread Aaron J. Seigo
/107413/#comment17178 and this blocks the entire UI which is not acceptable .. which is why show rather than exec is used. - Aaron J. Seigo On Nov. 22, 2012, 7:08 p.m., Jan Grulich wrote: --- This is an automatically generated e

Re: Review Request: Use static KNS3::DownloadDialog in PlasmoidPackage

2012-11-22 Thread Aaron J. Seigo
connect the finished() signal of the dialog to deleteLater(), which will cause it to be recreated after it's gone. - Aaron J. Seigo On Nov. 22, 2012, 7:08 p.m., Jan Grulich wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request: Plasmate: Make Publisher able to remove the packages which have been installed with the cmake method

2012-11-22 Thread Aaron J. Seigo
something? shouldn't this be a different function? in which case is it needed / desired to even do this from plasmate? - Aaron J. Seigo On Nov. 22, 2012, 8:02 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail

Re: Icon sizes on panel vs. SystemSettings

2012-11-20 Thread Aaron J. Seigo
will be in the panel, it is used as a default size and size hint for icons and as such is still in use. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https

<    1   2   3   4   5   6   7   8   9   10   >