Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-26 Thread Armin K.
marked as submitted. Review request for Plasma and Martin Klapetek. Changes --- Submitted with commit c974341fe3502c46d275ff56ae36477ed7cc573d by Armin K to branch master. Repository: kwallet-pam Description --- Currently, kwallet-pam is only usable when used in combination with

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-25 Thread Armin K.
s.txt 8bd526e pam_kwallet_init PRE-CREATION pam_kwallet_init.desktop.cmake PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126843/diff/ Testing --- Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, I was still asked for password in GNOME. Thanks,

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
it.reviewboard.kde.org/r/126843/#review91457 ------- On Jan. 22, 2016, 7:08 p.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
ATION Diff: https://git.reviewboard.kde.org/r/126843/diff/ Testing --- Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, I was still asked for password in GNOME. Thanks, Armin K. ___ Plasma-devel mailing list P

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
ed in KDE Plasma, I was still asked for password in GNOME. Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
> > Also we tend to use the lower case variants nowadays. > > > > on the feature: maybe better use add_feature_info and add it to the > > feature list as a required one. > > Armin K. wrote: > I was getting a syntax error without the conditional in else and

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
ror without the conditional in else and endif statements. I'll try with lowercase ones. Thanks. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/#review91445 -

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
> > Also we tend to use the lower case variants nowadays. > > > > on the feature: maybe better use add_feature_info and add it to the > > feature list as a required one. > > Armin K. wrote: > I was getting a syntax error without the conditional in else an

Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
--- Works in both KDE Plasma and GNOME. Previously, it only worked in KDE Plasma, I was still asked for password in GNOME. Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125187: Stop requiring Frameworks 5.15

2015-09-22 Thread Armin K.
. Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125187: Stop requiring Frameworks 5.15

2015-09-18 Thread Armin K.
because it won't compile with 5.14 (which it currently requires) without this change. - Armin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353

Re: Review Request 125187: Stop requiring Frameworks 5.15

2015-09-14 Thread Armin K.
y generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85240 ------- On Sept. 12, 2015, 9:38 a.m., Armin K. wrote: > > --- > This is an autom

Review Request 125187: Stop requiring Frameworks 5.15

2015-09-12 Thread Armin K.
d. I don't have commit access, so someone needs to commit this for me. Diffs - applets/icon/plugin/icon_p.cpp 97af67a Diff: https://git.reviewboard.kde.org/r/125187/diff/ Testing --- It builds. Thanks, Armin K. ___ Plasma-devel ma

Re: Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2015-04-19 Thread Armin K.
/diff/ Testing --- Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2015-02-09 Thread Armin K.
- network/ioslave/CMakeLists.txt 06a964d network/kded/CMakeLists.txt 3be676e network/network/CMakeLists.txt c0fb43e Diff: https://git.reviewboard.kde.org/r/121084/diff/ Testing --- Thanks, Armin K. ___ Plasma-devel mailing list Plasma

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2015-01-09 Thread Armin K.
4/#review73572 --- On Nov. 9, 2014, 4:10 p.m., Armin K. wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.re

Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2014-11-09 Thread Armin K.
/network/CMakeLists.txt c0fb43e Diff: https://git.reviewboard.kde.org/r/121084/diff/ Testing --- Thanks, Armin K. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2014-11-09 Thread Armin K.
68f46 thumbnail/jpegcreatorsettings.kcfgc 3f6cdab thumbnail/jpegcreatorsettings5.kcfg PRE-CREATION thumbnail/jpegcreatorsettings5.kcfgc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121086/diff/ Testing --- Thanks, Armin K. ___ P