[Powerdevil] [Bug 350807] Desktop freezes when monitor switched off

https://bugs.kde.org/show_bug.cgi?id=350807 Christoph Cullmann changed: What|Removed |Added Resolution|--- |UPSTREAM CC

Review Request 125528: Check for nullptr screen

for nullptr. Thanks, Christoph Cullmann ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125528: Check for nullptr screen

tically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125528/#review86371 ------- On Oct. 5, 2015, 1:41 p.m., Christoph Cullmann wrote: > > --- > This is an

Re: Review Request 125528: Check for nullptr screen

enough to change the API, we now need to check for nullptr. Thanks, Christoph Cullmann ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125528: Check for nullptr screen

> On Oct. 5, 2015, 1:59 p.m., David Edmundson wrote: > > src/plasmaquick/dialog.cpp, line 156 > > <https://git.reviewboard.kde.org/r/125528/diff/1/?file=409731#file409731line156> > > > > just QGuiApplication::screens() should be fine here. > > Chris

Re: Review Request 125528: Check for nullptr screen

marked as submitted. Review request for Plasma and Marco Martin. Changes --- Submitted with commit 3f9109a2657a132879f29cc56471598a5f519b94 by Christoph Cullmann to branch master. Bugs: 345173 http://bugs.kde.org/show_bug.cgi?id=345173 Repository: plasma-framework Description

Review Request 128890: Make e.g. Baloo::Query thread safe.

nks, Christoph Cullmann

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

marked as submitted. Review request for KDE Frameworks, Plasma and Boudhayan Gupta. Changes --- Submitted with commit e34da150d82a57cf417a59b8b632b2fecb32a6f7 by Christoph Cullmann to branch master. Repository: baloo Description --- lmdb itself is thread safe (e.g. you can use the

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128890/#review99103 ------- On Sept. 11, 2016, 6:27 p.m., Christoph Cullmann wrote: > > -

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

mail. To reply, visit: https://git.reviewboard.kde.org/r/128890/#review99103 --- On Sept. 11, 2016, 6:27 p.m., Christoph Cullmann wrote: > > --- > This is an automa

Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

1a56c64 src/tools/balooshow/main.cpp f45f2e0 Diff: https://git.reviewboard.kde.org/r/128892/diff/ Testing --- Unit tests still work, balooctl seems to do something. Thanks, Christoph Cullmann

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

ard.kde.org/r/128892/#review99110 --- On Sept. 11, 2016, 7:19 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

/r/128892/#review99115 --- On Sept. 11, 2016, 7:19 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

marked as submitted. Review request for KDE Frameworks, Plasma, Boudhayan Gupta, and Vishesh Handa. Changes --- Submitted with commit 02047b524a176da447d8c96e15c7e2abae8339ae by Christoph Cullmann to branch master. Repository: baloo Description --- At the moment, any application

Fwd: Scrap baloo?

/contributors 2) We share the index with GNOME/* and save double indexing on "many" Linux systems which are not plain KDE Plasma Desktop based 3) We can delete 99% of the code (question is if we can remove the very buggy extractors from KFileMetaData, too, afterwards somewhen). => Opinions

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

cullmann added a reviewer: broulik. cullmann added a comment. Perhaps Kai has some opinion. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor, broulik Cc: cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D27109: Fix duplicate results for sessions, simplify and optimize

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Improved output seems fine for me, thanks for taking care. REPOSITORY R114 Plasma Addons BRANCH katesession_improvements (branched from master) REVISION DETAIL https://phabricato

D27109: Fix duplicate results for sessions, simplify and optimize

cullmann added a comment. Btw., for Kate, we would prefer merge requests on invent.kde.org/kde/kate, but I will just apply this via arc. REPOSITORY R114 Plasma Addons BRANCH katesession_improvements (branched from master) REVISION DETAIL https://phabricator.kde.org/D27109 To: alex, b

D27109: Fix duplicate results for sessions, simplify and optimize

cullmann added a comment. Upsa ;) missed that this is in plasma addons, not in the session launcher applet we have in our repo, ignore my comment about the invent stuff ;=) REPOSITORY R114 Plasma Addons BRANCH katesession_improvements (branched from master) REVISION DETAIL https://pha

D27109: Fix duplicate results for sessions, simplify and optimize

This revision was automatically updated to reflect the committed changes. Closed by commit R114:2c832dbdd087: Fix duplicate results for sessions, simplify and optimize (authored by alex, committed by cullmann). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.o

[Differential] [Commented On] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

cullmann added a comment. > Currently if you try to convert the cursor to coordinates and then convert these coordinates back to a cursor again, it produces an invalid cursor (-1, -1) when the original cursor is located at the end of line > Converting back to cursor coordinates that have b

[Differential] [Accepted] D4538: [KTextEditor] consistent conversion from/to cursor to/from coordinates

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for extending the test case + trying the KDevelop navigation! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4538 EMAIL PREFERENCES https://phabri

Re: KInit - Current state and benchmarks

Hi, On 2019-06-17 11:56, David Edmundson wrote: From API.kde.org: Using kdeinit to launch KDE applications makes starting a typical KDE applications 2.5 times faster (100ms instead of 250ms on a P-III 500) Certainly sounds like a good thing. ===The current State=== ==Plasma== * Apps launche

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

cullmann added a comment. Thanks! REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: cullmann, wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Z

D22630: Slow down the busy indicator's rotation speed

cullmann accepted this revision. cullmann added a comment. Jup, looks less iritating. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH slower-busy-indicator REVISION DETAIL https://phabricator.kde.org/D22630 To: ngraham, #vdg, filipf, cullmann Cc: filipf, plasma-devel, cullma

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. 0.05 is no good idea either ;) Just like 0.1 that is no 1/2, 1/4, 1/8, ... If we really need something finer than 0.25, could we stick with 1/8 or 1/16? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, ro

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. In D24321#540014 , @ngraham wrote: > In D24321#540011 , @cullmann wrote: > > > 0.05 is no good idea either ;) > > Just like 0.1 that is no 1/2, 1/4, 1/8, ... > > If we

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. And the custom scale factor dialog really should have some warning text like on Windows ;=) see e.g. https://www.pcworld.com/article/2953978/use-windows-10s-individual-display-scaling-to-perfect-your-multi-monitor-setup.html (custom scale factor not re

D24321: [KCM] Scale more grossly with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. Btw., I think GNOME is more clever than us, too, they allow just sane scalings in the UI: https://www.omgubuntu.co.uk/2019/06/enable-fractional-scaling-ubuntu-19-04 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vd

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. Hi, I thought about this a bit more ;) I really think we shall limit the minimal increase to 0.25, without any advanced field. Perhaps the range should be larger, like 1-4, if some people get "really" high DPI screens. Rational: 1. For small 0.1 change

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. In D24321#540056 , @davidedmundson wrote: > > it would go into Plasma 5.17. :) > > There's still a feature freeze. At least moving away from 0.1 increases is actually a bugfix. Look at my konsole screenshot,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. In D24321#540218 , @davidedmundson wrote: > > For small 0.1 changes: Just change your font size, we did that always for the old non-hidpi world were displays did differ a bit in the DPI, that works without any glitch

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. ;=) I talked only about the Qt HiDPI scaling code paths. For any other scaling I don't care, as that should be application transparent, like you say. But if Wayland really just scales up the stuff via GL fonts will look terrible. And no, its non-trivial t

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. Hmm, I just tried here a Wayland session, and yes, the KCM has there just some 1x/2x combobox and my fonts are maximal ugly compared to some export QT_SCALE_FACTOR=2 + starting a Qt application (on Wayland). But I must try that at home on real HiDPI screens, perhap

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. In D24321#540437 , @romangg wrote: > In D24321#540433 , @cullmann wrote: > > > ;=) I talked only about the Qt HiDPI scaling code paths. > > > In this case I recommend

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. Ok, tried Wayland now on my HiDPI setup. In Plasma's KCM I only have Scale 1x or 2x and that works ok, as one would think. But I see no way to set any more fine-grained scale to check if the scaling is nice for other values. The slider is for me only there for

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. I will investigate the https://bugreports.qt.io/browse/QTBUG-66036 bug again, too :/ Even with the rounding issues one gets over larger multiplications, it shouldn't be that buggy for short ones. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. I got some more insight into https://bugreports.qt.io/browse/QTBUG-66036 If one turns off anti-aliasing, in KTextEditor most of the evil artifacts disappear, but not all. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. Ok, I wasted one evening on the rendering artifacts stuff. https://bugreports.qt.io/browse/QTBUG-66036 I have now ugly workarounds in KTextEditor: 1. no anti-aliasing, else fillRect misses to fill 1 pixel at the borders by rounding errors 2. adjust th

D24321: [KCM] Scale more coarsely with the slider, but more finely with a semi-hidden spinbox

cullmann added a comment. Even with my hacks for https://bugreports.qt.io/browse/QTBUG-66036 in current KTextEditor master (see https://bugs.kde.org/show_bug.cgi?id=390451) you will still get after every xx lines some stray artifact in some cases during selection if you have some 1.1 scaling

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. I like that UI, too. For Wayland: Can somebody tell me how I can try there some fractional scaling? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, romangg, ndavis Cc: dhaumann, davidedmundson, ouwerkerk,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. Hmm, could we perhaps adjust the minimal step to 0,0625. That is 1/16 and with that, I never get any artifacts with KWrite in current master, as it nicely sums up. Then you don't need to round at all for output. REPOSITORY R104 KScreen REVISION DETAIL https:

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. To illustrate that, just try, with master of KTextEditor: export QT_SCALE_FACTOR=1.125 kwrite with some file => select 100 lines, zoom font in and out => I get no artifacts export QT_SCALE_FACTOR=1.0625 > same == export QT_SCALE_FACTOR=1

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. I don't get why we want to introduce artifacts we can very simple avoid by using a different base for the steps. Is 0.0625 really that much worse than 0.05? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Besides, I think you missed half of the code, as for me, I still get a different widget here, as for my setup the OutputPanel.qml is used, not Panel.qml. (as I have two displays th

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. Or I am maximal confused ;=) If I compile a master kscreen, have sourced the prefix.sh, shall I see the correct stuff in e.g. the kcm_testapp in bin of the kscreen build dir? If not, I am sorry, could somebody help me out how to test this properly? REPOSITO

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. Ok, but given I have a system wide installed kcm anyways, from the distro, is there a way to use the own I have in my user local prefix? That explains why I am too dumb to try the fractional scaling on Wayland with my installed master version, too. REPOSITORY R1

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. Ok, that explains why all my tries fail... I thought the hint above about looking for kcm_screen in the system was just if I have mixed up some stuff, but I always thought if the QT_PLUGIN_PATH is properly set like with prefix.sh the local plugins will be prefered.

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. Ok ,works for me, too. Sorry for the noise! And thanks for the explanation! I think this is already much better than before, the details of the last finesse with the minimal step can be discussed elsewhere. REPOSITORY R104 KScreen REVISION DETAIL https://phabr

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

cullmann added a comment. I would just reformulate "Scale factors are limited to multiples of 6.25% on X11 to minimize visual glitches in applications." to "Scale factors are limited to multiples of 6.25% to minimize visual glitches in applications." I think adding X11 onl

D24283: Add clang format file

cullmann added a comment. See D24568 for the draft of an ECM module that applies the Kate/KTextEditor/Artikulate style. Is the same file as here, with sorting of includes, but with column limit. REPOSITORY R120 Plasma Workspace REVISION DETAIL https

D24283: Add clang format file

cullmann added a comment. This is just a base file for discussion. Stuff like the mentioned case indentation can be adjusted to be frameworks conform. For the alignment of comments, I am not sure, it makes the stuff a lot more readable in many cases and after the initial re-format you don

D24283: Add clang format file

cullmann added inline comments. INLINE COMMENTS > zzag wrote in .clang-format:83 > s/coding/coding style/ Fixed that in D24568 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24283 To: davidedmundson Cc: zzag, cullmann, pl

D24283: Add clang format file

cullmann added a comment. There will anyways be one "big" change in the history, but normally git will be able to handle that well by ignoring space changes for blame or diff. I don't think without the aligning the change will be much smaller. REPOSITORY R120 Plasma Workspace REVISION DE

D24373: [KCM] Limit scale factor increment to 6.25% on X11

cullmann added a comment. On Wayland one seems to always scale up to the next full factor (e.g. 2) and then scale down the rendered stuff via gl to the selected factor (e.g 1.5). That leads to other issues but doesn't let rounding stuff creep into the rendering via Qt. For non IEEE

Re: CI system maintainability

or features you not use yourself at all), any meaningful review is a full-time job. e.g. in our company you would let some student test the changed behavior some days. This is just not feasible for me, and yes, for some of these changes, rather than abandoning them (and trashing precious work