D6719: [aurorae] Add support for shaded windows

2017-07-16 Thread Christoph Feck
cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH aurorae-support-shaded REVISION DETAIL https://phabricator.kde.org/D6719 To: graesslin, #kwin, #plasma, cfeck Cc: cfeck, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,

D6719: [aurorae] Add support for shaded windows

2017-07-16 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > aurorae.cpp:407 > connect(client().data(), > ::DecoratedClient::maximizedChanged, this, > ::updateBorders, Qt::QueuedConnection); > +connect(client().data(), ::DecoratedClient::shadedChanged, > this, ::updateBorders); >

D6565: Query supported OpenGL core profile version on X11, GLX

2017-07-08 Thread Christoph Feck
cfeck added a comment. BUG: 373856 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D6565 To: madcatx Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

[Powerdevil] [Bug 382105] Power devil crash dès la sortie de veille

2017-07-07 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=382105 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Severity|normal |crash -- You are rec

[Powerdevil] [Bug 378498] Power settings missing scrollbar

2017-07-07 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=378498 Christoph Feck <cf...@kde.org> changed: What|Removed |Added CC||domenico.iezzi@gm

[Powerdevil] [Bug 382097] Powerdevil config window too big and unresizable

2017-07-07 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=382097 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Reso

D6544: Don't draw focus line on selected list item

2017-07-07 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > cfeck wrote in breezestyle.cpp:3082 > Of course inherits(QString) is slower than qobject_cast<>. > > The only reason to use inherits() is when you do not link to the library that > the class defines. Also order to make the fastest test come

D6544: Don't draw focus line on selected list item

2017-07-07 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > broulik wrote in breezestyle.cpp:3082 > From what I can tell the difference is negligible. `qobject_cast` goes > through `QMetaObject::cast` which then calls `inherits` internally, so I'd > say `inherits` is the better choice. > > I didn't

[Powerdevil] [Bug 381487] OSD brightness control (Fn key combination) randomly stops working after standby and external screen switching.

2017-06-28 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=381487 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Assignee|se...@kde.org |plasma-devel@kde.org

D6373: [libksysguard] Fix text color in memory html view

2017-06-27 Thread Christoph Feck
cfeck added a comment. This can be abandoned, https://phabricator.kde.org/D6402 was committed. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D6373 To: anthonyfieroni, #plasma, davidedmundson, graesslin Cc: cfeck, broulik, plasma-devel, ZrenBot, progwolff,

D6327: [ksshaskpass] Support mercurial (hg) ssh prompts

2017-06-24 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R105:4a6d3f932c36: Support mercurial (hg) ssh prompts (authored by cfeck). REPOSITORY R105 KDE SSH Password Dialog CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6327?vs=15715=15816 REVISION

D6334: [kcms/touchpad] Fix crash with 'Drag me' in X11 test area

2017-06-22 Thread Christoph Feck
cfeck added a comment. Pushed to 5.10 and merged to master. Feel free to cherry-pick to 5.8 branch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6334 To: cfeck, #plasma, knambiar, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,

D6332: [kcms/touchpad] Fix warning 'returning reference to temporary'

2017-06-22 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R119:838777eaa6f0: Fix warning 'returning reference to temporary' (authored by cfeck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6332?vs=15721=15752

D6334: [kcms/touchpad] Fix crash with 'Drag me' in X11 test area

2017-06-22 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R119:5c3b8c7afa4a: Fix crashes with 'Drag me' in touchpad test area (authored by cfeck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6334?vs=15723=15751

D6334: [kcms/touchpad] Fix crash with 'Drag me' in X11 test area

2017-06-21 Thread Christoph Feck
cfeck created this revision. cfeck added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Something really fishy was going on when dragging the 'Drag me' folder in the X11 test area onto itself. Instead of using a custom QStandardItemModel with

D6332: [kcms/touchpad] Fix warning 'returning reference to temporary'

2017-06-21 Thread Christoph Feck
cfeck created this revision. cfeck added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Our APIs still should not declare reference results for implicitly shared objects. This is not a problem with the current backends, because they just

D6327: [ksshaskpass] Support mercurial (hg) ssh prompts

2017-06-21 Thread Christoph Feck
cfeck created this revision. cfeck added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The stricter parsing of ssh password prompts causes another regression for mercurial users, see https://bugs.kde.org/show_bug.cgi?id=380085 This is similar

D6313: WIP: Support device pixel ratio in icon loader and engine

2017-06-21 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > cfeck wrote in kiconloader.cpp:863 > Please use some rounding here. Scaling factors such as 1.4 cannot be > represented exactly. > > Either add some formatting specifiers, e.g. for three decimal places, or use > qRound(scale * 1000). Just

D6313: WIP: Support device pixel ratio in icon loader and engine

2017-06-21 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > kiconloader.cpp:1299 > > -if (d->findCachedPixmapWithPath(key, pix, path)) { > +if (d->findCachedPixmapWithPath(key, pix, path)) {// skip cache > if (path_store) { Is this a left-over change from disabling this check? REPOSITORY

D6313: WIP: Support device pixel ratio in icon loader and engine

2017-06-21 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > kiconloader.cpp:863 > + % QLatin1Char('@') > + % QString::number(scale) > % QLatin1Char('_') Please use some rounding here. Scaling factors such as 1.4 cannot be represented exactly. Either add some formatting

[Powerdevil] [Bug 381465] Powerdevil crashes after undocking from Lenovo UltraBase

2017-06-21 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=381465 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Resolution|--- |DUPLICATE As

[Powerdevil] [Bug 381387] display brightness is increased when come back from closed lid

2017-06-19 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=381387 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Component|general |general V

[Breeze] [Bug 381169] Change Virtualbox icon more similar to the vendor's icon

2017-06-13 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=381169 Christoph Feck <cf...@kde.org> changed: What|Removed |Added CC||kain...@gma

[kio-extras] [Bug 379680] MTP protocol died unexpectedly

2017-06-13 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379680 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Status|NEEDSINFO |UNCONFIRMED Reso

[kio-extras] [Bug 379817] Behaviour change: JPEG image preview scaled to widget size

2017-06-13 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379817 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Resolution|--- |FIXED

[kio-extras] [Bug 379680] MTP protocol died unexpectedly

2017-06-13 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379680 --- Comment #3 from Christoph Feck <cf...@kde.org> --- To further investigate this issue, KDE developers need the information requested in comment #1. If you can provide it, or need help with finding that information, please add a comment. -

[Powerdevil] [Bug 378498] Power settings missing scrollbar

2017-06-07 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=378498 Christoph Feck <cf...@kde.org> changed: What|Removed |Added CC||pas...@dhermi

Re: Review Request 130129: Don't upscale jpeg images when creating thumbnails

2017-06-03 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130129/#review103268 --- Ship it! Ship It! - Christoph Feck On June 3, 2017

[kio-extras] [Bug 379817] Behaviour change: JPEG image preview scaled to widget size

2017-06-02 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379817 --- Comment #3 from Christoph Feck <cf...@kde.org> --- Alexander, could you please upload the patch using https://phabricator.kde.org/differential/diff/create/ It is missing from the link in comment #1, and it looks like reviewboard does no

[kio-extras] [Bug 379680] MTP protocol died unexpectedly

2017-06-02 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379680 --- Comment #2 from Christoph Feck <cf...@kde.org> --- If you can provide the information requested in comment #1, please add it. -- You are receiving this mail because: You are the assignee for the bug.

[plasmashell] [Bug 380374] WindowList should group by Activity

2017-05-30 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=380374 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-05-29 Thread Christoph Feck
cfeck added a comment. Yes, let's not argue about the names. I just wanted to make sure you understand the difference between 1D and 3D LUTs, and why color management (should it ever come back to KWin), needs 3D LUTs. REPOSITORY R108 KWin REVISION DETAIL

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-05-28 Thread Christoph Feck
cfeck added a comment. In https://phabricator.kde.org/D5928#112364, @subdiff wrote: > In https://phabricator.kde.org/D5928#112359, @cfeck wrote: > > > http://www.color.org/faqs.xalter > > > Sorry, but I can't find the relevant part here. Can you quote it? I wanted you to

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-05-28 Thread Christoph Feck
cfeck added a comment. In https://phabricator.kde.org/D5928#112357, @subdiff wrote: > In https://phabricator.kde.org/D5928#112339, @cfeck wrote: > > > The difference between gamma correction and color correction is that the former only uses three 1D LUTs, while the latter can use

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-05-28 Thread Christoph Feck
cfeck added a comment. I agree that this code should not talk about night mode at all. Indeed we only need code in KWin to control the gamma LUTs per screen, and maybe even compute the LUTs from a number of gamma/contrast/brightness control points so that we do not have to transfer a lot of

D5928: Introducing Night Color - KWin's native blue light filter at nighttime

2017-05-28 Thread Christoph Feck
cfeck added a comment. In https://phabricator.kde.org/D5928#112334, @subdiff wrote: > In https://phabricator.kde.org/D5928#111282, @graesslin wrote: > > > I wouldn't call it color correction as we used to have a mechanism called color correction in the past which did something very

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #37 from Christoph Feck <cf...@kde.org> --- > kio_smb sets the permissions on the UDSEntries correctly but Dolphin seems to > have a mind of its own. In other words, using Dolphin copying fails, but using "kioclient5 cp

D5806: When building menu hyerarchies, parent menus to their containers

2017-05-17 Thread Christoph Feck
cfeck added a comment. Konsole could also be affected, see https://bugs.kde.org/show_bug.cgi?id=379795 Timing indicate all reporters use newest frameworks. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5806 To: mart, #plasma, #plasma_on_wayland, #frameworks,

[Powerdevil] [Bug 379858] Windows open too small

2017-05-16 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379858 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Version|5.34.0 |unspecified As

[Powerdevil] [Bug 379643] When I turn on my notebook, after the full startup of KDE Plasma 5, I verify that the battery monitor is disabled, as if the battery was not present.

2017-05-09 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379643 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Resolution|--- |INVALID

D5723: Cleanup wayland resources used in kwindowsystem before they're deleted by QPA

2017-05-06 Thread Christoph Feck
cfeck added a comment. In https://phabricator.kde.org/D5723#107203, @davidedmundson wrote: > add bug mentioned by cfeck Uhm, where did you add it? REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D5723 To:

D5728: Release the wl_registry before QPA shutdown in QStyl

2017-05-06 Thread Christoph Feck
cfeck added a reviewer: hpereiradacosta. cfeck added a comment. Probably needs a similar fix in Oxygen. And if "Registry" is related to pixmap/tile caches, it might even fix the shutdown crashes we got there, e.g. bug 331260. REPOSITORY R31 Breeze REVISION DETAIL

D5723: Cleanup wayland resources used in kwindowsystem before they're deleted by QPA

2017-05-05 Thread Christoph Feck
cfeck added a comment. We are tracking the wl_map_insert_at crashes at bug 372597. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D5723 To: davidedmundson, #plasma Cc: cfeck, plasma-devel, spstarr, progwolff, Zren, lesliezhai,

[kio-extras] [Bug 379550] XCF preview thumbnails in dolphin, new format not recognized

2017-05-05 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379550 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Reso

D5704: Improve the x11 timestamp handling

2017-05-04 Thread Christoph Feck
cfeck added a comment. I may be totally unaware about what the changes do, but from reading the comments on the bug report, I had expected to see something like if (timestamp > m_X11Time || int(timestamp + INT_MAX / 2) < m_X11Time) ... REPOSITORY R108 KWin REVISION DETAIL

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-04-28 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #19 from Christoph Feck <cf...@kde.org> --- I can only speak for myself, but I only used sftp:// which is based on ssh. -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 378305] breeze-icons.rcc can't be cross-compiled

2017-04-27 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=378305 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Component|Icons |general As

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-04-27 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #17 from Christoph Feck <cf...@kde.org> --- If it was easy to fix, someone actually (still?) using Samba could trace/analyze the code and check where it fails. Otherwise we cannot even confirm _where_ the bug is, so no need to

[Breeze] [Bug 379022] Update Task Switcher screenshots

2017-04-26 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=379022 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Component|general |general As

[Powerdevil] [Bug 378498] Power settings missing scrollbar

2017-04-13 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=378498 Christoph Feck <cf...@kde.org> changed: What|Removed |Added CC||hans.ullr...@l

[Breeze] [Bug 378606] Please replace those childish avatar images

2017-04-10 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=378606 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Target Milestone|1.0 |--- Assi

[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)

2017-03-29 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=363147 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Resolution|DUPLICATE |---

[Breeze] [Bug 348603] Small mouse size (24 size too small, 48 too big)

2017-03-29 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=348603 Christoph Feck <cf...@kde.org> changed: What|Removed |Added CC||ja...@james.tl --- Comm

[Breeze] [Bug 363147] Breeze cursors should have more sizes (patch included)

2017-03-29 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=363147 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Resolution|--- |DUPLICATE

D5169: Port away from KDELibs4Support

2017-03-24 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > kpci.cpp:96 > // line.setAscii(nameBuffer); //not work, > workaround below > - line = QString::fromAscii(pci_lookup_name(PCIAccess, > nameBuffer, NAME_BUFFER_SIZE, PCI_LOOKUP_VENDOR, info->cooked.vendor, 0,

D5169: Port away from KDELibs4Support

2017-03-24 Thread Christoph Feck
cfeck added a comment. Please add KCrash integration (which was done automatically for KApplication, but not for QApplication). REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D5169 To: rthomsen, #plasma, elvisangelaccio Cc: cfeck, plasma-devel, progwolff,

Re: style not drawing menu section/separator if 1st in menu

2017-03-21 Thread Christoph Feck
On 21.03.2017 16:36, René J. V. Bertin wrote: FWIW the same thing happens with both Breeze and Oxygen in their Qt4 versions. Expected, since QMenu:addSection() is new in Qt 5. Anyway, I researched a bit, you want QStyle::SH_Menu_SupportsSections.

Re: style not drawing menu section/separator if 1st in menu

2017-03-20 Thread Christoph Feck
On 20.03.2017 18:45, René J. V. Bertin wrote: The style I use (QtCurve) renders texted separators just fine, but not at the top of a menu. Always test with Fusion style. If it works there, the bug is in QtCurve.

Re: DrKonqi dependencies

2017-03-19 Thread Christoph Feck
On 19.03.2017 11:52, Jasem Mutlaq wrote: Problem is DrKonqi is now part of plasma-workspace. This makes it a *HUGE* dependency just for crash reporting. I obviously cannot ask non-KDE users to install plasma-workspace _just_ to have crash reporting capabilities. Using openSUSE packages here,

[Powerdevil] [Bug 377566] powerdevil crashes on boot

2017-03-13 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=377566 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Component|general |general Produ

D4970: Get rid of QWeakPointer

2017-03-11 Thread Christoph Feck
cfeck set the repository for this revision to R122 Powerdevil. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4970 To: denisshienkov, afiestas, ltoscano, volkov, davidedmundson, aacid Cc: aacid, davidedmundson, plasma-devel, volkov, progwolff, lesliezhai,

Re: LGPL a possibility for Breeze Qt widget style?

2017-03-11 Thread Christoph Feck
y omit the file. For a future KF5 version, I plan to make the KCharSelect class work better when the data file is missing. Christoph Feck

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

2017-03-10 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=375333 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Version Fixed In||17.04 -- You are rec

D5002: [oxygen/kstyle] Fix build

2017-03-10 Thread Christoph Feck
cfeck created this revision. cfeck added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Not sure if the stricter error checking is from gcc, cmake, or Qt, but on my system with recent versions, I get compile errors, because 'int' cannot be

[Powerdevil] [Bug 377130] Power Saving Settings screen cut off when using resolution scaling. Does not scroll, either.

2017-03-03 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=377130 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Component|general |general P

D4905: Disable editing of 'Global Shortcuts' component names

2017-03-02 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes.Closed by commit R119:cafc7d5a448a: Disable editing of 'Global Shortcuts' component names (authored by cfeck). View RevisionREPOSITORYR119 Plasma DesktopCHANGES SINCE LAST

D4905: Disable editing of 'Global Shortcuts' component names

2017-03-02 Thread Christoph Feck
cfeck created this revision.cfeck added a project: Plasma.Restricted Application added a subscriber: plasma-devel. View RevisionREVISION SUMMARYDouble clicking component names in systemsettings5 > Global Shortcuts starts name editing, which does not seem to be intended (the changes are not saved).

[Differential] [Closed] D4640: Fix array allocation for non-continuous cpu numbers

2017-02-18 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R106:e4c58c2f6ef7: Fix array allocation for non-continuous cpu numbers (authored by cfeck). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4640?vs=11423=11495

[Differential] [Closed] D4540: fix bug with git after update to Plasma 5.9 in neon

2017-02-17 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R105:408c284f6a35: Fix git ssh password detection (authored by cfeck). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4540?vs=11428=11475#toc REPOSITORY R105 KDE SSH Password Dialog CHANGES

[Differential] [Accepted] D4540: fix bug with git after update to Plasma 5.9 in neon

2017-02-16 Thread Christoph Feck
cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Thanks, looks good now. Do you have commit rights? If not, I will commit it on your behalf. REPOSITORY R105 KDE SSH Password Dialog BRANCH master REVISION DETAIL

[Differential] [Commented On] D4540: fix bug with git after update to Plasma 5.9 in neon

2017-02-16 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > main.cpp:62 > + > +//Case 3: Fix password extraction from git after update to Plasma 5.9 in > neon > +QRegularExpression re3("^(Password|Username) for (.*?)[:] $"); So are these strings really specific to git? Also, it makes no sense to

[Differential] [Commented On] D4540: fix bug with git after update to Plasma 5.9 in neon

2017-02-16 Thread Christoph Feck
cfeck added a comment. Use "Update Diff" to upload the correct diff. If you switched between different branches (as the current diff suggests), please make sure you solve the git issues first. If everything else fails, "git reset origin/master", and re-apply your changes. REPOSITORY R105

[Differential] [Request, 3 lines] D4640: Fix array allocation for non-continuous cpu numbers

2017-02-16 Thread Christoph Feck
cfeck created this revision. cfeck added a reviewer: Plasma. cfeck set the repository for this revision to R106 KSysguard. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As per https://bugs.kde.org/show_bug.cgi?id=376537

[Differential] [Commented On] D4540: fix bug with git after update to Plasma 5.9 in neon

2017-02-16 Thread Christoph Feck
cfeck added a comment. Any update? REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D4540 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: idekels, whiting, bbuch, mpyne, cfeck Cc: broulik, bbuch, cfeck,

[Differential] [Requested Changes To] D4540: fix bug with git after update to Plasma 5.9 in neon

2017-02-11 Thread Christoph Feck
cfeck requested changes to this revision. cfeck added a reviewer: cfeck. cfeck added a comment. This revision now requires changes to proceed. The patch is borked. Did you swap branches? REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D4540 EMAIL

[Differential] [Commented On] D4540: fix bug with git after update to Plasma 5.9 in neon

2017-02-10 Thread Christoph Feck
cfeck added a comment. The duplicate bug 376318 does not mention 'git', but simply opening a (secure) shell. Do both use the same 'ssh-add' command? If yes, then the comment mentioning 'git' might be misleading. REPOSITORY R105 KDE SSH Password Dialog BRANCH master REVISION DETAIL

[Differential] [Commented On] D4540: fix bug with git after update to Plasma 5.9 in neon

2017-02-09 Thread Christoph Feck
cfeck added a comment. One issue: The comments for the change that broke this state that 'sshaskpass' has no translations, so the prompt is the same in any locale. Could you verify if 'git' uses the same prompt in any language/locale? REPOSITORY R105 KDE SSH Password Dialog REVISION

[Differential] [Updated] D4540: fix bug with git after update to Plasma 5.9 in neon

2017-02-09 Thread Christoph Feck
cfeck added reviewers: whiting, mpyne. cfeck added a comment. Thanks, this looks good so far, but adding more eyes, because it touches privacy sensitive code. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D4540 EMAIL PREFERENCES

[Differential] [Commented On] D4533: Avoid a crash on Kwin decoration KCM teardown

2017-02-09 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > kcm.cpp:103 > m_quickView->rootContext()->setContextProperty("_borderSizesIndex", 3); > // 3 is normal > -m_quickView->rootContext()->setContextProperty("configurationModule", > this); > +

[Differential] [Commented On] D4533: Avoid a crash on Kwin decoration KCM teardown

2017-02-09 Thread Christoph Feck
cfeck added a comment. Be my hero! +1 REVISION DETAIL https://phabricator.kde.org/D4533 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Powerdevil] [Bug 376037] Plasma ignores screen lid action settings

2017-02-09 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=376037 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Assignee|k...@davidedmundson.co.uk|plasma-devel@kde.org

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-07 Thread Christoph Feck
cfeck added a comment. QApplication::desktopFileName() was only added in Qt 5.7, while frameworks still support Qt 5.6. Please add a Qt version check around the new code. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4416 EMAIL PREFERENCES

[Differential] [Accepted] D4410: Fix header content size when sorting is disabled

2017-02-03 Thread Christoph Feck
cfeck accepted this revision. cfeck added a reviewer: cfeck. This revision is now accepted and ready to land. REPOSITORY R113 Oxygen Theme BRANCH fix-unsortable-item-view-header-size REVISION DETAIL https://phabricator.kde.org/D4410 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D4406: Fix header content size when sorting is disabled

2017-02-02 Thread Christoph Feck
cfeck added a subscriber: hpereiradacosta. cfeck added a comment. I have added Hugo (Breeze and Oxygen style maintainer). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D4406 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: astan,

[Differential] [Commented On] D4406: Fix header content size when sorting is disabled

2017-02-02 Thread Christoph Feck
cfeck added a comment. QCommonStyle also adds the margins only when a sort indicator is needed, so +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D4406 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: astan, #breeze Cc: cfeck,

Re: Review Request 129835: [IconDialog] Set proper icons group

2017-02-01 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129835/#review102347 --- Ship it! Ship It! - Christoph Feck On Jan. 15, 2017

[Differential] [Commented On] D4401: Pressing Enter should open submenus in Kicker

2017-02-01 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > MenuRepresentation.qml:404 > } else if (event.key == Qt.Key_Enter || event.key == > Qt.Key_Return) { > +console.log("DAVE"); > if (runnerColumns.visible && > runnerModel.modelForRow(0).count) { Dave?

[Differential] [Commented On] D4401: Pressing Enter should open submenus in Kicker

2017-02-01 Thread Christoph Feck
cfeck added a comment. You won't believe how often I have stumbled upon this, so +1 Since you now cannot focus the search field on Enter (after you already used Up/Down), I suggest to focus it on Tab, but without actually inserting a Tab character. REPOSITORY R119 Plasma Desktop

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

2017-01-20 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=375333 Christoph Feck <cf...@kde.org> changed: What|Removed |Added CC||lui...@lftabera.es --- C

[plasmashell] [Bug 363860] Slideshow does not cycle if only one image in set directory

2017-01-19 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=363860 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Target Milestone|--- |1.0 V

Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

2017-01-19 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129851/#review102095 --- Ship it! Ship It! - Christoph Feck On Jan. 18, 2017

Re: Review Request 129851: JpegCreator: Use Qt's support for fast downscaling and auto-rotation

2017-01-18 Thread Christoph Feck
if the rotation options expected by Qt are the same as returned by the settings. - Christoph Feck On Jan. 18, 2017, 9:36 p.m., Alexander Volkov wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Crash in new connections KCM

2017-01-11 Thread Christoph Feck
On 11.01.2017 08:51, Jan Grulich wrote: Hi, I'm experiencing a crash when closing (using cancel button) the new connections KCM (from plasma-nm) and I'm not able to find out why this is happening. Don't worry, happens with all KCM modules that use QML, see

Re: Plasma 5.9 Beta announce

2017-01-10 Thread Christoph Feck
On 10.01.2017 19:37, Jonathan Riddell wrote: Draft announce is up for Plasma 5.9, please have a read though and check it's accurate and makes sense. Look at the pictures to check they match, check the links and captions and see it all makes sense.

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2017-01-04 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #20 from Christoph Feck <cf...@kde.org> --- Kai, would it be possible to fade to say 25% instead of 0%, and fade the remaining 25% a second before it is turned off? This way, the user still sees that the display is not off yet, but

[Powerdevil] [Bug 374483] Powerdevil KCM is too tall for my screen

2017-01-03 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=374483 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Resolution|--- |DUPLICATE

[Breeze] [Bug 374168] make buttons flat in breeze

2016-12-30 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=374168 Christoph Feck <cf...@kde.org> changed: What|Removed |Added Severity|normal |wishlist --- Comment #

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

2016-12-29 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=374311 --- Comment #2 from Christoph Feck <cf...@kde.org> --- https://bugreports.qt.io/browse/QTBUG-6632 -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 374311] it is too easy to activate context menu item if mouse moves during right-click

2016-12-29 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=374311 --- Comment #1 from Christoph Feck <cf...@kde.org> --- This needs to be fixed in Qt, and was already reported, but some Qt bug triager did not believe it is possible to select a menu item without explicitely clicking on it, so it was closed as i

[Breeze] [Bug 374035] Some controls do not scale according to current DPI

2016-12-22 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=374035 --- Comment #6 from Christoph Feck <cf...@kde.org> --- We can only support what Qt offers us. Right now, Qt only supports scaling by integer factors, i.e. 1x, 2x, 3x etc. -- You are receiving this mail because: You are the assignee for the bug.

<    1   2   3   4   5   6   >