Re: ddcutil in Plasma Powerdevil

problem may jump out at me. > > > > Sanford > > > > On 9/30/19 9:07 AM, Jonathan Riddell wrote: > > > > I put ddcutils package in Neon unstable to be able to test it, using > > Sanford's packaging from Debian but with the libraries turned on. However &g

Re: ddcutil in Plasma Powerdevil

Hey Jonathan, Unfortunately I did not test it for a long time (last time was around 5.15), and don't really have the possibility now because I'm away from home. *If I remember correctly,* back then I had a few instances when the startup of plasma (during the splashscreen) was quite longer due to

D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors

dvogel updated this revision to Diff 55854. dvogel added a comment. Applied changes suggested by @broulik. Thank you for your help. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8626?vs=55690=55854 REVISION DETAIL https://phabricator.kde.org/D8626

D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors

dvogel updated this revision to Diff 55690. dvogel marked an inline comment as done. dvogel added a comment. Reverted to the "old way" of trying ddcutil compatibility of the detected displays: by trying to read the feature setting. The `ddca_get_feature_list_by_dref` function was giving

D8626: DDCUtil: Improved DDCUtil support for brightness control

dvogel updated this revision to Diff 55605. dvogel added a comment. Thanks to Nate, I went a bit back to it. It is again in a working state with the current DDCUtil API. Still, single slider independently of the number of displays supporting ddc connected. Tested with my dell 2212hm and

D8626: DDCUtil: Improved DDCUtil support for brightness control

dvogel added a comment. Yes it has to be modified. I got it to compile again over lunch on a laptop, however could not test it (has to be on a desktop, since powerdevil picks integrated screens first for brightness). REPOSITORY R122 Powerdevil REVISION DETAIL

D8626: DDCUtil: Improved DDCUtil support for brightness control

dvogel added a comment. In D8626#443079 , @ngraham wrote: > Probably because @dvogel doesn't have commit access and nobody ever landed the patch on his behalf. :( Feel free to do so now I guess, since @kbroulik has accepted it. Yes, kind

D8626: DDCUtil: Improved DDCUtil support for brightness control

dvogel updated this revision to Diff 33105. dvogel added a comment. Applied changes to the CMakeList. Somehow the previous diff was messed-up: downloading it would provide a diff with the wrong folder structure... REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE

D8626: DDCUtil: Improved DDCUtil support for brightness control

dvogel updated this revision to Diff 32187. dvogel marked 5 inline comments as done. dvogel added a comment. Applied changes suggested by broulik. CMake fixed, using the checkbox for WITH_DDCUTIL in Kdevelop now works. I must appologise for the long time this is taking. The diff is based

D8626: DDCUtil: Improved DDCUtil support for brightness control

dvogel created this revision. dvogel added reviewers: broulik, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Reworked & simplified based on feedback from DDCUtil author. Fixed CMakeList to add

D5381: Add brightness control using ddcutil lib

dvogel updated this revision to Diff 21592. dvogel added a comment. Reworked for simplification. REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5381?vs=14856=21592 REVISION DETAIL https://phabricator.kde.org/D5381 AFFECTED FILES CMakeLists.txt

Re: ddcutil .deb

Hi all, Thanks for the comments ! And sorry for the late reply. I realize the implementation is far from optimal, and would be happy to rework it. Unfortunately I'm quite busy with other things right now, and for about two more weeks so I can not really swear anything until then. Jonathan:

D5381: Add brightness control using ddcutil lib

dvogel updated this revision to Diff 14854. dvogel added a comment. applied comments from d_ed fixed brightness jumping to previous position after brightness change: see DDCutilBrightness::brightness() CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5381?vs=14843=14854 REVISION

D5381: Add brightness control using ddcutil lib

dvogel updated this revision to Diff 14843. dvogel added a comment. Absence of ddcutil on the system is now handled: the ddcbrightness object is still instantiated in powerdevilupowerbackend, however, this is a dummy object, returning isSupported()=FALSE, making powerdevilupowerbackend

D5381: Add brightness control using ddcutil lib

dvogel added a comment. The final conclusion was that I should figure out some cmake to allow building without ddccontrol. I kind of did it locally (tho it's a bit dirty). The second big point is that powerdevil only supports one brightness controller at a time. The solution kbroulik

D5381: Add brightness control using ddcutil lib

dvogel updated this revision to Diff 13586. dvogel added a comment. Addition of a QTimer set by default to 1 sec to filter setBrightness calls: the actual DDC communication happens 1 sec after the last setBrightness() call. This solves brightness flickering when scrolling quickly on the

D5381: Add brightness control using ddcutil lib

dvogel updated this revision to Diff 13395. dvogel marked 6 inline comments as done. dvogel added a comment. Applied changes suggested by reviewers. The only issue remaining is brightness restoration when waking up the monitor after shutting it down: we try to set brightness before the

D5381: Add brightness control using ddcutil lib

dvogel marked 9 inline comments as done. dvogel added a comment. Ok, so there is apparently an issue when the screen gets dimmed. Application: org_kde_powerdevil (org_kde_powerdevil), signal: Segmentation fault Using host libthread_db library "/usr/lib/libthread_db.so.1".

D5381: Add brightness control using ddcutil lib

dvogel created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Setting up ddcutil for non-root CLI use is required first. Please refer to