D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. I installed a fresh Neon (dev unstable), removed the preinstalled files from /etc/fonts, copied your files to /etc/fonts and applied this patch. Still cannot reproduce your issue. F6216652: Screenshot_20180826_151000.png

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. I still cannot reproduce your issue. Any idea what I could try? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, ngraham, #plasma Cc: rkflx, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff planned changes to this revision. progwolff added a comment. In D12925#302675 , @ngraham wrote: > With this latest version, the issue I mentioned earlier persists for me. I did briefly get sub-pixel rendering again to work by switching

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38969. progwolff added a comment. - fix writing config temporarily (previews) with missing local config entries REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=38829=38969 BRANCH arcpatch-D12925

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. could you give me all those files? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, ngraham, #plasma Cc: rkflx, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. Works for me F6167260: Screenshot_20180731_164900.png Could you show me your `~/.config/fontconfig/fonts.conf` and the content of `/etc/fonts/conf.d`? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38829. progwolff added a comment. - fix previews REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=38828=38829 BRANCH arcpatch-D12925 REVISION DETAIL https://phabricator.kde.org/D12925 AFFECTED

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. I am not sure about the case when neither global nor local configs exist for subpixel or hint. On my system it seems like rgb subpixel rendering with slight hinting is used when no configs exist. But I cannot find any documentation on this. We also need to

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38828. progwolff added a comment. - Merge branch 'master' of git://anongit.kde.org/plasma-desktop into arcpatch-D12925 - Merge branch 'master' of git://anongit.kde.org/plasma-desktop into arcpatch-D12925 - also drop vendor-default-option for

D14480: Don't unintentionally change font rendering when rendering preview images

This revision was automatically updated to reflect the committed changes. Closed by commit R119:79a4bbc36cee: Dont unintentionally change font rendering when rendering preview images (authored by progwolff). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D14480: Don't unintentionally change font rendering when rendering preview images

progwolff created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY Font rendering settings are changed temporarily to render preview images. The changed settings

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38764. progwolff added a comment. - split changes to previewimageprovider.cpp to a separate commit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=38757=38764 BRANCH arcpatch-D12925 REVISION DETAIL

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. Big sorry for being away for so long. I had some things to do that took much more time than initally planned. Many thanks to those who fixed the bugs I introduced or created workarounds... I tried to get this patch working now. First of all, I want to say a

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38757. progwolff added a comment. Rebase on master. Partial rewrite. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=34315=38757 BRANCH arcpatch-D12925 REVISION DETAIL

D12851: Change preview text background color to match with default combobox background color

progwolff added a comment. Sorry for the delay... I planned to land this together with D12849 and D12925 . It will take me two weeks or so until I can continue working on this. I need to finish my master thesis

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. In D12925#264085 , @rkflx wrote: > I'll resume testing once this works a bit better. I'd say let's not rush this, and get it right for 5.14. I agree. Thanks for investigating! REPOSITORY R119 Plasma Desktop

D12849: Improve layout of fonts kcm

progwolff updated this revision to Diff 34350. progwolff added a comment. - i18n REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12849?vs=34349=34350 BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL

D12849: Improve layout of fonts kcm

progwolff updated this revision to Diff 34349. progwolff added a comment. - title case for 'Choose a Font' REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12849?vs=34209=34349 BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL

D12849: Improve layout of fonts kcm

progwolff added a comment. In D12849#263865 , @rkflx wrote: > Did not review the code, but I noticed some warnings in addition to those mentioned above: > > share/kpackage/kcms/kcm_fonts/contents/ui/main.qml:230:25: QML Image: Invalid

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 34315. progwolff added a comment. - remove unintentionally committed debug lines REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=34274=34315 BRANCH fonts_kcm_globalConfigFiles (branched from master)

D12849: Improve layout of fonts kcm

progwolff added a comment. That would be this one: In D12849#262919 , @progwolff wrote: > F5849709: Screenshot_fonts_layout_tabbar.png @mart @rkflx @broulik is this okay for you? REPOSITORY

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. In D12925#263459 , @mart wrote: > if it removes the vendor default option, how can i ask to not touch the global/local defaults in any way? Just don't change anything in the kcm. The global config files are

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 34274. progwolff added a comment. - Fix 'disabled from' REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=34272=34274 BRANCH fonts_kcm_globalConfigFiles (branched from master) REVISION DETAIL

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff created this revision. progwolff added a reviewer: rkflx. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY The fonts kcm did only parse a local config file. Global and

D12849: Improve layout of fonts kcm

progwolff added a comment. In D12849#263302 , @broulik wrote: > We were always told by VDG that tabs are bad and a 5 km vertically scrolling list is better no matter what. So be consistent, please. I thought I read something like this in

D12849: Improve layout of fonts kcm

progwolff added a comment. From what I could find there is no TabView in QtQuickControls2 or Kirigami. This is how it's done in Kirigami Gallery: F5849728: kirigami.png I agree that this should be improved, but it's probably better to do this in

D12849: Improve layout of fonts kcm

progwolff added a comment. In D12849#262903 , @ngraham wrote: > @progwolff, what happened to the frame for the tabbed view? Did it the wrong way. Is fixed now. > Also, why is there still a scrollbar there? I have no idea. The

D12849: Improve layout of fonts kcm

progwolff updated this revision to Diff 34209. progwolff added a comment. - fix tabbar frame REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12849?vs=34197=34209 BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL

D12849: Improve layout of fonts kcm

progwolff added a comment. Using tabs there are some problems with Kirigami now: file:///usr/lib/qt/qml/org/kde/kirigami.2/ScrollablePage.qml:159: ReferenceError: applicationWindow is not defined ... : QML QQuickLayoutAttached: Binding loop detected for property "alignment"

D12849: Improve layout of fonts kcm

progwolff updated this revision to Diff 34197. progwolff added a comment. - fix button widths REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12849?vs=34196=34197 BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL

D12849: Improve layout of fonts kcm

progwolff updated this revision to Diff 34196. progwolff added a comment. - use tabs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12849?vs=34191=34196 BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL

D12849: Improve layout of fonts kcm

progwolff added a comment. F5849518: Screenshot_fonts_layout_tab2.png F5849517: Screenshot_fonts_layout_tab1.png REPOSITORY R119 Plasma Desktop BRANCH fonts_kcm_layout (branched from master) REVISION

D12849: Improve layout of fonts kcm

progwolff marked an inline comment as done. progwolff added a comment. F5849439: Screenshot_fonts_layout_radio2.png REPOSITORY R119 Plasma Desktop BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D12849

D12849: Improve layout of fonts kcm

progwolff updated this revision to Diff 34191. progwolff added a comment. - Use radio buttons. Use spacing instead of Separator. Simplify max(...). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12849?vs=34065=34191 BRANCH fonts_kcm_layout

D12849: Improve layout of fonts kcm

progwolff added a comment. In D12849#262782 , @rkflx wrote: > In D12849#262781 , @progwolff wrote: > > > In D12849#262777 , @rkflx wrote: > > > > >

D12849: Improve layout of fonts kcm

progwolff added a comment. In D12849#262777 , @rkflx wrote: > > BTW, what's the difference between Vendor Default and the regular Defaults button? Either we provide an option to reset to the default for every single option

D12849: Improve layout of fonts kcm

progwolff added a comment. How about joining the options instead? F5849093: Screenshot_fonts_layout_radio.png REPOSITORY R119 Plasma Desktop BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D12849

D12849: Improve layout of fonts kcm

progwolff added a comment. You mean like this? F5848305: Screenshot_fonts_layout_nocheckableitems.png Not sure if I like this better... This way "Exclude range" seems to be somewhat unrelated to "Anti-Aliasing". Also, it is not very clear what

D12849: Improve layout of fonts kcm

progwolff added a comment. In D12849#261837 , @ngraham wrote: > We might want to take the opportunity to also center-align the titles, which it better-looking for these centered formlayout style UIs. Section titles in form layouts are

D12851: Change preview text background color to match with default combobox background color

progwolff created this revision. progwolff added reviewers: mart, abetts, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY The default combobox background color is

D12849: Improve layout of fonts kcm

progwolff created this revision. progwolff added reviewers: mart, abetts, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY Change the layout of the fonts kcm using

D11289: checkable FormLayout items

This revision was automatically updated to reflect the committed changes. Closed by commit R169:6ac4e62002ae: checkable FormLayout items (authored by progwolff). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11289?vs=29937=31751 REVISION DETAIL

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 30325. progwolff added a comment. - giant comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28856=30325 BRANCH arcpatch-D11064 REVISION DETAIL https://phabricator.kde.org/D11064 AFFECTED

D11289: checkable FormLayout items

progwolff updated this revision to Diff 29937. progwolff marked 3 inline comments as done. progwolff added a comment. - split buddyComponent and checkableBuddyComponent - toggle checkbox on shortcut activated REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D11289: checkable FormLayout items

progwolff planned changes to this revision. progwolff added a comment. In D11289#229340 , @mart wrote: > can you provide screenshots as well t see how does it look? I added one under "test plan". INLINE COMMENTS > mart wrote in

D10251: [RFC] Use mipmap filtering in window thumbnails

progwolff added a comment. Thanks! I tested it with several running applications, including windows with different apect ratios and combined previews for multiple instances of the same application. Looks great in every case. +1 from me! REPOSITORY R242 Plasma Framework (Library)

D10251: [RFC] Use mipmap filtering in window thumbnails

progwolff added a comment. Could you please rebase on current master? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: progwolff, broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot,

D11308: Use the default Plasma wallpaper on the lock screen

progwolff added a comment. @hein might be right here. If it's the single-click/double-click thing or this issue here: People who are happy with the status quo won't reach out to us. Maybe we need to discuss at a different place if and how we can learn about the opinion of the majority of

D11316: Components for Cards

progwolff added a comment. There seems to be a problem with the overflow menu: F5753673: Screenshot_20180314_121900.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D11316 To: mart, #kirigami Cc: davidedmundson,

D11316: Components for Cards

progwolff added a comment. Marked some typos. Note that I am not a native speaker, so please re-check them. Besides that, looks good to me. INLINE COMMENTS > CardsGridViewGallery.qml:61 > +wrapMode: Text.WordWrap > +text: "The Kirigami types AbstractCard and

D11289: checkable FormLayout items

progwolff created this revision. progwolff added reviewers: VDG, Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY In some cases, form items go together with a

D11064: add preview images to fonts kcm

progwolff added a comment. @davidedmundson ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson, ngraham Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai,

D11180: Reverse tooltip colors for Breeze colorscheme

progwolff added a comment. I remember that the dark tooltips felt strange to me when I started using breeze. Now that I am used to it, I actually prefer the dark tooltips because of their high contrast to the other GUI elements. But as breeze dark uses dark tooltips too, this change

D11174: fix detecting changes in sub-pixel and hinting settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ac5c39292836: fix detecting changes in sub-pixel and hinting settings (authored by progwolff). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D11174: fix detecting changes in sub-pixel and hinting settings

progwolff created this revision. progwolff added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY Since #R119, on changes to the sub-pixel and hinting

D11064: add preview images to fonts kcm

progwolff added a comment. In D11064#220180 , @ngraham wrote: > Since this is a patch for `plasma-desktop`, perhaps it would be more appropriate to use the Heading from PlasmaComponents rather than the one from Kirigami? We already have

D11064: add preview images to fonts kcm

progwolff added a comment. Sounds reasonable. F5743624: Screenshot_20180306_190613.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28856. progwolff added a comment. - use Kirigami heading instead of QQuickControls2 Label REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28844=28856 BRANCH master REVISION DETAIL

D11064: add preview images to fonts kcm

progwolff added a comment. In D11064#220134 , @ngraham wrote: > My vote goes to using the standard colors from the active theme without messing with them. At least we should not hardcode colors. So it's either an opacity of about 0.8 to

D11064: add preview images to fonts kcm

progwolff added a comment. In D11064#220131 , @ngraham wrote: > I'm not thrilled with the really light 50% opacity labels, to be honest. What do you propose? I am not much of a designer... REPOSITORY R119 Plasma Desktop REVISION

D11064: add preview images to fonts kcm

progwolff added a comment. In D11064#220120 , @abetts wrote: > In D11064#220118 , @progwolff wrote: > > > Seems like VDG is happy then :D > > Many thanks to both of you! > > > >

D11064: add preview images to fonts kcm

progwolff edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham, davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D11064: add preview images to fonts kcm

progwolff added a comment. Seems like VDG is happy then :D Many thanks to both of you! @davidedmundson Any objections left? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11064: add preview images to fonts kcm

progwolff added a comment. F5743545: Screenshot_20180306_170938.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham, davidedmundson, abetts,

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28844. progwolff added a comment. - Merge branch 'master' of git://anongit.kde.org/plasma-desktop - adjust label opacity and size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28817=28844 BRANCH

D11064: add preview images to fonts kcm

progwolff added a comment. We don't have a font name here. The choices are always "Vendor default", "None", "RGB", "BGR", "vertical RGB", "vertical BGR". I am not sure what a number would mean here? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To:

D11064: add preview images to fonts kcm

progwolff added a comment. The list will always have the same 6 entries. This is not about choosing a font, but about choosing details about how a font is rendered. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart,

D11064: add preview images to fonts kcm

progwolff added a comment. How about this? F5743529: Screenshot_20180306_164925.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11064: add preview images to fonts kcm

progwolff added a comment. @abetts @ngraham Do you count from 0 or 1? Number 2 is single line `The quick brown fox...`? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: ngraham,

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28817. progwolff added a comment. - fix parsing hinting index REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28811=28817 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11064

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28811. progwolff added a comment. - style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28804=28811 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11064 AFFECTED FILES

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28804. progwolff added a comment. - never show scrollbars for the combobox popup (force pixel aligment) - prepare for multi-line preview images, resize images to pixel-align on high dpi displays REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D11064: add preview images to fonts kcm

progwolff marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28802. progwolff added a comment. - adjust popup width to fit contents REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28792=28802 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11064

D11064: add preview images to fonts kcm

progwolff added a comment. In D11064#219273 , @abetts wrote: > Is there a way that the list width can be dynamic so as to accommodate the name of the font family? I would prefer not to include the font family name in the combobox at all.

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28792. progwolff added a comment. - revert qml transforms, workaround QTBUG-38127 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28767=28792 BRANCH master REVISION DETAIL

D11064: add preview images to fonts kcm

progwolff added inline comments. INLINE COMMENTS > davidedmundson wrote in previewrenderengine.cpp:136 > change to > > QImage image(draw(name, style,...)); > image.setDevicePixelRatio(ratio); > return image; > > This keeps the metadata of the image scaling with the image, and then the > Image

D11064: add preview images to fonts kcm

progwolff marked 3 inline comments as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart, davidedmundson Cc: davidedmundson, abetts, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D11064: add preview images to fonts kcm

progwolff added inline comments. INLINE COMMENTS > progwolff wrote in previewrenderengine.cpp:136 > Thanks, this would be much cleaner. Sadly it doesn't seem to work. > I tried this before. Also tried `setDotsPerMeterX`. > > The image is drawn too big with `QT_SCREEN_SCALE_FACTORS=2`: >

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28767. progwolff added a comment. - fix preview scale on high dpi screens REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28740=28767 BRANCH master REVISION DETAIL

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28740. progwolff added a comment. - fix face number REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28737=28740 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11064 AFFECTED FILES

D11064: add preview images to fonts kcm

progwolff added a comment. Thanks for your feedback! This patch was ment to provide the functionality we need for the UI redesign, but you are probably right that I should fix the mentioned problems before we land this. I will see what I can do about the popup width, the preview text

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28737. progwolff marked 7 inline comments as done. progwolff edited the summary of this revision. progwolff added a comment. - revert QtQuick.Controls version - coding style, unneccessary defaults, Label instead of Text - split only once, add range

D11064: add preview images to fonts kcm

progwolff updated this revision to Diff 28735. progwolff added a comment. - cleanup - add license REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11064?vs=28734=28735 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11064 AFFECTED

D11064: add preview images to fonts kcm

progwolff edited the summary of this revision. progwolff edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11064 To: progwolff, #plasma, harmathy, mart Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D11064: add preview images to fonts kcm

progwolff created this revision. progwolff added reviewers: Plasma, harmathy, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. progwolff requested review of this revision. REVISION SUMMARY The fonts kcm offers different font

D7424: Very slightly increase text contrast for the default Breeze color scheme

progwolff added a comment. But only for breeze dark. And it seems to have the same contrast between background and text like the regular breeze dark. Nathanial, maybe you could introduce a breeze light high contrast color scheme and try to optimize the contrast on the two high contrast

D7424: Very slightly increase text contrast for the default Breeze color scheme

progwolff added a comment. In https://phabricator.kde.org/D7424#157438, @ngraham wrote: > In https://phabricator.kde.org/D7424#157398, @progwolff wrote: > > > The W3C recommendation you referenced has an online tool to check specific colors:

D7424: Very slightly increase text contrast for the default Breeze color scheme

progwolff added a comment. The W3C recommendation you referenced has an online tool to check specific colors: http://juicystudio.com/services/luminositycontrastratio.php#specify Current breeze colors give > Passed at Level AAA: The luminosity contrast ratio is very good for the

D8276: [SideBar] enable LayoutMirroring for RTL

progwolff added a comment. Is it just for me, or is the layout mirrored unconditionally now? F5436506: systemsettings_rtl.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8276 To: ttv20, broulik, davidedmundson

D8277: Background color for sidebar headers

This revision was automatically updated to reflect the committed changes. Closed by commit R124:c47fa0c75736: Background color for sidebar headers (authored by progwolff). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20801=20934 REVISION

Re: Bold font rendering

Am Freitag, 6. Oktober 2017, 13:49:07 CEST schrieb Guanpeng Xu: > Hello, > > I found an issue on bold font rendering in KDE Frameworks 5.37.0 using Qt > 5.9.1, on NixOS 17.09.1502.19879836d1. > > The issue was previously discussed here: https://marc.info/?l=kde=150 > 728730630509=2 The

D8277: Background color for sidebar headers

progwolff added a comment. @mart ? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma_workspaces, mart Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8277: Background color for sidebar headers

progwolff updated this revision to Diff 20801. progwolff added a comment. - also revert newline REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20799=20801 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8277 AFFECTED FILES

D8277: Background color for sidebar headers

progwolff updated this revision to Diff 20799. progwolff added a comment. - revert changes to SubCategoryPage REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20688=20799 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8277

D8232: Add option to center shadow

progwolff added a comment. I am on Michail's side. Having the shadow falling at the bottom right feels more natural to me. I also like the sharper edge at the left. Makes the overall look of the desktop a little cleaner. Actually, the clean look of breeze was the main reason why I

D8277: Background color for sidebar headers

progwolff updated this revision to Diff 20688. progwolff added a comment. - normal font weight REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20687=20688 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8277 AFFECTED FILES

D8277: Background color for sidebar headers

progwolff added a comment. F5428500: systemsettings_small.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D8277 To: progwolff, #plasma_workspaces, mart Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff,

D8277: Background color for sidebar headers

progwolff updated this revision to Diff 20687. progwolff added a comment. - change opacity of secondary heading REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8277?vs=20684=20687 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8277

D8277: Background color for sidebar headers

progwolff added a comment. On second thought, the secondary heading acts like a button for small screens. This means, now that the background is the same as buttonBackground, it will look like a disabled button. I will change the text color to solid black. REPOSITORY R124 System

  1   2   >