D26958: [Kickoff] Don't enable OpacityMask layer.effect in software mode

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a727fde4cb9: [Kickoff] Dont enable OpacityMask layer.effect in software mode (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26958: [Kickoff] Don't enable OpacityMask layer.effect in software mode

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It won't render otherwise. The code tried to check but only disabled the outline, not the actual

D26953: Replace Ice Cold with Volna for Plasma 5.18

broulik added a comment. What's with the odd dithering, though? Is that intentional? FTR at 3840x2160 our past images were: 5.16 (ice cold) 3.2 MiB 5.14 (the one with the galaxy) 3.9 MiB 5.12 (the blue-brown stripe) 3.2 MiB 5.10 2.3 MiB 5.9 (canoppee with the "9") a whopping 5.9

D26943: [Notifications] Set transient parent for file menu

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3c31b7a6a1b7: [Notifications] Set transient parent for file menu (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26943: [Notifications] Set transient parent for file menu

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Required on Wayland so it can be properly positioned. BUG: 387597 FIXED-IN: 5.18.0 TEST

D26941: [Task Manager] Remove strict URL handling

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The code tried hard to ignore garbage URLs, as Qt is quite lenient, e.g. `QUrl("Garbage

D26881: [Applets/Folder View] Allow using a folder that ends with a space

broulik added a comment. That's somewhat oddly spcific, isn't it? I'd be surprised that `fromLocalFile` strips trailing spaces? :0 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26881 To: ngraham, hein, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n,

D26896: Kill the KinfoCenter binary

broulik added a comment. Would it make sense to keep a `kinfocenter` script that just launchers `systemsettings5 -i` for compat? Does it still show up if you type "kinfocenter" into KRunner, not sure if it uses the `Exec` for that if this name is in the desktop file somewhere other than

D26895: Introduce an Info Center mode

broulik added a comment. Great idea! INLINE COMMENTS > SettingsBase.h:100 > KAboutApplicationDialog * aboutDialog = nullptr; > +bool m_infoCenterMode = false; > }; I would prefer this to be an enum > main.cpp:66 > +if (infoCenterMode) { > +

D26850: [SystemTray] Refresh icon in settings on update

broulik added inline comments. INLINE COMMENTS > systemtraymodel.cpp:269 > +QHash roleNames = sourceModel->roleNames(); > +for (const int key : roleNames.keys()) { > +if (!m_roleNames.contains(key)) { Avoid `keys()` which creates a temporary list, instead use iterators const

D26797: KCM/Component Refactor UI to a single list of combobox

broulik added inline comments. INLINE COMMENTS > componentchooser.cpp:65 > > - if (loadedConfigWidget) { > - configWidgetMap.insert(service, loadedConfigWidget); > - configContainer->addWidget(loadedConfigWidget); > - connect(loadedConfigWidget,

D26842: Fix fonts KCM button state

broulik added inline comments. INLINE COMMENTS > fonts.cpp:479 > +defaultState.dpi = 0; > +defaultState.subPixel = KXftConfig::SubPixel::Rgb; > +defaultState.hinting = KXftConfig::Hint::Slight; Kinda defies the purpose of using kconfigxt if we end up hardcoding the state in code

D26806: [Applets/Power Manager] Update layout based on T10470

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in BatteryItem.qml:64 > You can't do that. > > That'll change the column size, which will change our text bounding box which > will change our paintedWidth. A loop. That's been in there ever since the initial release 2013.

D26862: Remove unused includes

This revision was automatically updated to reflect the committed changes. Closed by commit R102:5a5f32ea02f8: Remove unused includes (authored by broulik). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26862?vs=74197=74219 REVISION DETAIL

D26825: Bind gtk-enable-animations setting to global animation speed slider

This revision was automatically updated to reflect the committed changes. Closed by commit R99:66ab37df7aed: Bind gtk-enable-animations setting to global animation speed slider (authored by broulik). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D26825: Bind gtk-enable-animations setting to global animation speed slider

broulik updated this revision to Diff 74203. broulik added a comment. - Fix typos REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74193=74203 REVISION DETAIL https://phabricator.kde.org/D26825 AFFECTED FILES

D26862: Remove unused includes

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - Compiles REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D26862

D26825: Bind gtk-enable-animations setting to global animation speed slider

broulik updated this revision to Diff 74193. REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74115=74193 REVISION DETAIL https://phabricator.kde.org/D26825 AFFECTED FILES kded/configeditor.cpp kded/configeditor.h

D26640: [applets/weather] Port weather station picker to QQC2+ListView

broulik added a comment. Using `Kirigami.SearchField` would be nice, so Ctrl+F acts as a shortcut for getting back to the search field when focus jumped to the list. (And can we later improve that weird workflow where no providers are selected and the Search field is disabled for no

D26784: KCM KDED: Add immutability and fix default, reset, apply buttons

broulik added a comment. Not a fan of the `AutoloadEnabledSavedRole` in the model INLINE COMMENTS > kcmkded.cpp:269 > +if (!idx.data(ModulesModel::ImmutableRole).toBool()) { > +m_model->setData(idx, true, ModulesModel::AutoloadEnabledRole); > } I think instead

D26825: Bind gtk-enable-animations setting to global animation speed slider

broulik updated this revision to Diff 74115. broulik added a comment. - Drop pointless argument REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74108=74115 REVISION DETAIL https://phabricator.kde.org/D26825 AFFECTED FILES

D26825: Bind gtk-enable-animations setting to global animation speed slider

broulik updated this revision to Diff 74108. broulik added a comment. - Drop superfluous `reparseConfiguration` call REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74094=74108 REVISION DETAIL https://phabricator.kde.org/D26825

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

broulik added inline comments. INLINE COMMENTS > settings.cpp:40 > > +const static QString s_configFile { QStringLiteral("plasmanotifyrc") }; > + Global statics are to be avoided in libraries > settings.cpp:183 > > +Settings::Settings(const KSharedConfig::Ptr &, QObject *parent) > +:

D26825: Bind gtk-enable-animations setting to global animation speed slider

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in configvalueprovider.cpp:146 > You don't need this. > > KConfigWatcher does it automagically on change. > > I did that because I wanted a way for N connections to only reparse the file > once. It also means you can use

D26825: Bind gtk-enable-animations setting to global animation speed slider

broulik updated this revision to Diff 74094. broulik added a comment. - Fix settings key REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74080=74094 REVISION DETAIL https://phabricator.kde.org/D26825 AFFECTED FILES

D26825: Bind gtk-enable-animations setting to global animation speed slider

broulik updated this revision to Diff 74080. broulik added a comment. - Add GTK2 key REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74077=74080 REVISION DETAIL https://phabricator.kde.org/D26825 AFFECTED FILES

D26825: Bind gtk-enable-animations setting to global animation speed slider

broulik created this revision. broulik added reviewers: Plasma, gikari. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When it is set to "Instant", turn off GTK animations. TEST PLAN - Started gedit,

D26726: [Breeze Cursors] Add some more cursor names

This revision was automatically updated to reflect the committed changes. Closed by commit R31:419274f46a67: [Breeze Cursors] Add some more cursor names (authored by broulik). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26726?vs=73760=74076 REVISION DETAIL

D26494: Runner/Windows make the window finding more reliable

broulik added a comment. Sorry, I don't know how any of that prepare and teardown stuff works, so I can't really judge. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26494 To: meven, #plasma, ngraham, broulik Cc: plasma-devel, Orage, LeGast00n,

D26047: Expose KConfig settings to allow registration in KCM Notification

broulik added a comment. Other than the seemingly missing `config`, looks good INLINE COMMENTS > settings.cpp:173 > -if (!s_settingsInited) { > -DoNotDisturbSettings::instance(config); > -NotificationSettings::instance(config); I still want to be able to specify what

D26531: [Wallpaper] Show author as subtitle in configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3729873fdd1d: [Wallpaper] Show author as subtitle in configuration (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26803: [Notifications] Send reply text as targeted signal

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5369cf775c4b: [Notifications] Send reply text as targeted signal (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26796: [Notifications] When there is only a reply action, show reply field right away

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3328f6a2f5ad: [Notifications] When there is only a reply action, show reply field right away (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26796?vs=73998=74010#toc

D26803: [Notifications] Send reply text as targeted signal

broulik updated this revision to Diff 74006. broulik added a comment. - No fallback, `createTargetedSignal` without a service seems to behave like the non-targeted version REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26803?vs=73999=74006

D26803: [Notifications] Send reply text as targeted signal

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoids waking up non-interested parties. TEST PLAN 5.18 while it is an API change, it was

D26796: [Notifications] When there is only a reply action, show reply field right away

broulik updated this revision to Diff 73998. broulik added a comment. - Move `MouseArea` inside as to not break the `RowLayout` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26796?vs=73972=73998 REVISION DETAIL

D26796: [Notifications] When there is only a reply action, show reply field right away

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Makes it more obvious that there is an inline reply rather than having a "Reply" button

D26640: [applets/weather] Port weather station picker to QQC2+ListView

broulik added inline comments. INLINE COMMENTS > WeatherStationPicker.qml:44 > if (!success) { > noSearchResultReport.text = i18nc("@info", "No weather stations > found for '%1'", searchString); > noSearchResultReport.visible = true; Given the item is hidden

D26726: [Breeze Cursors] Add some more cursor names

broulik added a comment. > even though they're still "up for discussion." Yeah, and then I looked at the date ;) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26726 To: broulik, #vdg, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D26726: [Breeze Cursors] Add some more cursor names

broulik created this revision. broulik added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY They are "up for discussion" [1] but seem to be used by e.g. Chrome. [1]

D26330: [MPRIS Data Engine] Ignore players with CanControl false in multiplexer

broulik abandoned this revision. broulik added a comment. Superseded by D26702 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26330 To: broulik, #plasma Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D26689: [MPRIS Data Engine] Refactor to reduce code duplication

broulik abandoned this revision. broulik added a comment. Incorporated in D26702 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26689 To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D26720: Cache single image wallpapers locally

broulik added a comment. This doesn't appear to be containment-aware (e.g. multi-screen, activities, etc). How does the settings page handle this scenario? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26720 To: ngraham, #plasma Cc: broulik, filipf,

D26718: autostart KRunner with Plasma, aggregate text for KRunner in DesktopView

broulik added a comment. Hmm, I'd appreciate some startup time optimizations for KRunner first. Maybe if we autostarted KRunner based on whether it was used previously would be a nice trade-off between resources for systems that don't use it and power users that always use it and get

D26710: [Notifications] Support DESKTOP_FILE_HINT without BAMF prefix

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY No idea why this has changed for my Spotify but that's what I have now... TEST PLAN 5.18 My

D26709: add gpu entry to about system

broulik added inline comments. INLINE COMMENTS > GPUEntry.cpp:49 > +// It seems the renderer value may have excess information in > parentheses -> > +// strip that. Elide would probably be nicer, a bit meh with > QWidgets though. > +value = value.mid(0,

D26706: Remove notification inhibitor lock

This revision was automatically updated to reflect the committed changes. Closed by commit R116:8df6c01ca46f: Remove notification inhibitor lock (authored by broulik). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:aa2119a835e9: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26506?vs=73369=73705#toc REPOSITORY R119 Plasma Desktop

D26706: Remove notification inhibitor lock

broulik created this revision. broulik added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. broulik requested review of this revision. REVISION SUMMARY Now that the notifications dodge the

D26702: [MPRIS Data Engine] Support player proxying for another one

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:e4f91a3ee8b0: [MPRIS Data Engine] Support player proxying for another one (authored by broulik). REPOSITORY R120

D26684: [Notifications KCM] Add docbook for new KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:75481705c68e: [Notifications KCM] Add docbook for new KCM (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26684?vs=73618=73681#toc REPOSITORY R119 Plasma Desktop

D26702: [MPRIS Data Engine] Support player proxying for another one

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Plasma Browser Integration provides controls for Chrome, so when a player with `kde:pid`

D26689: [MPRIS Data Engine] Refactor to reduce code duplication

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `addPlayer` and `playerUpdated` effectively do the same, so merge the two implementations.

D26684: [Notifications KCM] Add docbook for new KCM

broulik updated this revision to Diff 73618. broulik added a comment. - Fix wording REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26684?vs=73600=73618 REVISION DETAIL https://phabricator.kde.org/D26684 AFFECTED FILES

D26684: [Notifications KCM] Add docbook for new KCM

broulik created this revision. broulik added a reviewer: Documentation. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 415250 FIXED-IN: 5.18.0 TEST PLAN - Clicked "Help"

D26162: [Notifications KCM] Force re-evaluation of position radio buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R119:db95a53cbdb6: [Notifications KCM] Force re-evaluation of position radio buttons (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26162?vs=72014=73599#toc REPOSITORY

D26583: [Application Style] Add GTK Application Style Page

broulik added inline comments. INLINE COMMENTS > gikari wrote in gtkthemesmodel.cpp:107 > Did you mean > > if (parent.isValid()) { > return 0; > } > return m_themesList.count(); > > ? I think so :D REPOSITORY R119 Plasma Desktop BRANCH gtk-style-page REVISION DETAIL

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top of its category

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a0f16565015e: [Notifications] Move Plasma Workspace service to the top of its category (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26423?vs=73419=73508#toc

D26654: support mobile mode scrollbar

broulik added a comment. Cool! The width change during the slide animation looks a bit odd, though INLINE COMMENTS > ScrollBar.qml:50 > +id: handleGraphics > +x: scrolling ? parent.width/2 - width/2 : parent.width - width > + `Math.round` REPOSITORY R858 Qt Quick

D26622: RFC: [Notifications] Raise application window if no default action is provided

This revision was automatically updated to reflect the committed changes. Closed by commit R120:48d3613aa843: [Notifications] Raise application window if no default action is provided (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26622?vs=73403=73497#toc

D26627: Mark applications that play audio for small panels.

broulik accepted this revision. broulik added a comment. Lovely, thanks. REPOSITORY R119 Plasma Desktop BRANCH audiosize (branched from master) REVISION DETAIL https://phabricator.kde.org/D26627 To: gvgeo, #vdg, #plasma, hein, ngraham, broulik Cc: plasma-devel, LeGast00n,

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top of its category

broulik updated this revision to Diff 73419. broulik retitled this revision from "[Notifications KCM] Move Plasma Workspace "service" to the top" to "[Notifications KCM] Move Plasma Workspace "service" to the top of its category". broulik edited the summary of this revision. broulik edited the

D26624: [Workspace Behavior KCM] Add "animation speed" keyword

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6f1de8e8f0d3: [Workspace Behavior KCM] Add animation speed keyword (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26624: [Workspace Behavior KCM] Add "animation speed" keyword

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since that's where the animation speed slider is now in REPOSITORY R119 Plasma Desktop

D25925: Mark applications that play audio, for all task icon sizes

broulik added inline comments. INLINE COMMENTS > AudioStream.qml:92 > +// Do not display the indicator if the icons are too small. > +visible: opacity > 0 && Math.min(iconBox.width, iconBox.height) >= > units.iconSizes.small > This breaks displaying the icon on small panels like

D26622: RFC: [Notifications] Raise application window if no default action is provided

broulik created this revision. broulik added reviewers: Plasma, VDG, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 416107 TEST PLAN - Clicked Thunderbird notification, got Thunderbird window

D26120: [Wizard] Show notification instead of finished page when pairing succeeds

This revision was automatically updated to reflect the committed changes. Closed by commit R97:5101d7902f9f: [Wizard] Show notification instead of finished page when pairing succeeds (authored by broulik). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE

D25860: [plasmoid] Show device battery percentage

This revision was automatically updated to reflect the committed changes. Closed by commit R97:3686a5acf6cf: [plasmoid] Show device battery percentage (authored by broulik). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25860?vs=71216=73397 REVISION DETAIL

D26516: [Icon Item] Check URL validity and scheme

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c765c990: [Icon Item] Check URL validity and scheme (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26516?vs=73038=73393

D26531: [Wallpaper] Show author as subtitle in configuration

broulik added a comment. > can you look into that? Perhaps @ngraham can. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma, #vdg Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

Re: Long press global shortcuts

Hi, I noticed on my phone all buttons (power, volume, home) react only on release. On the desktop I don't know how annoying it would be to react only on press. However, that would also make it consistent with in-application shortcuts, which also trigger on press. Perhaps it's best to only

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

broulik updated this revision to Diff 73369. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Remove enable/disable animation - Enabled becomes green - Now monitors kded running - Notifies when modules got

D26587: [GTK3] Improve Electron menubar legibility

broulik added a comment. Hmm this makes inactive tabs even harder to spot than already :/ REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D26587 To: cblack, #vdg, #breeze, ndavis Cc: broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26489: Use qmlRegisterAnonymousType

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R112 Milou BRANCH arcpatch-D26489 REVISION DETAIL https://phabricator.kde.org/D26489 To: tcanabrava, broulik Cc: meven, broulik, plasma-devel, LeGast00n,

D26547: pk: Load the AppStream database on a separate thread

broulik added inline comments. INLINE COMMENTS > PackageKitBackend.cpp:198 > } > +} else > +ret.components << component; Coding style .. > PackageKitBackend.cpp:502 > +} else { > +QTimer::singleShot(0, this, f); > +} Why is this

D25449: Start of the new Formats KCM

broulik added a comment. I'm not a huge fan of that language list selection mode, it's unlike anything we use anywhere else. Most importantly, it makes the KCM take *forever* to load as it creates the entire list at once. Instead, you want to use the `ListView` properly so only that part

D26531: [Wallpaper] Show author as subtitle in configuration

broulik added a comment. > "By" can also be tricky to translate into other languages That's why we have context. Currently it also has " by " explanation. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma, #vdg Cc: filipf,

D26531: [Wallpaper] Show author as subtitle in configuration

broulik added a comment. > However I see a problem with the delegate cell size: That's unrelated and something I would have expected was tested when this feature was added. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26531 To: broulik, #plasma,

D26530: ScrollView: Do not overlay scrollbars over contents

broulik added a comment. > every application developer needs to account for the scrollbars Says who? If the standard qqc2 desktop style item delegate and kirigami list delegate take it into account for their padding //reliably// you get 99% covered. > I was assuming mobile was out

D26530: ScrollView: Do not overlay scrollbars over contents

broulik added a comment. I thought back then we explicitly did not want that? Also, how does this behave on mobile, ie. "transient scrollbars"? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D26530 To: ahiemstra, #plasma Cc: broulik,

D26531: [Wallpaper] Show author as subtitle in configuration

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY If we have this feature now, let's use it and give the wallpaper authors the credit they

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

broulik updated this revision to Diff 73089. broulik added a comment. - Filter duplicates REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26506?vs=73085=73089 REVISION DETAIL https://phabricator.kde.org/D26506 AFFECTED FILES CMakeLists.txt

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

broulik updated this revision to Diff 73085. broulik added a comment. - Minor fixes - Fix Cmake REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26506?vs=73017=73085 REVISION DETAIL https://phabricator.kde.org/D26506 AFFECTED FILES

Re: Plasma 5.18 repo freeze and announce prep

In case the link doesn't work (like here), scroll down to the "plasma-5_18.md" file in the "ommunity Notes/Plasma" folder... Am 08.01.20 um 16:09 schrieb Jonathan Riddell: 5.18 repo freeze was a while ago, new repos in 5.18 will be plasma-nano and plasma-phone-components.  These two will be

D25449: Start of the new Formats KCM

broulik added inline comments. INLINE COMMENTS > Messages.sh:2 > #! /usr/bin/env bash > -$EXTRACTRC *.ui >> rc.cpp > -$XGETTEXT *.cpp -o $podir/kcmformats.pot > -rm -f rc.cpp > - > +$EXTRACTRC `find . -name "*.qml"` >> rc.qml || exit 11 > +$XGETTEXT `find . -name "*.qml"` -o

D25375: Start of the accessibility KCM

broulik added inline comments. INLINE COMMENTS > kcmaccess.cpp:141 > > -QString result; > -if ((modifiers & ScrollMask) != 0) > -if ((modifiers & LockMask) != 0) > -if ((modifiers & NumMask) != 0) > -result = i18n("Press %1 while NumLock, CapsLock

D26516: [Icon Item] Check URL validity and scheme

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Creating a `KFileItemList` with a `KFileItem` with a URL that doesn't have a scheme triggers an

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This rewrites the "Background services" KCM in QML using `ScrollViewKCM`. The two separate

D26489: Use qmlRegisterAnonymousType

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. needs a qt version `ifdef` REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D26489 To: tcanabrava, broulik Cc: broulik, plasma-devel, LeGast00n,

D26485: [Pager] Fix switching pages on

broulik closed this revision. broulik added a comment. f5d1675a0dc1a1a0098eb5b1c727b5fe197e9930 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26485 To: broulik, #plasma, hein, mart

D26445: [KRunner KCM] Mark KCM as dirty when plugin configuration changes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d2d30a9667d2: [KRunner KCM] Mark KCM as dirty when plugin configuration changes (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26425: [Notifications KCM] Fixup current item syncing logic

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b639338291d4: [Notifications KCM] Fixup current item syncing logic (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26416: Kicker/Documents optimization: Lazily build KFileItem

broulik added a comment. Would be lovely in the future to cache those items and make it a proper model with backing data rather than requesting everything on demand every time `data` is called. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26416 To:

D26483: Add /usr/share/wallpapers as a default wallpaper slideshow location

broulik added a comment. Perhaps we could leverage some code from Task Manager to have a fake `preferred://wallpaperlocation` URL or something like that? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26483 To: ngraham, #plasma, #vdg, ndavis,

D26485: [Pager] Fix switching pages on

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The code was clearly intending to use the index, as indicated by a comparison with

D26422: [Notifications] Fix ListView attached property

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cc9a1a6803d2: [Notifications] Fix ListView attached property (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26422?vs=72768=72948

D26447: Dynamically show and hide based on whether or not any vaults are configured

broulik added a comment. > why this is a `count` It's only consistent with how we usually do it elsewhere, and I think for a list model having a `count` in general makes more sense/is more generic/more useful than an `isEmpty` property REPOSITORY R845 Plasma Vault REVISION DETAIL

D26447: Dynamically show and hide based on whether or not any vaults are configured

broulik added a comment. +1 INLINE COMMENTS > vaultsmodel.h:36 > Q_PROPERTY(bool hasError READ hasError NOTIFY hasErrorChanged) > +Q_PROPERTY(int rowCount READ rowCount NOTIFY rowCountChanged) > The property name should stay `count` to avoid conflict with `rowCount` which us

D26447: Dynamically show and hide based on whether or not any vaults are configured

broulik added inline comments. INLINE COMMENTS > vaultsmodel.cpp:103 > > +if (vaultKeys.size() > 0) { > +emit q->countChanged(vaultKeys.size()); You probably want to remember the old count and emit when it's different. The model could have been full and become

D26445: [KRunner KCM] Mark KCM as dirty when plugin configuration changes

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Connect `configCommitted` to ensure "Apply" gets enabled when you change any of the runner

<    1   2   3   4   5   6   7   8   9   10   >