This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:fbf0fc710cfb: Add missing includes (authored by palimaka).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES
palimaka created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
palimaka requested review of this revision.
REVISION SUMMARY
These includes aren't always available transitively, so
include them explicitly to avoid
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:03653a7d75ba: Port knsbackendtest to ecm_add_test
(authored by palimaka).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21239?vs=58159=58233
palimaka created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
palimaka requested review of this revision.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21239
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R258:1d7e4cc7c7be: Remove unused dependencies. (authored by
palimaka).
REPOSITORY
R258 Plymouth KCM
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5649?vs=13956=14185
REVISION DETAIL
palimaka created this revision.
Restricted Application added a project: Plasma.
TEST PLAN
Inspected source, builds, tests pass.
REPOSITORY
R258 Plymouth KCM
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D5649
AFFECTED FILES
CMakeLists.txt
src/CMakeLists.txt
To:
Hi Martin,
On 25/02/17 07:02, Martin Gräßlin wrote:
> Hi,
>
> I just noticed that since we did the kde-workspace repo split we no
> longer install the PAM service files.
>
> This used to be done by:
> https://cgit.kde.org/kde-workspace.git/tree/mkpamserv?h=KDE/4.11 and the
> pam service file is
://git.reviewboard.kde.org/r/122919/diff/
Testing
---
Inspected source. Builds. No library links to the affected dependencies before
and after the change.
Thanks,
Michael Palimaka
On 05/11/16 01:52, Elvis Angelaccio wrote:
> Hi
> plasma-workspace currently ships the remote:/, applications:/ and
> desktop:/ kioslaves. The remote:/ one is also used by Dolphin, so
> currently the dolphin package has an (optional) dependency on
> plasma-workspace.
>
> As discussed in [1], they
palimaka added a comment.
As org.kde.klipper.desktop is also installed into /etc/xdg/autostart, this
change now means Klipper automatically launches eg. in GNOME. Is that
intentional?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1537
EMAIL
matically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126848/#review91578
---
On Jan. 22, 2016, 6:08 p.m., Michael Palimaka wrote:
>
> ---
> This is an automat
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit b9173ba3c4d610b42bc174a1621cb9eb3f14dd78 by Michael
Palimaka to branch master.
Repository: kgamma5
Description
---
I can't find any usage of Qt5X11Extras, so remove it.
Diffs
-
CMakeLists.txt
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit cc2b33dcdbcd46ea3ec8f7cafc55d879ab541098 by Michael
Palimaka to branch master.
Repository: plasma-workspace
Description
---
Since we can toggle find_package natively, we no longer need these old
can't find any usage of Qt5X11Extras, so remove it.
Diffs
-
CMakeLists.txt 264a457b3903158be4a90dbc01b0f6e63b5448ed
Diff: https://git.reviewboard.kde.org/r/126848/diff/
Testing
---
Inspected source, builds.
Thanks,
Michael Palimaka
/diff/
Testing
---
Builds enabled/disabled as expected.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit 7665ca02a536faf6c2bb643b60c9060d54896889 by Michael
Palimaka to branch master.
Repository: polkit-kde-agent-1
Description
---
KF5Config doesn't look like it was ever really used, and the last use
: https://git.reviewboard.kde.org/r/126272/diff/
Testing
---
Inspected source, builds.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On 04/12/15 01:30, Jonathan Riddell wrote:
> 5.5.0 tars are up now on depot available to packagers, will be made
> public along with the release scheduled for Tuesday
>
> Jonathan
> ___
> release-team mailing list
> release-t...@kde.org
>
https://bugs.kde.org/show_bug.cgi?id=355892
--- Comment #4 from Michael Palimaka <kensing...@gentoo.org> ---
How do you expect KDE to fix a problem caused by features removed by upower
upstream?
--
You are receiving this mail because:
You are the assignee for t
https://bugs.kde.org/show_bug.cgi?id=355892
--- Comment #8 from Michael Palimaka <kensing...@gentoo.org> ---
(In reply to Mathieu Roy from comment #7)
> "Which turns it into a distro problem. Your distribution configured the
> system in a way that suspend/hibernate is broken&quo
https://bugs.kde.org/show_bug.cgi?id=355892
Michael Palimaka <kensing...@gentoo.org> changed:
What|Removed |Added
CC||kensing...@gent
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit b0ef3acac320ca68069ed0153315448fcd5d83d0 by Michael
Palimaka to branch master.
Repository: breeze-gtk
Description
---
It seems that kconf_update_bin/gtkbreeze5.5 uses only Qt5Core, so remove other
,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit accf75fefe71657412f0ad0c2d8766f30a810c94 by Michael
Palimaka to branch master.
Repository: libksysguard
Description
---
Seems to be unused since 931d7d4b64bbe39f75060f3e61198b5b0c1126f0.
Diffs
---
Seems to be unused since 931d7d4b64bbe39f75060f3e61198b5b0c1126f0.
Diffs
-
signalplotter/ksignalplotter.cpp 7932c8ef564acb7b2549d256062de52c9ee053fb
Diff: https://git.reviewboard.kde.org/r/124728/diff/
Testing
---
Builds.
Thanks,
Michael Palimaka
marked as submitted.
Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and
Sujith Haridasan.
Changes
---
Submitted with commit 3f31240925e9fc9ecc5617ebba7d030c926f5da8 by Michael
Palimaka to branch master.
Repository: plasma-mediacenter
Description
---
I can't
/mediacenter/mpris2/mediaplayer2.cpp
a11cf3bc9fa1a967647a3b5af55bf7e472754ba9
Diff: https://git.reviewboard.kde.org/r/124665/diff/
Testing
---
Builds. Inspected source and links.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel
On 23/05/15 00:33, Bernd Steinhauser wrote:
Hi,
since the commit with the id 78c97fin plasma-workspace [1], it depends
on NetworkManagerQt and hence on Network Manager unconditionally. The
use case outlined in the commit is that the data engine tries to access
wlan via network manager to
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit 34acf352dc5b1769ecfd0b7ee9bb1bcea3ca6c01 by Michael
Palimaka to branch Plasma/5.3.
Repository: kscreen
Description
---
The kded test depends on freedesktop_interface which is generated
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit 1c5ff8e91ae5ae6d496d7834a4c9ef576ae19807 by Michael
Palimaka to branch Plasma/5.3.
Repository: kscreen
Description
---
The only usage I can find of QX11Extras is a stray include, so remove
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123354/#review78898
---
On April 13, 2015, 5:33 p.m., Michael Palimaka wrote
---
The kded test depends on freedesktop_interface which is generated by
kscreen_daemon.
Diffs
-
tests/kded/CMakeLists.txt 528eaa817980d0027c98441666b1a1ca5f56dbcb
Diff: https://git.reviewboard.kde.org/r/123354/diff/
Testing
---
Builds in parallel now.
Thanks,
Michael Palimaka
https://bugs.kde.org/show_bug.cgi?id=344456
Michael Palimaka kensing...@gentoo.org changed:
What|Removed |Added
Version|5.2.0 |5.2.2
https://bugs.kde.org/show_bug.cgi?id=344456
--- Comment #22 from Michael Palimaka kensing...@gentoo.org ---
Created attachment 91963
-- https://bugs.kde.org/attachment.cgi?id=91963action=edit
environment with krapper
--
You are receiving this mail because:
You are the assignee for the bug
https://bugs.kde.org/show_bug.cgi?id=344456
--- Comment #23 from Michael Palimaka kensing...@gentoo.org ---
Created attachment 91964
-- https://bugs.kde.org/attachment.cgi?id=91964action=edit
environment without kwrapper
--
You are receiving this mail because:
You are the assignee for the bug
https://bugs.kde.org/show_bug.cgi?id=344456
Michael Palimaka kensing...@gentoo.org changed:
What|Removed |Added
Attachment #91963|environment with krapper|environment
https://bugs.kde.org/show_bug.cgi?id=344456
--- Comment #24 from Michael Palimaka kensing...@gentoo.org ---
Note that the environment with kwrapper is from kwrapper5 ksmserver and
ksmserver [kdeinit5] has none.
--
You are receiving this mail because:
You are the assignee for the bug
/CMakeLists.txt 8c693b50ec04e3143735b8917aedc7e81d987fbd
tests/kded/CMakeLists.txt 528eaa817980d0027c98441666b1a1ca5f56dbcb
Diff: https://git.reviewboard.kde.org/r/122990/diff/
Testing
---
Inspected source and checked library links. Builds and runs.
Thanks,
Michael Palimaka
/
Testing
---
Inspected source. Builds. No library links to the affected dependencies before
and after the change.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
. No library links to the affected dependencies before
and after the change.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120566/#review68294
---
On Oct. 12, 2014, 6:47 p.m., Michael Palimaka wrote:
---
This is an automatically
On 09/27/2014 02:13 AM, Michael Palimaka wrote:
On 09/26/2014 08:28 AM, Jonathan Riddell wrote:
New in this release..
- standard version number 5.0.95 for all
Does this mean the stuff in extragear is moving to workspace?
Any more thoughts about this? Are libkscreen, libmm-qt, libnm-qt
On 09/26/2014 08:28 AM, Jonathan Riddell wrote:
New in this release..
- standard version number 5.0.95 for all
Does this mean the stuff in extragear is moving to workspace?
___
Plasma-devel mailing list
Plasma-devel@kde.org
.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
a
matching header include rename. Not aware of any other frameworks-based
libkworkspace consumers.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On 07/22/2014 06:10 AM, Martin Gräßlin wrote:
On Tuesday 22 July 2014 05:28:36 Michael Palimaka wrote:
On 07/18/2014 06:54 PM, Harald Sitter wrote:
On Thu, Jul 17, 2014 at 1:37 PM, Michael Palimaka kensing...@gentoo.org
wrote:
I just discused this with mgraesslin on IRC and he's fine
/CMakeLists.txt 8224900e633c18f57ac3fbc7e5a77a8f5a34edb0
Diff: https://git.reviewboard.kde.org/r/118900/diff/
Testing
---
Inspected source, builds, tests pass.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https
240cc7b57bd38e86fd50084e53c17f1672b2b946
Diff: https://git.reviewboard.kde.org/r/118638/diff/
Testing
---
Builds and filter/documentation files install as expected depending on what
KArchive was build with.
Thanks,
Michael Palimaka
___
Plasma-devel
c80465709a701e9703405ac9e6b7c91f08d0db1f
Diff: https://git.reviewboard.kde.org/r/119402/diff/
Testing
---
Inspected source. Builds.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
requirements to what is actually used
Diffs
-
CMakeLists.txt c80465709a701e9703405ac9e6b7c91f08d0db1f
Diff: https://git.reviewboard.kde.org/r/119402/diff/
Testing
---
Inspected source. Builds.
Thanks,
Michael Palimaka
___
Plasma-devel mailing
On 07/18/2014 06:54 PM, Harald Sitter wrote:
On Thu, Jul 17, 2014 at 1:37 PM, Michael Palimaka kensing...@gentoo.org
wrote:
I just discused this with mgraesslin on IRC and he's fine with adding
a compatibility build flag to 4.x that makes it only install the
necessary libraries to avoid
On 07/11/2014 07:45 PM, Harald Sitter wrote:
On Fri, Jul 11, 2014 at 11:10 AM, Harald Sitter sit...@kde.org wrote:
On Thu, Jul 10, 2014 at 5:40 PM, Michael Palimaka kensing...@gentoo.org
wrote:
It's probably a bit late now, but we could just rename the offending
libraries in Plasma 5 (as has
On 07/07/2014 07:16 PM, Jonathan Riddell wrote:
On Fri, Jul 04, 2014 at 10:36:00AM +0100, John Layt wrote:
Co-installabilty of Plasma 4 and Plasma 5 with minimal work required
by the distros is a must if we want to avoid the mess of KDE4.
Already openSUSE has announced that you can't have both
On 07/04/2014 08:05 PM, Sune Vuorela wrote:
On Friday 04 July 2014 11:13:19 Vishesh Handa wrote:
I would really like the tarballs to have the same name. Also, baloo4 and 5
are not really co-installable. They both ship executables with the same
name.
Are you saying that one can't use a
On 07/04/2014 07:19 PM, Jonathan Riddell wrote:
On Fri, Jul 04, 2014 at 11:13:19AM +0200, Vishesh Handa wrote:
A similar case exists for kactivites. It existed in kde4 as well and the
current framework has the same name.
I would really like the tarballs to have the same name. Also,
4bfa2e93abfc6f8087693c363e5982fa862cf0fa
wallpapers/image/CMakeLists.txt 32dbf310ce7c243a62e042c71f8b9de420048cd8
Diff: https://git.reviewboard.kde.org/r/118899/diff/
Testing
---
Inspected source. Builds.
Thanks,
Michael Palimaka
___
Plasma
32dbf310ce7c243a62e042c71f8b9de420048cd8
Diff: https://git.reviewboard.kde.org/r/118899/diff/
Testing
---
Inspected source. Builds.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
://git.reviewboard.kde.org/r/118900/diff/
Testing
---
Inspected source, builds, tests pass.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
On June 23, 2014, 3:07 p.m., Michael Palimaka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118900
://git.reviewboard.kde.org/r/118696/diff/
Testing
---
Inspected sources, builds.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
cb7466b344028e09d0f26f6117da64d694853372
kcms/kfontinst/kcmfontinst/CMakeLists.txt
90c96a06047ebf7522bd6a249b77a5d046cdcc8b
Diff: https://git.reviewboard.kde.org/r/117751/diff/
Testing
---
Inspected source. Builds.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
9cb406e5f5604a718ecd588b09cb2c738b13a28f
Diff: https://git.reviewboard.kde.org/r/117727/diff/
Testing
---
Tests + docs build or are skipped as expected.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma
---
Builds and filter/documentation files install as expected depending on what
KArchive was build with.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/CMakeLists.txt 14bf2dffa50f88ec591eeffcd918685be97d8f27
src/kscreen.pc.in 01b99783dd3d0092311a6f16a5e153ca011a7d8f
Diff: https://git.reviewboard.kde.org/r/118169/diff/
Testing
---
Builds, installs.
Thanks,
Michael Palimaka
___
Plasma-devel mailing
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118257/#review58292
---
Where is the kpty usage located?
- Michael Palimaka
On May
On May 22, 2014, 11:40 a.m., Michael Palimaka wrote:
Where is the kpty usage located?
Jonathan Riddell wrote:
When compiling without kpty installed:
In file included from /usr/include/KF5/KDESu/kdesu/stubprocess.h:13:0,
from /usr/include/KF5/KDESu
/CMakeLists.txt 14bf2dffa50f88ec591eeffcd918685be97d8f27
src/kscreen.pc.in 01b99783dd3d0092311a6f16a5e153ca011a7d8f
Diff: https://git.reviewboard.kde.org/r/118169/diff/
Testing
---
Builds, installs.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
/118169/diff/
Testing
---
Builds, installs.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
On 05/10/2014 02:07 AM, Jonathan Riddell wrote:
Tars are available for Plasma Next Beta 1
Soon to be landing on depot.kde.org http://depot.kde.org
unstable/plasma/4.96.0
Temporary site:
http://starsky.19inch.net/~jr/tmp/plasma-4.96.0/
are missing.
Also add some info to the feature summary about what's found or not.
Diffs
-
CMakeLists.txt 2334ffc22ed683f528c4ca986a056946143ab41f
Diff: https://git.reviewboard.kde.org/r/117728/diff/
Testing
---
Builds with optional packages present and missing.
Thanks,
Michael
Diff: https://git.reviewboard.kde.org/r/117751/diff/
Testing
---
Inspected source. Builds.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/diff/
Testing
---
Inspected source. Builds.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
build or are skipped as expected.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
-
CMakeLists.txt 2334ffc22ed683f528c4ca986a056946143ab41f
Diff: https://git.reviewboard.kde.org/r/117728/diff/
Testing
---
Builds with optional packages present and missing.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel
8eb170bedd32f04f5d2cc0fbd3079758e6138cc6
Diff: https://git.reviewboard.kde.org/r/117393/diff/
Testing
---
Builds. Tests pass (when QtTest is found).
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
. To reply, visit:
https://git.reviewboard.kde.org/r/117393/#review55995
---
On April 18, 2014, 6:44 a.m., Michael Palimaka wrote:
---
This is an automatically generated e-mail
.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
from kde-workspace.
Diffs
-
CMakeLists.txt acdfb319d76a9aaf6b5d74b70b138d302e3d6b0b
Diff: https://git.reviewboard.kde.org/r/117404/diff/
Testing
---
Builds with/without tests as expected.
Thanks,
Michael Palimaka
___
Plasma-devel mailing
---
Remove unused dependencies. Add a feature summary. Use renamed KDELibs4Support.
Diffs
-
CMakeLists.txt 313d63a143e761d99f1dc0e7b9ac8080e7c9ed06
Diff: https://git.reviewboard.kde.org/r/117625/diff/
Testing
---
Inspected source. Builds.
Thanks,
Michael Palimaka
8eb170bedd32f04f5d2cc0fbd3079758e6138cc6
Diff: https://git.reviewboard.kde.org/r/117393/diff/
Testing
---
Builds. Tests pass (when QtTest is found).
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
., Michael Palimaka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117393/
---
(Updated April 7, 2014, 2:50 p.m
to ON or the user invokes the ``buildtests`` target.
#
# BUILD_TESTING is created as a cache variable by the CTest module and by
the
# :kde-module:`KDECMakeSettings` module.
Michael Palimaka wrote:
That's true (and it seems there's some stuff here and there that should
use
8eb170bedd32f04f5d2cc0fbd3079758e6138cc6
Diff: https://git.reviewboard.kde.org/r/117393/diff/
Testing (updated)
---
Builds. Tests pass (when QtTest is found).
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org
On April 7, 2014, 4:03 p.m., Martin Gräßlin wrote:
I still do not understand the rational behind the change. Could you please
explain why we would want this build option?
Michael Palimaka wrote:
It's just nice to have, useful for some people, not useful for others.
It's not a new
://git.reviewboard.kde.org/r/117393/#review55226
---
On April 7, 2014, 2:50 p.m., Michael Palimaka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On April 7, 2014, 4:03 p.m., Martin Gräßlin wrote:
I still do not understand the rational behind the change. Could you please
explain why we would want this build option?
Michael Palimaka wrote:
It's just nice to have, useful for some people, not useful for others.
It's not a new
---
Inspected source. Builds.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
bc8f05f93d9b861af4fdc9b76f2ea61c3bbca413
Diff: https://git.reviewboard.kde.org/r/117406/diff/
Testing
---
Builds.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
: https://git.reviewboard.kde.org/r/117393/diff/
Testing (updated)
---
Builds. Tests pass (when enabled).
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
---
On April 7, 2014, 2:50 p.m., Michael Palimaka wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117393
On April 7, 2014, 4:03 p.m., Martin Gräßlin wrote:
I still do not understand the rational behind the change. Could you please
explain why we would want this build option?
Michael Palimaka wrote:
It's just nice to have, useful for some people, not useful for others.
It's not a new
0adfde946b783cbee09661cfe445792eb1a54649
keditfiletype/tests/CMakeLists.txt 489bb4da97f80ce6bc777d4ca99661d7bba261b2
keditfiletype/tests/filetypestest.cpp
68eef26f53c0122d70340f3c7ca60ea768a8cf86
Diff: https://git.reviewboard.kde.org/r/117404/diff/
Testing
---
Builds.
Thanks,
Michael Palimaka
---
Init does not appear to be used, so remove it.
Diffs
-
CMakeLists.txt bc8f05f93d9b861af4fdc9b76f2ea61c3bbca413
Diff: https://git.reviewboard.kde.org/r/117405/diff/
Testing
---
Inspected source. Builds.
Thanks,
Michael Palimaka
---
Builds.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
/oxygenbaseanimationconfigwidget.cpp
68f7d32b4e22c198093ca7a281b18953424a0a20
Diff: https://git.reviewboard.kde.org/r/117389/diff/
Testing
---
Inspected source. Builds.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org
/CMakeLists.txt 223e900273762b554ec0016ef62eb91a5479df92
liboxygen/oxygenbaseanimationconfigwidget.cpp
68f7d32b4e22c198093ca7a281b18953424a0a20
Diff: https://git.reviewboard.kde.org/r/117389/diff/
Testing
---
Inspected source. Builds.
Thanks,
Michael Palimaka
/test_tabbox_handler.cpp
tests/CMakeLists.txt 39566e167156f3f513c10f94940c36814950b58c
Diff: https://git.reviewboard.kde.org/r/117393/diff/
Testing
---
Builds. Tests pass.
Thanks,
Michael Palimaka
___
Plasma-devel mailing list
Plasma-devel@kde.org
https
/test_tabbox_config.cpp
16d8986e3f9e9df2a11128a7ef4e48483568b394
tabbox/autotests/test_tabbox_handler.cpp
tests/CMakeLists.txt 39566e167156f3f513c10f94940c36814950b58c
Diff: https://git.reviewboard.kde.org/r/117393/diff/
Testing
---
Builds. Tests pass.
Thanks,
Michael Palimaka
1 - 100 of 117 matches
Mail list logo
