D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens

hoffmannrobert added a comment. I tested the new code: Tests 1-5 of the test plan behave like previously "without patch", in tests 6 and 7 the integrated laptop screen isn't reacitivated after opening. After adapting my changes to the new code, all tests work as described "with patch".

D21082: Fix lid open/closed configurations, OSD actions, more than 2 screens

hoffmannrobert updated this revision to Diff 60637. hoffmannrobert edited the summary of this revision. hoffmannrobert edited the test plan for this revision. hoffmannrobert added a comment. Rebase and adapt to new upstream code REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://ph

D21959: Fix selectedNameFilter() multiple matches

hoffmannrobert added a comment. Can you please push it for me, I don't have commit access. Thanks. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH fix_selectedNameFilter REVISION DETAIL https://phabricator.kde.org/D21959 To: hoffmannrobert, #frameworks, apol, dfaure C

D21959: Fix selectedNameFilter() multiple matches

hoffmannrobert updated this revision to Diff 60286. hoffmannrobert added a comment. - Remove redundant condition REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21959?vs=60217&id=60286 BRANCH fix_selectedNameFilter REVIS

D21959: Fix selectedNameFilter() multiple matches

hoffmannrobert created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY If your filter list has two matching filters for an extension, KFileWidget will return the name of the first filter

D21082: Fix lid open/closed configurations

hoffmannrobert added a comment. I added some more fixes: - The OSD was displayed even on a closed laptop panel. - With more than two screens, using the OSD always generated an "extend to right" configuration, even if "extend to left", "clone", or "disable external/internal" was selecte

D21082: Fix lid open/closed configurations

hoffmannrobert added a comment. In D21082#463848 , @romangg wrote: > This is the real issue. Why are the screen positions scrambled around although there should be a config from before shutdown/suspend (not the lidOpened one), that has the curre

D21082: Fix lid open/closed configurations

hoffmannrobert updated this revision to Diff 58471. hoffmannrobert added a comment. - Fix OSD displayed on closed laptop panel. - Fix generated configurations if there are more than two screens. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21082?vs=5776

D21082: Fix lid open/closed configurations

hoffmannrobert added a comment. My goal is to make the screen configurations work reliably with notebooks, not to support a new use case. The use case is: work with a notebook docked and undocked, with and without external screen(s), lid open or closed. The configurations work fine, if n

D21082: Fix lid open/closed configurations

hoffmannrobert created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Screen configurations on notebooks couldn't distinguish properly between open lid and closed lid configurations. The

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert updated this revision to Diff 55115. hoffmannrobert added a comment. - Add KIO_VERSION check, use SkipMimeTypeFromContent REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19784?vs=54863&id=55115 BRANCH fix_recent_documents_kicker_hang

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert updated this revision to Diff 54863. hoffmannrobert added a comment. - Use new KFileItem::SkipMimeTypeDetermination parameter REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19784?vs=54339&id=54863 BRANCH fix_recent_documents_kicker_

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert added a comment. In D19784#437715 , @dfaure wrote: > ... > Indeed this doesn't need the stat() done by KFileItem's init(). This means the right solution is indeed for KFileItem to do that stat() on demand, and this co

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert added a comment. In D19784#434564 , @hoffmannrobert wrote: > In D19784#431683 , @ngraham wrote: > > > Nice, kinda sounds like this fixes https://bugs.kde.org/show_bug.cgi?id=373352.

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert marked an inline comment as done. hoffmannrobert added a comment. In D19784#431683 , @ngraham wrote: > Nice, kinda sounds like this fixes https://bugs.kde.org/show_bug.cgi?id=373352. Can you confirm? No, unfortunately it do

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert marked 3 inline comments as done. hoffmannrobert added a comment. See https://phabricator.kde.org/D19887 INLINE COMMENTS > dfaure wrote in recentusagemodel.cpp:261 > How do you expect isFile() and isDir() to work without a QT_LSTAT call? A document should always be a file, so

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert updated this revision to Diff 54339. hoffmannrobert added a comment. - Use new KFileItem constructor with skipStat set to true REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19784?vs=53951&id=54339 BRANCH fix_recent_documents_kicker

D19784: Avoid calling QT_LSTAT and accessing recent documents

hoffmannrobert created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Document entries pointing to unavailable network shares freeze the application menu, so avoid calling QT_LSTAT (lsta

D13853: Fix setting primary connector if primary output changed

hoffmannrobert added a comment. Thanks for reviewing. Can you please land it for me, I don't have commit access. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D13853 To: hoffmannrobert, #plasma, mart, davidedmundson Cc: davidedmundson, ngr

D10344: Create panel on current screen

hoffmannrobert updated this revision to Diff 38614. hoffmannrobert added a comment. Fix crash if screen numbers are not consecutive. Add ShellCorona::screenForId(int screenNum) for easy access to a panel's QScreen replacing wrong access via QGuiApplication::screens().at(screenNum). REPOSITO

D10344: Create panel on current screen

hoffmannrobert added a comment. Thank you. If these non-consecutive screen numbers are legitimate, then getting the QScreen via QGuiApplication::screens().at(screenNum) is wrong. I found a solution using ShellCorona::m_desktopViewforId. REPOSITORY R120 Plasma Workspace REVISION DETAIL h

D10344: Create panel on current screen

hoffmannrobert added a comment. In D10344#297751 , @hoffmannrobert wrote: > In Wayland there seems to be a problem with QScreen: creating a panel on the second screen crashes plasmashell in QScreen::size(), called by PanelView::panelConfig() (s

D10344: Create panel on current screen

hoffmannrobert marked an inline comment as done. hoffmannrobert added a comment. Sorry for the delay. In Wayland there seems to be a problem with QScreen: creating a panel on the second screen crashes plasmashell in QScreen::size(), called by PanelView::panelConfig() (shell/panelview.cpp

D10344: Create panel on current screen

hoffmannrobert updated this revision to Diff 38411. hoffmannrobert added a comment. Regard focus window position only if manually creating panels. This fixes initial panel placement on wrong screen in dual monitor setup. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST U

D13612: Fix drop between shared views

hoffmannrobert added a comment. Can somebody please land this patch for me? Thanks. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13612 To: hoffmannrobert, mart Cc: amantia, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, je

D13853: Fix setting primary connector if primary output changed

hoffmannrobert updated this revision to Diff 37174. hoffmannrobert added a comment. - Remove wrong Q_ASSERT REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13853?vs=37072&id=37174 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1385

D13853: Fix setting primary connector if primary output changed

hoffmannrobert marked an inline comment as done. hoffmannrobert added a comment. Addition to last comment: In the other case, booting with HDMI-2 and hotplugging HDMI-3 the problem with primary switching doesn't exist. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.

D13853: Fix setting primary connector if primary output changed

hoffmannrobert marked an inline comment as done. hoffmannrobert added inline comments. INLINE COMMENTS > davidedmundson wrote in screenpool.cpp:108 > Either this is a valid case to be in, and this assert doesn't make sense. > > Or we should never be in this case, and the patch doesn't make sense

D13853: Fix setting primary connector if primary output changed

hoffmannrobert created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY If a user logged in with one screen connected plugs in a second screen, which become

D13612: Fix drop between shared views

hoffmannrobert added a comment. I don't have commit access, can you please land it for me? Thanks. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13612 To: hoffmannrobert, mart Cc: amantia, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, a

D13612: Fix drop between shared views

hoffmannrobert created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Remove trailing slash from folderUrl, too, when comparing to the file's url (minus f

D12539: Klipper: Do not insert secret data into history

hoffmannrobert added a comment. The keepassx pull request: https://github.com/keepassx/keepassx/pull/211 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D12539 To: hoffmannrobert, davidedmundson Cc: broulik, graesslin, davidedmundson, pl

D12539: Klipper: Do not insert secret data into history

hoffmannrobert added a comment. No, I haven't. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D12539 To: hoffmannrobert, davidedmundson Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abet

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert added a comment. Thank you, that caused the issue. Now it works well with keepassx. That's a much better solution, than removing from history. I've create a new revision for it: https://phabricator.kde.org/D12539 REPOSITORY R120 Plasma Workspace REVISION DETAIL h

D12539: Klipper: Do not insert secret data into history

hoffmannrobert created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Password manager tools like Keepassx offer an option to clear the clipboard/selectio

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert added a comment. In D12373#253569 , @davidedmundson wrote: > mimeData is key value pairs, you can have many pieces of mimeData. > > So we have text/plain with the password as before > and x-kde-passwordManagerHint data

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert updated this revision to Diff 33060. hoffmannrobert added a comment. Klipper: Fix option RemoveTopHistoryItemOnClear REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12373?vs=32630&id=33060 BRANCH master REVISION DETAIL https://p

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert added a comment. Some facts: - The clipboard in KDE is a QClipboard instance. - Klipper is a frontend to the clipboard with a history. It exchanges data with the QClipboard instance. - QClipboard provides the facility of setting mime types with data it stores. All data

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert added a comment. You are right, the "prevent empty clipboard" option needs to be set to false to make the "RemoveTopHistoryItemOnClear" option work correctly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12373 To: hoffmannrobert Cc: brouli

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert added a comment. In D12373#250306 , @davidedmundson wrote: > Right, but pressing control+v again won't paste the item after clearing which I assumed was the intended goal Yes, pressing Control+V won't paste the item after

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert added a comment. In D12373#250303 , @davidedmundson wrote: > Aren't you just duplicating the existing "prevent empty clipboard" option ? No, the "prevent empty clipboard" option ensures that the clipboard doesn't stay emp

D12373: Klipper: Remove first history item on clipboard clear

hoffmannrobert created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Password manager tools like Keepassx offer an option to clear the clipboard/selectio

D10344: Create panel on current screen

hoffmannrobert edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10344 To: hoffmannrobert Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10344: Create panel on current screen

hoffmannrobert created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY In multi-monitor environments panels are always created on screen number 0. There is