Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Rukshan Chathuranga
, imo) solution you can try is reverse the parenting order of MouseEventListener and ToolButton (i.e. MouseEventListener { ToolButton { } }). This way you will get both the interactions (click and scroll) and will still feel natural. Rukshan Chathuranga wrote: Oh really. But i can't

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Rukshan Chathuranga
://git.reviewboard.kde.org/r/116517/diff/ Testing --- tested the function and not change the default controlling due to new changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Rukshan Chathuranga
://git.reviewboard.kde.org/r/116517/diff/ Testing --- tested the function and not change the default controlling due to new changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-03 Thread Rukshan Chathuranga
--- On March 3, 2014, 3:21 p.m., Rukshan Chathuranga wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-02 Thread Rukshan Chathuranga
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51601 --- On March 1, 2014, 3:03 p.m., Rukshan Chathuranga wrote: --- This is an automatically generated

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-02 Thread Rukshan Chathuranga
, imo) solution you can try is reverse the parenting order of MouseEventListener and ToolButton (i.e. MouseEventListener { ToolButton { } }). This way you will get both the interactions (click and scroll) and will still feel natural. Rukshan Chathuranga wrote: Oh really. But i can't

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
://git.reviewboard.kde.org/r/116517/diff/ Testing --- tested the function and not change the default controlling due to new changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
968c459 Diff: https://git.reviewboard.kde.org/r/116517/diff/ Testing --- tested the function and not change the default controlling due to new changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
://git.reviewboard.kde.org/r/116517/diff/ Testing --- tested the function and not change the default controlling due to new changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51430 --- On March 1, 2014, 3:03 p.m., Rukshan Chathuranga wrote: --- This is an automatically generated e

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-03-01 Thread Rukshan Chathuranga
the volume slider. Hint to the solution lies in the order in which Qt delivers events (like mouse event in this case). Try if you can figure it out :) Rukshan Chathuranga wrote: ohhh. i will try to fix that also. hi, i fixed the volume icon click event when working with wheel event

Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Rukshan Chathuranga
changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Rukshan Chathuranga
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116517/#review51404 --- On March 1, 2014, 7:11 a.m., Rukshan Chathuranga wrote

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Rukshan Chathuranga
the terminal, use git diff patchname.diff which will save the exact diff to patchname.diff which you can then upload.) Rukshan Chathuranga wrote: sorry for that. But i have chnged some things in the metadataupdater.cpp to support my ubuntu version. So i cant change those

Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll

2014-02-28 Thread Rukshan Chathuranga
://git.reviewboard.kde.org/r/116517/diff/ Testing --- tested the function and not change the default controlling due to new changes. Thanks, Rukshan Chathuranga ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel