[Differential] [Accepted] D2025: [platforms] Call setSoftWareCursor in init instead of ctor

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH software-cursor-init-5.7 REVISION DETAIL https://phabricator.kde.org/D2025 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Accepted] D2010: On Wayland never try to create a WindowPixmap from an X11 pixmap

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH window-pixmap-wayland-always-5.7 REVISION DETAIL https://phabricator.kde.org/D2010 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emai

[Differential] [Accepted] D2024: Properly clip the damage region and windows in SceneQPainter

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH scene-qpainter-clipping-5.7 REVISION DETAIL https://phabricator.kde.org/D2024 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Accepted] D1973: Support for syncing the clipboard from X11 to Wayland and vice versa

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH xclipboard-syncer REVISION DETAIL https://phabricator.kde.org/D1973 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D1779: Add a parent_window event to Plasma Window interface

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH parent-window REVISION DETAIL https://phabricator.kde.org/D1779 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Accepted] D2036: Properly handle destroying a Keyboard resource

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > keyboard_interface.cpp:186 > if (wl_resource_get_version(d->resource) < > WL_KEYBOARD_REPEAT_INFO_SINCE_VERSION) { > // only

[Differential] [Accepted] D2035: Properly handle release of a touch resource

2016-06-28 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH touch-unbound REVISION DETAIL https://phabricator.kde.org/D2035 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

Re: Is it able to make kservice's weightedOffers public access?

2016-06-28 Thread Sebastian Kügler
On Tuesday 28 June 2016 08:56:31 Leslie Zhai wrote: > I am so sorry for my mistake, it will not happen again! No problem at all, just wanted to make sure you get an answer (by posting to the more relevant list). Cheers, -- sebas Sebastian Kügler•http://vizZzion.org•h

Minutes Monday Plasma Meeting

2016-06-27 Thread Sebastian Kügler
Minutes Plasma 'hangout', 27-6-2016, 12:00 CET Present: mgraesslin, bshah, notmart, Sho, kbroulik, d_ed, sitter, sebas mgraesslin: * went to opensuse conf, reported * let's discuss an LTS * openqa usage * sync of clipboard between X11 and Wayland * tests found some issues regarding XWayland win

[Differential] [Accepted] D1972: [server] Add support for setting the clipboard selection DataDeviceInterface manually

2016-06-27 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH selection REVISION DETAIL https://phabricator.kde.org/D1972 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: Is it able to make kservice's weightedOffers public access?

2016-06-27 Thread Sebastian Kügler
Hi Leslie, On maandag 27 juni 2016 12:47:03 CEST 翟翔 wrote: > in the src/services/kservicetypetrader.h about line 216, > > static KServiceOfferList weightedOffers(const QString &serviceType); is > private access, is it able to make it public access? This is best discussed on the frameworks maili

[Differential] [Requested Changes To] D1976: Image of the Day wallpaper plugin

2016-06-23 Thread Sebastian Kügler
sebas requested changes to this revision. sebas added a reviewer: sebas. sebas added a comment. This revision now requires changes to proceed. There are lots of ; (at the end of every line of QML. We generally don't do that. In order to make the code more consistent, please remove them. (They

[Differential] [Accepted] D1974: Don't set both font and pixel size in DigitalClock

2016-06-23 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1974 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

[Differential] [Accepted] D1780: Expose the transientFor relationship to PlasmaWindowInterface

2016-06-22 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH transient-for-plasma-window REVISION DETAIL https://phabricator.kde.org/D1780 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Accepted] D1953: Fix XembedSNIProxy Logging Category Registration

2016-06-21 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH logging_categories REVISION DETAIL https://phabricator.kde.org/D1953 EMAIL PREFERENCES https://phabricator.kde.org/settings/p

[Differential] [Accepted] D1938: [server] Ensure that Resource::Private::get returns nullptr if passed a nullptr

2016-06-21 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH resource-get-nullptr REVISION DETAIL https://phabricator.kde.org/D1938 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

[Differential] [Accepted] D1932: [tests] Add a test application for PlasmaShellSurface

2016-06-21 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH plasma-surface-test-app REVISION DETAIL https://phabricator.kde.org/D1932 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Accepted] D1930: Add support for new Notification role on PlasmaSurface

2016-06-21 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH support-plasma-surface-notification REVISION DETAIL https://phabricator.kde.org/D1930 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Accepted] D1929: [kwindowsystem] Wrap the notification type

2016-06-21 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland BRANCH notification REVISION DETAIL https://phabricator.kde.org/D1929 EMAIL PREFERENCES https://phab

Re: KCM/colord-kde and it's KF5 release

2016-06-21 Thread Sebastian Kügler
On dinsdag 21 juni 2016 08:09:16 CEST Martin Graesslin wrote: > On Monday, June 20, 2016 9:13:28 PM CEST Alessandro Longo wrote: > > Hi, I hope this is the right ml to talk about KCMs. > > I tried to install latest stable release (0.3) of colord-kde[1] to > > manage icc color profiles, but the KCM

Re: Review Request 127651: [kdeplasma-addons] plasma-applet-minimizeall

2016-06-21 Thread Sebastian Kügler
e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127651/ > --- > > (Updated April 28, 2016, 8:11 a.m.) > > > Review request for Plasma, KDE Usability, Martin Gräßlin, and Sebastian > Kügler. > >

[Differential] [Accepted] D1960: Fix krunner build without qalculate

2016-06-20 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1960 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

[Differential] [Accepted] D1961: [server] Add resource check in QtExtendedSurfaceInterface::close

2016-06-20 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH surfaceextension-nullptr-check REVISION DETAIL https://phabricator.kde.org/D1961 EMAIL PREFERENCES https://phabricator.kde.org/settings/pane

Minutes Monday Plasma Hangout

2016-06-20 Thread Sebastian Kügler
Minutes Plasma 'hangout', 20-6-2016, 12:00 CET Present: mgraesslin, bshah, Sho, sebas, Riddell, Jens, Andreas, d_ed mgraesslin: * Since Tuesday on Plasma/Wayland session * Major WTF moment: if a surface gets created for an id, which was used for a previous surface it will have the same wl_resour

Re: Review Request 128221: windowlist resizing

2016-06-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128221/#review96627 --- Ship it! Ship It! - Sebastian Kügler On June 17, 2016

[Differential] [Abandoned] D1855: relax lidswitch check for external monitor

2016-06-16 Thread Sebastian Kügler
sebas abandoned this revision. sebas added a comment. https://quickgit.kde.org/?p=powerdevil.git&a=commit&h=d3162725cfffb79da7bb8f276a31a915e3349dab does the same, it just never made it into master, only 5.5 and 5.6 branches. I'll merge it into master and 5.7 branches and will abandon this r

[Differential] [Accepted] D1858: [platforms/drm] Apply new global position on DrmOutput for a changeset

2016-06-14 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Cool! REPOSITORY rKWIN KWin BRANCH drm-apply-output-position-change REVISION DETAIL https://phabricator.kde.org/D1858 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/em

[Differential] [Closed] D1866: Use QVector and QLatin1String, and range-based for

2016-06-14 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREEN2792f55ff5c2: Use QVector and QLatin1String, and range-based for (authored by sebas). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1866?vs=44

[Differential] [Accepted] D1868: [server] Introduce a Resource::unbound signal emitted from unbind handler

2016-06-14 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH resource-unbound REVISION DETAIL https://phabricator.kde.org/D1868 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Commented On] D1856: more creative output type detection in xrandr backend

2016-06-14 Thread Sebastian Kügler
sebas added a comment. https://phabricator.kde.org/D1866 there. REPOSITORY rLIBKSCREEN KScreen Library REVISION DETAIL https://phabricator.kde.org/D1856 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma, dvratil Cc: broulik, graesslin, p

[Differential] [Request, 10 lines] D1866: Use QVector and QLatin1String, and range-based for

2016-06-14 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. sebas added subscribers: graesslin, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This moves the code to the right string types and uses the C++11 t

[Differential] [Closed] D1856: more creative output type detection in xrandr backend

2016-06-14 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREEN54ec74901a0f: more creative output type detection in xrandr backend (authored by sebas). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1856?vs

[Differential] [Commented On] D1856: more creative output type detection in xrandr backend

2016-06-14 Thread Sebastian Kügler
sebas added inline comments. INLINE COMMENTS > graesslin wrote in xrandroutput.cpp:253 > sure you want to use a QStringList? It looks to me like you wanted to have > them as QLatin1Strings for the startsWith check. But that doesn't work when > converted to QString. So maybe QVector? This code

[Differential] [Commented On] D1855: relax lidswitch check for external monitor

2016-06-13 Thread Sebastian Kügler
sebas added a comment. Et voila ... https://phabricator.kde.org/D1856 (more creative output type detection in xrandr backend). REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1855 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Updated, 38 lines] D1856: more creative output type detection in xrandr backend

2016-06-13 Thread Sebastian Kügler
sebas updated this revision to Diff 4427. sebas added a comment. - Fix TV detection The more specific tv types could never be reached, so fix detection order so specific TV flavours are preferred over the general TV case. REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UP

[Differential] [Request, 34 lines] D1856: more creative output type detection in xrandr backend

2016-06-13 Thread Sebastian Kügler
sebas created this revision. sebas added reviewers: Plasma, dvratil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Many users report Unknown output types, while the reported output names are more reliable. This patch m

[Differential] [Request, 2 lines] D1855: relax lidswitch check for external monitor

2016-06-13 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KScreen::Output::Type isn't very reliable and produces Unknown for quite a number of connected displays. Instea

[Differential] [Accepted] D1820: Properly call Toplevel::setSurface for wl_surface_id X11 client message event

2016-06-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH events-call-setSurface REVISION DETAIL https://phabricator.kde.org/D1820 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Accepted] D1808: Introduce a RequestGeometryBlocker in ShellClient

2016-06-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH request-geometry-blocker REVISION DETAIL https://phabricator.kde.org/D1808 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Accepted] D1812: Update window geometry when creating the decoration in ShellClient

2016-06-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH update-geometry-on-create-deco REVISION DETAIL https://phabricator.kde.org/D1812 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Accepted] D1807: Request the resize of ShellSurface after Decoration updated the borders when maximizing

2016-06-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY rKWIN KWin BRANCH resize-after-maximize-changed-deco REVISION DETAIL https://phabricator.kde.org/D1807 EMAIL PREFERENCES

[Differential] [Accepted] D1789: Add destructor request to org_kde_kwin_shadow and org_kde_kwin_shadow_manager

2016-06-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH shadow-destructor REVISION DETAIL https://phabricator.kde.org/D1789 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Accepted] D1784: Ensure that WaylandServer::shellClientAdded only gets emitted once

2016-06-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good. :) REPOSITORY rKWIN KWin BRANCH shell-client-no-multiple-add REVISION DETAIL https://phabricator.kde.org/D1784 EMAIL PREFERENCES https://p

[Differential] [Accepted] D1783: [server] Don't assert when destroying a still referenced BufferInterface

2016-06-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH buffer-dont-assert REVISION DETAIL https://phabricator.kde.org/D1783 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

Minutes Monday Plasma Meeting

2016-06-13 Thread Sebastian Kügler
Minutes Plasma 'hangout', 13-6-2016, 12:00 CET Present: mgraesslin, bshah, notmart, Sho, kbroulik, sebas, Riddell mgraesslin: * lost my notes for second last week due to X crashing * many bug fixes which are open on phab, please review I want them integrated soon as I need to do more fixes which

[Differential] [Requested Changes To] D1844: Add Appinfo metadata file

2016-06-13 Thread Sebastian Kügler
sebas requested changes to this revision. sebas added a reviewer: sebas. sebas added a comment. This revision now requires changes to proceed. Should also have a screenshot? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1844 EMAIL PREFERENCES htt

[Differential] [Accepted] D1733: SceneXRender::Window uses a static XRenderPicture which it didn't clean up

2016-06-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY rKWIN KWin BRANCH cleanup-static-fade-alpha-picture REVISION DETAIL https://phabricator.kde.org/D1733 EMAIL PREFERENCES https://phabri

[Differential] [Accepted] D1731: [libkwinxrenderutils] Clean up static blend picture before going down

2016-06-13 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY rKWIN KWin BRANCH cleanup-static-blend-picture REVISION DETAIL https://phabricator.kde.org/D1731 EMAIL PREFERENCES https://phabricator

[Differential] [Accepted] D1802: Hide the fact that sebas managed to spell his own name wrong.Not once, but 62 times.

2016-06-08 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Huh, nice. REPOSITORY rLIBKSCREEN KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D1802 EMAIL PREFERENCES https://phabricato

[Differential] [Accepted] D1797: drop useless shebang

2016-06-08 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMASDK Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D1797 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, sebas Cc: plasma-de

Re: Review Request 128070: Update mouse kcm docbook to 5.6

2016-06-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128070/#review96265 --- Ship it! Ship It! - Sebastian Kügler On June 1, 2016

PSA: libkscreen dependency bumped to Qt 5.4

2016-06-07 Thread Sebastian Kügler
dency for Plasma has already been bumped to 5.6 recently, but I thought a heads-up wouldn't hurt, still. Cheers, -- sebas Sebastian Kügler•http://vizZzion.org•http://www.kde.org ___ Plasma-devel mailing list Plasma-devel@kde

[Differential] [Accepted] D1792: Fix calculation of the shadow size in the OpenGL compositor

2016-06-07 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH shadow-opengl-size-fix REVISION DETAIL https://phabricator.kde.org/D1792 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Commented On] D1784: Ensure that WaylandServer::shellClientAdded only gets emitted once

2016-06-07 Thread Sebastian Kügler
sebas added a comment. a few questions and suggestions, feedback welcome... INLINE COMMENTS > shell_client_test.cpp:129 > +{ > +#define CLEANUP(name) \ > +if (name) { \ aren't you going overboard here? I don't think this makes the backtrace a lot easier to read... > shell_client_test.c

Re: Review Request 128108: update weather applet ui

2016-06-06 Thread Sebastian Kügler
Just killing these lines will have the same effect. - Sebastian Kügler On June 6, 2016, 6:48 a.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://gi

Re: Proposal: kde-libs.org, a repository of contributed libraries

2016-06-05 Thread Sebastian Kügler
the > https://www.opendesktop.org/ pages, so no need of extra registrations. IMO it doesn't make sense to create another site oriented at the criteria you mention. Get in touch with Cornelius Schumacher (who works on inqlude.org) instead and discuss the op

[Differential] [Accepted] D1738: [startkde] Set QT_WAYLAND_FORCE_DPI from startplasmacompositor

2016-06-01 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH force-dpi-startplasmacompositor REVISION DETAIL https://phabricator.kde.org/D1738 EMAIL PREFERENCES https://phabricator.kde.o

[Differential] [Accepted] D1732: [Kickoff] Use a single MouseArea for opening user manager

2016-06-01 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1732 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broul

Re: Review Request 128074: [libkscreen] [Backend Manager] emitBackendReady() only after fetching the config finishes

2016-06-01 Thread Sebastian Kügler
> On June 1, 2016, 2:19 p.m., Sebastian Kügler wrote: > > I've gone over the handlers for backendReady, and none of them is actually > > used to request a config then (that's encapsulated in backendmanager), so > > requesting a config before the backend is announ

[Differential] [Closed] D1730: address race condition around setoperation

2016-06-01 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN17199d32f292: address race condition around setoperation (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1730?vs=4136&id=4137 REVISION D

[Differential] [Closed] D1736: Use QObject's parent to memory-manage the timers

2016-06-01 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN13a03dc11bb0: Use QObject's parent to memory-manage the timers (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1736?vs=4139&id=4140 REVI

[Differential] [Updated, 16 lines] D1736: Use QObject's parent to memory-manage the timers

2016-06-01 Thread Sebastian Kügler
sebas updated this revision to Diff 4139. sebas added a comment. - Use QScopedPointer for the elapsed timer REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1736?vs=4138&id=4139 BRANCH sebas/timer-parenting REVISION DETAIL https://phabricator.kde.or

[Differential] [Request, 12 lines] D1736: Use QObject's parent to memory-manage the timers

2016-06-01 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: graesslin. sebas added a subscriber: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use QObject's memory management tricks by parenting the timers. TEST PLAN

[Differential] [Updated, 15 lines] D1730: address race condition around setoperation

2016-06-01 Thread Sebastian Kügler
sebas updated this revision to Diff 4136. sebas added a comment. - --debug and invalidate REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1730?vs=4135&id=4136 BRANCH sebas/setop-race REVISION DETAIL https://phabricator.kde.org/D1730 AFFECTED FILES

[Differential] [Updated, 15 lines] D1730: address race condition around setoperation

2016-06-01 Thread Sebastian Kügler
sebas updated this revision to Diff 4135. sebas added a comment. - Use QElapsedTimer instead of QTimer REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1730?vs=4103&id=4135 BRANCH sebas/setop-race REVISION DETAIL https://phabricator.kde.org/D1730 A

Re: Review Request 128074: [libkscreen] [Backend Manager] emitBackendReady() only after fetching the config finishes

2016-06-01 Thread Sebastian Kügler
Ready, and none of them is actually used to request a config then (that's encapsulated in backendmanager), so requesting a config before the backend is announced ready makes sense. - Sebastian Kügler On June 1, 2016, 1:30 p.m., Kai Uwe Bro

[Differential] [Commented On] D1726: Introduce a test server

2016-06-01 Thread Sebastian Kügler
sebas added a comment. Changes look good. REPOSITORY rKWAYLAND KWayland BRANCH test-server REVISION DETAIL https://phabricator.kde.org/D1726 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, sebas, #plasma, bshah Cc: sebas, bshah, plasma-

[Differential] [Accepted] D1734: [server] Properly handle the case that a PlasmaWindow is unmapped before client bound it

2016-06-01 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH plasma-window-destroy REVISION DETAIL https://phabricator.kde.org/D1734 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

Re: Review Request 128073: Make Wayland optional

2016-06-01 Thread Sebastian Kügler
reasons valid or not), but for us it's causing more work and for the sake of our users, I'm making the call that we concentrate on bugs our users report, not on making our builds more complex, because that would achieve the opposite. So, NAK. - Sebastian Kügle

[Differential] [Accepted] D1726: Introduce a test server

2016-05-31 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Aside from @bshah 's request, it looks good to me. INLINE COMMENTS > graesslin wrote in main.cpp:30-33 > right, but then more needs to be changed. All positiona

Re: kscreen daemon race

2016-05-31 Thread Sebastian Kügler
On Tuesday 31 May 2016 14:29:06 Sebastian Kügler wrote: > Discussed with mgraesslin on IRC, preliminary conclusion below... > > On dinsdag 31 mei 2016 14:05:06 CEST Sebastian Kügler wrote: > > https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after > >

Re: kscreen daemon race

2016-05-31 Thread Sebastian Kügler
tification that > the config file has been changed i think. > > [1] http://doc.qt.io/qt-5/qobject.html#blockSignals That is essentially already what's happening, the problem is that signals come in after unblocking them. -- sebas Sebastian Kügler•

[Differential] [Request, 13 lines] D1730: address race condition around setoperation

2016-05-31 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: graesslin. sebas added a subscriber: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use a timer to avoid catching configChanged signals after we set changes.

[Differential] [Accepted] D1711: [server] Don't destroy ShadowInterface when SurfaceInterface gets destroyed

2016-05-31 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH shadow-destroy-surface REVISION DETAIL https://phabricator.kde.org/D1711 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Accepted] D1713: [server] Properly handle destructor in SlideInterface

2016-05-31 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH slide-destroy-callback REVISION DETAIL https://phabricator.kde.org/D1713 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Accepted] D1710: [server] Don't destroy ServerSideDecorationInterface when parent SurfaceInterface is destroyed

2016-05-31 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH ssd-destroy-surface REVISION DETAIL https://phabricator.kde.org/D1710 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Accepted] D1708: [server] Don't destroy BlurInterface when parent SurfaceInterface is destroyed

2016-05-31 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH blur-destroy-surface REVISION DETAIL https://phabricator.kde.org/D1708 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpre

Re: kscreen daemon race

2016-05-31 Thread Sebastian Kügler
Discussed with mgraesslin on IRC, preliminary conclusion below... On dinsdag 31 mei 2016 14:05:06 CEST Sebastian Kügler wrote: > https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after > reboot > > This bugreport seems to be a common problem, and it's a good exam

kscreen daemon race

2016-05-31 Thread Sebastian Kügler
Hey, I've been looking into the bug 358011, that is: https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after reboot This bugreport seems to be a common problem, and it's a good example for what's wrong with the screen configuration on startup. TL;DR: We have a race condition wh

[Differential] [Accepted] D1667: Pass LibInput::Device* through the event handlers

2016-05-30 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. nice work INLINE COMMENTS > pointer_input.cpp:198 > { > +Q_UNUSED(device) > if (!m_inited) { device is used here, though REPOSITORY rKWIN KWin BR

[Differential] [Accepted] D1714: [server] Don't destroy SlideInterface when parent SurfaceInterface is destroyed

2016-05-30 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH slide-destroy-surface REVISION DETAIL https://phabricator.kde.org/D1714 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

Re: [plasma-workspace] /: Bump minimum requirement to Qt 5.6.0

2016-05-30 Thread Sebastian Kügler
On maandag 30 mei 2016 11:29:50 CEST Aleix Pol wrote: > Git commit c003b80cc2c8237218c01996fb419e9892f8f599 by Aleix Pol. > Committed on 30/05/2016 at 11:11. > Pushed by apol into branch 'master'. > > Bump minimum requirement to Qt 5.6.0 That should have been 5.6.1, though. 5.6.0 contains a block

[Differential] [Accepted] D1666: [libinput] Add the Device to Event

2016-05-30 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH libinput-device-in-event REVISION DETAIL https://phabricator.kde.org/D1666 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

Minutes Monday Plasma Meeting

2016-05-30 Thread Sebastian Kügler
Minutes Plasma 'hangout', 30-5-2016, 12:00 CET Present: mgraesslin, bshah, notmart, Sho, kbroulik, sebas mgraesslin: * Text input integrated in KWayland * virtual keyboard in KWin ready to push * cursor image deactivated if no pointer device connected * bunch of KWayland crash fixes * main proble

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-30 Thread Sebastian Kügler
> On May 30, 2016, 9:38 a.m., Andreas Kainz wrote: > > Is It possible too sync the colors between agenda and calender view. > > > > II I I lkelike the I think that would look very cool, but there may be more than one item with different colors for a given day, so it's more complicated than jus

[Differential] [Accepted] D1668: Add the Device to the input event summary

2016-05-26 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > debug_console.cpp:135 > +if (!device) { > +return tableRow(i18n("Input Device"), i18nc("The input device for > the event is not

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

2016-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127870/#review95815 --- Ship it! ping :) - Sebastian Kügler On May 8, 2016, 4

[Differential] [Accepted] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-25 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. looks good to me INLINE COMMENTS > integration.cpp:46 > +#include > +#include > +#include cross fingers? > inputmethodstest.qml:82 > +TextField { > +

[Differential] [Commented On] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces

2016-05-25 Thread Sebastian Kügler
sebas added a comment. ship it! REPOSITORY rKWAYLAND KWayland BRANCH graesslin/text-input REVISION DETAIL https://phabricator.kde.org/D1631 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, sebas, Plasma Cc: sebas, broulik, plasma-devel _

[Differential] [Accepted] D1683: [PanelView] Fix auto hide

2016-05-25 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. good catch! REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1683 EMAIL PREFERENCES https://phabricator.kde.org/

[Differential] [Accepted] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces

2016-05-25 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. a few niggles, but generally, look good to me. INLINE COMMENTS > outputmanagement.cpp:94 > { > +Q_UNUSED(parent); > OutputConfiguration *config = new

Re: DWD HIG Draft

2016-05-24 Thread Sebastian Kügler
Hi Ken, On dinsdag 17 mei 2016 10:49:08 CEST Ken Vermette wrote: > We have our first serious formal proposal for the DWD HIGs and the > functionality we are looking for; here's a link to the publicly editable > Google doc: > > https://docs.google.com/document/d/1mYzHjcuDitWmk99syjC0xzQPPmyUrpL_29

Re: Plasma depending on Qt 5.6.1 shortly

2016-05-23 Thread Sebastian Kügler
On maandag 23 mei 2016 13:28:50 CEST Luca Beltrame wrote: > In data lunedì 23 maggio 2016 13:03:02 CEST, Sebastian Kügler ha scritto: > > During today's Plasma meeting, we've decided to go ahead and switch > > Plasma's Qt dependency to 5.6.1 (which is to be released

Minutes Monday Plasma Meeting

2016-05-23 Thread Sebastian Kügler
Minutes Plasma 'hangout', 23-5-2016, 12:00 CET Present: mgraesslin, bshah, notmart, Sho, kbroulik, jensreuterberg, Riddell (nothing to report), sebas mgraesslin: * support for touch events on window decoration * support for forcing DPI in KWin/Wayland by honoring QtWayland env variable * fixed

Plasma depending on Qt 5.6.1 shortly

2016-05-23 Thread Sebastian Kügler
Hey, During today's Plasma meeting, we've decided to go ahead and switch Plasma's Qt dependency to 5.6.1 (which is to be released shortly). That means: if you're building Plasma from git master, you'll have to rebuild your Qt from git as well, to the 5.6 branch. The reason is that we need Qt 5

[Differential] [Closed] D1534: make the serializer a bit more robust

2016-05-06 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN7497eb49a142: make the serializer a bit more robust (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1534?vs=3647&id=3670 REVISION DETAIL

[Differential] [Closed] D1533: guard access to unsafe config pointer

2016-05-06 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN3cd5c74d5523: guard access to unsafe config pointer (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1533?vs=3648&id=3669 REVISION DETAIL

[Differential] [Closed] D1532: validate the config before checking if it can be applied

2016-05-06 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREENd80fedea86d6: validate the config before checking if it can be applied (authored by sebas). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1532

[Differential] [Accepted] D1546: Fix the building of tests in parallel

2016-05-06 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH fix-build-parallel REVISION DETAIL https://phabricator.kde.org/D1546 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, sebas, Plasma

[Differential] [Commented On] D1533: guard access to unsafe config pointer

2016-05-06 Thread Sebastian Kügler
sebas added a comment. Yes, it's to deep. It would pretty much require running the daemon. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D1533 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, Plasma Cc: graesslin, plas

<    2   3   4   5   6   7   8   9   10   11   >