This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cf2d64fa9718: Set a transient parent for SNI context
menus (authored by fvogt).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11584?vs=30279=30293
fvogt updated this revision to Diff 30279.
fvogt added a comment.
Split mouse.xy stuff into separate patch.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11584?vs=30251=30279
BRANCH
snitest
REVISION DETAIL
https://phabricator.kde.org/D11584
fvogt added inline comments.
INLINE COMMENTS
> broulik wrote in StatusNotifierItem.qml:63
> I think this change is fine. Except that the `MouseArea` covers the entire
> list item, so for hidden SNIs the app might get coordinates outside of its
> icon.
>
> For context menu we ignore the
broulik added inline comments.
INLINE COMMENTS
> StatusNotifierItem.qml:63
> onClicked: {
> -var pos = plasmoid.nativeInterface.popupPosition(taskIcon, 0, 0);
> +var pos = plasmoid.nativeInterface.popupPosition(taskIcon, mouse.x,
> mouse.y);
>
I think this change is
fvogt added inline comments.
INLINE COMMENTS
> davidedmundson wrote in StatusNotifierItem.qml:63
> This change is unrelated, and not a change I would support.
Why not?
It is a fix for an oversight, which is currently a no-op due to another bug.
REPOSITORY
R120 Plasma Workspace
REVISION
davidedmundson added inline comments.
INLINE COMMENTS
> StatusNotifierItem.qml:63
> onClicked: {
> -var pos = plasmoid.nativeInterface.popupPosition(taskIcon, 0, 0);
> +var pos = plasmoid.nativeInterface.popupPosition(taskIcon, mouse.x,
> mouse.y);
>
This change is
fvogt updated this revision to Diff 30251.
fvogt added a comment.
Now for real. Please arc, cooperate.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11584?vs=30250=30251
BRANCH
snitest
REVISION DETAIL
https://phabricator.kde.org/D11584
fvogt updated this revision to Diff 30250.
fvogt added a comment.
Split into https://phabricator.kde.org/D11586
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11584?vs=30248=30250
BRANCH
snitest
REVISION DETAIL
fvogt updated this revision to Diff 30248.
fvogt added a comment.
libdbusmenu-qt: Remove nonexistant actions directly from the menu
The getLayout response handler compares the new list of actions with the
current actions in the menu and calls deleteLater on all actions which aren't
fvogt added a comment.
Urgh, arc. I'll split again.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D11584
To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
fvogt added a comment.
The blank line deletion should be ok, but someone should test on X11 as
well. I don't expect any regressions there though.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D11584
To: fvogt, #plasma
Cc: plasma-devel, ZrenBot,
fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.
REVISION SUMMARY
Those had no transient parent set, so they got displayed somewhere, most of
the
time on the wrong screen.
Also pass the
12 matches
Mail list logo
