D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

fvogt added a comment. In D20186#465586 , @ngraham wrote: > Also keep in mind that it's possible to have global config files in `/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work around the lack of this feature being

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#465586 , @ngraham wrote: > Also keep in mind that it's possible to have global config files in `/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work around the lack of this feature being

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. Also keep in mind that it's possible to have global config files in `/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work around the lack of this feature being implemented yet: $ cat /etc/X11/xorg.conf.d/99-libinput.conf Section

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. > In D20186#465395 , @romangg wrote: > >> I found a grave issue now when testing though: Saved values are not restored on Reboot. Are they saved at all to a config file? >> >> EDIT: No, they are not. In X11 + evdev

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg added a comment. In D20186#465502 , @atulbi wrote: > In D20186#465361 , @ngraham wrote: > > > @atulbi This has caused a failure in the CI: > > [...] > > > > Looks like we need to make

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#465361 , @ngraham wrote: > @atulbi This has caused a failure in the CI: > > https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console > > 09:12:41

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg added a comment. In D20186#465361 , @ngraham wrote: > @atulbi This has caused a failure in the CI: > > https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console > > 09:12:41

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a subscriber: fvogt. ngraham added a comment. @atulbi This has caused a failure in the CI: https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console 09:12:41 /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ce84d6ab4bab: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is… (authored by atulbi, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#465278 , @ngraham wrote: > Are you ready for me to land this? Yeah \o/ I'll take that for the next patch. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D20186 REVISION DETAIL

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham accepted this revision. ngraham added a comment. Are you ready for me to land this? REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D20186 REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: GB_2, jriddell, knambiar,

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 58083. atulbi added a comment. Set visible to false, until accel profiles are not supported. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=58082=58083 BRANCH arcpatch-D20186 REVISION DETAIL

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. In D20186#465267 , @atulbi wrote: > Regarding acceleration profile, maybe we should set visible to false for now. +1, let's do that in this patch > If no touchpad is connected, we could also show a large

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 58082. atulbi added a comment. Finally no more greyed settings there \o/ Work I've planned for future releases : - Adding support to disable horizontal scrolling on wayland. - Provide settings to Disable touchpad on external mouse.

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. In D20186#464906 , @romangg wrote: > For the next release some pointers where still work could be done: > > - Touchpads do never feature acceleration profiles I believe. That's true for the moment, but this is

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. I tested it now. I think it's working robustly and should still go in the upcoming release. We have the beta phase to further test then. For the next release some pointers where

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57933. atulbi added a comment. - lmr mapping working now REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=57923=57933 BRANCH arcpatch-D20186 REVISION DETAIL https://phabricator.kde.org/D20186

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57923. atulbi added a comment. - Added Copyright notice - Corrected asterisk placement REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=57521=57923 BRANCH arcpatch-D20186 REVISION DETAIL

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added inline comments. INLINE COMMENTS > romangg wrote in libinputtouchpad.h:57 > Why is there the negation? Put the Enabled-related function in the parent > class. X provides property for the disabled, while Wayland provides property for enabled. REPOSITORY R119 Plasma Desktop

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Looks really nice. I have yet to try it out, but following a code review. In general it is good practice to make class member variables private and have protected

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. I'm afraid I don't think I have the technical chops to adequately review this, but hopefully @romangg does! :) Or any of the other #plasma people. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#462883 , @GB_2 wrote: > Ping Hey... Have you tried this patch ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson,

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57521. atulbi added a comment. - Remove CMakeLists.txt.user REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=57520=57521 BRANCH arcpatch-D20186 REVISION DETAIL https://phabricator.kde.org/D20186

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57520. atulbi added a comment. - Changes Made : 1. Added abstract class LibinputCommon. 2. All the Q_PROPERTY are in LibinputCommon. 3. Added Disable Horizontal Support on X11 on Libinput. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57519. atulbi added a comment. - Removed last commit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=57508=57519 BRANCH arcpatch-D20186 REVISION DETAIL https://phabricator.kde.org/D20186 AFFECTED

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57508. atulbi added a comment. - Added new abstract class LibinputCommon - Add overriding destructor - Added support for disable horizontal scrolling on Libinput On X11. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55532=57508

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. Wonderful! I'll stop bugging you now. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#458259 , @ngraham wrote: > @atulbi were you able to get in touch with @romangg? Can I help in any way? > > The feature freeze for Plasma 5.16 is in a little over two weeks

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. @atulbi were you able to get in touch with @romangg? Can I help in any way? The feature freeze for Plasma 5.16 is in a little over two weeks (https://community.kde.org/Schedules/Plasma_5) and it would really nice to finally have full Libinput support in our KCM

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg added a comment. In D20186#454584 , @atulbi wrote: > In D20186#454420 , @ngraham wrote: > > > @atulbi ping! Does Roman's request make sense? In general I think it does make sense to do code

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#454420 , @ngraham wrote: > @atulbi ping! Does Roman's request make sense? In general I think it does make sense to do code clean-up in a separate patch first. Totally!! I'm working on it... Currently

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. @atulbi ping! Does Roman's request make sense? In general I think it does make sense to do code clean-up in a separate patch first. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson,

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg added a comment. In D20186#31 , @atulbi wrote: > In D20186#443596 , @romangg wrote: > > > Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#443596 , @romangg wrote: > Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from the Wayland backend. It would make sense to have a new abstract parent class such that the

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55532. atulbi added a comment. - Resolved issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55277=55532 BRANCH X11Libinput REVISION DETAIL https://phabricator.kde.org/D20186 AFFECTED FILES

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#443723 , @knambiar wrote: > > Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#443554 , @ngraham wrote: > In D20186#443262 , @knambiar wrote: > > > >> I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

knambiar added a comment. > Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee for bugs to the Touchpad-KCM product. @atulbi Congratulations, you’re now the

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from the Wayland backend. It would make sense to have a new abstract parent class such

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. In D20186#443262 , @knambiar wrote: > >> I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D > > > > Hey, I would be

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

knambiar added a subscriber: jriddell. knambiar added a comment. >> I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D > > Hey, I would be happy to take that responsibility. Fantastic.

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#442088 , @knambiar wrote: > > Got to Know a lot about how X works with input handling. XD > > I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55277. atulbi added a comment. - Code Cleanup and resolved unexpected behaviour REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55251=55277 BRANCH X11Libinput REVISION DETAIL

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

knambiar added a comment. > Got to Know a lot about how X works with input handling. XD I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D REPOSITORY R119 Plasma Desktop REVISION DETAIL

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55251. atulbi added a comment. - Avoid Setup Backend two times REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55234=55251 BRANCH X11Libinput REVISION DETAIL https://phabricator.kde.org/D20186

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#441892 , @ngraham wrote: > Thanks so much for this! Got to Know a lot about how X works with input handling. XD REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To:

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added reviewers: romangg, davidedmundson, Plasma. ngraham added a comment. Thanks so much for this! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen,

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55234. atulbi added a comment. - Minor changes to optimise code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55230=55234 BRANCH X11Libinput REVISION DETAIL https://phabricator.kde.org/D20186

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY Earlier when libinput was used on X11, XInput specific UI was shown, due to which most of the options were grayed out. Now we show