D23274: Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. @mart I found a bug with this: the titlebar title doesn't update. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg, ngraham, mart Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev,

D23274: Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. This can be closed. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg, ngraham, mart Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D23274: Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#538369 , @ngraham wrote: > I could get behind always having an "app-global" hamburger menu on the left when the menubar isn't shown, but this would require implementing the same pattern for every app, by putting

D23274: Add "Show intro page" button to System Settings sidebar

ngraham added a comment. Implemented the requested change for Systemsettings (https://commits.kde.org/systemsettings/ea0f40c9c03b679ff23688d1eabda61c972f6bc1) and Discover (https://commits.kde.org/discover/b8dfc2d02cc2ac8e7416923e00454a7dc8020f7b). REPOSITORY R124 System Settings

D23274: Add "Show intro page" button to System Settings sidebar

ngraham added a comment. I could get behind always having an "app-global" hamburger menu on the left when the menubar isn't shown, but this would require implementing the same pattern for every app, by putting a little mini-toolbar above the app's sidebar that's separate from the toolbar

D23274: Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#538334 , @ngraham wrote: > In D23274#538315 , @mart wrote: > > > In D23274#537633 , @ngraham wrote: > > > > > Yeah I

D23274: Add "Show intro page" button to System Settings sidebar

ngraham added a comment. In D23274#538315 , @mart wrote: > In D23274#537633 , @ngraham wrote: > > > Yeah I would say so. > > > i strongly disagree, it's the opposite of every other kirigami

D23274: Add "Show intro page" button to System Settings sidebar

mart reopened this revision. mart added a comment. This revision is now accepted and ready to land. In D23274#537633 , @ngraham wrote: > Yeah I would say so. i strongly disagree, it's the opposite of every other kirigami app, and i

D23274: Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#537632 , @GB_2 wrote: > Shouldn't the "Show intro page" button be on the left, like in Discover, and the hamburger menu button on the right, like in for example Dolphin? (#consistency

D23274: Add "Show intro page" button to System Settings sidebar

This revision was automatically updated to reflect the committed changes. Closed by commit R124:de351c8ed6c3: Add Show intro page button to System Settings sidebar (authored by GB_2). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23274?vs=66829=66830#toc REPOSITORY R124 System

D23274: Add "Show intro page" button to System Settings sidebar

GB_2 updated this revision to Diff 66829. GB_2 added a comment. Swap menu and home button position REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=66806=66829 BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274

D23274: Add "Show intro page" button to System Settings sidebar

ngraham added a comment. Yeah I would say so. REPOSITORY R124 System Settings BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23274: Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. Shouldn't the "Show intro page" button be on the left, like in Discover, and the hamburger menu button on the right, like in for example Dolphin? REPOSITORY R124 System Settings BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2,