D24706: [RFC] Change button style

ndavis abandoned this revision. ndavis added a comment. Resuming this on invent REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: mart, ahiemstra, cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, dmenig, manueljlin,

D24706: [RFC] Change button style

ngraham added a comment. In D24706#595764 , @ngraham wrote: > Thanks Noah. > > So you're the boss after all (as the de- facto Breeze maintainer now), and I think we should follow your lead design-wise. But it might also be interesting to hav

D24706: [RFC] Change button style

ndavis added a comment. In D24706#619482 , @mart wrote: > hmm, buttons look quite.. flat now? there was a lot of discussion on what should be flat and what not. while i think having things a bit flatter doesn't actually hurt, could this be consi

D24706: [RFC] Change button style

mart added a comment. hmm, buttons look quite.. flat now? there was a lot of discussion on what should be flat and what not. while i think having things a bit flatter doesn't actually hurt, could this be considered an usability issue? REPOSITORY R31 Breeze REVISION DETAIL https://phabri

D24706: [RFC] Change button style

ndavis updated this revision to Diff 76490. ndavis added a comment. Update REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=73742&id=76490 BRANCH ndavis/pushbutton-style (branched from master) REVISION DETAIL https://phabricator.kde.org/D24706 A

D24706: [RFC] Change button style

ahiemstra added a comment. > Or is QML's rotation property not the right property to use? Basically this. I would even go further and say that a normal Button/ToolButton is not the right control to use and instead you should use some sort of "VerticalTextButton" or so. Except that of cou

D24706: [RFC] Change button style

ndavis added a comment. In D24706#596541 , @ahiemstra wrote: > KScreen uses QML, so it may well be that the buttons were rotated using QML's rotation property, which does rotate the frame, since that's rendered by qqc2-desktop-style's StyleItem

D24706: [RFC] Change button style

ahiemstra added a comment. KScreen uses QML, so it may well be that the buttons were rotated using QML's rotation property, which does rotate the frame, since that's rendered by qqc2-desktop-style's StyleItem as a sub-part of the button. REPOSITORY R31 Breeze REVISION DETAIL https://pha

D24706: [RFC] Change button style

ndavis added a comment. In D24706#595796 , @cfeck wrote: > If application developers need a rotated button, they need to rotate only the contents, not the frame. Good to know. I remembered seeing an earlier version of the KScreen redesign

D24706: [RFC] Change button style

cfeck added a comment. If application developers need a rotated button, they need to rotate only the contents, not the frame. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plas

D24706: [RFC] Change button style

ndavis added a comment. TBH, the current way control shadows are rendered seems kind of wrong anyway. The shadow is rendered within the button, so when you rotate a button, the shadow gets rotated as well. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: nda

D24706: [RFC] Change button style

ndavis added a comment. I think I'm going to need bigger, fancier shadows to get a good pressed movement (besides changing background color) with the diagonal movement removed. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: The-Fer

D24706: [RFC] Change button style

ndavis added a comment. In D24706#595764 , @ngraham wrote: > Thanks Noah. > > So you're the boss after all (as the de- facto Breeze maintainer now), and I think we should follow your lead design-wise. But it might also be interesting to have

D24706: [RFC] Change button style

ngraham added a comment. Thanks Noah. So you're the boss after all (as the de- facto Breeze maintainer now), and I REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, manu

D24706: [RFC] Change button style

ndavis added a comment. There were some conflicts, so this isn't exactly how it was before. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, manueljlin, Orage, LeGast00n, k

D24706: [RFC] Change button style

ndavis updated this revision to Diff 73742. ndavis added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=69901&id=73742 BRANCH ndavis/pushbutton-style (branched from master) REVISION DETAIL https://phabricator.kde.org/D24706 A

D24706: [RFC] Change button style

ngraham added a comment. Would you mind rebasing this? It seems like we're moving forward with the idea of iterating on Breeze rather than making a whole new theme, and since Plasma 5.18 just branched, we have some space to hack on master now. I'd like to see if we can move forward with this

D24706: [RFC] Change button style

ndavis added a comment. The effect of removing a shadow in Breeze is pretty subtle. I think it makes it at least a little better, but I wonder if the shadow should be bigger. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: The-Feren

D24706: [RFC] Change button style

ndavis updated this revision to Diff 69901. ndavis added a comment. - Don't use focus colors on sunken buttons - If sunken, remove shadow - Use Button AlternateBackground color for sunken buttons REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=686

D24706: [RFC] Change button style

ndavis added a comment. In D24706#563524 , @ngraham wrote: > +1, I like that effect too. I think they also move the drop shadow to the top to make it look like the button has been depressed and the top edge is casting a shadow on it, right?

D24706: [RFC] Change button style

ngraham added a comment. +1, I like that effect too. I think they also move the drop shadow to the top to make it look like the button has been depressed and the top edge is casting a shadow on it, right? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndav

D24706: [RFC] Change button style

ndavis added a comment. In D24706#563496 , @The-Feren-OS-Dev wrote: > How about doing what GNOME does with Adwaita where a small drop shadow is applied on the bottom of the button to create the illusion of a push-in-able button only for the sha

D24706: [RFC] Change button style

The-Feren-OS-Dev added a comment. How about doing what GNOME does with Adwaita where a small drop shadow is applied on the bottom of the button to create the illusion of a push-in-able button only for the shadow to then go when the button is being pushed down? REPOSITORY R31 Breeze REVISI

D24706: [RFC] Change button style

ndavis added a comment. In D24706#563165 , @cblack wrote: > I'm not a fan of dropping the diagonal movement- the transformation makes buttons feel much more button-y. How about vertical movement? I feel like the diagonal movement only wor

D24706: [RFC] Change button style

cblack added a comment. I'm not a fan of dropping the diagonal movement- the transformation makes buttons feel much more button-y. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: cblack, bodoeggert, ngraham, plasma-devel, LeGast00n,

D24706: [RFC] Change button style

ngraham added a comment. In D24706#562797 , @ndavis wrote: > How is it for you compared to the git master focus decorations? I know it's not what you're asking, but I'd like to know. Almost perfect except for I'd like the focus outline to

D24706: [RFC] Change button style

ndavis added a comment. In D24706#562666 , @ngraham wrote: > In D24706#553074 , @ngraham wrote: > > > I do like how obvious it makes the selected button, but by doing this, it visually overwhelms an

D24706: [RFC] Change button style

ngraham added a comment. In D24706#553074 , @ngraham wrote: > I do like how obvious it makes the selected button, but by doing this, it visually overwhelms and destroys the concept of the default button (which is supposed to be the most visually

D24706: [RFC] Change button style

ndavis added a comment. In D24706#552981 , @ndavis wrote: > In D24706#552980 , @ngraham wrote: > > > Combobox still affected: F7659165: Screenshot_20191023_145546.png

D24706: [RFC] Change button style

bodoeggert added a comment. The confusing thing about focus / hover colors is having to move away the mouse in order to see weather it's focused or toggled. I need to know: This button is pressed or not, that button will be interacted when I press space/enter. Highlighting the button und

D24706: [RFC] Change button style

ndavis updated this revision to Diff 68637. ndavis added a comment. - Don't use HighlightedText for focused non-flat toolbuttons REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=68632&id=68637 BRANCH ndavis/pushbutton-style (branched from master) R

D24706: [RFC] Change button style

ndavis added a comment. Looks like that's because those were ToolButtons and I only changed PushButtons REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: bodoeggert, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkina

D24706: [RFC] Change button style

bodoeggert added a comment. /me thinks that hover colors are more confusing than helpful, especially if they are similar / mixed with the "pressed" color. I have a mouse cursor to indicate the position of the mouse. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D2470

D24706: [RFC] Change button style

ndavis added a comment. I still prefer having the focus background. It's a distinct feature of Breeze. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: bodoeggert, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinart

D24706: [RFC] Change button style

ndavis updated this revision to Diff 68645. ndavis added a comment. - Don't use QIcon::Selected on non-flat focused buttons REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=68637&id=68645 BRANCH ndavis/pushbutton-style (branched from master) REVISI

D24706: [RFC] Change button style

ndavis added a comment. In D24706#552849 , @bodoeggert wrote: > /me thinks that hover colors are more confusing than helpful, especially if they are similar / mixed with the "pressed" color. I have a mouse cursor to indicate the position of the

D24706: [RFC] Change button style

ndavis updated this revision to Diff 68632. ndavis added a comment. - Don't use HightlightedText on PushButton labels REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=68584&id=68632 BRANCH ndavis/pushbutton-style (branched from master) REVISION DET

D24706: [RFC] Change button style

ngraham added a comment. Nice, this is looking better now. I'm gonna use it full time for a while. I'm wondering if we might want to increase the thickness of the focus effect. It's maybe a bit too subtle now. In Adwaita, the focus outline around, say, spinboxes is quite chunky. But I th

D24706: [RFC] Change button style

ngraham added a comment. Combobox still affected: F7659165: Screenshot_20191023_145546.png Icons on focused buttons (ToolButtons as well as PushButtons) still have reversed colors: F7659169: Screenshot_20191023_145628.png

D24706: [RFC] Change button style

ndavis added a comment. In D24706#552980 , @ngraham wrote: > Combobox still affected: F7659165: Screenshot_20191023_145546.png > > Icons on focused buttons (ToolButtons as well as PushButtons) still have

D24706: [RFC] Change button style

ngraham added a comment. Well that changed things, but it didn't fully fix the issue: F7659135: demo-2019-10-23_14.39.54.webm REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: bodoeggert, ngraham

D24706: [RFC] Change button style

ngraham added a comment. In general +1, I think this is an improvement. However something seems off about the text colors for focused buttons: F7659086: demo-2019-10-23_14.25.10.webm REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde

D24706: [RFC] Change button style

ngraham added a comment. I do like how obvious it makes the selected button, but by doing this, it visually overwhelms and destroys the concept of the default button (which is supposed to be the most visually distinctive button). IMO it also interferes with the the checked and hover states I

D24706: [RFC] Change button style

ndavis added a comment. Should be fixed now. I forgot to add that to the diff here after I made the video. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: bodoeggert, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konk

D24706: [RFC] Change button style

ndavis added a comment. I think it might be a good idea to add an animation mode for the sunken state. Right now, the transition is just instant. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: ngraham, plasma-devel, LeGast00n, The-

D24706: [RFC] Change button style

ndavis added a comment. In D24706#552291 , @ngraham wrote: > I'm not a fan of changing the background for focused buttons. I think it just confuses things, and doesn't fix the current problem; it just changes it. IMO focus (not hover, focus) sho

D24706: [RFC] Change button style

ndavis updated this revision to Diff 68584. ndavis added a comment. - Remove focus background REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=68496&id=68584 BRANCH ndavis/pushbutton-style (branched from master) REVISION DETAIL https://phabricato

D24706: [RFC] Change button style

ngraham added a comment. I'm not a fan of changing the background for focused buttons. I think it just confuses things, and doesn't fix the current problem; it just changes it. IMO focus (not hover, focus) should be indicated exclusively with an outline around the control drawn in the highli

D24706: [RFC] Change button style

ndavis added a comment. Currently, this makes text on light colorschemes that use a light Selection Text color difficult to read. To fix that and keep this look, one of these things will need to happen: -Change the colorschemes to use dark Selection Text on light themes. For colorschem