D25019: Ensure that GlobalDrawer topContent always stays on top

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of D25426 and D25425 . REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25019 To: ngraham, #kirigami, mart, apol, a

D25019: Ensure that GlobalDrawer topContent always stays on top

ngraham added a subscriber: dfaure. ngraham added a comment. Done, I've asked @dfaure for a re-spin to pick up the reverting commit. Sorry about this. :/ I'll try to fix it and re-submit for review for 5.65. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25019

D25019: Ensure that GlobalDrawer topContent always stays on top

wbauer added a comment. In D25019#558919 , @mart wrote: > Unfortunately, it has been pushed too near to framework release, so now it has been released, breaking several apps for a whole framework release. It has only been tagged so far, i

D25019: Ensure that GlobalDrawer topContent always stays on top

davidedmundson added inline comments. INLINE COMMENTS > GlobalDrawer.qml:258 > +//as items are added only after this column creation > +Layout.minimumWidth: parent.width > +visible: children.length > 0 && childrenRect.height > 0 && > opacity > 0 General rule

D25019: Ensure that GlobalDrawer topContent always stays on top

mart reopened this revision. mart added a comment. This revision is now accepted and ready to land. I just reverted this, it causes all sort of breakages in the side drawers of many apps, mostly those that support the "collapsed sidebar" mode, like the emoji selector and ksysguardqml Unfort

D25019: Ensure that GlobalDrawer topContent always stays on top

This revision was automatically updated to reflect the committed changes. Closed by commit R169:cae9d9cdbd71: Ensure that GlobalDrawer topContent always stays on top (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25019?vs=69116&id=69139

D25019: Ensure that GlobalDrawer topContent always stays on top

ngraham added a comment. Got confirmation from @notmart in chat that this is good to go. Landing it! REPOSITORY R169 Kirigami BRANCH topContent-always-on-top (branched from master) REVISION DETAIL https://phabricator.kde.org/D25019 To: ngraham, #kirigami, mart, apol, ahiemstra Cc: pla

D25019: Ensure that GlobalDrawer topContent always stays on top

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > ahiemstra wrote in GlobalDrawer.qml:370 > We **really** should fix scrollview's scrollbars... See https://phabricator.kde.org/T9126. I *really* dislike overlay scrollbars, both in terms of utility and als

D25019: Ensure that GlobalDrawer topContent always stays on top

ngraham updated this revision to Diff 69116. ngraham marked 3 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25019?vs=68920&id=69116 BRANCH topContent-always-on-top (branched from

D25019: Ensure that GlobalDrawer topContent always stays on top

ahiemstra added inline comments. INLINE COMMENTS > GlobalDrawer.qml:241 > > -rightPadding: !Settings.isMobile && mainFlickable.contentHeight > > mainFlickable.height ? Units.gridUnit : Units.smallSpacing > +leftPadding: 0 > +rightPadding: 0 +1 for getting rid of these paddings. >

D25019: Ensure that GlobalDrawer topContent always stays on top

ngraham created this revision. ngraham added reviewers: Kirigami, mart, apol. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now, if you define `topContent` for your GlobalDrawer, it's added to the scr